[PATCH iproute v2] tc: util: Don't call NEXT_ARG_FWD() in __parse_action_control()

2017-12-08 Thread Michal Privoznik
Not all callers want parse_action_control*() to advance the arguments. For instance act_parse_police() does the argument advancing itself. Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions") Signed-off-by: Michal Privoznik --- Technically, even t

Re: [PATCH iproute2] tc: police: fix control action parsing

2017-11-29 Thread Michal Privoznik
On 11/28/2017 02:02 PM, Jiri Pirko wrote: > Mon, Nov 27, 2017 at 09:32:59PM CET, step...@networkplumber.org wrote: >> On Mon, 27 Nov 2017 19:00:14 +0100 >> Michal Privoznik wrote: >> >>> parse_action_control helper does advancing of the arg inside. So don'

Re: [PATCH iproute2] tc: police: fix control action parsing

2017-11-28 Thread Michal Privoznik
On 11/27/2017 09:32 PM, Stephen Hemminger wrote: > On Mon, 27 Nov 2017 19:00:14 +0100 > Michal Privoznik wrote: > >> parse_action_control helper does advancing of the arg inside. So don't >> do it outside. >> >> Fixes: e67aba559581 ("tc: acti

[PATCH] tc: police: fix control action parsing

2017-11-27 Thread Michal Privoznik
parse_action_control helper does advancing of the arg inside. So don't do it outside. Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions") Signed-off-by: Michal Privoznik --- tc/m_police.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-