rface
is not STA, IBSS, or AP, scanning should not be permitted. This patch allows
scanning on any interface if a SSID is specified. NACK.
-Michael Wu
signature.asc
Description: This is a digitally signed message part.
that check more explicitly linked to
> master devices rather than simply checking if the value has been
> previously set.
>
> CC: Daniel Drake <[EMAIL PROTECTED]>
> Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
Acked-by: Michael Wu <[EMAIL PROTECTED]>
-Michael Wu
pgpq0GOLj4M4L.pgp
Description: PGP signature
device is
dev == sdata->local->mdev
wme.c doesn't quite follow this but that code needs to die anyway.
This does look nicer than the other patch.
-Michael Wu
pgpN7ucTU8vgB.pgp
Description: PGP signature
ere we can
add checks like this because if an assumption should ever break, the code
will break into pieces. However, we don't, and there's no reason to do so
here other than to needlessly add code just because it makes you feel safer.
-Michael Wu
pgpHBxhRxxDdA.pgp
Description: PGP signature
one of them. That gives some sort of protection against cosmic rays
flipping bits, but down here on earth, it's bloat.
-Michael Wu
pgpvLIbudqBzS.pgp
Description: PGP signature
all under RTNL and the pointer is only modified while the interface is
down.
-Michael Wu
pgpshSQvult93.pgp
Description: PGP signature
can verify that this condition
will never occur within the mac80211 layer, so there's no need to have it.
The only thing this can catch is someone deciding to manually invoke
dev->uninit, which only the unregister code should be doing.
-Michael Wu
pgpdJwtzOzO1V.pgp
Description: PGP signature
e logic here later.
> + BUG_ON(netif_running(dev));
This will never happen, so there's no point.
ACK with that bit removed.
Thanks,
-Michael Wu
pgp8tWf3hoFjQ.pgp
Description: PGP signature
On Sunday 16 September 2007 00:50, David Miller wrote:
> From: Michael Wu <[EMAIL PROTECTED]>
> Date: Sun, 16 Sep 2007 00:47:40 -0400
>
> > Huh? How does a driver use NAPI if it can't pass a struct net_device?
>
> It is now managed by a struct napi_struct which you
t; >> type information.
> >
> > I'd rather not.
>
> Elaboration?
>
What form of debugging are you talking about? I don't see how it makes a
difference for debugging. The type checking provided by enums won't make a
difference for my code - any problems with using the wrong register bits in
the wrong place is obvious due to the prefixes. I don't really see how enum
type checking is even effective at all without annotations and casts all over
the place.
Thanks,
-Michael Wu
pgpKxv01TUAxV.pgp
Description: PGP signature
t_dma_mask(pdev, DMA_32BIT_MASK) ||
> > + pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK)) {
> > + printk(KERN_ERR "%s (adm8211): No suitable DMA available\n",
> > + pci_name(pdev));
> > + goto err_free_reg;
> > + }
> > +
> > + pci_set_master(pdev);
> > +
> > + dev = ieee80211_alloc_hw(sizeof(*priv), &adm8211_ops);
> > + if (!dev) {
> > + printk(KERN_ERR "%s (adm8211): ieee80211 alloc failed\n",
> > + pci_name(pdev));
> > + err = -ENOMEM;
> > + goto err_free_reg;
> > + }
> > + priv = dev->priv;
> > + priv->pdev = pdev;
> > +
> > + spin_lock_init(&priv->lock);
> > +
> > + SET_IEEE80211_DEV(dev, &pdev->dev);
> > +
> > + pci_set_drvdata(pdev, dev);
> > +
> > + priv->map = pci_iomap(pdev, 1, mem_len);
> > + if (!priv->map)
> > + priv->map = pci_iomap(pdev, 0, io_len);
>
> is this paranoia?
>
> just code 100% MMIO only, and ditch the iomap per-register-access overhead
>
Will do.
> > + pci_read_config_byte(pdev, PCI_CLASS_REVISION, &priv->revid);
>
> this is in struct pci_dev now
>
Convenient.
> > +/* CSR (Host Control and Status Registers) */
> > +struct adm8211_csr {
>[snip]
> > +} __attribute__ ((packed));
>
> attributed(packed) is unneccesary here, and its use results in
> sub-optimal code
>
How? Doesn't this just turn into a bunch of offsets?
> enums are preferred. they do not disappear at the cpp stage, and confer
> type information.
>
I'd rather not.
> > +#define ADM8211_IDLE_RX() \
> > +do {
> > \
> > + if (priv->nar & ADM8211_NAR_SR) { \
> > + ADM8211_CSR_WRITE(NAR, priv->nar & ~ADM8211_NAR_SR);\
> > + ADM8211_CSR_READ(NAR); \
> > + mdelay(20); \
> > + } \
> > +} while (0)
>
> should be msleep() AFAICS
>
Nope, this can be called in atomic context. Admittedly, 20 ms delay is
ridiculously long.. I'll find a better way to handle this.
> use of to separate type and name greatly enhances readability.
> look at many other net drivers, to see the positive effects
>
Sure, will do.
Thanks,
-Michael Wu
pgpOaX1OsRMry.pgp
Description: PGP signature
specs (publically downloadable, no
NDA), released their Linux driver source (under GPL), sent hardware samples,
and offered an engineer's help a few months after the first release of the
adm8211 driver.
-Michael Wu
pgpwvD8Xe1LEr.pgp
Description: PGP signature
On Tuesday 15 May 2007 13:12, John W. Linville wrote:\
> Patch below...does this work better? Looks like upstream needs
> it too...
>
ACK. Looks like I forgot to set sdata after removing the code that set it.
Thanks,
-Michael Wu
pgpG4koPmIL63.pgp
Description: PGP signature
On Thursday 10 May 2007 00:21, Jeff Garzik wrote:
> Michael Wu wrote:
> > On Wednesday 09 May 2007 19:12, Jeff Garzik wrote:
> >> John W. Linville wrote:
> >>> +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6
> >>> *eeprom) +{
> >
NT_TXB_ERR(1 << 11)
> > +#define RTL818X_INT_ATIM (1 << 12)
> > +#define RTL818X_INT_BEACON (1 << 13)
> > +#define RTL818X_INT_TIME_OUT (1 << 14)
> > +#define RTL818X_INT_TX_FO (1 << 15)
> > + __le32 TX_CONF;
> > +#define RTL818X_TX_CONF_LOOPBACK_MAC (1 << 17)
> > +#define RTL818X_TX_CONF_NO_ICV (1 << 19)
> > +#define RTL818X_TX_CONF_DISCW (1 << 20)
> > +#define RTL818X_TX_CONF_R8180_ABCD (2 << 25)
> > +#define RTL818X_TX_CONF_R8180_F(3 << 25)
> > +#define RTL818X_TX_CONF_R8185_ABC (4 << 25)
> > +#define RTL818X_TX_CONF_R8185_D(5 << 25)
> > +#define RTL818X_TX_CONF_HWVER_MASK (7 << 25)
> > +#define RTL818X_TX_CONF_CW_MIN (1 << 31)
> > + __le32 RX_CONF;
> > +#define RTL818X_RX_CONF_MONITOR(1 << 0)
> > +#define RTL818X_RX_CONF_NICMAC (1 << 1)
> > +#define RTL818X_RX_CONF_MULTICAST (1 << 2)
> > +#define RTL818X_RX_CONF_BROADCAST (1 << 3)
> > +#define RTL818X_RX_CONF_DATA (1 << 18)
> > +#define RTL818X_RX_CONF_CTRL (1 << 19)
> > +#define RTL818X_RX_CONF_MGMT (1 << 20)
> > +#define RTL818X_RX_CONF_BSSID (1 << 23)
> > +#define RTL818X_RX_CONF_RX_AUTORESETPHY(1 << 28)
> > +#define RTL818X_RX_CONF_ONLYERLPKT (1 << 31)
> > + __le32 INT_TIMEOUT;
> > + __le32 TBDA;
> > + u8 EEPROM_CMD;
> > +#define RTL818X_EEPROM_CMD_READ(1 << 0)
> > +#define RTL818X_EEPROM_CMD_WRITE (1 << 1)
> > +#define RTL818X_EEPROM_CMD_CK (1 << 2)
> > +#define RTL818X_EEPROM_CMD_CS (1 << 3)
> > +#define RTL818X_EEPROM_CMD_NORMAL (0 << 6)
> > +#define RTL818X_EEPROM_CMD_LOAD(1 << 6)
> > +#define RTL818X_EEPROM_CMD_PROGRAM (2 << 6)
> > +#define RTL818X_EEPROM_CMD_CONFIG (3 << 6)
> > + u8 CONFIG0;
> > + u8 CONFIG1;
> > + u8 CONFIG2;
> > + __le32 ANAPARAM;
> > + u8 MSR;
> > +#define RTL818X_MSR_NO_LINK(0 << 2)
> > +#define RTL818X_MSR_ADHOC (1 << 2)
> > +#define RTL818X_MSR_INFRA (2 << 2)
> > + u8 CONFIG3;
> > +#define RTL818X_CONFIG3_ANAPARAM_WRITE (1 << 6)
> > + u8 CONFIG4;
> > +#define RTL818X_CONFIG4_POWEROFF (1 << 6)
> > +#define RTL818X_CONFIG4_VCOOFF (1 << 7)
> > + u8 TESTR;
> > + u8 reserved_9[2];
> > + __le16 PGSELECT;
> > + __le32 ANAPARAM2;
> > + u8 reserved_10[12];
> > + __le16 BEACON_INTERVAL;
> > + __le16 ATIM_WND;
> > + __le16 BEACON_INTERVAL_TIME;
> > + __le16 ATIMTR_INTERVAL;
> > + u8 reserved_11[4];
> > + u8 PHY[4];
> > + __le16 RFPinsOutput;
> > + __le16 RFPinsEnable;
> > + __le16 RFPinsSelect;
> > + __le16 RFPinsInput;
> > + __le32 RF_PARA;
> > + __le32 RF_TIMING;
> > + u8 GP_ENABLE;
> > + u8 GPIO;
> > + u8 reserved_12[10];
> > + u8 TX_AGC_CTL;
> > +#define RTL818X_TX_AGC_CTL_PERPACKET_GAIN_SHIFT(1 << 0)
> > +#define RTL818X_TX_AGC_CTL_PERPACKET_ANTSEL_SHIFT (1 << 1)
> > +#define RTL818X_TX_AGC_CTL_FEEDBACK_ANT(1 << 2)
> > + u8 TX_GAIN_CCK;
> > + u8 TX_GAIN_OFDM;
> > + u8 TX_ANTENNA;
> > + u8 reserved_13[16];
> > + u8 WPA_CONF;
> > + u8 reserved_14[3];
> > + u8 SIFS;
> > + u8 DIFS;
> > + u8 SLOT;
> > + u8 reserved_15[5];
> > + u8 CW_CONF;
> > +#define RTL818X_CW_CONF_PERPACKET_CW_SHIFT (1 << 0)
> > +#define RTL818X_CW_CONF_PERPACKET_RETRY_SHIFT (1 << 1)
> > + u8 CW_VAL;
> > + u8 RATE_FALLBACK;
> > + u8 reserved_16[25];
> > + u8 CONFIG5;
> > + u8 TX_DMA_POLLING;
> > + u8 reserved_17[2];
> > + __le16 CWR;
> > + u8 RETRY_CTR;
> > + u8 reserved_18[5];
> > + __le32 RDSAR;
> > + u8 reserved_19[18];
> > + u16 TALLY_CNT;
> > + u8 TALLY_SEL;
> > +} __attribute__((packed));
>
> enums have more visibility to the compiler and debugging tools
>
enums don't have the same kind of typechecking this has.
-Michael Wu
pgpAX8vfG7Nic.pgp
Description: PGP signature
;s also consistent with how the (unreleased) rtl8180 driver works,
which really does have support for different radios in different files.
But of course, we can just make an exception for rtl8187. Would merging the
files together make that much of a difference for you?
-Michael Wu
pgpXT8QQmP8PQ.pgp
Description: PGP signature
On Monday 07 May 2007 19:09, Jeff Garzik wrote:
> The general idea is everything you want in 2.6.22 should be prepared and
> in -mm BEFORE 2.6.21 is released, and the 2.6.22 merge window opens.
>
rtl8187 has been in -mm since 2.6.21-rc2-mm1.
-Michael Wu
pgpqlzKVzSGGX.pgp
Descrip
ers consistently in their own
directory or all together in drivers/net/wireless.
-Michael Wu
pgpOSGaxbCyiw.pgp
Description: PGP signature
On Monday 07 May 2007 10:27, Ben Dooks wrote:
> On Mon, May 07, 2007 at 03:46:04AM -0400, Michael Wu wrote:
> > From: Ivo van Doorn <[EMAIL PROTECTED]>
> >
> > This patch adds a library for reading from and writing to 93cx6 eeproms.
>
> This looks remarkably li
From: Ivo van Doorn <[EMAIL PROTECTED]>
This patch adds a library for reading from and writing to 93cx6 eeproms.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/misc/Kconfig |6 +
drivers/misc/Makefile|1
drivers/misc/eeprom_93c
; in order to be consistent. I would prefer that there be one patch to
replace both instances of "(DeviceScape stack)" with "(mac80211 stack)".
-Michael Wu
pgpdfFfONCtcV.pgp
Description: PGP signature
On Saturday 03 February 2007 11:40, Ivo van Doorn wrote:
> It would only be generated for AP mode.
> In any case, the new patch:
>
> Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]>
>
ACK
Thanks,
-Michael Wu
pgprYlsoEM9TR.pgp
Description: PGP signature
aren't actually handled yet. BEACON_TEMPLATE can just be turned
off for now if it's causing problems, though I don't see a reason why a
beacon would be generated for managed mode.
-Michael Wu
pgp4nEF1flQzu.pgp
Description: PGP signature
Hi John,
Please pull
git://git.kernel.org/pub/scm/linux/kernel/git/mwu/d80211-drivers.git
for these patches:
adm8211-week05 branch:
Michael Wu (1):
adm8211: set MAC address properly
p54-week05 branch:
Michael Wu (3):
p54: set MAC address properly
p54usb: silence warnings on BE
On Wednesday 24 January 2007 04:35, Marcus Better wrote:
> The d80211 stack requires CRC32 functions for the WEP implementation.
ACK. Please CC John Linville <[EMAIL PROTECTED]> and Jiri Benc
<[EMAIL PROTECTED]> on d80211 patches next time.
Thanks,
-Michael Wu
pgp7BD1v6LTlQ.
st users once
auto channel selection is implemented, and fixing it for users manually
setting the channel should be trivial.
-Michael Wu
pgp5LtQxHoU24.pgp
Description: PGP signature
nager 0.6.2 (from SuSE 10.1) with wpa_supplicant
0.5.7.
> zd1211 has this problem too:
> Error for wireless request "Set Encode" (8B2A) :
> SET failed on device wlan1 ; Invalid argument.
>
Shouldn't happen if it works for rt2570. Both use software encryption.
-Michael Wu
pgpGy8QeW2zFa.pgp
Description: PGP signature
). Only client mode is
currently supported.
-Michael Wu
pgpgKymarwK0A.pgp
Description: PGP signature
ompatibility with configuration scripts.
-Michael Wu
pgpzpfom9PxaA.pgp
Description: PGP signature
tp://kernel.org/git/?p=linux/kernel/git/jbenc/dscape.git;a=commitdiff_plain;h=e3973cb079b24875af1f196d03569ce7eb517c92;hp=f85c9f7b6a0fe662b95595c51aed92d784e93c5e
-Michael Wu
pgpOMGuxIjYio.pgp
Description: PGP signature
derstand... the wlan0 interface
> does not appear in snmp queries. Any idea about that?
>
Nope.
-Michael Wu
pgp27kMghCcBL.pgp
Description: PGP signature
gs and can push
your patch upstream. Also, you should have a '\n' at the end of the new
printks.
Thanks,
-Michael Wu
pgpFrRiLusyw0.pgp
Description: PGP signature
also allows
the removal of the call to ieee80211_if_shutdown in ieee80211_if_reinit
because ieee80211_if_reinit now will never be called while the interface
is up.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
net/d80211/ieee80211.c |2 ++
net/d80211/ieee80211_iface.c |4 ---
wireless stack is sufficiently polished. New
softmac wireless drivers should be based on that stack if possible. I am
working on a d80211 version of the rtl8187/rtl8185 driver right now, which is
I think is the last linux 802.11g driver which needs to be ported.
-Michael Wu
pgpLv2C3LmE6G.pgp
Description: PGP signature
en the device is registered however, so we
should be able to free it safely on unregister.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
net/d80211/ieee80211.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c
i
These attached patches are a simplified version of Michael Buesch's original
hwmode API patches to adm8211, p54, and zd1211rw-d80211. These will be
necessary once you pull up2 from Jiri Benc's tree.
Thanks,
-Michael Wu
adm8211: Fix compilation for d80211 hwmode API change
From:
A patch which updates zd1211rw-d80211 to the new workqueue API is attached
for when you pull those changes.
Thanks,
-Michael Wu
zd1211rw-d80211: fix workqueue breakage
From: Michael Wu <[EMAIL PROTECTED]>
This allows zd1211rw-d80211 to compile with the workqueue API changes.
Signed-off-b
1_RATE_*, though I think MODE_IEEE80211A/B/G should be all you need.
> Even if it does get out, constants should be in capitals.
>
Sure. Submit a patch. :)
-Michael Wu
pgpT0vuMOW8nC.pgp
Description: PGP signature
/?p=linux/kernel/git/jbenc/dscape.git;a=commitdiff;h=4ae94181f808da96352478c6d4102e3b0b5dfaac
-Michael Wu
pgpiiIQUKezSE.pgp
Description: PGP signature
pace. As Arjan suggests, there's then the intermediate state of
> "disable as much as possible while still providing scanning and link
> detection".
>
In order to scan, we need to have the radio on and we need to be able to send
and receive. What are you gonna turn off?
-
ers can
> depend on, deciding that existing functionality is a bug is, well,
> impolite.
>
No, it's absolutely a bug. It just so happens that some drivers incorrectly
allowed it.
-Michael Wu
pgpc8jW7GJRT5.pgp
Description: PGP signature
d80211: allow migration to ieee80211_dev
This patch allows drivers to switch from ieee80211_hw to ieee80211_dev before
we really rename ieee80211_hw and break everything.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
include/net/d80211.h |3 +++
1 files changed, 3 insertions
-by: Michael Wu <[EMAIL PROTECTED]>
---
include/net/d80211.h |3 +++
net/d80211/ieee80211.c | 41 -
net/d80211/ieee80211_iface.c |5 -
3 files changed, 39 insertions(+), 10 deletions(-)
diff --git a/include/net/d80211.h b/i
the driver to fill it properly. Having drivers fill the
radiotap header also avoids the problem of running out of header space.
-Michael Wu
pgpHliOi1pRSA.pgp
Description: PGP signature
On Monday 18 December 2006 12:20, David Kimdon wrote:
> htons and friends can handle determining the argument is a constant on
> their own, so this change should be dropped.
>
Hm, appears so. Didn't know that. I'll resend the patch without this change.
Thanks,
-Michael Wu
-by: Michael Wu <[EMAIL PROTECTED]>
---
include/net/d80211.h |3 +++
net/d80211/ieee80211.c | 43 --
net/d80211/ieee80211_iface.c |5 -
3 files changed, 40 insertions(+), 11 deletions(-)
diff --git a/include/net/d80211.h b/i
it return void
instead? This would simplify the fixes for drivers a bit.
-Michael Wu
pgpbs9yM7GdbU.pgp
Description: PGP signature
80211_RADIOTAP_EXT = 31
> };
>
> /* Channel flags. */
Did you send this part to netbsd also? We really don't want to fork
radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's
all rolled together for convenience.
-Michael Wu
pgpnuZGgLuAbT.pgp
Description: PGP signature
On Friday 15 December 2006 14:45, Michael Buesch wrote:
> This fixes compilation for the d80211 hwmode API change.
>
> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
>
We can't specify modes before device registration now? There would be less
duplicated code here if
On Friday 15 December 2006 14:44, Michael Buesch wrote:
> This fixes compilation for the d80211 hwmode API change.
>
> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
>
ACK, looks good to me.
-Michael Wu
pgpxYbqaiCNCw.pgp
Description: PGP signature
d80211: fix workqueue breakage
This patch updates d80211 to use the new workqueue API.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
net/d80211/ieee80211.c |7 ---
net/d80211/ieee80211_i.h |8 +---
net/d80211/ieee80211_iface.c |2 +-
net/d80211/ieee80211
On Wednesday 13 December 2006 13:13, Jiri Benc wrote:
> On Tue, 12 Dec 2006 12:55:53 -0500, Michael Wu wrote:
> > - schedule_work(&local->scan_work);
> > + schedule_work(&local->scan_work.work);
>
> Hm, what is the
+ __le16 up:3;
> + __le16 ack_policy:2;
> + u8 schedule:1;
> + u8 reserved:7;
> +} __attribute__ ((packed));
> +
Mind eliminating the bitfields?
-Michael Wu
pgp8Ba7jizphp.pgp
Description: PGP signature
d80211 then and would
rather see it removed. As far as I can tell, this patch is just a symptom of
that issue.
-Michael Wu
pgp5JTyWMOqu6.pgp
Description: PGP signature
of the things that bothered me when I ported zd1211rw.
> We could add a timeout value to each
> packet to make sure, that we don't ACK or NAK packets, which have
> been overdue.
Some sort of watchdog to kick things when things stall could be useful, though
I'm not sure how to g
orted out?
If you really think the idea of LED classes and LED triggers is that
incredibly bad, I will drop this patch and just fix the workqueues. However,
as far as I can tell, it helps move policy out of the kernel while allowing
the most common use case to continue to work without userspace intervention.
-Michael Wu
pgpMnRIEcF0wq.pgp
Description: PGP signature
d80211: fix workqueue breakage
This patch updates d80211 to use the new workqueue API.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
net/d80211/ieee80211.c |7 ---
net/d80211/ieee80211_i.h |8 +---
net/d80211/ieee80211_iface.c |2 +-
net/d80211/ieee80211
a reason why it shouldn't work. Hope you
find this useful.
-Michael Wu
pgptTNY09pbnm.pgp
Description: PGP signature
d80211: fix wep.c breakage
This patch fixes wep.c, which was broken by Al Viro's severing
skbuff.h -> mm.h patch.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
net/d80211/wep.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/d80211/wep.c b/ne
d80211: fix wme.c breakage
This fixes wme.c, which was broken by a recent qdisc api change.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
net/d80211/wme.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/d80211/wme.c b/net/d80211/wme.c
index b9505dc..b
tx_queue.
> Maybe disable rate control
> until we can come up with a nicer solution.
>
I don't think that's gonna happen unless changes are made in the firmware, or
there's some bit somewhere to flip that does exactly what we need. And
surely, having some working rate con
On Monday 11 December 2006 20:07, Daniel Drake wrote:
> Michael Wu wrote:
> > zd1211rw-d80211: Use ieee80211_tx_status
>
> I've thought some more about this and I'm not so sure that this is the
> right approach.
>
> Can't devicescape be taught that
s-dev. I will also probably port the rts/cts code after wireless-dev
deals with the workqueue changes.
Sound tolerable to you?
-Michael Wu
pgpQx8gvjRmUA.pgp
Description: PGP signature
Hi John,
Please pull
git://git.kernel.org/pub/scm/linux/kernel/git/mwu/d80211-drivers.git week-48
for these patches:
Michael Wu (3):
zd1211rw-d80211: check IEEE80211_TXCTL_USE_CTS_PROTECT
zd1211rw-d80211: Use ieee80211_tx_status
zd1211rw-d80211: Use LED class
zd_chip.c |2
This makes zd1211rw-d80211 register an LED class to control the link LED
instead of trying to determine when the LED should be on based on the
current bssid. No default trigger is set since d80211 doesn't currently
have a link on/off LED trigger.
Signed-off-by: Michael Wu <[EMAIL P
d80211: move d80211_common.h to net/d80211
This moves d80211_common.h to net/d80211/ieee80211_common.h since
d80211 drivers should not include this file.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/bcm43xx/bcm43xx.h |1
include/net/d80211_co
merge d80211_shared.h into d80211.h
This merges d80211_shared.h into d80211.h.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
include/net/d80211.h| 32 +-
include/net/d80211_shared.h | 46 ---
2 files c
d80211: move 802.11 defines to linux/ieee80211.h
This moves 802.11 defines from net/d80211.h into linux/ieee80211.h.
It also renames IEEE80211_DATA_LEN to IEEE80211_MAX_DATA_LEN to better
match the other definitions.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
include/linux/
d80211: merge d80211_mgmt.h into linux/ieee80211.h
This merges d80211_mgmt.h with linux/ieee80211.h, to keep all the general
802.11 definitions in one place.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/bcm43xx/bcm43xx.h |1
include/linux/ieee8
ot of
the definitions are just copied from net/ieee80211.h now, and most of those
originated from Jouni, afaik..) Let me know if there's a better way. I also
added myself since I've been poking at these defines a bit.
Thanks,
-Michael Wu
pgp35MNuB9riQ.pgp
Description: PGP signature
d80211: remove pkt_type/pkt_probe_resp
Nobody uses pkt_type, and the information can be obtained from the
header. This removes it and the associated code that keeps tracks of it.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
include/net/d80211.h |1 -
net/d80211/ieee8
ually be another
user of this code. Take a look at drivers/scsi/aic7xxx/aic7xxx_93cx6.c
I'm not sure who the maintainer for this is. Should be okay to just have
adm8211 and rt2x00 using eeprom_93cx6 for now, unless you have a spare
aic7xxx supported device lying around. ;)
Thanks,
We have to guess which ACKs match up with which
frames we're trying to send.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/zd1211rw/zd_chip.h |3 +
drivers/net/wireless/d80211/zd1211rw/zd_mac.c | 96
drivers/net/wireless/d80
zd1211rw-d80211: check IEEE80211_TXCTL_USE_CTS_PROTECT
This makes zd1211 check for IEEE80211_TXCTL_USE_CTS_PROTECT and set things
appropriately in the hardware TX header.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/zd1211rw/zd_mac.c | 14 +--
On Monday 04 December 2006 07:51, John W. Linville wrote:
> On Mon, Dec 04, 2006 at 02:50:39AM -0500, Michael Wu wrote:
> > Other (d80211) wireless drivers are welcome
> > to send patches this way if they do not have their own git tree for
> > Linville to pull.
>
> Ple
end patches this way if they do not have their own git tree for Linville
to pull.
Currently, patches are going into the week-48 branch, but I will switch to
putting patches in the master branch and branching off master before every
pull request for next week.
-Michael Wu
pgpLsagXFtkaN.pgp
Description: PGP signature
ugh for adm8211 to use
too. I'll have to try it..
-Michael Wu
pgpjt3tLYG0s7.pgp
Description: PGP signature
Hi John,
Please pull
git://git.kernel.org/pub/scm/linux/kernel/git/mwu/d80211-drivers.git up
for these patches:
Michael Wu (4):
zd1211-d80211: Copy zd1211 driver to d80211 directory
zd1211-d80211: Hook up Kconfig and Makefiles
zd1211-d80211: Port zd1211 to Devicescape stack
rdportsi of the mainline fixes, but IMHO we should
> not care to much for backports and backport compatibility.
I avoided cleanups in the patch to make any patch porting from the mainline
driver easier, but if it's okay with you, I might make a few zd1211-d80211
specific clean up patche
t like any other d80211 drivers have regulatory domains support,
and they need the exactly the same features that zd1211 needs. Also, the
limited support for regulatory domains that d80211 does have restricts it to
channels 1-11 (FCC) regardless, so the code would not be effective.
Thanks,
-Michael Wu
pgpMQ7cClQqGX.pgp
Description: PGP signature
know how to use
the LED api. Not too worried about this issue though.
I will push this to wireless-dev soon if there are no major problems.
Thanks,
-Michael Wu
zd1211-kconfig.bz2
Description: BZip2 compressed data
zd1211-port-to-d80211.bz2
Description: BZip2 compressed data
pgpsQqp0c
when maxssi was added. I
don't mind adding a dummy maxssi just to make sure we don't divide by zero.
In fact, I'm going to come up with a patch for p54 to do that soon.
-Michael Wu
pgp67DV8dGnpA.pgp
Description: PGP signature
0
do the same? Then we won't have to go through all the trouble of adding
things to ieee80211_hw and ieee80211_register_hw to set things in net_device.
This would work out pretty well for SET_NETDEV_DEV too.
-Michael Wu
pgpIZyGVpJaIw.pgp
Description: PGP signature
struct ieee80211_hw.
> + local->mdev->class_dev.dev = hw->dev;
Why not use SET_NETDEV_DEV?
-Michael Wu
pgpED2SctxFK0.pgp
Description: PGP signature
also puts it into sysfs.
>
> Is that good enough?
>
I still prefer obtaining the name of the master interface because well.. all
other network drivers prefix their messages with the name of their interface.
The master interface name should be as good as the wiphy index to enumerate
attach
e a better idea.
Also, do we need to update interfaces associated with the master interface
when the master MAC address changes?
-Michael Wu
pgpGDCT9RsJnl.pgp
Description: PGP signature
uh, what am I going to prefix all my printk messages with now that I can't
access dev->name? It seems like the other d80211 drivers have a habit of
prefixing their messages with the driver name (wrong thing to do, IMHO),
which is different from pretty much all other network drivers.
-
b+0x1248): undefined reference to
`wireless_send_event'
make: *** [.tmp_vmlinux1] Error 1
This is with cfg80211 turned off.
Thanks,
-Michael Wu
pgpDYhLuuGOBL.pgp
Description: PGP signature
en there's something really bad going on) However, what's so bad
about letting drivers update some statistics if it is possible? If you remove
ieee80211_dev_stats, please provide some other way for drivers to access
struct net_device_stats.
-Michael Wu
pgpSXbD257dOW.pgp
Description: PGP signature
adm8211: fix suspend code
Apparently, I forgot to port the suspend and resume code in the
d80211 port of adm8211. Thanks to Johannes Berg for finding this.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/adm8211/adm8211.c | 19 ---
1
spend/resume code properly when I
ported to d80211. The fix is easy - the code just needs to call the
adm8211_open/stop functions directly. I'll send a patch later tonight.
-Michael Wu
pgpQYkVQJIbQS.pgp
Description: PGP signature
On Thursday 02 November 2006 13:47, Larry Finger wrote:
> These patches modify adm8211-d80211 to use the wireless statics added in
> patch 1.
>
> Signed-Off-By: Larry [EMAIL PROTECTED]>
ACK. I can put better values in later.
Thanks,
-Michael Wu
pgpduYKxxEeea.pgp
Description: PGP signature
side stuff to userspace should be
orthogonal to the driver interface and can be dealt with later, IMHO.
-Michael Wu
pgpWGSngKV0AL.pgp
Description: PGP signature
t for p54_assign_address.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/p54/prism54common.c | 10 +-
drivers/net/wireless/d80211/p54/prism54common.h |2 ++
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless
-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/adm8211/adm8211.c |3 ++
drivers/net/wireless/d80211/adm8211/adm8211.h | 42
---
drivers/net/wireless/d80211/p54/prism54.h |1 +
drivers/net/wireless/d80211/p54/prism54common.c
On Tuesday 17 October 2006 11:43, Dan Williams wrote:
> On Tue, 2006-10-17 at 11:05 -0400, Michael Wu wrote:
> > The attached patch adds support for 3887 based prism54 usb wireless
> > adaptors. It is partially based on the islsm driver by Jean-Baptiste
> > Note, but most of
to hack on.
Thanks,
-Michael Wu
p54patch.bz2
Description: BZip2 compressed data
p54usb: remove struct pt_regs *
This patch is necessary to compile once the changes from 2.6.19-rc2 are merged.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/p54/prism54usb.c
cm43xx driver that called the irq handler manually.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/adm8211/adm8211.c |3 +--
drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c |4 ++--
drivers/net/wireless/d80211/rt2x00/rt2400pci.c |3 +--
Remove struct pt_regs * from d80211 drivers
This patch will be necessary once wireless-dev pulls the 2.6.19-rc2 changes
which include the removal of the struct pt_regs * argument in interrupt
handler callbacks.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/
adm8211: small cleanups in adm8211_probe
This patch adds a KERN_INFO to a printk that didn't have anything, and
shortens another line.
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
---
drivers/net/wireless/d80211/adm8211/adm8211.c |4 ++--
1 files changed, 2 insertions(+),
1 - 100 of 167 matches
Mail list logo
