Re: [PATCH bpf v2] bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K

2018-12-11 Thread Michael Roth
e for > vmalloc_exec() cases like on ppc64 we use VMALLOC_{END,_START}. > > Additionally, for archs supporting large page sizes, we should change > the sysctl to be handled as long to not run into sysctl restrictions > in future. > > Fixes: ede95a63b5e8 ("bpf: add bpf_ji

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-10 Thread Michael Roth
Quoting Daniel Borkmann (2018-12-10 08:26:31) > On 12/07/2018 04:36 PM, Michael Roth wrote: > > Quoting Michael Ellerman (2018-12-07 06:31:13) > >> Michael Roth writes: > >> > >>> Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > >&g

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-07 Thread Michael Roth
Quoting Michael Ellerman (2018-12-07 06:31:13) > Michael Roth writes: > > > Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > > JIT allocations. At compile time it defaults to PAGE_SIZE * 4, > > and is adjusted again at init time if MODULES_VADDR

[PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-06 Thread Michael Roth
trict unpriv allocations") Cc: linuxppc-...@ozlabs.org Cc: Daniel Borkmann Cc: Sandipan Das Cc: Alexei Starovoitov Signed-off-by: Michael Roth --- kernel/bpf/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index b1a3545d0ec8..5

Re: [PATCH bpf] bpf: fix default unprivileged allocation limit

2018-12-06 Thread Michael Roth
Quoting Sandipan Das (2018-12-06 03:27:32) > When using a large page size, the default value of the bpf_jit_limit > knob becomes invalid and users are not able to run unprivileged bpf > programs. > > The bpf_jit_limit knob is represented internally as a 32-bit signed > integer because of which the