Re: [PATCH iproute2] link_xfrm: don't forcce to set phydev

Acked-by: Matt Ellison -- Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to

Re: [iproute2] ip: support for xfrm interfaces

> One comment. It seems to accept -ve value for if_id and quietly set > to 0 may be throw an error for -ve values? or take it as u32? > in my opinion setting to 0 is confusing Ah good catch. I'll add the check in my version. -- Please be advised that this email may contain confidential info

Re: [iproute2] ip: support for xfrm interfaces

I recently submitted v3 of the patch, please take a look there. > Question: is it easy to add "if_id" to "ip link show" output? Yes, it should show up under the detailed output for the interface (-d). - Matt -- Please be advised that this email may contain confidential information. If you

[PATCH v3 iproute2] ip: support for xfrm interfaces

Interfaces take a 'if_id' which is an interface id which can be set on an xfrm policy as its interface lookup key (XFRMA_IF_ID). Signed-off-by: Matt Ellison --- My apologies for taking so long to get v3 out: v3 Changes: * Only set IF_ID if set on command line. i

Re: [PATCH v2 iproute2] ip: support for xfrm interfaces

On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern wrote: > You always add IF_ID even if not set by user. The kernel code does not > appear to require it so why pass a default value? 0 (the default) is a valid IF_ID, so setting an interface with a non-zero IF_ID back to 0 is possible. I think the b

[PATCH v2 iproute2] ip: support for xfrm interfaces

Interfaces take a 'if_id' which is an interface id which can be set on an xfrm policy as its interface lookup key (XFRMA_IF_ID). Signed-off-by: Matt Ellison --- ip/Makefile | 2 +- ip/iplink.c | 3 +- ip/l

[PATCH iproute2] ip: support for xfrm interfaces

Support for new (4.19+) xfrm virtual interfaces. Interfaces take a 'if_id' which is an interface id which can be set on an xfrm policy as its interface lookup key (XFRMA_IF_ID). Signed-off-by: Matt Ellison --- ip/Makefile | 2 +- i

[PATCH iproute2] ip: support for xfrm interfaces

Support for new (4.19+) xfrm virtual interfaces. Interfaces take a 'if_id' which is an interface id which can be set on an xfrm policy as its interface lookup key (XFRMA_IF_ID). Signed-off-by: Matt Ellison --- ip/Makefile| 2 +- ip/iplink.c| 3 +- ip/link_x