Re: [PATCH 2/2] ixgb: enable sun hardware support for broadcom phy

2008-01-14 Thread Matheos Worku
Jeff Garzik wrote: Auke Kok wrote: From: Matheos Worku <[EMAIL PROTECTED]> Implement support for a SUN-specific PHY. SUN provides a modified 82597-based board with their own PHY that works with very little modification to the code. This patch implements this new PHY which is identified

Re: [PATCH]: Third (final?) release of Sun Neptune driver

2007-10-05 Thread Matheos Worku
Ingo Oeser wrote: Hi David, Repost since my last post ended up being html Regards, matheos some minor nits. Some Neptune HW info to explain some of the constants ... Could this driver be split into more files. 8k lines per file + case 0: + ctrl_reg = ENET_SERDE

Re: [PATCH]: Third (final?) release of Sun Neptune driver

2007-10-05 Thread Matheos Worku
Ingo Oeser wrote: Hi David, some minor nits. Could this driver be split into more files. 8k lines per file is quite a lot. Although GCC might optimize it best this way :-) Ingo, Some r info on Neptune HW to explains some of the constants ... Regards Matheos + ctrl_val = (ENET_SE

Re: [PATCH]: Second preliminary release of Sun Neptune driver

2007-09-28 Thread Matheos Worku
David Miller wrote: Ok, this is rev2, changes: 1) Jumbo MTU support is now present. I got stuck on this for a while because I didn't realize that resetting the RX XMAC would reset the XMAC_MAX register. I thought that was a TX XMAC resource, ho hum... Fix this by re-initializing t