[OOPS] 2.6.23-rc5 in tcp/net/nfsd

2007-09-11 Thread Mark Hindley
This oops appeared over night on a box running 2.6.23-rc5 (recent with the tcp_input.c fix). I can't find a similar one reported. Mark BUG: unable to handle kernel NULL pointer dereference at virtual address 007e printing eip: c02625bf *pde = Oops: 0002 [#1] PREEMPT Modules

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-06 Thread Mark Hindley
On Thu, Sep 06, 2007 at 03:25:55PM +0530, Satyam Sharma wrote: > This is a GCC bug (regression, actually, as you've found out) -- no two > ways about it. Although different from the kind Jeff mentioned couple days > back -- that was about wising GCC up to false positives and /not/ emitting > warn

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Mark Hindley
On Tue, Sep 04, 2007 at 11:17:57AM +0200, Steffen Klassert wrote: > The only warning that I was able to trigger with gcc 4.2 is in the case of a > .config > without PCI support. In this case I get > > drivers/net/3c59x.c: In function 'vortex_up': > drivers/net/3c59x.c:1672: warning: 'err' is us

Re: [PATCH -mm 1/2] 3c59x: Fix uninitialized variable bug

2007-09-04 Thread Mark Hindley
up': > > > drivers/net/3c59x.c:1495: warning: 'err' may be used uninitialized in > > > this function > > > > This came in with the recently applied > > 3c59x-check-return-of-pci_enable_device patch > > from Mark Hindley. I just compile

[OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Mark Hindley
I have now got an oops trace out of this box, which I presume has been the cause of the previously observed hangs. To my inexperienced eye it looks like it is related to via-rhine. Thanks Mark BUG: unable to handle kernel NULL pointer dereference at virtual address 0025 prin

Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-16 Thread Mark Hindley
Revised patch for this. Mark commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley <[EMAIL PROTECTED]> Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in vortex_up(). Also modify vortex_up to return error to callers. Handle fail

Re: [patch 08/18] 3c59x: check return of pci_enable_device()

2007-08-14 Thread Mark Hindley
On Tue, Aug 14, 2007 at 01:33:26AM -0400, Jeff Garzik wrote: > I would strongly prefer that vortex_up return a value, since all the > important callers of this function can themselves return an error back > to the system. > > we can definitely return a meaningful return value here, if > pci_ena

[PATCH] 3c59x, check return of pci_enable_device()

2007-07-21 Thread Mark Hindley
commit 36d139ccebba6a1082b743fbedb53c5a5097987c Author: Mark Hindley <[EMAIL PROTECTED]> Date: Sat Jul 21 22:56:08 2007 +0100 Check return of pci_enable_device in vortex_up(). Signed-off-by: Mark Hindley <[EMAIL PROTECTED]> diff --git a/drivers/net/3c59x.c b/drivers