Re: post 2.6.24-rc7 regression: unregister_netdevice: waiting for eth1 to become free

2008-01-21 Thread Mariusz Kozlowski
Hello, > > kernel: unregister_netdevice: waiting for eth1 to become free. Usage count > > = 1 > > Known problem: > > http://bugzilla.kernel.org/show_bug.cgi?id=9778 Hm ... I was largely offline on weekend and did not see that. Is there any way I can subscribe 'somewhere' to get notified

post 2.6.24-rc7 regression: unregister_netdevice: waiting for eth1 to become free

2008-01-20 Thread Mariusz Kozlowski
Hello, I found that on current Linus tree unplugging my pcmcia wifi card (Cabletron RoamAbout) causes part of the system to hang. I.e. mouse works but keyboard is frozen until reboot. Actually only sysrq works but I can not type in any terminal. Syslog shows: kernel: pccard: card ejected

sparc oops in ip_fast_csum

2008-01-04 Thread Mariusz Kozlowski
Hello, This comes from the Linus latest linux-2.6 tree. Randomly happened. Can't reproduce that. More info below. Unable to handle kernel paging request at virtual address be286000 tsk->{mm,active_mm}->context = 0eae tsk->{mm,active_mm}->pgd = f800be0e4000

Re: [PACKET]: Fix /proc/net/packet crash due to bogus private pointer

2007-12-16 Thread Mariusz Kozlowski
Hello, > Surprise surprise. The namespace seq patch missed two spots in > AF_PACKET. > > [PACKET]: Fix /proc/net/packet crash due to bogus private pointer > > The seq_open_net patch changed the meaning of seq->private. > Unfortunately it missed two spots in AF_PACKET, which still > used the old

Re: 2.6.24-rc5-mm1: cat /proc/net/packet -> oops

2007-12-15 Thread Mariusz Kozlowski
Hello, As one of usual tests I run the following script: for i in `find /proc -type f`; do echo -n "cat $i > /dev/null ... "; cat $i > /dev/null; echo "done"; done This time the culprit is /proc/net/packet. cat process gets killed $ cat /proc/net/packet Segment

Re: kernel panic when running tcpdump

2007-10-22 Thread Mariusz Kozlowski
> > I'm seeing reproducible oops on 2.6.23-mm1 when trying to run tcpdump > > over ppp0 interface. > > Can you please test the latest Linus kernel from > ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/? Sure. > Because all netwrking things which were in 2.6.23-mm1 are now in mainline.

kernel panic when running tcpdump

2007-10-22 Thread Mariusz Kozlowski
Hello, I'm seeing reproducible oops on 2.6.23-mm1 when trying to run tcpdump over ppp0 interface. To reproduce I type simply: # tcpdump -i ppp0 and wait a few seconds. I captured two oopses with a bit different stack trace but EIP always points to packet_rcv(): (gdb) l* 0xc02d7d49 0xc02

Re: [PATCH] skge: unbalanced parenthesis fix

2007-09-01 Thread Mariusz Kozlowski
> > This patch fixes unbalanced parenthesis. > > > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > > > drivers/net/skge.h |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-2.6.23-rc4-mm1-a/drive

[PATCH] skge: unbalanced parenthesis fix

2007-08-31 Thread Mariusz Kozlowski
Hello, This patch fixes unbalanced parenthesis. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/skge.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.0 +0200 +++ linux-2.6.

Re: [PATCH 2.6.23-rc3-mm1] request_irq fix DEBUG_SHIRQ handling Re: 2.6.23-rc2-mm1: rtl8139 inconsistent lock state

2007-08-25 Thread Mariusz Kozlowski
only about lockdep complaining, > but real lockup possibility, because any locks in such a handler are > taken in another, not expected for them context, and could be > vulnerable (especially with softirqs, but probably hardirqs as well). > > Reported-by: Mariusz Kozlowski <[EMAI

Re: 2.6.23-rc2-mm2: possible irq lock inversion dependency detected

2007-08-10 Thread Mariusz Kozlowski
Hello, Have fun :) = [ INFO: possible irq lock inversion dependency detected ] 2.6.23-rc2-mm2 #1 - depscan.sh/5928 just changed the state of lock: (_xmit_ETHER){-+..}, at: [] d

Re: 2.6.23-rc2-mm1: rtl8139 inconsistent lock state

2007-08-09 Thread Mariusz Kozlowski
Hello, = [ INFO: inconsistent lock state ] 2.6.23-rc2-mm1 #7 - inconsistent {in-hardirq-W} -> {hardirq-on-W} usage. ifconfig/5492 [HC0[0]:SC0[0]:HE1:SE1] takes: (&tp->lock){+...}, at: [] rtl8139_interrupt+0x27/0x46b [8139too] {in-har

[PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-08 Thread Mariusz Kozlowski
eof_priv) dev->priv = netdev_priv(dev); This patch removes superfluous code. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/tulip/xircom_cb.c | 32853 -> 32831 (-22 bytes) drivers/net/tulip/xircom_cb.o | 123984 -> 123984 (0 bytes) drivers/net/tulip/xirco

[PATCH] drivers/net: remove superfluous memset

2007-08-08 Thread Mariusz Kozlowski
Hello, This patch covers sth like this: dev = alloc_*dev(... ... priv = netdev_priv(dev); memset(priv, 0, sizeof(*priv)); The memset() here is superfluous. alloc_netdev() uses kzalloc() to allocate needed memory so there is no need to zero the priv region twice. Signed-off-by: Mariusz

Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset

2007-08-07 Thread Mariusz Kozlowski
> Please send wireless patches to [EMAIL PROTECTED], > and CC me. Ok. Did you pick the patch up? Regards, Mariusz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

[PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset

2007-08-06 Thread Mariusz Kozlowski
Hello, This memset() looks superfluous. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/wireless/wl3501_cs.c | 58885 -> 58858 (-27 bytes) drivers/net/wireless/wl3501_cs.o | 200252 -> 20 (-252 bytes) drivers/net/wireless/wl3501_cs.c |1 - 1 fil

Re: [PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Mariusz Kozlowski
> >>Looks like memset() is zeroing wrong nr of bytes. > > > > Good catch, however, I think we can just remove this memset altogether > > since the memory gets allocated via kzalloc. > > Correct, that memset() is superfluous. Ok. Then this should do it.

[PATCH] drivers/net/ibmveth.c: memset fix

2007-08-06 Thread Mariusz Kozlowski
Hello, Looks like memset() is zeroing wrong nr of bytes. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/ibmveth.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23-rc1-mm2-a/drivers/net/ibmveth.c2007-08-01 08:43:46.0

[PATCH 76] drivers/net/via-velocity.c: mostly kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/via-velocity.c | 88263 -> 88120 (-143 bytes) drivers/net/via-velocity.o | 254264 -> 253828 (-436 bytes) drivers/net/via-velocity.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-

[PATCH 69] drivers/net/sb1250-mac.c: kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/sb1250-mac.c | 76286 -> 76199 (-87 bytes) drivers/net/sb1250-mac.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/net/sb1250-mac.c 2007-07-26 13:07:43.00

[PATCH 68] drivers/net/s2io.c: kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/s2io.c | 235587 -> 235340 (-247 bytes) drivers/net/s2io.o | 460768 -> 460120 (-648 bytes) drivers/net/s2io.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) --- linux-2.6.23-rc1-mm1-a/driver

[PATCH 67] net/ipv4/route.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/ipv4/route.c | 75650 -> 75628 (-22 bytes) net/ipv4/route.o | 256303 -> 256467 (+164 bytes) net/ipv4/route.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/ipv4/route.c 2007

[PATCH 66] net/ipv4/raw.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/ipv4/raw.c | 21650 -> 21628 (-22 bytes) net/ipv4/raw.o | 179112 -> 179272 (+160 bytes) net/ipv4/raw.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/ipv4/raw.c 2007

Re: [PATCH 39] net/ipv4/ip_options.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
> Applied, but note that this patch changes behavior, previously > only the ip_options structure base was cleared out, but now > the whole memory region is cleared. > > I think it's OK for this case, but I'm just making note of it. Agrh. Sorry. I must have overlook this. Feel free to drop it if y

[PATCH 39] net/ipv4/ip_options.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/ipv4/ip_options.c | 15425 -> 15368 (-57 bytes) net/ipv4/ip_options.o | 133668 -> 133588 (-80 bytes) net/ipv4/ip_options.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/ipv4/

[PATCH 20] net/decnet/dn_route.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/decnet/dn_route.c | 45013 -> 44991 (-22 bytes) net/decnet/dn_route.o | 199388 -> 199580 (+192 bytes) net/decnet/dn_route.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/net/decne

Re: [git patches] net driver updates

2007-05-18 Thread Mariusz Kozlowski
> > > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h > > > index 7053026..111f23d 100644 > > > --- a/drivers/net/smc91x.h > > > +++ b/drivers/net/smc91x.h > > > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg) > > > > ... > > > > > +#define SMC_outb(v, a, r) __ __

[PATCH] net: af_netlink module_put cleanup

2007-01-02 Thread Mariusz Kozlowski
Hello, This patch removes redundant argument check for module_put(). Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> net/netlink/af_netlink.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/net/netlink/af_netlink.c linux-2.6.20-r

Re: [PATCH] net: ifb error path loop fix

2007-01-02 Thread Mariusz Kozlowski
7;s why the > error recovery code had to be coded specially :-) Now when I look at it I might be wrong and it is not a bug at all. It's just coded in weird way. Anyway isn't there kfree(ifbs) missing on error path? The patch below should clear things a bit (against plain 2.6.20-r

[PATCH] net: ifb error path loop fix

2007-01-01 Thread Mariusz Kozlowski
Hello, On error we should start freeing resources at [i-1] not [i-2]. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/ifb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/drivers/net/ifb.c linux-2.6.20-rc2-mm1-b/d

[2.4 PATCH] netfilter broken and unused macro removal

2006-12-04 Thread Mariusz Kozlowski
Hello, This patch removes broken and unused macro from netfilter code. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>  net/ipv4/netfilter/ip_nat_standalone.c |    6 --  1 file changed, 6 deletions(-) --- linux-2.4.34-pre6-a/net/ipv4/netfilter/ip_nat_standalone.c 2005

Re: [PATCH] mv643xx add missing brackets

2006-11-30 Thread Mariusz Kozlowski
y: This patch fixes some mv643xx macros. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> include/linux/mv643xx.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h 2006-11-16 05:03:40.0 +0100 +++ linux-2

[PATCH] mv643xx add missing brackets

2006-11-30 Thread Mariusz Kozlowski
Hello, This patch adds missing brackets. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> include/linux/mv643xx.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h 2006-11-16 05:03:40.0 +0100 +++