[PATCH v5 2/4] e1000e: bump up timeout to wait when ME un-configures ULP mode

2020-12-14 Thread Mario Limonciello
-lan/patch/20200323191639.48826-1-aaron...@canonical.com/ Link: https://lkml.org/lkml/2020/12/13/15 Link: https://lkml.org/lkml/2020/12/14/708 Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH v5 1/4] e1000e: Only run S0ix flows if shutdown succeeded

2020-12-14 Thread Mario Limonciello
If the shutdown failed, the part will be thawed and running S0ix flows will put it into an undefined state. Reported-by: Alexander Duyck Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++-- 1 file changed, 7

[PATCH v5 0/4] Improve s0ix flows for systems i219LM

2020-12-14 Thread Mario Limonciello
vice matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain. Mario Limonciello (4): e1000e: Only run S0ix flows if shutdown succeeded e1000e: bump up timeout to wait

[PATCH v5 4/4] e1000e: Export S0ix flags to ethtool

2020-12-14 Thread Mario Limonciello
igned-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/e1000.h | 1 + drivers/net/ethernet/intel/e1000e/ethtool.c | 46 + drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++-- 3 files changed, 52 insertions(+), 4 deletions(-) diff --git a/drivers/net/eth

[PATCH v5 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-14 Thread Mario Limonciello
pervious to platform firmware behavior. Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 45 +- 1 file changed, 2 insertions(+),

[PATCH 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-14 Thread Mario Limonciello
pervious to platform firmware behavior. Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 45 +- 1 file changed, 2 insertions(+), 43 deletions(-) diff --gi

[PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-14 Thread Mario Limonciello
djust from DMI matching to PCI subsystem vendor ID/device matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain. Mario Limonciello (4): e1000e: Only run S0ix flows

[PATCH 2/4] e1000e: bump up timeout to wait when ME un-configure ULP mode

2020-12-14 Thread Mario Limonciello
nk: https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200323191639.48826-1-aaron...@canonical.com/ Link: https://lkml.org/lkml/2020/12/13/15 Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[PATCH 1/4] e1000e: Only run S0ix flows if shutdown succeeded

2020-12-14 Thread Mario Limonciello
If the shutdown failed, the part will be thawed and running S0ix flows will put it into an undefined state. Reported-by: Alexander Duyck Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[PATCH 4/4] e1000e: Export S0ix flags to ethtool

2020-12-14 Thread Mario Limonciello
igned-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/e1000.h | 1 + drivers/net/ethernet/intel/e1000e/ethtool.c | 40 + drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++--- 3 files changed, 46 insertions(+), 4 deletions(-) diff --git a/drivers/net/eth

[PATCH RESEND] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Mario Limonciello
;). Fixes: 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown Signed-off-by: Tony Nguyen Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello --- This patch was originally part of https://marc.in

Re: [PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Mario Limonciello
On 12/4/20 2:09 PM, Mario Limonciello wrote: From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case").

[PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Mario Limonciello
Adjust from DMI matching to PCI subsystem vendor ID/device matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain. Mario Limonciello (6): e1000e: Move all S0ix relate

[PATCH v3 6/7] e1000e: Add Dell TGL desktop systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
These Tiger Lake systems are not yet released, but have been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello

[PATCH v3 2/7] e1000e: Move all S0ix related code into its own source file

2020-12-04 Thread Mario Limonciello
Introduce a flag to indicate the device should be using the S0ix flows and use this flag to run those functions. Splitting the code to it's own file will make future heuristics more self contained. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e

[PATCH v3 5/7] e1000e: Add more Dell CML systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c b/drivers/net/ethernet/intel/e1000e/s0ix.c index 74043e80c32f..0dd2e2702ebb 100644 --- a/drivers/net/ethernet/intel/e1000e/s0ix.c +++ b

[PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-04 Thread Mario Limonciello
From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown Signe

[PATCH v3 4/7] e1000e: Add Dell's Comet Lake systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
s0ix entry and exit flows for ME systems") Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 33 +--- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c b/drivers/net

[PATCH v3 3/7] e1000e: Export S0ix flags to ethtool

2020-12-04 Thread Mario Limonciello
This flag can be used for debugging and development purposes including determining if S0ix flows work properly for a system not currently recognized by heuristics. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ethtool.c | 40

[PATCH v3 7/7] e1000e: Add another Dell TGL notebook system into S0ix heuristics

2020-12-04 Thread Mario Limonciello
This Tiger Lake system is not yet released, but has been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello

[PATCH v2 1/5] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-02 Thread Mario Limonciello
From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown Signe

[PATCH v2 3/5] e1000e: Add Dell's Comet Lake systems into s0ix heuristics

2020-12-02 Thread Mario Limonciello
Dell's Comet Lake Latitude and Precision systems containing i219LM are properly configured and should use the s0ix flows. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 33 +--- 1 file changed, 29 insertions(

[PATCH v2 0/5] Improve s0ix flows for systems i219LM

2020-12-02 Thread Mario Limonciello
italy's dependency patch in the series - Split out s0ix code into it's own file - Adjust from DMI matching to PCI subsystem vendor ID/device matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and

[PATCH v2 2/5] e1000e: Move all s0ix related code into it's own source file

2020-12-02 Thread Mario Limonciello
Introduce a flag to indicate the device should be using the s0ix flows and use this flag to run those functions. Splitting the code to it's own file will make future heuristics more self containted. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e

[PATCH v2 5/5] e1000e: Export s0ix flags to ethtool

2020-12-02 Thread Mario Limonciello
This flag can be used for debugging and development purposes including determining if s0ix flows work properly for a system not currently recognized by heuristics. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ethtool.c | 40

[PATCH v2 4/5] e1000e: Add more Dell CML systems into s0ix heuristics

2020-12-02 Thread Mario Limonciello
: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c b/drivers/net/ethernet/intel/e1000e/s0ix.c index 74043e80c32f..0dd2e2702ebb 100644 --- a/drivers/net/ethernet/intel/e1000e/s0ix.c +++ b

[PATCH] r8152: Add support for MAC address pass through on RTL8153-BND

2018-12-11 Thread Mario Limonciello
containing RTL8153-BND should activate MAC pass through and there won't use pass through bit on efuse like in RTL8153-AD. Signed-off-by: Mario Limonciello --- drivers/net/usb/r8152.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/ne

[PATCH v6 RESEND] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-07-11 Thread Mario Limonciello
t and available under \_SB.AMAC in the DSDT at runtime. This technology is currently implemented in the Dell TB15 and WD15 Type-C docks. More information is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- drivers/net/usb/r8152.c

[PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Mario Limonciello
t and available under \_SB.AMAC in the DSDT at runtime. This technology is currently implemented in the Dell TB15 and WD15 Type-C docks. More information is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- Changes from v5: * Correct r

[PATCH v5] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-07 Thread Mario Limonciello
t and available under \_SB.AMAC in the DSDT at runtime. This technology is currently implemented in the Dell TB15 and WD15 Type-C docks. More information is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- Changes from v4: * Correct

[PATCH v4] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario Limonciello
t and available under _SB\AMAC in the DSDT at runtime. This technology is currently implemented in the Dell TB15 and WD15 Type-C docks. More information is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- Changes from v3: * Add addit

[PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario Limonciello
activated. - Expected experience is that if two docks (RTL8153-AD's w/ mac pass thru bit set) were plugged in both should have MAC pass through activated. Mario Limonciello (1): r8152: Add support for setting pass through MAC address on RTL8153-AD drivers/net/u

[PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-06 Thread Mario Limonciello
t and available under _SB\AMAC in the DSDT at runtime. This technology is currently implemented in the Dell TB15 and WD15 Type-C docks. More information is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- drivers/net/usb/r8152.c

[PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Mario Limonciello
ac_address() implementation. - I haven't yet done this. If this is the right approach. I would like to know the proper place in arch/x86 to put this code. My initial thought was a new file in arch/x86/platform/intel Mario Limonciello (1): r8152: Add support for setting MAC to system&

[PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Mario Limonciello
information for the system's persistent MAC address is burned in when the HW is built and available under _SB\AMAC in the DSDT at runtime. More information about the technology is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- dr

[PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-01 Thread Mario Limonciello
information for the system's persistent MAC address is burned in when the HW is built and avilable under _SB\AMAC in the DSDT at runtime. More information about the technology is available here: http://www.dell.com/support/article/us/en/04/SLN301147 Signed-off-by: Mario Limonciello --- dr