Jeff, thanks for the feedback. If dropped your comments for the sections
I've either already implemented or will be doing shortly. The remaining
comments are below to help clarify the code in question or if I didn't
understand your comment.
Marc
Jeff Garzik wrote:
> Marc
Jeff Garzik wrote:
> Marc St-Jean wrote:
> > I asked if the remaining section (above) was acceptable so we could
> retain our
> > buffer recycling which enhances throughput. I never received a rely
> so it was
> > left in my last patch.
> >
> > The
Jeff Garzik wrote:
> Marc St-Jean wrote:
> > +inline static void
> > +mspeth_skb_headerinit(struct sk_buff *skb)
> > +{
> > + /* these are essential before init */
> > + dst_release(skb->dst);
> > +#ifdef CONFIG_XFRM
> > +
Thanks for the feedback Jeff. I have made all modifications but I have one
question regarding the SKB recycling.
Removing the backwards compatibility for the linux 2.4 eliminated the
badness in mspeth_skb_headerinit(). However there is still some SKB code
in mspeth_alloc_skb(). You didn't specific
