[PATCH iproute2 v2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob

tc_pie_xstats->prob has a maximum value of (2^64 - 1). Signed-off-by: Leslie Monis --- tc/q_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_pie.c b/tc/q_pie.c index f7924ef5..236ea31b 100644 --- a/tc/q_pie.c +++ b/tc/q_pie.c @@ -198,7 +198,7 @@ static

[PATCH iproute2 v2 2/2] tc: pie: update man page

Update man page to reflect the changes made in Linux. Signed-off-by: Leslie Monis --- man/man8/tc-pie.8 | 40 ++-- man/man8/tc.8 | 1 + 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/man/man8/tc-pie.8 b/man/man8/tc-pie.8 index 278293bd

[PATCH iproute2 v2 0/2] tc: pie: make tc/q_pie.c consistent with the kernel

. Leslie Monis (2): tc: pie: change maximum integer value of tc_pie_xstats->prob tc: pie: update man page man/man8/tc-pie.8 | 40 ++-- man/man8/tc.8 | 1 + tc/q_pie.c| 2 +- 3 files changed, 20 insertions(+), 23 deletions(-) -- 2.17.1

Re: [PATCH iproute2 2/2] tc: pie: update man page

On Wed, Mar 27, 2019 at 07:54:58AM -0700, Stephen Hemminger wrote: > On Sun, 24 Mar 2019 00:18:35 +0530 > Leslie Monis wrote: > > > Update man page to reflect the changes made in Linux. > > > > Signed-off-by: Leslie Monis > > This one is fine. Please resub

Re: [PATCH iproute2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob

On Wed, Mar 27, 2019 at 07:53:57AM -0700, Stephen Hemminger wrote: > On Sun, 24 Mar 2019 00:18:34 +0530 > Leslie Monis wrote: > > > tc_pie_xstats->prob has a maximum value of (2^64 - 1). > > > > Signed-off-by: Leslie Monis > > --- > > tc/q_pie.c | 2

[PATCH iproute2 2/2] tc: pie: update man page

Update man page to reflect the changes made in Linux. Signed-off-by: Leslie Monis --- man/man8/tc-pie.8 | 40 ++-- man/man8/tc.8 | 1 + 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/man/man8/tc-pie.8 b/man/man8/tc-pie.8 index 278293bd

[PATCH iproute2 1/2] tc: pie: change maximum integer value of tc_pie_xstats->prob

tc_pie_xstats->prob has a maximum value of (2^64 - 1). Signed-off-by: Leslie Monis --- tc/q_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_pie.c b/tc/q_pie.c index f7924ef5..6566ca10 100644 --- a/tc/q_pie.c +++ b/tc/q_pie.c @@ -198,7 +198,7 @@ static

[PATCH iproute2 0/2] tc: pie: make tc/q_pie.c consistent with the kernel

The PIE qdisc implementation in Linux has recently been aligned with RFC 8033. This patch series makes tc/q_pie.c consistent with that implementation and also updates the man page tc-pie(8). Leslie Monis (2): tc: pie: change maximum integer value of tc_pie_xstats->prob tc: pie: update

[PATCH] net: sched: Kconfig: update reference link for PIE

RFC 8033 replaces the IETF draft for PIE Signed-off-by: Leslie Monis --- net/sched/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/Kconfig b/net/sched/Kconfig index 1b9afdee5ba9..5c02ad97ef23 100644 --- a/net/sched/Kconfig +++ b/net/sched/Kconfig

[PATCH net-next] net: sched: pie: avoid slow division in drop probability decay

As per RFC 8033, it is sufficient for the drop probability decay factor to have a value of (1 - 1/64) instead of 98%. This avoids the need to do slow division. Suggested-by: David Laight Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH net-next] net: sched: pie: fix 64-bit division

On Thu, Feb 28, 2019 at 10:10:33AM +, David Laight wrote: > From: Leslie Monis > > Sent: 27 February 2019 16:12 > > > > On Wed, Feb 27, 2019 at 10:11:14AM +, David Laight wrote: > > > From: Leslie Monis > > > > Sent: 27 February 2019 01:00 >

Re: [PATCH net-next] net: sched: pie: fix 64-bit division

On Wed, Feb 27, 2019 at 10:11:14AM +, David Laight wrote: > From: Leslie Monis > > Sent: 27 February 2019 01:00 > > Use div_u64() to resolve build failures on 32-bit platforms. > > > > Fixes: 3f7ae5f3dc52 ("net: sched: pie: add more cases to auto-tune alpha

[PATCH net-next] net: sched: pie: fix 64-bit division

Use div_u64() to resolve build failures on 32-bit platforms. Fixes: 3f7ae5f3dc52 ("net: sched: pie: add more cases to auto-tune alpha and beta") Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_p

Re: [PATCH] net: sched: pie: fix mistake in reference link

On Tue, Feb 26, 2019 at 03:53:31PM +0530, Leslie Monis wrote: > Fix the incorrect reference link to RFC 8033 > > Signed-off-by: Leslie Monis > --- > net/sched/sch_pie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/sch_pie.c b/net

[PATCH] net: sched: pie: fix mistake in reference link

Fix the incorrect reference link to RFC 8033 Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index f8314a14a256..4c0670b6aec1 100644 --- a/net/sched/sch_pie.c +++ b/net/sched

Re: [PATCH net-next v3 0/7] net: sched: pie: align PIE implementation with RFC 8033

On Mon, Feb 25, 2019 at 04:38:11PM -0800, Stephen Hemminger wrote: > On Tue, 26 Feb 2019 00:39:54 +0530 > Leslie Monis wrote: > > > The current implementation of the PIE queuing discipline is according to the > > IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] a

[PATCH net-next v3 2/7] net: sched: pie: change default value of pie_params->target

From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the target queue delay. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-

[PATCH net-next v3 7/7] net: sched: pie: update references

From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht

[PATCH net-next v3 3/7] net: sched: pie: change default value of pie_params->tupdate

From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the update interval. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-

[PATCH net-next v3 4/7] net: sched: pie: change initial value of pie_vars->burst_time

: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 702f75afc312..d88ab53593b3 100644 --- a/net/sched/sch_pie.c

[PATCH net-next v3 5/7] net: sched: pie: add more cases to auto-tune alpha and beta

ned-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_pie.c| 65 +- 2 files c

[PATCH net-next v3 6/7] net: sched: pie: add derandomization mechanism

by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis Acked-by: Dave Taht Acked-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletio

[PATCH net-next v3 0/7] net: sched: pie: align PIE implementation with RFC 8033

The current implementation of the PIE queuing discipline is according to the IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. However, a lot of necessary modifications and enhancements have been propos

[PATCH net-next v3 1/7] net: sched: pie: change value of QUEUE_THRESHOLD

From: "Mohit P. Tahiliani" RFC 8033 recommends a value of 16384 bytes for the queue threshold. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Mo

Re: [PATCH net-next v2 5/7] net: sched: pie: add more cases to auto-tune alpha and beta

On Mon, Feb 25, 2019 at 09:40:38AM -0800, David Miller wrote: > From: Leslie Monis > Date: Mon, 25 Feb 2019 15:50:49 +0530 > > > + power = 100; > > + while (q->vars.prob < MAX_PROB / (u64)power && > > You have to use div_u64() or sim

Re: [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033

On Mon, Feb 25, 2019 at 06:11:25AM -0800, Dave Taht wrote: > Jamal Hadi Salim writes: > > > On 2019-02-25 8:43 a.m., Jamal Hadi Salim wrote: > >> On 2019-02-25 5:20 a.m., Leslie Monis wrote: > >>> The current implementation of the PIE queuing discipline is > &

[PATCH net-next v2 3/7] net: sched: pie: change default value of pie_params->tupdate

From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the update interval. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-

[PATCH net-next v2 5/7] net: sched: pie: add more cases to auto-tune alpha and beta

ned-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_pie.c| 65 +- 2 files changed, 33 insertions(+), 34 deletions(-) diff --git

[PATCH net-next v2 6/7] net: sched: pie: add derandomization mechanism

by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched

[PATCH net-next v2 2/7] net: sched: pie: change default value of pie_params->target

From: "Mohit P. Tahiliani" RFC 8033 suggests a default value of 15 milliseconds for the target queue delay. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-

[PATCH net-next v2 7/7] net: sched: pie: update references

From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch

[PATCH net-next v2 4/7] net: sched: pie: change initial value of pie_vars->burst_time

: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 702f75afc312..d88ab53593b3 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -92,8 +92,8 @@ s

[PATCH net-next v2 1/7] net: sched: pie: change value of QUEUE_THRESHOLD

From: "Mohit P. Tahiliani" RFC 8033 recommends a value of 16384 bytes for the queue threshold. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Le

[PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033

The current implementation of the PIE queuing discipline is according to the IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. However, a lot of necessary modifications and enhancements have been propos

[PATCH net-next 8/8] net: sched: pie: update references

From: "Mohit P. Tahiliani" RFC 8033 replaces the IETF draft for PIE Signed-off-by: Mohit P. Tahiliani Signed-off-by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch

[PATCH net-next 7/8] net: sched: pie: add derandomization mechanism

by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c ind

[PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta

by: Dhaval Khandla Signed-off-by: Hrishikesh Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_p

[PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive

h Hiraskar Signed-off-by: Manish Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index c84e91e..b68b367 100644 --- a

[PATCH net-next 4/8] net: sched: pie: change initial value of pie_vars->burst_time

sh Kumar B Signed-off-by: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 9912d9cc..f4e189a 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -

[PATCH net-next 3/8] net: sched: pie: change default value of pie_params->tupdate

n D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index c5d6d6b..9912d9cc 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -81,7 +81,7 @@ static void pie_p

[PATCH net-next 2/8] net: sched: pie: change default value of pie_params->target

: Sachin D. Patil Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index 56c9e4d..c5d6d6b 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -83,7 +83,7 @@ static void pie_p

[PATCH net-next 1/8] net: sched: pie: change value of QUEUE_THRESHOLD

Signed-off-by: Leslie Monis --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index d142937..56c9e4d 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -31,7 +31,7 @@ #include #include -#define QUEUE

[PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033

The current implementation of PIE queueing discipline is according to an IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. However, a lot of necessary modifications and enhancements have been proposed i