Re: [net-next PATCH v2 10/14] device property: Introduce fwnode_get_id()

ference(const struct > fwnode_handle *fwnode, > > const char *fwnode_get_name(const struct fwnode_handle *fwnode); > const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode); > +int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id); > struct fwnode_handle *fwnode_get_parent(const struct fwnode_handle *fwnode); > struct fwnode_handle *fwnode_get_next_parent( > struct fwnode_handle *fwnode); -- Regards, Laurent Pinchart

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

Hi Rafael, On Mon, Nov 30, 2020 at 06:55:57PM +0100, Rafael J. Wysocki wrote: > On Mon, Nov 30, 2020 at 6:35 PM Laurent Pinchart wrote: > > On Mon, Nov 30, 2020 at 05:37:52PM +0100, Rafael J. Wysocki wrote: > > > On Fri, Nov 27, 2020 at 11:16 AM Geert Uytterhoeven wrote: >

Re: [PATCH v3 1/2] PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter

opic, I was wondering, is there a reason we can't select autosuspend behaviour automatically when autosuspend is enabled ? > > to make it clear it does a synchronous get? > > > > I had to look into the implementation to verify that a change like > > I'm not sure why, because the kerneldoc is unambiguous AFAICS. > > > > > - ret = pm_runtime_get_sync(&pdev->dev); > > + ret = pm_runtime_resume_and_get(&pdev->dev); > > > > in the follow-up patches is actually a valid change, maintaining > > synchronous operation. Oh, pm_runtime_resume() is synchronous, too... > > Yes, it is. -- Regards, Laurent Pinchart

Re: [PATCH 00/49] DRM driver for Hikey 970

Hi Mauro, On Tue, Aug 25, 2020 at 01:30:25PM +0200, Mauro Carvalho Chehab wrote: > Em Tue, 25 Aug 2020 05:29:29 +1000 > Dave Airlie escreveu: > > > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > > wrote: > > > > > > Hi Mauro, > > > >

Re: [PATCH 00/49] DRM driver for Hikey 970

Hi Mauro, On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu: > > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart wrote: > > > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote: >

Re: [PATCH 00/49] DRM driver for Hikey 970

644 drivers/staging/hikey9xx/gpu/Makefile > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin960_defs.c > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin970_defs.c > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dpe.h > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c > > create mode 100644 > > drivers/staging/hikey9xx/gpu/kirin9xx_drm_overlay_utils.c > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_dw_dsi_reg.h > > create mode 100644 drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h -- Regards, Laurent Pinchart

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

On Mon, Jul 27, 2020 at 08:37:20PM +0300, Laurent Pinchart wrote: > On Mon, Jul 27, 2020 at 08:41:23AM -0700, Chris Healy wrote: > > On Mon, Jul 27, 2020 at 8:24 AM Laurent Pinchart wrote: > > > On Mon, Jul 27, 2020 at 02:05:45PM +0200, Andrew Lunn wrote: > > > > On S

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

Hi Chris, On Mon, Jul 27, 2020 at 08:41:23AM -0700, Chris Healy wrote: > On Mon, Jul 27, 2020 at 8:24 AM Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 02:05:45PM +0200, Andrew Lunn wrote: > > > On Sun, Jul 26, 2020 at 08:01:25PM -0700, Chris Healy wrote: > > &g

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

61] Sending DHCP requests ., OK [ 15.720925] IP-Config: Got DHCP answer from 192.168.2.47, my address is 192.168.2.210 The LED on the connected switch confirms this, it lits up synchronously with the "Link is up" message. It's not an urgent issue, but if someone had a few pointers on how I could debug that, it would be appreciated. -- Regards, Laurent Pinchart

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

20 Reverting this on top of v5.8-rc6 (without any revert of FEC commits) fixes the issue too. > On Sun, Jul 26, 2020 at 7:33 PM Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 04:14:32AM +0200, Andrew Lunn wrote: > > > On Mon, Jul 27, 2020 at 05:06:31AM +0300, Laurent Pinchart

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

Hi Chris, On Sun, Jul 26, 2020 at 07:13:20PM -0700, Chris Healy wrote: > On Sun, Jul 26, 2020 at 7:06 PM Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > >> On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > &g

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

Hi Andrew, On Mon, Jul 27, 2020 at 04:14:32AM +0200, Andrew Lunn wrote: > On Mon, Jul 27, 2020 at 05:06:31AM +0300, Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: &g

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > > > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM, >

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

ecs_to_jiffies(FEC_MII_TIMEOUT)); > + if (time_left == 0) { > netdev_err(fep->netdev, "MDIO write timeout\n"); > + ret = -ETIMEDOUT; > + } > > out: > pm_runtime_mark_last_busy(dev); > @@ -2144,9 +2145,6 @@ static int fec_enet_mii_init(struct platform_device > *pdev) > > writel(fep->phy_speed, fep->hwp + FEC_MII_SPEED); > > - /* Clear any pending transaction complete indication */ > - writel(FEC_ENET_MII, fep->hwp + FEC_IEVENT); > - > fep->mii_bus = mdiobus_alloc(); > if (fep->mii_bus == NULL) { > err = -ENOMEM; > @@ -3688,6 +3686,7 @@ fec_probe(struct platform_device *pdev) > fep->irq[i] = irq; > } > > + init_completion(&fep->mdio_done); > ret = fec_enet_mii_init(pdev); > if (ret) > goto failed_mii_init; -- Regards, Laurent Pinchart

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

t; - file = anon_inode_getfile("[eventfd]", &eventfd_fops, ctx, > >> + file = anon_inode_getfile("[eventfd]", fops, ctx, > >> O_RDWR | (flags & EFD_SHARED_FCNTL_FLAGS)); > >>if (IS_ERR(file)) > >>eventfd_free_ctx(ctx); > >> diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h > >> index ff0b981..87de343 100644 > >> --- a/include/linux/eventfd.h > >> +++ b/include/linux/eventfd.h > >> @@ -8,23 +8,11 @@ > >> #ifndef _LINUX_EVENTFD_H > >> #define _LINUX_EVENTFD_H > >> > >> +#include > >> + > >> #include > >> #include > >> > >> -/* > >> - * CAREFUL: Check include/uapi/asm-generic/fcntl.h when defining > >> - * new flags, since they might collide with O_* ones. We want > >> - * to re-use O_* flags that couldn't possibly have a meaning > >> - * from eventfd, in order to leave a free define-space for > >> - * shared O_* flags. > >> - */ > >> -#define EFD_SEMAPHORE (1 << 0) > >> -#define EFD_CLOEXEC O_CLOEXEC > >> -#define EFD_NONBLOCK O_NONBLOCK > >> - > >> -#define EFD_SHARED_FCNTL_FLAGS (O_CLOEXEC | O_NONBLOCK) > >> -#define EFD_FLAGS_SET (EFD_SHARED_FCNTL_FLAGS | EFD_SEMAPHORE) > >> - > >> struct file; > >> > >> #ifdef CONFIG_EVENTFD > >> diff --git a/include/uapi/linux/eventfd.h b/include/uapi/linux/eventfd.h > >> new file mode 100644 > >> index 000..097dcad > >> --- /dev/null > >> +++ b/include/uapi/linux/eventfd.h > >> @@ -0,0 +1,33 @@ > >> +/* > >> + * Copyright (C) 2013 Martin Sustrik > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License as published by > >> + * the Free Software Foundation; either version 2 of the License, or > >> + * (at your option) any later version. > >> + */ > >> + > >> +#ifndef _UAPI_LINUX_EVENTFD_H > >> +#define _UAPI_LINUX_EVENTFD_H > >> + > >> +/* For O_CLOEXEC */ > >> +#include > >> +#include > >> + > >> +/* > >> + * CAREFUL: Check include/asm-generic/fcntl.h when defining > >> + * new flags, since they might collide with O_* ones. We want > >> + * to re-use O_* flags that couldn't possibly have a meaning > >> + * from eventfd, in order to leave a free define-space for > >> + * shared O_* flags. > >> + */ > >> + > >> +/* Provide semaphore-like semantics for reads from the eventfd. */ > >> +#define EFD_SEMAPHORE (1 << 0) > >> +/* Provide event mask semantics for the eventfd. */ > >> +#define EFD_MASK (1 << 1) > >> +/* Set the close-on-exec (FD_CLOEXEC) flag on the eventfd. */ > >> +#define EFD_CLOEXEC O_CLOEXEC > >> +/* Create the eventfd in non-blocking mode. */ > >> +#define EFD_NONBLOCK O_NONBLOCK > >> +#endif /* _UAPI_LINUX_EVENTFD_H */ -- Regards, Laurent Pinchart

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

Hi Geert, On Saturday, 21 April 2018 11:07:11 EEST Laurent Pinchart wrote: > On Friday, 20 April 2018 16:28:29 EEST Geert Uytterhoeven wrote: > > The Renesas Fine Display Processor driver is used on Renesas R-Car SoCs > > only. Since commit 9b5ba0df4ea4f940 ("ARM:

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

a more appropriate platform dependency > than the legacy ARCH_SHMOBILE, hence use the former. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven Acked-by: Laurent Pinchart How would you like to get this merg

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

s > > masking if those users already integrate the limit check, and lfence > > they don't." > > > > ...which translates to narrow the pointer for get_user() and use a > > barrier for __get_user(). > > Great, that matches my thinking re set_fs but I'm still worried about > finding all the places where the bound is conditional for other users > of the macro. Then again, finding the places that need this macro in the > first place is tough enough so perhaps analysing the bound calculation > doesn't make it much worse. It might not now, but if the bound calculation changes later, I'm pretty sure we'll forget to update the speculation barrier macro at least in some cases. Without the help of static (or possibly dynamic) code analysis I think we're bound to reintroduce problems over time, but that's true for finding places where the barrier is needed, not just for barrier selection based on bound calculation. -- Regards, Laurent Pinchart

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

Hi Greg, On Tuesday, 9 January 2018 12:04:10 EET Greg KH wrote: > On Tue, Jan 09, 2018 at 10:40:21AM +0200, Laurent Pinchart wrote: > > On Saturday, 6 January 2018 11:40:26 EET Greg KH wrote: > >> On Sat, Jan 06, 2018 at 10:09:07AM +0100, Greg KH wrote: > >> > &g

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

eads based on an invalid value of 'pin'. > >> > >> Based on an original patch by Elena Reshetova. > >> > >> Cc: Laurent Pinchart > >> Cc: Mauro Carvalho Chehab > >> Cc: linux-me...@vger.kernel.org > >> Signed-off-by: Elena Resh

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

es for this, even if I agree with them. > Based on an original patch by Elena Reshetova. > > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Elena Reshetova > Signed-off-by: Dan Williams > --- > drivers/media/usb/

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

think that's a good idea. > > But I'm about to slurp up this whole series into my tree, how about making > that an incremental patch? I'm fine with that. Bhumika, would you like to submit an incremental patch, or should I do it ? -- Regards, Laurent Pinchart

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

+static const struct config_item_type uvcg_streaming_class_grp_type = { > .ct_owner = THIS_MODULE, > }; > > @@ -2104,7 +2104,7 @@ static void uvcg_streaming_class_drop_link(struct > config_item *src, struct config_group group; > } uvcg_streaming_grp; > > -static struct config_item_type uvcg_streaming_grp_type = { > +static const struct config_item_type uvcg_streaming_grp_type = { > .ct_owner = THIS_MODULE, > }; Now we have 9 const instances of the config_item_type structure that are identical, with only the .ct_owner field set. Should they be all merged into a single structure ? > @@ -2190,7 +2190,7 @@ static void uvc_attr_release(struct config_item *item) > NULL, > }; > > -static struct config_item_type uvc_func_type = { > +static const struct config_item_type uvc_func_type = { > .ct_item_ops= &uvc_item_ops, > .ct_attrs = uvc_attrs, > .ct_owner = THIS_MODULE, -- Regards, Laurent Pinchart

Re: [PATCH 2/2] sh_eth: Do not print an error message for probe deferral

ess the error message in case of probe deferral. > While at it, shorten the message, and add the actual error code. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/net/ethernet/renesas/sh_eth.c | 3 ++- > 1 file changed, 2 insertions(+),

Re: [PATCH 1/2] sh_eth: Use platform device for printing before register_netdev()

he platform device instead to fix this: > > sh-eth ee70.ethernet: failed to initialise MDIO > > Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the > network device") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart >

[PATCH][RESEND] dt-bindings: net: renesas-ravb: Add support for R8A7796 RAVB

Add a new compatible string for the R8A7796 (M3-W) RAVB. Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) The patch has been posted to the linux-renesas-soc

Re: NFS issue on v4.4-rc3

Ping ? On Saturday 05 December 2015 00:53:24 Laurent Pinchart wrote: > Hello, > > I ran into the following warning when running v4.4-rc3 on a TI OMAP4 > (pandaboard) using nfsroot. > > [ 8063.208526] [ cut here ] > [ 8063.213653] WARNING: CPU:

NFS issue on v4.4-rc3

from 192.168.1.254, port=938 (67248960 bytes) I'm afraid the client messages have been lost in my scroll buffer, but they were related to the to oversized requests as well. I've been running the same setup on v4.3 without any issue for quite a long time. -- Regards, Laurent

Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

his is quite easy to fix for the non-CONFIG_PPC_CPM_NEW_BINDING case but I'm not familiar with OF bindings (yet) to fix the CONFIG_PPC_CPM_NEW_BINDING case. -- Laurent Pinchart CSE Semaphore Belgium Chaussée de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75 pgp1gLzoe0cQF.pgp Description: PGP signature

Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart

ven though they both contain some kind of status information. -- Laurent Pinchart CSE Semaphore Belgium Chaussée de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75 pgp4F3bh4jbhk.pgp Description: PGP signature

Re: [PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25

a pair of patches from Laurent Pinchart > for addition platform-data based configuration, please > apply these from this if you can attribute these correctly > to Laurent, otherwise ask Laurent to resubmit. I have > signed-off-by both these patches, but would be equally > happy a

Re: [PATCH 1/2] [DM9000] Added support for big-endian hosts

On Saturday 25 August 2007 06:31, Jeff Garzik wrote: > Laurent Pinchart wrote: > > This patch splits the receive status in 8bit wide fields and convert the > > packet length from little endian to CPU byte order. > > > > Signed-off-by: Laurent Pinchart <[EMAIL PROTEC

[PATCH 2/2] [DM9000] External PHY support

This patch adds a flag to the DM9000 platform data which, when set, configures the device to use an external PHY. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c |6 ++ include/linux/dm9000.h |1 + 2 files changed, 7 insertions(+), 0 deletions(-)

[PATCH 1/2] [DM9000] Added support for big-endian hosts

This patch splits the receive status in 8bit wide fields and convert the packet length from little endian to CPU byte order. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 0/2] [DM9000] Support for big endian hosts and external PHY

These patches update the DM9000 driver to add support for big endian hosts and external PHY. They are resubmissions of patches based on 2.6.22, that I have now updated to 2.6.23-rc3. -- Laurent Pinchart CSE Semaphore Belgium Chaussée de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387

Re: [PATCH] [DM9000] Add support for big-endian hosts

On Tuesday 14 August 2007 20:25, Ben Dooks wrote: > On Tue, Aug 14, 2007 at 01:22:32PM +0200, Laurent Pinchart wrote: > > This patch splits the receive status in 8bit wide fields and convert the > > packet length from little endian to CPU byte order. > > Which version of th

[PATCH] [DM9000] Add support for big-endian hosts

This patch splits the receive status in 8bit wide fields and convert the packet length from little endian to CPU byte order. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/d

[PATCH] [DM9000] External PHY support

This patch adds a flag to the DM9000 platform data which, when set, configures the device to use an external PHY. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/dm9000.c |6 ++ include/linux/dm9000.h |1 + 2 files changed, 7 insertions(+), 0 deletions(-)