[PATCH] Set DF bit for IPv4 GRE tunnels with fixed TTL

2015-12-05 Thread Konstantin Shemyak
The DF bit on IPv4 GRE tunnels with fixed TTL is enforced in order to prevent networking loops. This was the original behavior of GRE tunnels, lost in the refactoring. Signed-off-by: Konstantin Shemyak --- net/ipv4/ip_gre.c | 4 1 file changed, 4 insertions(+) diff --git a/net/ipv4

Re: IPv4 tunnels: why IP-IP and SIT enforce DF bit, but GRE does not?

2015-12-05 Thread Konstantin Shemyak
On 01.12.2015 19:08, David Miller wrote: From: Hannes Frederic Sowa Date: Tue, 01 Dec 2015 14:30:55 +0100 On Tue, Dec 1, 2015, at 14:20, Konstantin Shemyak wrote: My point was not to question its feasibility, but to make it similar across GRE, IP-IP and SIT tunnels. I would send a patch to

Re: IPv4 tunnels: why IP-IP and SIT enforce DF bit, but GRE does not?

2015-12-01 Thread Konstantin Shemyak
On 01.12.2015 12:15, Hannes Frederic Sowa wrote: Hello, On Thu, Nov 26, 2015, at 19:28, Konstantin Shemyak wrote: The kernel has taken the decision to always enforce DF bit on IPv4 tunnels, which have fixed (not inherited) TTL (e.g. net/ipv4/ipip.c:ipip_tunnel_ioctl()). Commment by Alexey

IPv4 tunnels: why IP-IP and SIT enforce DF bit, but GRE does not?

2015-11-26 Thread Konstantin Shemyak
c54419321455631 removed this enforcing from GRE tunnels, not changing this behavior for IP-IP (net/ipv4/ipip.c) and SIT (net/ipv6/sit.c). It can be discussed whether such enforcing of DF bit is exactly the desired behavior, but shouldn't it at least be identical across IPv4 tunnels? Konst

Re: [PATCH iproute2] ip_tunnel: determine tunnel address family from the tunnel type

2015-11-26 Thread Konstantin Shemyak
On 24.11.2015 02:26, Stephen Hemminger wrote: On Thu, 12 Nov 2015 21:10:08 + Konstantin Shemyak wrote: When creating an IP tunnel over IPv6, the address family must be passed in the option, e.g. ip -6 tunnel add mode ip6gre local 1::1 remote 2::2 This makes it impossible to create both

[PATCH iproute2] ip_tunnel: determine tunnel address family from the tunnel type

2015-11-12 Thread Konstantin Shemyak
relevant for only one address family. The patch determines whether the applicable address family is AF_INET6 instead of the default AF_INET and makes the "-6" option unnecessary for "ip tunnel add". Signed-off-by: Konstantin Shemyak --- ip/iptunnel.c

[PATCH iproute2 v3] add 'vti'/'vti6' tunnel modes to ip-tunnel manual page

2015-08-29 Thread Konstantin Shemyak
* "vti" and "vti6" tunnel modes added to ip-tunnel.8 manual page * Added "hoplimit" terminology for IPv6 * Corrected usage line * Minor language fix --- man/man8/ip-tunnel.8 | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/man/man8/ip-tunnel.8 b/man/ma