Re: [PATCH net] amd-xgbe: Fix DMA API debug warning

buffer > pages allocated and then performing a dma_sync_single_for_cpu against > a calculated DMA address. The proper thing to do is to use the > dma_sync_single_range_for_cpu with a base DMA address and an offset. > > Reported-by: Kim Phillips > Signed-off-by: Tom Lendacky >

amd-xgbe e0700000.xgmac: DMA-API: device driver tries to sync DMA memory it has not allocated

Hi Tom, A pristine 4.1 kernel with CONFIG_DMA_API_DEBUG=y produces this call trace on an AMD Seattle: [ 112.896576] [ cut here ] [ 112.896591] WARNING: CPU: 2 PID: 1059 at lib/dma-debug.c:1202 check_sync+0x138/0x56c() [ 112.896597] amd-xgbe e070.xgmac: DMA-API: dev

[PATCH] phylib: Add Realtek 821x eth PHY support

this PHY present on the MPC8315E and MPC837xE RDB boards. Signed-off-by: Johnson Leung <[EMAIL PROTECTED]> Signed-off-by: Kevin Lam <[EMAIL PROTECTED]> Signed-off-by: Joe D'Abbraccio <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- dri

Re: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

On Thu, 10 Jan 2008 21:41:20 -0700 "Aggrwal Poonam" <[EMAIL PROTECTED]> wrote: > Hello All > > I am waiting for more feedback on the patches. > > If there are no objections please consider them for 2.6.25. > if this isn't going to go through Alessandro Rubini/misc drivers, can it go through th

[PATCH 1/3][RESEND] phylib: add PHY interface modes for internal delay for tx and rx only

Allow phylib specification of cases where hardware needs to configure PHYs for Internal Delay only on either RX or TX (not both). Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Li Yang <[EMAIL PROTECTED]> --- include/

[PATCH 3/3][RESEND] ucc_geth: handle passing of RX-only and TX-only internal delay PHY connection type parameters

Extend the RGMII-Internal Delay specification case to include TX-only and RX-only variants. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 10 ++ 1

[PATCH 0/3][RESEND] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

these 3 patches are a resend of patches 2-4 (out of 5) that were originally sent 2007-11-05* (patches 1 and 5 were picked up by Kumar to go through powerpc). Jeff, Leo has acked these, please consider for 2.6.24. Thanks, Kim * http://marc.info/?l=linux-netdev&m=119428688804765&w=1 - To unsubscr

[PATCH 2/3][RESEND] phylib: marvell: add support for TX-only and RX-only Internal Delay

Previously, Internal Delay specification implied the delay be applied to both TX and RX. This patch allows for separate TX/RX-only internal delay specification. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Li Yang <[

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

On Mon, 5 Nov 2007 12:15:30 -0600 Kim Phillips <[EMAIL PROTECTED]> wrote: > Hello all, > > the following patches fix RGMII timing for rev. 2.1 of the mpc8360, > according to erratum #2 (erratum text included below). Basically the > most intrusive part is the addition of t

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

On Fri, 9 Nov 2007 16:25:07 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Thu, Nov 08, 2007 at 01:11:35PM -0600, Kim Phillips wrote: > [...] > > right, but whether it does or not doesn't affect your failure outcome > > either I'm assuming. > > &g

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

On Thu, 8 Nov 2007 21:39:52 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Thu, Nov 08, 2007 at 12:15:08PM -0600, Kim Phillips wrote: > > On Thu, 8 Nov 2007 17:16:11 +0300 > > Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > > > On Mon, Nov 05, 20

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

On Thu, 8 Nov 2007 17:16:11 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Mon, Nov 05, 2007 at 12:15:30PM -0600, Kim Phillips wrote: > > Hello all, > > > > the following patches fix RGMII timing for rev. 2.1 of the mpc8360, > > according to erratu

[PATCH 5/5] powerpc: handle mpc8360 rev. 2.1 RGMII timing erratum

if on a rev. 2.1, adjust UCC clock and data timing characteristics as specified in the rev.2.1 erratum #2. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/mpc836x_mds.c | 31 ++-- 1 files changed, 28 insertions(+), 3 deletions(-)

[PATCH 3/5] phylib: marvell: add support for TX-only and RX-only Internal Delay

Previously, Internal Delay specification implied the delay be applied to both TX and RX. This patch allows for separate TX/RX-only internal delay specification. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/marvell.c | 26 +- 1 files chang

[PATCH 4/5] ucc_geth: handle passing of RX-only and TX-only internal delay PHY connection type parameters

Extend the RGMII-Internal Delay specification case to include TX-only and RX-only variants. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drive

[PATCH 1/5] powerpc: document rgmii-rxid and rgmii-txid phy-connection-types

A h/w bug requires we program the PHY in RGMII mode for internal delay on the receive or transmit side only; document the new property values. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt |5 +++-- 1 files changed, 3 insertions

[PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

Hello all, the following patches fix RGMII timing for rev. 2.1 of the mpc8360, according to erratum #2 (erratum text included below). Basically the most intrusive part is the addition of two new RGMII Internal Delay modes; one for TX delay only, and the other for RX delay only (i.e, not both at t

[PATCH 2/5] phylib: add PHY interface modes for internal delay for tx and rx only

Allow phylib specification of cases where hardware needs to configure PHYs for Internal Delay only on either RX or TX (not both). Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- include/linux/phy.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux

[PATCH] ucc_geth: suppress 'qe_bd_t' undeclared error

drivers/net/ucc_geth.c:2151: error: ‘qe_bd_t’ undeclared (first use in this function) Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- Leo, this is for 2.6.23. drivers/net/ucc_geth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth.c b/d

Re: [PATCH] NET: add MAINTAINERS entry for ucc_geth driver

On Fri, 25 May 2007 13:54:02 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kim Phillips <[EMAIL PROTECTED]> Kim - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

On Wed, 23 May 2007 15:23:22 +0200 Jan Altenberg <[EMAIL PROTECTED]> wrote: > ucc_geth has been migrated to use the common phylib code. So lets add a > 'select PHYLIB' to the UCC_GETH Kconfig entry. > > Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> Acked-

Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

On Fri, 18 May 2007 09:07:42 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On May 17, 2007, at 8:53 PM, Jeff Garzik wrote: > > > Kim Phillips wrote: > >> On Tue, 15 May 2007 17:45:19 -0400 > >> Jeff Garzik <[EMAIL PROTECTED]> wrote: > >&

Re: [PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

On Tue, 15 May 2007 17:45:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kim Phillips wrote: > > It was agreed that phy-connection-type was a better name for > > the interface-type property, so this patch renames it. > > > > Also, the max-speed propert

[PATCH 4/5] gianfar: add support for SGMII

TECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/gianfar.c | 27 ++ drivers/net/gianfar.h |6 + drivers/net/gianfar_mii.c | 55 - 3 files changed, 77 insertions(+), 11 deletions(-)

[PATCH 5/5] phylib: m88e1111: enable SGMII mode

From: Kapil Juneja <[EMAIL PROTECTED]> If connected via SGMII, initialize with SGMII mode configured. Signed-off-by: Kapil Juneja <[EMAIL PROTECTED]> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/

[PATCH 1/5] phylib: add the ICPlus IP175C PHY driver

From: Michael Barkowski <[EMAIL PROTECTED]> The ICPlus IP175C sports a 100Mbit/s 4-port switch in addition to a dedicated 100Mbit/s WAN port. Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- RESEND of missed from last seri

[PATCH 2/5] phylib: enable RGMII-ID on the Marvell m88e1111 PHY

Support for configuring RGMII-ID (RGMII with internal delay) mode on the 88e and 88e1145. Also renamed 88es -> 88e (no references to an 88es part were found), and fixed some whitespace. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/marvell

[PATCH 3/5] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 40 drivers/net/ucc_geth_mii.c |9 + drivers/net/ucc_geth_mii.h | 10 +- 3 files changed, 26 insertions(+), 33 deletions(-) diff --git a/drive

[PATCH 6/6 v2] phylib: m88e1111: enable SGMII mode

From: Kapil Juneja <[EMAIL PROTECTED]> If connected via SGMII, initialize with SGMII mode configured. Signed-off-by: Kapil Juneja <[EMAIL PROTECTED]> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- somehow, a brace wen

[PATCH 2/6 v2] phylib: add the ICPlus IP175C PHY driver

From: Michael Barkowski <[EMAIL PROTECTED]> The ICPlus IP175C sports a 100Mbit/s 4-port switch in addition to a dedicated 100Mbit/s WAN port. Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- v2: adjusted to read PHY res

[PATCH 1/6 RESEND] Add support for the Davicom DM9161A PHY

Distinguish between the Davicom DM9161A PHY and the DM9161E. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- resend of the one of six in the series Jeff didn't receive. drivers/net/phy/davicom.c | 34 ++ 1 files changed, 26 insertions(+),

[PATCH 6/6] phylib: m88e1111: enable SGMII mode

From: Kapil Juneja <[EMAIL PROTECTED]> If connected via SGMII, initialize with SGMII mode configured. Signed-off-by: Kapil Juneja <[EMAIL PROTECTED]> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/

[PATCH 4/6] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 40 drivers/net/ucc_geth_mii.c |9 + drivers/net/ucc_geth_mii.h | 10 +- 3 files changed, 26 insertions(+), 33 deletions(-) diff --git a/drive

[PATCH 5/6] gianfar: add support for SGMII

TECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/gianfar.c | 27 ++ drivers/net/gianfar.h |6 + drivers/net/gianfar_mii.c | 55 - 3 files changed, 77 insertions(+), 11 deletions(-)

[PATCH 2/6] phylib: add the ICPlus IP175C PHY driver

The ICPlus IP175C sports a 100Mbit/s 4-port switch in addition to a dedicated 100Mbit/s WAN port. Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/Kconfig |6 ++ drivers/net/phy/Makefile |1 + dri

[PATCH 0/6] RESEND of missed ucc_geth phylib and SGMII patches

ith ucc_geth are currently broken. Thanks, Kim --- Kapil Juneja (2): gianfar: add support for SGMII phylib: m88e: enable SGMII mode Kim Phillips (4): Add support for the Davicom DM9161A PHY phylib: add the ICPlus IP175C PHY driver phylib: enable RGMII-ID on the Marvell

[PATCH 3/6] phylib: enable RGMII-ID on the Marvell m88e1111 PHY

Support for configuring RGMII-ID (RGMII with internal delay) mode on the 88e and 88e1145. Also renamed 88es -> 88e (no references to an 88es part were found), and fixed some whitespace. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/marvell

[PATCH 1/6] Add support for the Davicom DM9161A PHY

Distinguish between the Davicom DM9161A PHY and the DM9161E. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/davicom.c | 34 ++ 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/davicom.c b/drivers/n

Re: Kconfig warnings on latest GIT

On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez <[EMAIL PROTECTED]> wrote: > > drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' > refers to undefined symbol 'UCC_FAST' looks like this introduces the error: commit 7d776cb596994219584257eb5956b87628e5deaf Author: Timur

[PATCH] gianfar: add support for SGMII

TECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22 drivers/net/gianfar.c | 27 ++ drivers/net/gianfar.h |6 + drivers/net/gianfar_mii.c | 55 - 3 files changed, 77 ins

[PATCH] phylib: m88e1111: enable SGMII mode

From: Kapil Juneja <[EMAIL PROTECTED]> If connected via SGMII, initialize with SGMII mode configured. Signed-off-by: Kapil Juneja <[EMAIL PROTECTED]> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.

[PATCH] ucc_geth: eliminate max-speed, change interface-type to phy-connection-type

. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- Jeff, this patch depends on Stephen Rothwell's "[PATCH 2/2] Rename get_property to of_get_property: drivers" patch dated Tue, 1 May 2007 13:54:02 +1000 drivers/net/ucc_geth.c | 40

Re: patches for 2.6.22

On Wed, 2 May 2007 09:12:36 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > I'll pull patches 1, 3, 4 and wait on the dts changes until you sort > of the ucc driver issues with Jeff. sounds good. I was waiting for the get_property -> of_get_propery patches for ucc_geth before I submitted the

Re: [PATCH v2 1/7] phylib: add RGMII-ID interface mode definition

On Tue, 24 Apr 2007 14:02:33 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kim Phillips wrote: > > --- > > this 7 part series supercedes previous 2-set ucc_geth series submitted 10 > > apr 2007. > > please consider for 2.6.22 > > > > include

[PATCH v2] phylib: enable RGMII-ID on the Marvell m88e1111 PHY

Support for configuring RGMII-ID (RGMII with internal delay) mode on the 88e and 88e1145. Also renamed 88es -> 88e (no references to an 88es part were found), and fixed some whitespace. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- this version sets the d

[PATCH v2] phylib: add the ICPlus IP175C PHY driver

The ICPlus IP175C sports a 100Mbit/s 4-port switch in addition to a dedicated 100Mbit/s WAN port. Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- this version sets MII0 speed and duplex. drivers/net/phy/Kconfig |6 ++ dri

[PATCH v2 6/7] ucc_geth: fixes for ucc_geth_memclean

e positive values, although I think it's better to always initialize them. Signed-off-by: Ionut Nicu <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH v2 3/7] ucc_geth: NAPI-related bug fixes

s not there, simplify the event processing into if-else format. * Rx Busy now kicks off NAPI processing, while still being counted as an error. Signed-off-by: Michael Reiss <[EMAIL PROTECTED]> Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAI

[PATCH v2 4/7] ucc_geth: Fix interrupt coalescing size and alignment

From: Michael Barkowski <[EMAIL PROTECTED]> The rx interrupt coalescing table alignment was "guessed" to be 4, but should be 64. The size should be 8 * number of queues + 4. Verified in the MPC8323E manual. Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by

[PATCH v2 7/7] ucc_geth: version 1.1

Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 20bc105..16b9acd 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c @@

[PATCH v2 5/7] ucc_geth: Implement Transmit on Demand support

From: Michael Reiss <[EMAIL PROTECTED]> Transmit on Demand: Fix spelling in config option, and make it actually enable TOD. Signed-off-by: Michael Reiss <[EMAIL PROTECTED]> Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTE

[PATCH v2 1/7] phylib: add RGMII-ID interface mode definition

The RGMII spec allows compliance for devices that implement an internal delay on TXC or RXC inside the transmitter. This patch adds an RGMII_ID definition to support RGMII-ID devices in the phylib. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- this 7 part series supercedes previous

Re: phylib usage

On Wed, 11 Apr 2007 03:03:56 +0200 Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > On Tue, Apr 10, 2007 at 05:20:52PM -0500, Kim Phillips wrote: > > > (note I'm coming from an embedded world here.) > > Please read this: > > http://marc.info/?l=linux-net

Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

On Wed, 11 Apr 2007 03:01:58 +0200 Lennert Buytenhek <[EMAIL PROTECTED]> wrote: > On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote: > > > also adds RX & TX delay bits to help boards with clock skew > > problems. > > > > [...] > >

Re: phylib usage

On Tue, 10 Apr 2007 14:41:01 -0400 David Hollis <[EMAIL PROTECTED]> wrote: > I've been keeping an eye on PHYLIB since it's addition to the kernel > some time ago and I'm a bit curious as to why it doesn't seem to have > much up-take among other drivers. A quick check of the kernel source > shows

[PATCH] add the ICPlus IP175C PHY driver

From: Michael Barkowski <[EMAIL PROTECTED]> The ICPlus IP175C sports a 100Mbit/s 5-port switch in addition to a dedicated 100Mbit/s WAN port. Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]> Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22

[PATCH] Add support for the Davicom DM9161A PHY

Distinguish between the Davicom DM9161A PHY and the DM9161E. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22 drivers/net/phy/davicom.c | 34 ++ 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/drivers/n

[PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

also adds RX & TX delay bits to help boards with clock skew problems. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22 drivers/net/phy/marvell.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) di

[PATCH 2/2] ucc_geth: implement and increment version number

Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.22 drivers/net/ucc_geth.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 1b943e6..c9b1b28 100644 --- a/drivers/net/ucc_geth.c

[PATCH] Adapt ucc_geth driver to use new of_platform_device support

Include of_platform header, and use new of_[un]register_platform_driver() fns. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- please consider for 2.6.20 drivers/net/ucc_geth.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ucc_geth.c b/d

[PATCH 2/3] Add support for the Cicada 8201 PHY

Add support for the Cicada 8201 PHY, a.k.a Vitesse VSC8201. This PHY is present on the MPC8349mITX. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> --- drivers/net/phy/cicada.c | 42 -- 1 f