Re: [PATCHv3 2/2] kvm: retry nx_huge_page_recovery_thread creation

2025-03-04 Thread Keith Busch
On Tue, Mar 04, 2025 at 03:59:22PM +, Simon Horman wrote: > A minor nit from my side: > > As you are changing this line, and it seems like there will be another > revision of this series anyway, please consider updating the indentation to > use tabs. The patch is already applied to upstream a

Re: [PATCHv3 0/2]

2025-02-28 Thread Keith Busch
On Fri, Feb 28, 2025 at 07:29:45AM -0800, Sean Christopherson wrote: > On Fri, Feb 28, 2025, Keith Busch wrote: > > On Fri, Feb 28, 2025 at 06:32:47AM -0800, Sean Christopherson wrote: > > > > @@ -35,10 +35,12 @@ static inline int call_once(struct once *once, int >

Re: [PATCHv3 0/2]

2025-02-28 Thread Keith Busch
On Fri, Feb 28, 2025 at 06:32:47AM -0800, Sean Christopherson wrote: > On Fri, Feb 28, 2025, Sean Christopherson wrote: > > On Fri, Feb 28, 2025, Lei Yang wrote: > > > Hi Keith > > > > > > V3 introduced a new bug, the following error messages from qemu output > > > after applying this patch to boo

[PATCHv3 0/2]

2025-02-27 Thread Keith Busch
From: Keith Busch changes from v2: Fixed up the logical error in vhost on the new failure criteria Keith Busch (1): vhost: return task creation error instead of NULL Sean Christopherson (1): kvm: retry nx_huge_page_recovery_thread creation arch/x86/kvm/mmu/mmu.c| 12

[PATCHv3 1/2] vhost: return task creation error instead of NULL

2025-02-27 Thread Keith Busch
From: Keith Busch Lets callers distinguish why the vhost task creation failed. No one currently cares why it failed, so no real runtime change from this patch, but that will not be the case for long. Signed-off-by: Keith Busch --- arch/x86/kvm/mmu/mmu.c | 2 +- drivers/vhost/vhost.c | 2

[PATCHv3 2/2] kvm: retry nx_huge_page_recovery_thread creation

2025-02-27 Thread Keith Busch
_once complete only if what it called was successful. [implemented the kvm user side] Signed-off-by: Keith Busch --- arch/x86/kvm/mmu/mmu.c| 10 -- include/linux/call_once.h | 16 +++- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-05 Thread Keith Busch
On Mon, Apr 05, 2021 at 11:42:31PM +, Chuck Lever III wrote: > > On Apr 5, 2021, at 4:07 PM, Jason Gunthorpe wrote: > > On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote: > >> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote: > >>> From: Leon Romanovsky > >>> >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-30 Thread Keith Busch
On Mon, Mar 29, 2021 at 08:29:49PM -0500, Bjorn Helgaas wrote: > On Fri, Mar 26, 2021 at 04:01:48PM -0300, Jason Gunthorpe wrote: > > On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > > > > > My concern would be that we are defining the user space interface. > > > Once we have thi

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Keith Busch
On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > I also want to resurrect your idea of associating > "sriov_vf_msix_count" with the PF instead of the VF. I really like > that idea, and it better reflects the way both mlx5 and NVMe work. That is a better match for nvme: we can assi

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Keith Busch
On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > > > NVMe and mlx5 have basically identical functionality in this respect. > > Other devices and vendors will likely implement similar functionality. > > It would be i

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-12 Thread Keith Busch
On Fri, Mar 12, 2021 at 09:00:17AM -0400, Jason Gunthorpe wrote: > On Thu, Mar 11, 2021 at 06:53:16PM -0800, Alexander Duyck wrote: > > On Thu, Mar 11, 2021 at 3:21 PM Jason Gunthorpe wrote: > > > > > > On Thu, Mar 11, 2021 at 01:49:24PM -0800, Alexander Duyck wrote: > > > > > We don't need to inv

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Keith Busch
On Thu, Mar 11, 2021 at 04:22:34PM -0400, Jason Gunthorpe wrote: > On Thu, Mar 11, 2021 at 12:16:02PM -0700, Keith Busch wrote: > > On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > > > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > >

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Keith Busch
On Thu, Mar 11, 2021 at 12:17:29PM -0600, Bjorn Helgaas wrote: > On Wed, Mar 10, 2021 at 03:34:01PM -0800, Alexander Duyck wrote: > > > > I'm not so much worried about management software as the fact that > > this is a vendor specific implementation detail that is shaping how > > the kernel interf

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-09 Thread Keith Busch
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c > index eea0f453cfb6..8aac5bc60f4c 100644 > --- a/crypto/tcrypt.c > +++ b/crypto/tcrypt.c > @@ -2464,7 +2464,7 @@ static int do_test(const char *alg, u32 type, u32 mask, > int m, u32 num_m

Re: [PATCH nvme-cli v3 15/13] nvme: Add TCP transport

2018-11-26 Thread Keith Busch
The cli parts good to me. Is there any forseeable issue if I apply these ahead of the kernel integration? I don't see any, but just want to confirm since its all in one series.

Re: [PATCH net/jkirsher] bpf, xdp, i40e: fix i40e_build_skb skb reserve and truesize

2018-06-13 Thread Keith Busch
quot;). In any case, fix it by removing the I40E_SKB_PAD from both > skb_reserve() and truesize calculation. > > Fixes: cc5b114dcf98 ("bpf, i40e: add meta data support") > Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions") > Reported-by: Kei

Re: [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-12 Thread Keith Busch
On Mon, Mar 12, 2018 at 11:09:34AM -0700, Alexander Duyck wrote: > On Mon, Mar 12, 2018 at 10:40 AM, Keith Busch wrote: > > On Mon, Mar 12, 2018 at 10:21:29AM -0700, Alexander Duyck wrote: > >> diff --git a/include/linux/pci.h b/include/linux/pci.h > >> index 024a1b

Re: [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-12 Thread Keith Busch
On Mon, Mar 12, 2018 at 10:21:29AM -0700, Alexander Duyck wrote: > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 024a1beda008..9cab9d0d51dc 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1953,6 +1953,7 @@ static inline void pci_mmcfg_late_init(void) { } > int

Re: [PATCH] net/utils: fix semicolon.cocci warnings

2017-02-17 Thread Keith Busch
On Fri, Feb 17, 2017 at 01:52:54PM -0500, David Miller wrote: > From: kbuild test robot > Date: Fri, 17 Feb 2017 05:34:03 +0800 > > > net/core/utils.c:388:2-3: Unneeded semicolon > > > > > > Remove unneeded semicolon. > > > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > > > CC: