From: Keiichi KII <[EMAIL PROTECTED]>
This patch avoids a null pointer dereference when we read local_mac
for netconsole in configfs and shows default local mac address
value.
A null pointer dereference occurs when we call show_local_mac() via
local_mac entry in configfs before we set
}
> + netconsole_target_put(nt);
> }
> spin_unlock_irqrestore(&target_list_lock, flags);
> }
I created the following patch for performing some tests.
If there is nothing wrong with the patch, I'm going to continue to test.
Signed-off-by: Keiich
Hi Satyam,
I'm going to test/review these patches and report the result of tests
on IA64/x86 until this Friday.
> [0/9] netconsole: Multiple targets and dynamic reconfigurability
>
> This patchset is a rework of the original idea and patches posted by
> Keiichi Kii and Takayos
n't have enough time now. So I will check your patches more specific
at the weekend.
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
ld I add it to each patch and submit them to this list again?
Anybody could give me an advice?
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a messag
ot;network_interface" value is "eth0")?
I'm going to search configfs and modify interface to configfs.
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscri
make_netdev_class_name() here. I'd definitely recommend
not obfuscating this simple functionality here.
I understand. The wrapper method such as make_netdev_class_name() isn't
appropriate in this case.
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [EMAIL
andy for summary type tables.
4. Netlink does feel like overkill for this. Although newer generic netlink
makes it easier.
So, I implemented ioctls to add/remove port like this patch on the tty driver.
But I'm going to search configfs. Thank you for you information.
Thanks
--
Keiichi
rn -ENOMEM;
Just call kasprintf() directly, why the obfuscation?
I drew upon dev_change_name() method in net/core/dev.c.
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
t moving this up, but I'm misplacing the abobe
code?
or it isn't appropriate about coding style?
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bo
.
+static int miscdev_configured;
Is this really required? We just return with error if misc_register()
fails during module init time itself, so it's not really useful ever, is
it?
You're right. It isn't required.
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail
From: Keiichi KII <[EMAIL PROTECTED]>
We add ioctls for adding/removing target.
If we use NETCONSOLE_ADD_TARGET ioctl,
we can dynamically add netconsole target.
If we use NETCONSOLE_REMOVE_TARGET ioctl,
we can dynamically remoe netconsole target.
We attach a sample program for ioctl.
From: Keiichi KII <[EMAIL PROTECTED]>
update Documentation/networking/netconsole.txt
- how to use sysfs for dynamic configurability
- how to use ioctl for dynamic configurability
Signed-off-by: Keiichi KII <[EMAIL PROTECTED]>
---
Index: mm/Documentation/networking/ne
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are unable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
We use symbolic link for net_device.
The link in sysfs represents the corresponding network etherdevice.
-+- /sys/class/misc/
|-+- netconsole/
|-+- port1/
| |--- id [r--r--r--] id
| |--- net: [r--r--r--] net_dev: eth
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes for supporting multiple logging
agents.
1. extend netconsole to multiple netpolls
To send kernel messages to multiple logging agents, extend netcosnole
to be able to use multiple netpolls. Each netpoll
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
Acked-by: Matt Mackall <[EMAIL PROTECTED]>
Signed-off-by: Keiichi KII <[EMAIL PROTECTED]>
Signed-off-by: Takay
From: Keiichi KII <[EMAIL PROTECTED]>
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging age
/console because of the above
comments.
Thank you for your comments.
Any comments very welcome.
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 20 Apr 2007 18:51:13 +0900
Keiichi KII <[EMAIL PROTECTED]> wrote:
I started to do some cleanups and fixups here, but abandoned it when it was
all getting a bit large.
Here are some fixes against this patch:
I'm going to fix my patches by following your reviews and send new
ay that we had better use procfs instead of sysfs to show the
configurations of netconsole?
If so, I have a question.
I thought that "procfs use things related to process as far as possible".
Is it no problem to use procfs here?
--
Keiichi KII
NEC Corporation OSS Promotion Cent
Please include an update to Documentation/networking/netconsole.txt
OK, I update the documnet for the added functions in next patches.
Thank you for your comments.
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line
ments and reviews.
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Keiichi KII <[EMAIL PROTECTED]>
We add ioctls for adding/removing target.
If we use NETCONSOLE_ADD_TARGET ioctl,
we can dynamically add netconsole target.
If we use NETCONSOLE_REMOVE_TARGET ioctl,
we can dynamically remoe netconsole target.
We attach a sample program for ioctl.
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
We use symbolic link for net_device.
The link in sysfs represents the corresponding network etherdevice.
-+- /sys/class/misc/
|-+- netconsole/
|-+- port1/
| |--- id [r--r--r--] id
| |--- net: [rw-r--r--] net_dev: eth
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes for supporting multiple logging
agents.
1. extend netconsole to multiple netpolls
To send kernel messages to multiple logging agents, extend netcosnole
to be able to use multiple netpolls. Each netpoll
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
Acked-by: Matt Mackall <[EMAIL PROTECTED]>
Signed-off-by: Keiichi KII <[EMAIL PROTECTED]>
Signed-off-by: Takay
From: Keiichi KII <[EMAIL PROTECTED]>
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging age
Sorry, I sent the incomplete sample program.
So, I send the complete one again.
Any comments welcom.
#include
#include
#include
#include
#include
#include
#include
#include
#include
#include
#define NETCONSOLE_DEV_NAME "/dev/netconsole"
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])
Alexey Dobriyan wrote:
On 3/20/07, Keiichi KII <[EMAIL PROTECTED]> wrote:
This patch contains the following changes for supporting multiple logging
agents.
+#define CONFIG_SEPARATOR ";"
CONFIG_* is reserved for configuration options. Since you use
it in only one place ju
From: Keiichi KII <[EMAIL PROTECTED]>
We add ioctls for adding/removing target.
If we use NETCONSOLE_ADD_TARGET ioctl,
we can dynamically add netconsole target.
If we use NETCONSOLE_REMOVE_TARGET ioctl,
we can dynamically remoe netconsole target.
We attach a sample program for ioctl.
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number
From: Keiichi KII <[EMAIL PROTECTED]>
We use symbolic link for net_device.
The link in sysfs represents the corresponding network etherdevice.
-+- /sys/class/misc/
|-+- netconsole/
|-+- port1/
| |--- id [r--r--r--] id
| |--- net: [rw-r--r--] net_dev: eth
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes for supporting multiple logging
agents.
1. extend netconsole to multiple netpolls
To send kernel messages to multiple logging agents, extend netcosnole
to be able to use multiple netpolls. Each netpoll
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
Signed-off-by: Keiichi KII <[EMAIL PROTECTED]>
Signed-off-by: Takayoshi Kochi <[EMAIL PROTECTED]>
---
Index: li
From: Keiichi KII <[EMAIL PROTECTED]>
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging age
ld crash...
>
>
> Maybe having a state variable/sysfs file so you could setup the port and
> turn it on/off with write.
You are right.
When I tested above program, my machine crashed.
I'm going to rethink the interface for netconsole.
Thanks for your comments.
--
Keiich
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
Signed-off-by: Keiichi KII <[EMAIL PROTECTED]>
Signed-off-by: Takayoshi Kochi <[EMAIL PROTECTED]>
---
--- li
From: Keiichi KII <[EMAIL PROTECTED]>
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging age
l structure.
So, You can't use NIPQUAD to follow the current implementation of netpoll.
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROT
plication would rather find target MAC address and
change it through the sysfs.
--
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
To add port dynamically, create "add" element in /sys/class/misc/netconsole.
ex)
echo "@/eth0,@192.168.0.1/" > /sys/class/misc/netconsole/add
then the port is added with the set
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number
From: Keiichi KII <[EMAIL PROTECTED]>
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging age
From: Keiichi KII <[EMAIL PROTECTED]>
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging age
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
To add port dynamically, create "add" element in /sys/class/misc/netconsole.
ex)
echo "@/eth0,@192.168.0.1/" > /sys/class/misc/netconsole/add
then the port is added with the set
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains switch function of netpoll.
If "enabled" attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If "enabled" attribute of certain port
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number
From: Keiichi KII <[EMAIL PROTECTED]>
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
- remove "drop" initialization in the netpoll structure.
Signed-off-by: Keiichi KII <[EMAIL PROTECTED]>
--
57 matches
Mail list logo
