Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

2016-11-07 Thread Josh Triplett
On Mon, Nov 07, 2016 at 05:41:38PM -0500, Nicolas Pitre wrote: > On Mon, 7 Nov 2016, Josh Triplett wrote: > > > [snipping large patch] > > > > One suggestion that might make this patch easier to review: you might > > consider first regenerating the unchanged

Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

2016-11-07 Thread Josh Triplett
[snipping large patch] One suggestion that might make this patch easier to review: you might consider first regenerating the unchanged parser with Bison 3.0.4, then regenerating it again after the "imply" change. I think that'd eliminate quite a lot of noise in this patch. - Josh Triplett

Re: [PATCH 0/4] make POSIX timers optional with some Kconfig help

2016-10-20 Thread Josh Triplett
s across three subsystems for potential > upstream merging needs to be figured out. This looks good to me, and I like the new "imply" approach. I'd still like to see a more general solution for reporting the use of compiled-out syscalls, but I don't think that needs to block this patch series. Reviewed-by: Josh Triplett

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Josh Triplett
On Thu, Oct 20, 2016 at 04:06:02PM +0200, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Just out of c

Re: [PATCH 1/4] kconfig: introduce the "imply" keyword

2016-10-20 Thread Josh Triplett
On Thu, Oct 20, 2016 at 03:52:04PM +0100, Edward Cree wrote: > On 20/10/16 00:42, Nicolas Pitre wrote: > > diff --git a/Documentation/kbuild/kconfig-language.txt > > b/Documentation/kbuild/kconfig-language.txt > > index 069fcb3eef..c96127f648 100644 > > --- a/Documentation/kbuild/kconfig-language.

Re: [PATCH 1/2] ptp_clock: allow for it to be optional

2016-09-19 Thread Josh Triplett
On Mon, Sep 19, 2016 at 07:04:15PM +0200, Jiri Benc wrote: > On Mon, 19 Sep 2016 10:10:21 -0400 (EDT), Nicolas Pitre wrote: > > --- a/include/linux/ptp_clock_kernel.h > > +++ b/include/linux/ptp_clock_kernel.h > > @@ -207,7 +207,16 @@ int ptp_find_pin(struct ptp_clock *ptp, > > #else > > static i

Re: [PATCH] net: add sparse annotation to ptype_seq_start/stop

2008-01-20 Thread Josh Triplett
ves to that lock (whatever that may mean; hence why Sparse doesn't handle it yet). For mechanisms like RCU without a lock variable, this will likely entail some sort of fake lock expression, which again needs to match between all users of the same mechanism. Like any expression in C, case matters; thus, please match the existing references to "RCU" rather than "rcu". - Josh Triplett signature.asc Description: OpenPGP digital signature

[PATCH] Allow pktgen to work with loopback devices.

2007-03-07 Thread Josh Triplett
n and receipt. Thanks to Sarah Bailey for discovering and tracking down the problem. Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- I intentionally didn't change the error message "not an ethernet device". For the purposes of pktgen, loopback devices act like ethernet de