Re: [External] [RFC] vsock: add multiple transports support for dgram

> On 7 Apr 2021, at 20:25, Jiang Wang . wrote: > > On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: >> >> >>> On 6 Apr 2021, at 20:31, Jiang Wang wrote: >>> >>> From: "jiang.wang" >>> >>> Currently, only

Re: [RFC] vsock: add multiple transports support for dgram

> On 6 Apr 2021, at 20:31, Jiang Wang wrote: > > From: "jiang.wang" > > Currently, only VMCI supports dgram sockets. To supported > nested VM use case, this patch removes transport_dgram and > uses transport_g2h and transport_h2g for dgram too. Could you provide some background for introducin

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: > > This adds receive loop for SEQPACKET. It looks like receive loop for > STREAM, but there is a little bit difference: > 1) It doesn't call notify callbacks. > 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because > there is n

Re: [RFC PATCH v5 02/19] af_vsock: separate wait data loop

> On 18 Feb 2021, at 06:36, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 155 +-- > 1 file

Re: [RFC PATCH v4 02/17] af_vsock: separate wait data loop

> On 7 Feb 2021, at 16:14, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 158 +-- > 1 file c

RE: [PATCH net v2] vsock: fix potential null pointer dereference in vsock_poll()

> From: Stefano Garzarella > Sent: Wednesday, August 12, 2020 2:56 PM > To: da...@davemloft.net > Cc: linux-ker...@vger.kernel.org; Dexuan Cui ; > netdev@vger.kernel.org; Stefan Hajnoczi ; Jakub > Kicinski ; Jorgen Hansen ; > Stefano Garzarella > Subject: [PATCH net v2] v

RE: [PATCH net] vsock: fix timeout in vsock_accept()

ait, TASK_INTERRUPTIBLE); > > while ((connected = vsock_dequeue_accept(listener)) == NULL && > -- > 2.25.4 Thanks for fixing this! Reviewed-by: Jorgen Hansen

Re: [RFC] vsock: proposal to support multiple transports at runtime

On 30 May 2019, at 13:19, Stefano Garzarella wrote: > > On Tue, May 28, 2019 at 04:01:00PM +, Jorgen Hansen wrote: >>> On Thu, May 23, 2019 at 04:37:03PM +0100, Stefan Hajnoczi wrote: >>>> On Tue, May 14, 2019 at 10:15:43AM +0200, Stefano Garzarella wrote: >

Re: [RFC] vsock: proposal to support multiple transports at runtime

> On Thu, May 23, 2019 at 04:37:03PM +0100, Stefan Hajnoczi wrote: > > On Tue, May 14, 2019 at 10:15:43AM +0200, Stefano Garzarella wrote: > > > Hi guys, > > > I'm currently interested on implement a multi-transport support for VSOCK > > > in > > > order to handle nested VMs. Thanks for picking t

[PATCH v2] VSOCK: Send reset control packet when socket is partially bound

Signed-off-by: Jorgen Hansen --- v1 -> v2: - Changed order of local variables net/vmw_vsock/vmci_transport.c | 67 +++--- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c inde

[PATCH] VSOCK: Send reset control packet when socket is partially bound

Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 67 +++--- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 0ae3614..402d84e 100644 --- a/net/vmw_vsock/vmci_tr

[PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it

hat function. Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 56573dc..a7a73ff 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vs

[PATCH v2] VSOCK: Don't call vsock_stream_has_data in atomic context

lling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. v2: Rebased on top of recent change to sk_state values Reviewed-by: Adit Ranadive Reviewed-by: Aditya Sarwade Reviewed-by: Stefan Hajnoczi Signed-off-by: Jorgen Hansen --- net/vmw_

[PATCH] VSOCK: Don't call vsock_stream_has_data in atomic context

lling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. Reviewed-by: Adit Ranadive Reviewed-by: Aditya Sarwade Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 10 +++--- 1 files changed, 7 insertions(+), 3 dele

[PATCH] VSOCK: Don't dec ack backlog twice for rejected connections

If a pending socket is marked as rejected, we will decrease the sk_ack_backlog twice. So don't decrement it for rejected sockets in vsock_pending_work(). Testing of the rejected socket path was done through code modifications. Reported-by: Stefan Hajnoczi Signed-off-by: Jorgen Hansen Rev

[PATCH] VSOCK: Only check error on skb_recv_datagram when skb is NULL

If skb_recv_datagram returns an skb, we should ignore the err value returned. Otherwise, datagram receives will return EAGAIN when they have to wait for a datagram. Acked-by: Adit Ranadive Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c |7 ++- 1 files changed, 2

[PATCH] VSOCK: Detach QP check should filter out non matching QPs.

Zhang Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 0a369bb..662bdd2 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock

[PATCH] VSOCK: sock_put wasn't safe to call in interrupt context

from 1.0.2.0-k since up until now it appears that this module was sharing version with vsock that is currently at 1.0.1.0-k). Reviewed-by: Aditya Asarwade Reviewed-by: Thomas Hellstrom Signed-off-by: Jorgen Hansen --- net/vmw_vsock/vmci_transport.c | 173 +++-