Re: [PATCH net] bnxt_en: fix NULL dereference in case SR-IOV configuration fails

2020-07-10 Thread Jonathan Toppins
sys_sendmsg+0x88/0xd0 > __sys_sendmsg+0x5e/0xa0 > do_syscall_64+0x47/0x80 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.") > Reported-by: Fei Liu > CC: Jonathan Toppins Acked-by: Jonathan Toppins > CC: Michael Chan > Signed-off-by: Davide Caratti > ---

Re: [PATCH net] ionic: tame the watchdog timer on reconfig

2020-06-19 Thread Jonathan Toppins
for > queue 0, but has no effect on the remaining queues. Using > netif_device_detach() allows us to signal to the watchdog to > ignore us for the moment. > > Fixes: beead698b173 ("ionic: Add the basic NDO callbacks for netdev support") > Signed-off-by: Shannon Nelson Acked-by: Jonathan Toppins

Re: [PATCH net] ionic: no link check while resetting queues

2020-06-17 Thread Jonathan Toppins
On 6/17/20 3:53 PM, Shannon Nelson wrote: > On 6/17/20 12:41 PM, Jonathan Toppins wrote: >> On 6/15/20 9:14 PM, Shannon Nelson wrote: >>> If the driver is busy resetting queues after a change in >>> MTU or queue parameters, don't bother checking the link, >&g

Re: [PATCH net] ionic: no link check while resetting queues

2020-06-17 Thread Jonathan Toppins
On 6/15/20 9:14 PM, Shannon Nelson wrote: > If the driver is busy resetting queues after a change in > MTU or queue parameters, don't bother checking the link, > wait until the next watchdog cycle. > > Fixes: 987c0871e8ae ("ionic: check for linkup in watchdog") > Signed-off-by: Shannon Nelson > -

Re: [PATCH net] ionic: export features for vlans to use

2020-06-17 Thread Jonathan Toppins
On 6/16/20 11:06 AM, Shannon Nelson wrote: > Set up vlan_features for use by any vlans above us. > > Fixes: beead698b173 ("ionic: Add the basic NDO callbacks for netdev support") > Signed-off-by: Shannon Nelson Acked-by: Jonathan Toppins

[PATCH net-next] bnxt: remove printing of hwrm message

2018-12-12 Thread Jonathan Toppins
not confuse users as this message is really not very informative. Signed-off-by: Jonathan Toppins --- Notes: v2: include changes recommended by Michael Chan drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next] bnxt: lower log priority of hwrm message to info

2018-12-11 Thread Jonathan Toppins
priority to info to not confuse users as this message is really informative in nature. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net

Re: [PATCH v2 net] bonding: fix 802.3ad state sent to partner when unbinding slave

2018-11-27 Thread Jonathan Toppins
disabled state > + port->actor_oper_port_state &= ~AD_STATE_COLLECTING; > + port->actor_oper_port_state &= ~AD_STATE_DISTRIBUTING; required by IEEE std 801.AX 2014; figure 6-21 detached state > port->actor_oper_port_state &= ~AD_STATE_AGGREGATION;> > __update_lacpdu_from_port(port); > ad_lacpdu_send(port); > Acked-by: Jonathan Toppins

Re: [PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Jonathan Toppins
On 03/14/2018 01:22 PM, Michael Chan wrote: > On Wed, Mar 14, 2018 at 9:36 AM, Jonathan Toppins wrote: >> The problem was introduced in commit >> 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes"). The bug occurs >> because tp->lock spinlock is held which is

[PATCH net] tg3: prevent scheduling while atomic splat

2018-03-14 Thread Jonathan Toppins
used inside a spinlock. Fixes: 506b0a395f26 ("[netdrv] tg3: APE heartbeat changes") Signed-off-by: Jonathan Toppins --- Notes: The thing I need reviewed from Broadcom is if the udelay should be 20 instead of 10, due to any timing changes introduced by the offending patch.

[PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

2017-10-06 Thread Jonathan Toppins
There is no reason to wrap the data structures inside the ifdef. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h b/drivers/net/ethernet/broadcom

[PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

2017-10-06 Thread Jonathan Toppins
Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile the file when the option is not enabled. Now make and the preprocessor do not have to waste time compiling a no-op. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/Makefile | 3 ++- driver

Re: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

2017-07-27 Thread Jonathan Toppins
On 07/27/2017 11:37 AM, Andrew Lunn wrote: > On Thu, Jul 27, 2017 at 12:40:01AM +, Brown, Aaron F wrote: >>> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf >>> Of John W. Linville >>> Sent: Friday, July 21, 2017 11:12 AM >>> To: netdev@vger.kernel.org >>> Cc: intel-

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

2017-06-13 Thread Jonathan Toppins
On 06/13/2017 12:21 PM, Joe Perches wrote: > On Tue, 2017-06-13 at 11:34 -0400, David Miller wrote: >> From: Michael Dilmore >> Date: Tue, 13 Jun 2017 14:42:46 +0100 >> >>> The packets per slave parameter used by round robin mode does not have a >>> printk debug >>> message in its set function in

Re: [PATCH net-next 2/5] vxlan: support fdb and learning in COLLECT_METADATA mode

2017-01-31 Thread Jonathan Toppins
On 01/31/2017 12:57 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > Vxlan COLLECT_METADATA mode today solves the per-vni netdev > scalability problem in l3 networks. It expects all forwarding > information to be present in dst_metadata. This patch series > enhances collect metadata mode to inclu

Re: [PATCH V2 10/22] bnxt_re: Support for CQ verbs

2016-12-12 Thread Jonathan Toppins
On 12/09/2016 01:48 AM, Selvin Xavier wrote: > This patch implements support for create_cq, destroy_cq and req_notify_cq > verbs. > > Signed-off-by: Eddie Wai > Signed-off-by: Devesh Sharma > Signed-off-by: Somnath Kotur > Signed-off-by: Sriharsha Basavapatna > Signed-off-by: Selvin Xavier >

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Jonathan Toppins
On 12/09/2016 01:47 AM, Selvin Xavier wrote: > This series introduces the RoCE driver for the Broadcom > NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. > This driver is dependent on the bnxt_en NIC driver and is > based on the bnxt_re branch in Doug's repository. bnxt_en changes > required for this p

Re: [PATCH V2 03/22] bnxt_re: register with the NIC driver

2016-12-09 Thread Jonathan Toppins
On 12/09/2016 01:47 AM, Selvin Xavier wrote: > This patch handles the registration with bnxt_en driver. The driver registers > with netdev notifier chain. Upon receiving NETDEV_REGISTER event, the driver > in turn registers with bnxt_en driver. > 1. bnxt_en's ulp_probe function returns a stru

Re: [PATCH net-next v4 1/4] net core: Add protodown support.

2015-07-08 Thread Jonathan Toppins
On 7/8/15 5:04 PM, anurad...@cumulusnetworks.com wrote: diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h index 9cf2394..8d60fe7 100644 --- a/include/uapi/linux/if.h +++ b/include/uapi/linux/if.h @@ -156,6 +156,12 @@ enum { IF_LINK_MODE_DORMANT, /* limit upward transition t

Please backport 63b46242f707849 [was: Issue with LACP mode in linux bonding driver]

2015-07-02 Thread Jonathan Toppins
Please back port the following to the LTS trees v3.2, v3.4, v3.10, v3.12, v3.14, and v3.18 commit 63b46242f707849a1df10b70e026281bfa40e849 Author: Wilson Kok Date: Mon Jan 26 01:16:59 2015 -0500 bonding: fix incorrect lacp mux state when agg not active Sending this to verify the above p

Re: Issue with LACP mode in linux bonding driver

2015-06-26 Thread Jonathan Toppins
On 6/26/15 5:19 PM, Jay Vosburgh wrote: Ajith Adapa wrote: On 26 June 2015 at 07:45, Jay Vosburgh wrote: echo 'module bonding =p' > /sys/kernel/debug/dynamic_debug/control Hi, thanks for the reply. I tried this out a bit here, and could reproduce the problem on 3.13, but not on 4

[PATCH linux v1 net-next 1/4] bonding: Allow userspace to set actors' system_priority in AD system

2015-05-01 Thread Jonathan Toppins
wed-by: Nikolay Aleksandrov [jt: fixed up style issues reported by checkpatch] Signed-off-by: Jonathan Toppins --- Documentation/networking/bonding.txt |9 + drivers/net/bonding/bond_3ad.c |5 - drivers/net/bonding/bond_main.c | 14 ++ drivers/net/b

Re: [PATCH v1 net-next 1/2] igb: add PHY support for Broadcom 5461S

2015-04-27 Thread Jonathan Toppins
On 4/17/15 4:23 PM, Jonathan Toppins wrote: From: Alan Liebthal The Quanta LY8 Ethernet management port uses a Broadcom 5461S chip for the PHY layer. This adds support for this PHY to the Intel igb driver. Signed-off-by: Alan Liebthal Signed-off-by: Jonathan Toppins --- drivers/net

Re: [PATCH v1 net-next 1/3] igb: set driver data for device entries that were missing

2015-04-27 Thread Jonathan Toppins
On 4/10/15 7:03 PM, Jonathan Toppins wrote: Three of the supported PCI device entries neglected to set driver data to "board_82575". This is not a problem until a new board type is defined, so avoid the potential problem all together. Signed-off-by: Jonathan Toppins --- drivers/ne

[PATCH v1 net-next 1/2] igb: add PHY support for Broadcom 5461S

2015-04-17 Thread Jonathan Toppins
From: Alan Liebthal The Quanta LY8 Ethernet management port uses a Broadcom 5461S chip for the PHY layer. This adds support for this PHY to the Intel igb driver. Signed-off-by: Alan Liebthal Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/intel/igb/e1000_82575.c | 20

[PATCH v1 net-next 2/2] igb: support SIOCSMIIREG

2015-04-17 Thread Jonathan Toppins
From: Alan Liebthal Support setting the MII register via SIOCSMIIREG. Signed-off-by: Alan Liebthal Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/intel/igb/igb_main.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers