On Mon, Jul 17, 2017 at 2:37 PM, Abhishek Shah
wrote:
> Hi Jon,
>
>> This also will need to be added to
>> drivers/net/ethernet/broadcom/bgmac-bcma.c. Otherwise, the driver
>> will no longer work for those platforms. Since this was already
>> accepted, please push out a fix ASAP.
>>
> I do not s
On Thu, Jul 13, 2017 at 3:04 PM, Abhishek Shah
wrote:
> IDM operations are usually one time ops and should be done in
> firmware itself. Driver is not supposed to touch IDM registers.
>
> However, for some SoCs', driver is performing IDM read/writes.
> So this patch masks IDM operations in case fi
On Mon, Jul 10, 2017 at 8:56 AM, Andrew Lunn wrote:
> On Mon, Jul 10, 2017 at 02:35:23PM +0200, Martin Blumenstingl wrote:
>> mdio_mux_init parses the child nodes of the MDIO mux. When using
>> "mdio-mux-mmioreg" the child nodes are describing the register value
>> that is written to switch betwee
-by: Liviu Dudau
Signed-off-by: Jon Mason
Fixes: 342fa1964439 ("mdio: mux: make child bus walking more permissive and
errors more verbose")
---
drivers/of/of_mdio.c| 22 --
include/linux/of_mdio.h | 24 +++-
2 files changed, 23 inserti
On Wed, Jun 7, 2017 at 12:18 PM, Liviu Dudau wrote:
> On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote:
>> From: Jon Mason
>> Date: Wed, 31 May 2017 15:43:30 -0400
>>
>> > use of_mdio_parse_addr() in place of an OF read of reg and a bounds
>> &g
the MDIO bus be fatal for all entries. Instead, we
should provide verbose errors describing the error and then attempt to
continue if it all possible. Also, use of_mdio_parse_addr()
Signed-off-by: Jon Mason
---
drivers/net/phy/mdio-mux.c | 24 +---
1 file changed, 17
use of_mdio_parse_addr() in place of an OF read of reg and a bounds
check (which is litterally the exact same thing that
of_mdio_parse_addr() does)
Signed-off-by: Jon Mason
---
drivers/net/phy/mdio_bus.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a
On Fri, May 12, 2017 at 6:52 PM, Florian Fainelli wrote:
> On 05/12/2017 09:22 AM, David Miller wrote:
>> From: Julia Lawall
>> Date: Fri, 12 May 2017 22:54:23 +0800 (SGT)
>>
>>> Device node iterators put the previous value of the index variable, so an
>>> explicit put causes a double put.
>> ..
on. So, I am adding it where necessary to make it uniform.
Signed-off-by: Jon Mason
Fixes: f20e6657a875 ("mdio: mux: Enhanced MDIO mux framework for integrated
multiplexers")
Fixes: 0ca2997d1452 ("netdev/of/phy: Add MDIO bus multiplexer support.")
---
drivers/net/phy/mdio-m
for mdio_mux_init() which calls mdiobus_unregister() prior to
mdiobus_free().
Signed-off-by: Jon Mason
Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
---
drivers/net/phy/mdio-mux-bcm-iproc.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dr
On Tue, Apr 25, 2017 at 11:23 AM, Sergei Shtylyov
wrote:
> Hello!
>
> On 04/25/2017 06:15 PM, Jon Mason wrote:
>
>>>> Cygnus has a single amac controller connected to the B53 switch with 2
>>>> PHYs. On the BCM911360_EP platform, those two PHYs are connected
On Tue, Apr 25, 2017 at 5:40 AM, Sergei Shtylyov
wrote:
> Hello.
>
> On 4/25/2017 12:50 AM, Eric Anholt wrote:
>
>> Cygnus has a single amac controller connected to the B53 switch with 2
>> PHYs. On the BCM911360_EP platform, those two PHYs are connected to
>> the external ethernet jacks.
>
>
>
gt; https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt
I believe he wants this in net-next
Acked-by: Jon Mason
>> ---
>> drivers/net/ethernet/broadcom/bgmac-bcma.c | 39
>> ++
>> 1 fil
On Thu, Mar 02, 2017 at 12:56:05PM -0800, David Miller wrote:
> From: David Miller
> Date: Thu, 02 Mar 2017 12:50:15 -0800 (PST)
>
> > From: Jon Mason
> > Date: Tue, 28 Feb 2017 13:41:49 -0500
> >
> >> Changes in v4:
> >> * Added the ude
e to bring it out of
reset regardless of whether it was in reset or not). Also, removed
unnecessary usleeps (as there is already a read present to flush the
IDM writes).
Signed-off-by: Zac Schroff
Signed-off-by: Jon Mason
Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platform device support
From: Hari Vyas
ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
chopping and the wrong mac address was configured.
Signed-off-by: Hari Vyas
Signed-off-by: Jon Mason
Fixes: 4e209001b86 ("bgmac: writ
were being preserved (Per Rafal Mileki)
* Style change to reorder the function variables in patch 2 (per Sergei
Shtylyov)
Bug fixes for bgmac driver
Hari Vyas (1):
net: ethernet: bgmac: mac address change bug
Jon Mason (1):
net: ethernet: bgmac: init sequence bug
drivers/net/ethernet/broa
ement
Jon Mason (2):
net: ethernet: bgmac: use #defines for MAX size
net: ethernet: bgmac: unify code of the same family
drivers/net/ethernet/broadcom/bgmac-bcma.c | 64 +++---
drivers/net/ethernet/broadcom/bgmac-platform.c | 34 ++
drivers/net/ethernet/bro
The maximum frame size is really just the standard ethernet frame size
and FCS. So use those existing defines to make the code a little more
beautiful.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
From: Joey Zhong
Implement suspend/resume callbacks in the bgmac driver. This makes sure
that we de-initialize and re-initialize the hardware correctly before
entering suspend and when resuming.
Signed-off-by: Joey Zhong
Signed-off-by: Jon Mason
Reviewed-by: Florian Fainelli
---
drivers/net
BCM471X and BCM535X are of the same family (from what I can derive from
internal documents). Group them into the case statement together, which
results in more code reuse.
Also, use existing helper variables to make the code a little more
readable too.
Signed-off-by: Jon Mason
---
drivers/net
e to bring it out of
reset regardless of whether it was in reset or not). Also, removed
unnecessary usleeps (as there is already a read present to flush the
IDM writes).
Signed-off-by: Zac Schroff
Signed-off-by: Jon Mason
Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platform device support
mac driver
Hari Vyas (1):
net: ethernet: bgmac: mac address change bug
Jon Mason (1):
net: ethernet: bgmac: init sequence bug
drivers/net/ethernet/broadcom/bgmac-platform.c | 27 +-
drivers/net/ethernet/broadcom/bgmac.c | 6 +-
drivers/net/ethernet/broadc
From: Hari Vyas
ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
chopping and the wrong mac address was configured.
Signed-off-by: Hari Vyas
Signed-off-by: Jon Mason
Fixes: 4e209001b86 ("bgmac: writ
can
> directly be stored in netdev->dev_addr.
>
> Also use eth_hw_addr_random() instead of eth_random_addr() in case a
> random MAC is nedded. This will make sure netdev->addr_assign_type will
> be properly set.
>
> Signed-off-by: Tobias Klauser
Looks sane to me
Acked
Reddy
Fixes: ddc24ae1 ("net: phy: Broadcom iProc MDIO bus driver")
Reviewed-by: Florian Fainelli
Signed-off-by: Jon Mason
---
drivers/net/phy/mdio-bcm-iproc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-b
worked the first match to make it more obvious what portions of the
register were being preserved (Per Rafal Mileki)
* Style change to reorder the function variables in patch 2 (per Sergei
Shtylyov)
Bug fixes for bgmac driver
Hari Vyas (1):
net: ethernet: bgmac: mac address change bug
Jo
The maximum frame size is really just the standard ethernet frame size
and FCS. So use those existing defines to make the code a little more
beautiful.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Changes in v2:
* Reworked the PM patch with Florian's suggestions
Add code to support Power Management (only tested on NS2), and add some
code clean-ups
Joey Zhong (1):
net: ethernet: bgmac: driver power manangement
Jon Mason (2):
net: ethernet: bgmac: use #defines for MAX size
From: Joey Zhong
Implement suspend/resume callbacks in the bgmac driver. This makes sure
that we de-initialize and re-initialize the hardware correctly before
entering suspend and when resuming.
Signed-off-by: Joey Zhong
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac
BCM471X and BCM535X are of the same family (from what I can derive from
internal documents). Group them into the case statement together, which
results in more code reuse.
Also, use existing helper variables to make the code a little more
readable too.
Signed-off-by: Jon Mason
---
drivers/net
From: Hari Vyas
ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
chopping and the wrong mac address was configured.
Signed-off-by: Hari Vyas
Signed-off-by: Jon Mason
Fixes: 4e209001b86 ("bgmac: writ
e to bring it out of
reset regardless of whether it was in reset or not). Also, removed
unnecessary usleeps (as there is already a read present to flush the
IDM writes).
Signed-off-by: Zac Schroff
Signed-off-by: Jon Mason
Fixes: f6a95a24957 ("net: ethernet: bgmac: Add platform device support
On Fri, Feb 3, 2017 at 9:16 PM, Florian Fainelli wrote:
> On 02/03/2017 01:39 PM, Jon Mason wrote:
>> From: Joey Zhong
>>
>> Implements suspend/resume, external phy 54810 is assumed
>> to remain powered up during deep-sleep for wake-on-lane.
>
> s/wake-on-l
On Fri, Feb 3, 2017 at 4:41 PM, Rafał Miłecki wrote:
> On 02/03/2017 10:08 PM, Jon Mason wrote:
>>
>> @@ -61,15 +60,20 @@ static bool platform_bgmac_clk_enabled(struct bgmac
>> *bgmac)
>>
>> static void platform_bgmac_clk_enable(struct bgmac *bgmac, u32 flags)
On Fri, Feb 3, 2017 at 4:48 PM, Rafał Miłecki wrote:
> On 2017-02-03 22:39, Jon Mason wrote:
>>
>> BCM471X and BCM535X are of the same family (from what I can derive from
>> internal documents). Group them into the case statement together, which
>> results in more
Add code to support Power Management (only tested on NS2), and add some
code clean-ups
Joey Zhong (1):
net: ethernet: bgmac: driver power manangement
Jon Mason (2):
net: ethernet: bgmac: use #defines for MAX size
net: ethernet: bgmac: unify code of the same family
drivers/net/ethernet
BCM471X and BCM535X are of the same family (from what I can derive from
internal documents). Group them into the case statement together, which
results in more code reuse.
Also, use existing helper variables to make the code a little more
readable too.
Signed-off-by: Jon Mason
---
drivers/net
The maximum frame size is really just the standard ethernet frame size
and FCS. So use those existing defines to make the code a little more
beautiful.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
From: Joey Zhong
Implements suspend/resume, external phy 54810 is assumed
to remain powered up during deep-sleep for wake-on-lane.
Signed-off-by: Joey Zhong
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 34 +
drivers/net/ethernet/broadcom
From: Zac Schroff
Fix a bug in the 'bgmac' driver init sequence that blind writes for init
sequence where it should preserve most bits other than the ones it is
deliberately manipulating.
Signed-off-by: Zac Schroff
Signed-off-by: Jon Mason
Fixes: f6a95a24957 ("net: ether
From: Hari Vyas
ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
chopping and the wrong mac address was configured.
Signed-off-by: Hari Vyas
Signed-off-by: Jon Mason
Fixes: 4e209001b86 ("bgmac: writ
Changes in v2:
* Reworked the first match to make it more obvious what portions of the
register were being preserved (Per Rafal Mileki)
* Style change to reorder the function variables in patch 2 (per Sergei
Shtylyov)
Bug fixes for bgmac driver
Hari Vyas (1):
net: ethernet: bgmac: mac add
is possible to reuse it on NSP and I did that!
>
> This is old comment from Jon:
>
> In 30 March 2016 at 23:31, Jon Mason wrote:
>> On Mon, Mar 28, 2016 at 9:46 PM, Florian Fainelli
>> wrote:
>>>
>>> CC: bcm-kernel-feedback-list, Jon
>>
>>
>&g
On Thu, Feb 2, 2017 at 3:15 PM, Rafał Miłecki wrote:
> On 2017-02-02 01:31, Zac Schroff wrote:
>>
>> How about BCMA_IOCTL_PRESERVE_ACROSS_INIT?
>
>
> I think wireless drivers may still set some these bits during init.
>
> I've a simpler idea: make it bgmac specific. Call it sth like
> BGMAC_BCMA_I
On Wed, Feb 1, 2017 at 6:06 PM, Rafał Miłecki wrote:
> On 02/01/2017 11:39 PM, Jon Mason wrote:
>>
>> From: Zac Schroff
>>
>> Fix a bug in the 'bgmac' driver init sequence that blind writes for init
>> sequence where it should preserve most bit
On Wed, Feb 1, 2017 at 6:12 PM, Rafał Miłecki wrote:
> On 02/01/2017 11:39 PM, Jon Mason wrote:
>>
>> From: Hari Vyas
>>
>> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
>> bgmac_set_mac_address() but code assumed u8 *. This caused two by
From: Hari Vyas
ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
chopping and the wrong mac address was configured.
Signed-off-by: Hari Vyas
Signed-off-by: Jon Mason
Fixes: 4e209001b86 ("bgmac: writ
Bug fixes for bgmac driver
Hari Vyas (1):
net: ethernet: bgmac: mac address change bug
Zac Schroff (1):
net: ethernet: bgmac: init sequence bug
drivers/net/ethernet/broadcom/bgmac-platform.c | 10 +++---
drivers/net/ethernet/broadcom/bgmac.c | 6 +-
include/linux/bcma/bcma
From: Zac Schroff
Fix a bug in the 'bgmac' driver init sequence that blind writes for init
sequence where it should preserve most bits other than the ones it is
deliberately manipulating.
Signed-off-by: Zac Schroff
Signed-off-by: Jon Mason
Fixes: f6a95a24957 ("net: ether
On Sat, Jan 28, 2017 at 10:08 PM, Florian Fainelli wrote:
>
>
> On 01/28/2017 01:08 PM, Rafał Miłecki wrote:
>> From: Rafał Miłecki
>>
>> This adds support for using bgmac with PHYs supported by standalone PHY
>> drivers. Having any PHY initialization in bgmac is hacky and shouldn't
>> be extende
On Fri, Nov 04, 2016 at 04:31:40PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/4/2016 8:11 AM, Jon Mason wrote:
>
> >Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
> >tree
> >
> >Signed-off-by: Jon Mason
> >---
> &g
Add the documentation for PHY lane swapping. This is a boolean entry to
notify the phy device drivers that the TX/RX lanes need to be swapped.
Signed-off-by: Jon Mason
Reviewed-by: Florian Fainelli
Reviewed-by: Andrew Lunn
---
Documentation/devicetree/bindings/net/phy.txt | 4
1 file
Add a helper function to read the AUXCTL register for the BCM54xx. This
mirrors the bcm54xx_auxctl_write function already present in the code.
Signed-off-by: Jon Mason
Reviewed-by: Florian Fainelli
---
drivers/net/phy/broadcom.c | 10 ++
include/linux/brcmphy.h| 1 +
2 files
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
tree
Signed-off-by: Jon Mason
---
arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 +
arch/arm64/boot/dts/broadcom/ns2.dtsi| 12
2 files changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom
applicable.
Inspired-by: Vikas Soni
Signed-off-by: Jon Mason
Reviewed-by: Florian Fainelli
Reviewed-by: Andrew Lunn
---
drivers/net/phy/Kconfig| 2 +-
drivers/net/phy/broadcom.c | 58 +-
include/linux/brcmphy.h| 9 +++
3 files changed, 67
of the pending interrupts on init is required due to
observed issues on some platforms.
Signed-off-by: Jon Mason
Reviewed-by: Florian Fainelli
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +-
drivers/net/ethernet/broadcom/bgmac.c | 3 ++
drivers/net
Andrew Lunn and Florian
Fainelli)
* Remove bgmac sleep (per Florian Fainelli)
* Re-add bgmac chip reset (per Florian Fainelli and Ray Jui)
* Rebased on latest net-next
* Added patch for bcm54xx_auxctl_read, which is used in the BCM54810
Jon Mason (7):
net: phy: broadcom: add bcm54xx_auxctl_read
Clean-up the documentation to the bgmac-amac driver, per suggestion by
Rob Herring, and add details for NS2 support.
Signed-off-by: Jon Mason
Reviewed-by: Florian Fainelli
---
Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++-
1 file changed, 11 insertions(+), 5
Change the bgmac driver to allow for phy's defined by the device tree
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 22 +++
drivers/net/ethernet/broadcom/bgmac-platform.c | 22 ++-
drivers/net/ethernet/broadcom/bg
On Thu, Nov 03, 2016 at 09:31:21AM +0100, Rafal Milecki wrote:
> On 11/02/2016 06:08 PM, Jon Mason wrote:
> >Change the bgmac driver to allow for phy's defined by the device tree
>
> This is a late review, I know, sorry... :(
>
>
> >+static int bcma_phy_di
On Wed, Nov 02, 2016 at 08:18:51PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/02/2016 08:08 PM, Jon Mason wrote:
>
> >Clean-up the documentation to the bgmac-amac driver, per suggestion by
> >Rob Herring, and add details for NS2 support.
> &g
Clean-up the documentation to the bgmac-amac driver, per suggestion by
Rob Herring, and add details for NS2 support.
Signed-off-by: Jon Mason
---
Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a
phy changes are in addition to the changes necessary to get NS2
working.
Jon Mason (7):
net: phy: broadcom: add bcm54xx_auxctl_read
Documentation: devicetree: add PHY lane swap binding
net: phy: broadcom: Add BCM54810 PHY entry
Documentation: devicetree: net: add NS2 bindings to amac
Change the bgmac driver to allow for phy's defined by the device tree
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 48
drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++-
drivers/net/ethernet/broadcom/bg
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
tree
Signed-off-by: Jon Mason
---
arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 +
arch/arm64/boot/dts/broadcom/ns2.dtsi| 12
2 files changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom
of the pending interrupts on init is required due to
observed issues on some platforms.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +-
drivers/net/ethernet/broadcom/bgmac.c | 3 ++
drivers/net/ethernet/broadcom/bgmac.h
Add the documentation for PHY lane swapping. This is a boolean entry to
notify the phy device drivers that the TX/RX lanes need to be swapped.
Signed-off-by: Jon Mason
---
Documentation/devicetree/bindings/net/phy.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation
applicable.
Inspired-by: Vikas Soni
Signed-off-by: Jon Mason
---
drivers/net/phy/Kconfig| 2 +-
drivers/net/phy/broadcom.c | 58 +-
include/linux/brcmphy.h| 9 +++
3 files changed, 67 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy
Add a helper function to read the AUXCTL register for the BCM54xx. This
mirrors the bcm54xx_auxctl_write function already present in the code.
Signed-off-by: Jon Mason
---
drivers/net/phy/broadcom.c | 10 ++
include/linux/brcmphy.h| 1 +
2 files changed, 11 insertions(+)
diff
On Tue, Nov 01, 2016 at 05:05:13PM -0400, Jon Mason wrote:
> On Tue, Nov 01, 2016 at 01:34:30PM -0700, Scott Branden wrote:
> > One change in this patch
> >
> > On 16-11-01 01:04 PM, Jon Mason wrote:
> > >Add support for the variant of amac hardware present in the
On Tue, Nov 01, 2016 at 01:34:30PM -0700, Scott Branden wrote:
> One change in this patch
>
> On 16-11-01 01:04 PM, Jon Mason wrote:
> >Add support for the variant of amac hardware present in the Broadcom
> >Northstar2 based SoCs. Northstar2 requires an additional registe
On Tue, Nov 01, 2016 at 09:48:26PM +0100, Andrew Lunn wrote:
> > +- enet-phy-lane-swap: If set, indicates the PHY device requires swapping
> > the
> > + TX/RX lanes to function properly.
>
> Is 'requires' the right word here? The PHY performs the actual swap of
> the Tx/Rx lanes.
What I'm tryin
Add a helper function to read the AUXCTL register for the BCM54xx. This
mirrors the bcm54xx_auxctl_write function already present in the code.
Signed-off-by: Jon Mason
---
drivers/net/phy/broadcom.c | 10 ++
include/linux/brcmphy.h| 1 +
2 files changed, 11 insertions(+)
diff
applicable.
Inspired-by: Vikas Soni
Signed-off-by: Jon Mason
---
drivers/net/phy/Kconfig| 2 +-
drivers/net/phy/broadcom.c | 58 +-
include/linux/brcmphy.h| 9 +++
3 files changed, 67 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy
Change the bgmac driver to allow for phy's defined by the device tree
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 48
drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++-
drivers/net/ethernet/broadcom/bg
of the pending interrupts on init is required due to
observed issues on some platforms.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +-
drivers/net/ethernet/broadcom/bgmac.c | 3 ++
drivers/net/ethernet/broadcom/bgmac.h
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
tree
Signed-off-by: Jon Mason
---
arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 +
arch/arm64/boot/dts/broadcom/ns2.dtsi| 12
2 files changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom
Clean-up the documentation to the bgmac-amac driver, per suggestion by
Rob Herring, and add details for NS2 support.
Signed-off-by: Jon Mason
---
Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a
Add the documentation for PHY lane swapping. This is a boolean entry to
notify the phy device drivers that the TX/RX lanes need to be swapped.
Signed-off-by: Jon Mason
---
Documentation/devicetree/bindings/net/phy.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation
dcom Northstar2 SoC to the
bgmac driver. This necessitates adding support to connect to an
externally defined phy (as described in the device tree) in the driver.
These phy changes are in addition to the changes necessary to get NS2
working.
Jon Mason (7):
net: phy: broadcom: add bcm5
On Tue, Nov 01, 2016 at 11:01:19AM -0700, Scott Branden wrote:
> Hi Jon,
>
> On 16-11-01 10:51 AM, Jon Mason wrote:
> >Changes in v3:
> >* Clean-up the bgmac DT binding doc (per Rob Herring)
> >* Document the lane swap binding and make it generic (Per Andrew Lunn)
>
On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote:
> Hi Jon
>
> > @@ -56,6 +57,8 @@
> > #define PHY_BRCM_EXT_IBND_TX_ENABLE0x2000
> > #define PHY_BRCM_CLEAR_RGMII_MODE 0x4000
> > #define PHY_BRCM_DIS_TXCRXC_NOENRGY0x8000
> > +#define PHY_BRCM_EXP_LANE_SWAP
Change the bgmac driver to allow for phy's defined by the device tree
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 48
drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++-
drivers/net/ethernet/broadcom/bg
applicable.
Inspired-by: Vikas Soni
Signed-off-by: Jon Mason
---
drivers/net/phy/Kconfig| 2 +-
drivers/net/phy/broadcom.c | 58 +-
include/linux/brcmphy.h| 10
3 files changed, 68 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy
the device tree) in the driver.
These phy changes are in addition to the changes necessary to get NS2
working.
Jon Mason (6):
net: phy: broadcom: add bcm54xx_auxctl_read
net: phy: broadcom: Add BCM54810 PHY entry
Documentation: devicetree: net: add NS2 bindings to amac
net: ethernet: bgmac:
of the pending interrupts on init is required due to
observed issues on some platforms.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +-
drivers/net/ethernet/broadcom/bgmac.c | 3 ++
drivers/net/ethernet/broadcom/bgmac.h
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
tree
Signed-off-by: Jon Mason
---
arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 +
arch/arm64/boot/dts/broadcom/ns2.dtsi| 12
2 files changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom
Add a helper function to read the AUXCTL register for the BCM54xx. This
mirrors the bcm54xx_auxctl_write function already present in the code.
Signed-off-by: Jon Mason
---
drivers/net/phy/broadcom.c | 10 ++
include/linux/brcmphy.h| 1 +
2 files changed, 11 insertions(+)
diff
Clean-up the documentation to the bgmac-amac driver, per suggestion by
Rob Herring, and add details for NS2 support.
Signed-off-by: Jon Mason
---
Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a
On Tue, Nov 01, 2016 at 05:26:48PM +0100, Andrew Lunn wrote:
> > > > + if (of_property_read_bool(np, "brcm,enet-phy-lane-swap")) {
> > > > + /* Lane Swap - Undocumented register...magic! */
> > > > + ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER
> > > > +
On Sat, Oct 29, 2016 at 10:18:39AM +0200, Andrew Lunn wrote:
> On Fri, Oct 28, 2016 at 04:56:55PM -0400, Jon Mason wrote:
> > The BCM54810 PHY requires some semi-unique configuration, which results
> > in some additional configuration in addition to the standard config.
> > Al
e amac found in the Broadcom Northstar2 SoC to the
bgmac driver. This necessitates adding support to connect to an
externally defined phy (as described in the device tree) in the driver.
These phy changes are in addition to the changes necessary to get NS2
working.
Jon Mason (6):
net: phy
of the pending interrupts on init is required due to
observed issues on some platforms.
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-platform.c | 56 +-
drivers/net/ethernet/broadcom/bgmac.c | 3 ++
drivers/net/ethernet/broadcom/bgmac.h
applicable.
Inspired-by: Vikas Soni
Signed-off-by: Jon Mason
---
drivers/net/phy/Kconfig| 2 +-
drivers/net/phy/broadcom.c | 58 +-
include/linux/brcmphy.h| 10
3 files changed, 68 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy
Change the bgmac driver to allow for phy's defined by the device tree
Signed-off-by: Jon Mason
---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 48
drivers/net/ethernet/broadcom/bgmac-platform.c | 48 +++-
drivers/net/ethernet/broadcom/bg
Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device
tree
Signed-off-by: Jon Mason
---
arch/arm64/boot/dts/broadcom/ns2-svk.dts | 5 +
arch/arm64/boot/dts/broadcom/ns2.dtsi| 12
2 files changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom
Signed-off-by: Jon Mason
---
Documentation/devicetree/bindings/net/brcm,amac.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt
b/Documentation/devicetree/bindings/net/brcm,amac.txt
index ba5ecc1..f2b194e 100644
--- a
Add a helper function to read the AUXCTL register for the BCM54xx. This
mirrors the bcm54xx_auxctl_write function already present in the code.
Signed-off-by: Jon Mason
---
drivers/net/phy/broadcom.c | 10 ++
include/linux/brcmphy.h| 1 +
2 files changed, 11 insertions(+)
diff
On Thu, Oct 27, 2016 at 11:15:05AM +0200, Andrew Lunn wrote:
> On Wed, Oct 26, 2016 at 03:35:57PM -0400, Jon Mason wrote:
> > From: Vikas Soni
> >
> > Add BCM54810 phy entry
>
> Hi Jon, Vikis
>
> The subject line is a bit misleading. It does more than add a
1 - 100 of 163 matches
Mail list logo
