Re: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

2021-04-20 Thread Jon Hunter
On 20/04/2021 02:49, Joakim Zhang wrote: ... >> I have tested this patch, but unfortunately the board still fails to resume >> correctly. So it appears to suffer with the same issue we saw on the previous >> implementation. > > Could I double check with you? Have you reverted Commit 9c63faaa9

[PATCH] ptp: Don't print an error if ptp_kvm is not supported

2021-04-20 Thread Jon Hunter
/arm64") Signed-off-by: Jon Hunter --- drivers/ptp/ptp_kvm_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ptp/ptp_kvm_common.c b/drivers/ptp/ptp_kvm_common.c index 721ddcede5e1..fcae32f56f25 100644 --- a/drivers/ptp/ptp_kvm_common.c +++ b/drivers/

Re: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

2021-04-19 Thread Jon Hunter
Hi Joakim, On 19/04/2021 12:59, Joakim Zhang wrote: > When system resume back, STMMAC will clear RX descriptors: > stmmac_resume() > ->stmmac_clear_descriptors() > ->stmmac_clear_rx_descriptors() > ->stmmac_init_rx_desc() > ->

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Jon Hunter
On 01/04/2021 17:28, Jon Hunter wrote: > > On 31/03/2021 12:41, Joakim Zhang wrote: > > ... > >>> In answer to your question, resuming from suspend does work on this board >>> without your change. We have been testing suspend/resume now on this board >&g

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-01 Thread Jon Hunter
On 31/03/2021 12:41, Joakim Zhang wrote: ... >> In answer to your question, resuming from suspend does work on this board >> without your change. We have been testing suspend/resume now on this board >> since Linux v5.8 and so we have the ability to bisect such regressions. So >> it is >> clea

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Jon Hunter
On 31/03/2021 12:10, Joakim Zhang wrote: ... You mean one of your boards? Does other boards with STMMAC can work >>> fine? >>> >>> We have two devices with the STMMAC and one works OK and the >>> other > fails. >>> They are different generation of devic

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-31 Thread Jon Hunter
On 31/03/2021 08:43, Joakim Zhang wrote: ... >>> You mean one of your boards? Does other boards with STMMAC can >>> work >> fine? >> >> We have two devices with the STMMAC and one works OK and the other fails. >> They are different generation of device and so there

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-30 Thread Jon Hunter
On 25/03/2021 08:12, Joakim Zhang wrote: ... > You mean one of your boards? Does other boards with STMMAC can work fine? We have two devices with the STMMAC and one works OK and the other >> fails. They are different generation of device and so there could be some

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-25 Thread Jon Hunter
On 25/03/2021 07:53, Joakim Zhang wrote: > >> -Original Message- >> From: Jon Hunter >> Sent: 2021年3月24日 20:39 >> To: Joakim Zhang >> Cc: netdev@vger.kernel.org; Linux Kernel Mailing List >> ; linux-tegra ; >> Jakub Kicinski >> Subj

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-24 Thread Jon Hunter
On 24/03/2021 12:20, Joakim Zhang wrote: ... > Sorry for this breakage at your side. > > You mean one of your boards? Does other boards with STMMAC can work fine? We have two devices with the STMMAC and one works OK and the other fails. They are different generation of device and so there co

Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-03-24 Thread Jon Hunter
Hi Joakim, Starting with v5.12-rc3 I noticed that one of our boards, Tegra186 Jetson TX2, was not long resuming from suspend. Bisect points to commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume back") and reverting this on top of mainline fixes the problem. Interestingly, the b

Re: phy_attach_direct()'s use of device_bind_driver()

2021-02-11 Thread Jon Hunter
On 10/02/2021 22:56, Andrew Lunn wrote: > On Wed, Feb 10, 2021 at 02:13:48PM -0800, Saravana Kannan wrote: >> Hi, >> >> This email was triggered by this other email[1]. > > And it appears the Tegra194 Jetson Xavier uses the Marvell 88E1512 > PHY. So ensure the Marvell driver is available, and it

Re: [PATCH net-next 4/6] net: ipa: add support to code for IPA v4.5

2020-12-01 Thread Jon Hunter
On 25/11/2020 20:45, Alex Elder wrote: > Update the IPA code to make use of the updated IPA v4.5 register > definitions. Generally what this patch does is, if IPA v4.5 > hardware is in use: > - Ensure new registers or fields in IPA v4.5 are updated where > required > - Ensure registers o

Re: [PATCH v4 3/5] net: asix: Fix AX88772x resume failures

2016-11-30 Thread Jon Hunter
Chou > Signed-off-by: Robert Foss > Tested-by: Robert Foss > Tested-by: Jon Hunter > Tested-by: Allan Chou V3 of this patch is already in the current mainline branch. So you need to send a patch on top of V3 (or v4.9-rc7) to get this fixed. Also you should highlight the fact that

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-29 Thread Jon Hunter
gt;presvd_phy_advertise = > asix_mdio_read_nopm(dev->net, dev->mii.phy_id, > MII_ADVERTISE); > } I gave this a quick test this morning and I can confirm that with the above change I no longer see the error messages. So feel free to add my ... Tested-by: Jon Hunter Cheers Jon -- nvpublic

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-22 Thread Jon Hunter
Hi Allan, On 18/11/16 15:09, Jon Hunter wrote: > Hi Allan, > > On 14/11/16 09:45, ASIX_Allan [Office] wrote: >> Hi Jon, >> >> Please help to double check if the USB host controller of your Terga >> platform had been powered OFF while running the ax88772_suspend

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-18 Thread Jon Hunter
Hi Allan, On 14/11/16 09:45, ASIX_Allan [Office] wrote: > Hi Jon, > > Please help to double check if the USB host controller of your Terga > platform had been powered OFF while running the ax88772_suspend() routine or > not? Sorry for the delay. Today I set up a local board to reproduce this on

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-14 Thread Jon Hunter
Hi Allan, On 14/11/16 08:50, ASIX_Allan [Home] wrote: > It seems the AX88772x dongle had been unexpectedly removed while running the > ax88772_suspend() routine. If yes, you might see these error messages > because the hardware had been absent. In my case the hardware was never removed. The b

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-10 Thread Jon Hunter
Hi Robert, On 29/08/16 14:32, robert.f...@collabora.com wrote: > From: Robert Foss > > From: Allan Chou > > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when suspending > - Need to restart MII when restor