dation check
nl80211: Add new RSNXE related nl80211 extended features
James Prestwood (1):
nl80211: better document CMD_ROAM behavior
Joe Perches (1):
cfg80211: constify ieee80211_get_response_rate return
Johan Almbladh (1):
mac80211: Set priority and queue mapping for in
On Mon, 2021-04-19 at 11:54 +0200, Gonsolo wrote:
> > Do you use MFP?
>
> I don't think so. I'm running unmodified kernels from Ubuntu PPA and
> don't meddle with WIFI configs.
> How can I find out?
>
> > Could be related to
> > https://patchwork.kernel.org/project/linux-wireless/patch/2021041613
On Mon, 2021-04-19 at 11:08 +0200, Gon Solo wrote:
>
> [Apr19 10:50] iwlwifi :02:00.0: Queue 10 is active on fifo 1 and stuck
> for 1 ms. SW [40, 93] HW [40, 93] FH TRB=0x0c010a037
> [ +0,001244] iwlwifi :02:00.0: Microcode SW error detected. Restarting
> 0x200.
>
> The rest o
On Wed, 2021-04-14 at 12:06 -0300, Ramon Fontes wrote:
> > Advertise 60GHz channels to mac80211.
> Oh.. That was a mistake. Sorry for that.
>
> Anyway, can we indicate 60GHz support even though it is not being
> supported by mac80211 yet?
>
No, that makes no sense. DMG operation is significantly
On Mon, 2021-04-12 at 22:06 -0300, Ramon Fontes wrote:
> Advertise 60GHz channels to mac80211.
This is wrong. mac80211 doesn't support 60 GHz operation.
johannes
netlink beacon head validation buffer overrun
A. Cody Schuffelen (1):
virt_wifi: Return micros for BSS TSF values
Ben Greear (1):
mac80211: fix time-is-after bug in mlme
Du Cheng (1):
cfg80211: remove WARN_O
On Thu, 2021-04-08 at 14:53 +0200, Johannes Berg wrote:
> Hi,
>
> Yes, I'm late with this, sorry about that. I've mostly restricted this
> to the most necessary fixes, though the virt_wifi one isn't but since
> that's not used a lot, it's harmless and in
):
virt_wifi: Return micros for BSS TSF values
Ben Greear (1):
mac80211: fix time-is-after bug in mlme
Du Cheng (1):
cfg80211: remove WARN_ON() in cfg80211_sme_connect
Johannes Berg (4):
rfkill: revert back to old userspace API by default
mac80211: fix TXQ AC confusion
On Sat, 2021-04-03 at 15:13 +, Pavel Skripkin wrote:
> genl_family_rcv_msg_attrs_parse() can return NULL
> pointer:
>
> if (!ops->maxattr)
> return NULL;
>
> But this condition doesn't cause an error in
> genl_family_rcv_msg_doit
And I'm almost certain that in fact it
ad_encrypt for errors
Jarod Wilson (1):
wireless/nl80211: fix wdev_id may be used uninitialized
Johannes Berg (3):
mac80211: fix rate mask reset
mac80211: minstrel_ht: remove unused variable 'mg'
nl80211: fix locking for wireless device netns change
Kart
On Tue, 2021-03-16 at 19:29 +, Abhishek Kumar wrote:
> If BSS instance is not provided in __cfg80211_connect_result then
> a get bss is performed. This can return NULL if the BSS for the
> given SSID is expired due to delayed scheduling of connect result event
> in rdev->event_work. This can ca
On Tue, 2021-03-02 at 20:01 +0100, Dmitry Vyukov wrote:
>
> Looking at the reproducer that mostly contains just perf_event_open,
> It may be the old known issue of perf_event_open with some extreme
> parameters bringing down kernel.
> +perf maintainers
> And as far as I remember +Peter had some pa
On Wed, 2021-02-24 at 10:30 +0800, Hillf Danton wrote:
>
> Add budget for the 80211 softint handler - it's feasible not to try to
> build the giant pyramid in a week.
>
> --- x/net/mac80211/main.c
> +++ y/net/mac80211/main.c
> @@ -224,9 +224,15 @@ static void ieee80211_tasklet_handler(un
> {
>
> @@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map
> *lock, int read)
> /* avoid false negative lockdep_assert_not_held()
>* and lockdep_assert_held()
>*/
> - return -1;
> + return LOCK_STATE_UNKNOW
On Mon, 2021-02-22 at 19:51 +0100, Marc Kleine-Budde wrote:
> On 22.02.2021 17:30:59, Johannes Berg wrote:
> > On Mon, 2021-02-22 at 16:12 +0100, Oleksij Rempel wrote:
> > > This code is trying to clone the skb with optional skb->sk. But this
> > > will fail to clon
On Mon, 2021-02-22 at 16:12 +0100, Oleksij Rempel wrote:
> This code is trying to clone the skb with optional skb->sk. But this
> will fail to clone the skb if socket was closed just after the skb was
> pushed into the networking stack.
Which IMHO is completely fine. If we then still clone the SKB
On Fri, 2021-02-19 at 05:15 +, Srinivasan Raju wrote:
> Hi,
>
> Please find a few responses to the comments , We will fix rest of the
> comments and submit v14 of the patch.
>
> > Also, you *really* need some validation here, rather than blindly
> > trusting that the file is well-formed, oth
On Thu, 2021-02-18 at 18:31 +0100, Sebastian Andrzej Siewior wrote:
> The recent addition of in_serving_softirq() to kconv.h results in
You typo'ed "kconv.h" pretty consistently ;-)
But yes, that makes sense.
Acked-by: Johannes Berg
johannes
On Mon, 2021-02-15 at 17:04 +0100, Peter Zijlstra wrote:
> On Mon, Feb 15, 2021 at 02:12:30PM +0100, Johannes Berg wrote:
> > On Mon, 2021-02-15 at 11:44 +0100, Peter Zijlstra wrote:
> > > I think something like so will work, but please double check.
> >
>
On Mon, 2021-02-15 at 11:44 +0100, Peter Zijlstra wrote:
>
> I think something like so will work, but please double check.
Yeah, that looks better.
> +++ b/include/linux/lockdep.h
> @@ -294,11 +294,15 @@ extern void lock_unpin_lock(struct lockdep_map *lock,
> struct pin_cookie);
>
> #define
design the rate probing strategy
mac80211: minstrel_ht: show sampling rates in debugfs
mac80211: minstrel_ht: remove sample rate switching code for constrained
devices
Johannes Berg (1):
nl80211: add documentation for HT/VHT/HE disable attributes
Luca Coelho (1):
cfg80211:
Hi,
Thanks for your patience, and thanks for sticking around!
I'm sorry I haven't reviewed this again in a long time, but I was able
to today.
> +PUREILIFI USB DRIVER
Did you mistype "PURELIFI" here, or was that intentional?
> +PUREILIFI USB DRIVER
> +M: Srinivasan Raju
Probably would be
On Fri, 2021-02-05 at 18:20 +, Colin Ian King wrote:
>
> > > https://lore.kernel.org/linux-wireless/516c0c7f.3000...@openwrt.org/
> > >
> > > But maybe that isn't actually quite right due to integer promotion?
> > > OTOH, that's a u8, so it should do the ~ in u8 space, and then compare
> > >
On Fri, 2021-02-12 at 09:42 +0100, Johannes Berg wrote:
> On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote:
> > The right fix would be to pull the entire data path into the host
> > +++ b/net/mac80211/ieee80211_i.h
> > @@ -748,6 +748,8 @@ struct ieee80211_if_m
On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote:
> The right fix would be to pull the entire data path into the host
> +++ b/net/mac80211/ieee80211_i.h
> @@ -748,6 +748,8 @@ struct ieee80211_if_mesh {
> * back to wireless media and to the local net stack.
> * @IEEE80211_SDATA_D
On Fri, 2021-02-05 at 13:51 -0800, Abhishek Kumar wrote:
> Since using DELBA frame to APs to re-establish BA session has a
> dependency on APs and also some APs may not honour the DELBA frame.
That's completely out of spec ... Can you say which AP this was?
You could also try sending a BAR that
On Tue, 2020-12-15 at 23:00 +0530, Youghandhar Chintala wrote:
>
> * @WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK: The device supports bigger kek and kck
> keys
> + * @WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART: The device needs a trigger to
> + * disconnect STA after target hardware restart. This flag shou
Hi Colin,
> while working through a backlog of older static analysis reports from
> Coverity
So ... yeah. Every time I look at Coverity (not frequently, I must
admit) I see the same thing, and get confused.
> I found an interesting use of the ~ operator that looks
> incorrect to me in function i
On Wed, 2021-02-03 at 15:00 +0800, samirweng1979 wrote:
> From: wengjianfeng
>
> change 'iff' to 'if'.
>
> Signed-off-by: wengjianfeng
> ---
> net/wireless/chan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/chan.c b/net/wireless/chan.c
> index 285b807
, and then
notifiers are "unrolled", need to handle this properly
----
Johannes Berg (5):
nl80211: call cfg80211_dev_rename() under RTNL
wext: call cfg80211_change_iface() with wiphy lock held
wext: call cfg80211_s
Hi Jakub,
So, getting late, but we have two more fixes - the staging
one (acked by Greg) is for a recent regression I had through
my tree, and the rate tables one is kind of important for
(some) drivers to get proper rate scaling going.
Please pull and let me know if there's any problem.
Thanks,
On Mon, 2021-02-01 at 14:37 +0200, Mike Rapoport wrote:
> On Mon, Feb 01, 2021 at 01:17:13AM -0800, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit:b01f250d Add linux-next specific files for 20210129
> > git tree: linux-next
> > console output:
On Sun, 2021-01-31 at 21:26 -0800, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:bec4c296 Merge tag 'ecryptfs-5.11-rc6-setxattr-fix' of git..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=11991778d0
> kernel config
On Thu, 2021-01-28 at 19:56 +0800, samirweng1979 wrote:
> From: wengjianfeng
>
> If the length of hide ssid is zero in scan, don't pass
> it to driver, which doesn't make any sense.
Err, please check again how scanning works. This is quite obviously
intentional.
johannes
instrel_ht: fix rounding error in throughput calculation
mac80211: minstrel_ht: fix regression in the max_prob_rate fix
Johannes Berg (3):
cfg80211: change netdev registration/unregistration semantics
cfg80211: avoid holding the RTNL when calling the driver
virt_wifi: fix deadlo
On Tue, 2021-01-26 at 22:16 +0100, Johannes Berg wrote:
> Hi,
>
> So here's a pretty big and invasive mac80211-next pull. It has now been
> in linux-next for some time, and all the issues that had been reported by
> people running that are fixed. I've also thrown hwsim a
is case, as we still have the remaining
> > inconsistency.
>
> My problem with Krzysztof's patch[1] is that it adds a new Kconfig
> option for ath9k, is that really necessary? Like Arnd said, we should
> fix drivers to use CONFIG_MAC80211_LEDS instead of having driver
> specific options.
>
> So I would prefer take this Arnd's patch instead and queue it for v5.11.
> But as it modifies mac80211 I'll need an ack from Johannes, what do you
> think?
Sure, that seems fine.
Acked-by: Johannes Berg
johannes
cted-by: Ben Greear
> > Tested-by: Ben Greear
> > Cc: Luca Coelho
> > Cc: linux-wirel...@vger.kernel.org
> > Cc: Johannes Berg
>
> Johannes, Eric tagged this for net, are you okay with me taking it?
> No strong preference here.
I guess that really would norma
error in throughput calculation
Johannes Berg (2):
cfg80211: change netdev registration/unregistration semantics
cfg80211: avoid holding the RTNL when calling the driver
Lorenzo Bianconi (1):
mac80211: introduce aql_enable node in debugfs
Max Chen (1):
cfg80211: Add phyrate co
Hi Marek,
> I've checked today's linux-next with the updated commit 27bc93583e35
> ("cfg80211: avoid holding the RTNL when calling the driver") and there
> is still an issue there, but at least it doesn't cause a deadlock:
>
> cfg80211: Loading compiled-in X.509 certificates for regulatory data
On Mon, 2021-01-25 at 13:59 +0100, Hans de Goede wrote:
> Yes this fixes things, thank you that saves me from having to debug
> the NULL ptr deref.
:)
> Do you want to submit this to Greg, or shall I (I've already
> added it to me local tree as a commit with you as the author) ?
>
> If you want
some
recent cfg80211 changes
* fix NULL-ptr deref if cfg80211 returns -EINPROGRESS
to wext (syzbot)
* pause TX in mac80211 in type change to prevent crashes
(syzbot)
Johannes Berg (3):
wext: fix NULL-ptr-dereference
On Tue, 2021-01-26 at 12:20 +0100, Greg Kroah-Hartman wrote:
>
> > Greg, can you take this for 5.11 please? Or if you prefer, since the
> > patch that exposed this and broke the driver went through my tree, I
> > can take it as well.
>
> Please feel free to take it through yours, as I don't think
From: Johannes Berg
This code ends up calling wiphy_apply_custom_regulatory(), for which
we document that it should be called before wiphy_register(). This
driver doesn't do that, but calls it from ndo_open() with the RTNL
held, which caused deadlocks.
Since the driver just registers s
Hi,
> > I don't have that much sympathy for a staging driver that's clearly
> > doing things differently than it was intended (the documentation states
> > that the function should be called only before wiphy_register(), not
> > during ndo_open). :-)
>
> I completely understand and I already was
Hi Eric,
On Tue, 2021-01-19 at 11:02 +0100, Eric Dumazet wrote:
>
> > This does fix the problems reported on iwlwifi, were you planning to
> > submit it as a proper patch?
>
> Sure, I will do, thanks !
Did you do that and I missed it? Or would you prefer we did?
Thanks,
Johannes
On Mon, 2021-01-25 at 01:52 -0800, syzbot wrote:
>
> [ cut here ]
> WARNING: CPU: 0 PID: 1 at net/wireless/core.c:1336
> cfg80211_register_netdevice+0x235/0x330 net/wireless/core.c:1336
>
Yes, umm. I accidentally *copied* that line a few lines further down
rather than *
Hi,
Sorry, apparently we have two threads.
> Great, thank you for looking into this. Let me know if you have a patch
> which you want me to test on a RTL8723BS adapter.
Could you test this instead?
https://p.sipsolutions.net/235c352b8ae5db88.txt
I don't have that much sympathy for a staging d
On Sat, 2021-01-23 at 22:31 +0100, Hans de Goede wrote:
>
> So I'm afraid that I have some bad news about this patch, it fixes
> the RCU warning which I reported:
>
> https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdego...@redhat.com/
>
> But it introduces a deadlock. See:
>
> ht
On Wed, 2021-01-20 at 19:03 +0100, Johannes Berg wrote:
> Could you take a look at these bits to see if that's fine with you?
Actually, never mind. Given some bug reports, some rework was necessary,
and that means this is no longer needed :-)
johannes
Hi Marek,
> This patch landed in today's (20210122) linux-next as commit
> 791daf8fc49a ("cfg80211: avoid holding the RTNL when calling the
> driver"). Sadly, it causes deadlock with mwifiex driver. I think that
> lockdep report describes it enough:
Yeah, umm, sorry about that. Evidently, I so
On Wed, 2021-01-20 at 12:37 -0800, Jakub Kicinski wrote:
> On Wed, 20 Jan 2021 18:59:21 +0100 Johannes Berg wrote:
> > Hi Jakub,
> >
> > > This pull request was applied to netdev/net.git (refs/heads/master):
> >
> > Since you pulled this now, question:
>
Hi Oliver,
Could you take a look at these bits to see if that's fine with you? I'd
like to merge it through mac80211-next (pending some logistics with a
conflict)
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 1447da1d5729..47c4c1182ef1 100644
> --- a/drivers/net/usb/
Hi Jakub,
> This pull request was applied to netdev/net.git (refs/heads/master):
Since you pulled this now, question:
I have some pending content for mac80211-next/net-next that either
conflicts with or requires a fix from here, or such.
Could you pull net into net-next, so I can get it into ma
From: Johannes Berg
Currently, _everything_ in cfg80211 holds the RTNL, and if you
have a slow USB device (or a few) you can get some bad lock
contention on that.
Fix that by re-adding a mutex to each wiphy/rdev as we had at
some point, so we have locking for the wireless_dev lists and
all the
Hi Eric, all,
Sorry we've been so silent on this.
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c
> @@ -773,6 +773,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,
> unsigned int num_subframes,
>
> next = skb_gso_segment(skb, netdev
ted links
Ilan Peer (1):
cfg80211: Save the regulatory domain with a lock
Johannes Berg (1):
cfg80211/mac80211: fix kernel-doc for SAR APIs
Lorenzo Bianconi (1):
mac80211: check if atf has been disabled in __ieee80211_schedule_txq
Mauro Carvalho Chehab (1):
cfg80211:
On Mon, 2021-01-18 at 10:12 +0100, Johannes Berg wrote:
> Hi Jakub,
>
> Here are some fixes for wireless - probably the thing people
> have most been waiting for is the kernel-doc fixes :-)
Now that the email finally went through, let me withdraw this, there's a
sparse er
ts on encrypted links
Ilan Peer (1):
cfg80211: Save the regulatory domain with a lock
Johannes Berg (1):
cfg80211/mac80211: fix kernel-doc for SAR APIs
Lorenzo Bianconi (1):
mac80211: check if atf has been disabled in __ieee80211_schedule_txq
Mauro Carvalho Chehab (1):
Hi Andrew, all,
> > +For example, adding a link for a MBIM IP session with SessionId 5:
> > +
> > + ip link add link wwan0 name wwan0. type vlan id 5
>
> So, this is what all the Ethernet nonsense is all about. You have a
> session ID you need to somehow represent to user space. And you
> decide
On Thu, 2021-01-14 at 10:34 -0800, Jakub Kicinski wrote:
> On Thu, 14 Jan 2021 10:59:08 -0500 Jon Maloy wrote:
> > On 1/14/21 3:04 AM, Mauro Carvalho Chehab wrote:
> > > A function has a different name between their prototype
> > > and its kernel-doc markup:
> > >
> > > ../net/tipc/link.c:2551:
Hi Stephen,
> > Right, thanks. I believe I also fixed it in the patch I sent a few days
> > ago that fixed the other documentation warning related to SAR that you
> > reported.
>
> I don't think so :-( I did a htmldocs build with your patch ([PATCH
> v2] cfg80211/mac80211: fix kernel-doc for SAR
Hi Stephen,
On Thu, 2021-01-07 at 09:05 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Building Linus' tree, today's linux-next build (htmldocs) produced
> this warning:
>
> include/net/mac80211.h:4200: warning: Function parameter or member
> 'set_sar_specs' not described in 'ieee80211_ops'
>
>
On Fri, 2020-12-18 at 12:16 -0800, Jakub Kicinski wrote:
> On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote:
> > On 12/17/20 10:20 AM, Eric Dumazet wrote:
> > > On Thu, Dec 17, 2020 at 7:13 PM Ben Greear
> > > wrote:
> > > > It is the iwlwifi/mvm logic that supports ax200.
> > >
> > > Let
mac80211: Update rate control on channel change
Johannes Berg (10):
mac80211: support MIC error/replay detected counters driver update
mac80211: disallow band-switch during CSA
cfg80211: include block-tx flag in channel switch started event
cfg80211: remove struct ieee8021
SCALL_64_after_hwframe+0x44/0xa9
>
> Fixes: 60854fd94573 ("mac80211: mesh: convert path table to rhashtable")
> Signed-off-by: Eric Dumazet
> Reported-by: syzbot
Reviewed-by: Johannes Berg
Jakub, if you want to take it to the net tree I wouldn't mind at all,
since I _just_ sent a pull request a little while ago.
Thanks,
johannes
On Fri, 2020-12-04 at 17:26 +0100, Johannes Berg wrote:
> On Fri, 2020-12-04 at 08:24 -0800, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path)
> > while tbl_path rhashtable has not yet been initializ
On Fri, 2020-12-04 at 08:24 -0800, Eric Dumazet wrote:
> From: Eric Dumazet
>
> If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path)
> while tbl_path rhashtable has not yet been initialized, which causes
> panics.
Thanks Eric!
I was going to ask how you ran into this ...
> Report
Hi Jakub,
We've got a few more fixes for the current cycle, everything
else I have pending right now seems likely to go to 5.11 instead.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit bbe2ba04c5a92a49db8a42c850a5a2f6481e47eb:
Merge t
On Tue, 2020-12-01 at 18:15 +0530, Anant Thazhemadam wrote:
>
> cfg80211_supported_cipher_suite(&rdev->wiphy, params->cipher) returned
> false, and thus it worked for the syzbot reproducer.
> Would it be a safer idea to enforce the conditions that I initially put (in
> ieee80211_del_key()) directl
On Tue, 2020-12-01 at 17:26 +0530, Anant Thazhemadam wrote:
> On 01/12/20 3:30 pm, Johannes Berg wrote:
> > On Tue, 2020-12-01 at 15:26 +0530, Anant Thazhemadam wrote:
> > > Currently, it is assumed that key_idx values that are passed to
> > > ieee80211_del_key() are a
On Tue, 2020-12-01 at 15:26 +0530, Anant Thazhemadam wrote:
> Currently, it is assumed that key_idx values that are passed to
> ieee80211_del_key() are all valid indexes as is, and no sanity checks
> are performed for it.
> However, syzbot was able to trigger an array-index-out-of-bounds bug
> by p
On Sat, 2020-11-21 at 12:55 -0800, Jakub Kicinski wrote:
> [snip]
> Ack, you have to figure out all the places anyway, the question is
> whether you put probes there or calls in the source code.
>
> Shifting the maintenance burden but also BPF is flexibility.
Yeah, true. Though I'd argue also vis
On Sat, 2020-11-21 at 10:35 -0800, Jakub Kicinski wrote:
> On Sat, 21 Nov 2020 19:12:21 +0100 Johannes Berg wrote:
> > > So I'm leaning towards reverting the whole thing. You can attach
> > > kretprobes and record the information you need in BPF maps.
> >
On Sat, 2020-11-21 at 10:06 -0800, Jakub Kicinski wrote:
> On Sat, 21 Nov 2020 17:52:27 +0100 Florian Westphal wrote:
> > Ido Schimmel wrote:
> > > Other suggestions?
> >
> > Aleksandr, why was this made into an skb extension in the first place?
> >
> > AFAIU this feature is usually always dis
On Sat, 2020-11-21 at 17:52 +0100, Florian Westphal wrote:
>
> Aleksandr, why was this made into an skb extension in the first place?
>
> AFAIU this feature is usually always disabled at build time.
> For debug builds (test farm /debug kernel etc) its always needed.
>
> If thats the case this u6
uct ethtool_ops.
>
> Fix all the places which made use of this implicit include.
> include/net/cfg80211.h | 1 +
Sounds good to me, thanks. Will still cause all wireless drivers to
rebuild this way though. Maybe I'll see later if something can be done
ab
On Fri, 2020-11-20 at 11:26 -0800, Kees Cook wrote:
> On Tue, Nov 17, 2020 at 02:07:43PM -0800, Sami Tolvanen wrote:
> > On Tue, Nov 17, 2020 at 1:45 PM Kees Cook wrote:
> > > On Tue, Nov 17, 2020 at 12:59:02PM -0800, Sami Tolvanen wrote:
> > > > Instead of casting callback functions to type iw_ha
On Fri, 2020-11-13 at 11:51 -0800, Jakub Kicinski wrote:
> On Fri, 13 Nov 2020 14:25:25 +0200 Lev Stipakov wrote:
> > > Seems I should take this through my tree, any objections?
>
> Go for it, you may need to pull net-next first but that should happen
> soonish anyway, when I get to your pr.
Yeah
On Fri, 2020-11-13 at 10:58 +0200, Lev Stipakov wrote:
> Commits
>
> d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add")
> 451b05f413d3f ("net: netdevice.h: sw_netstats_rx_add helper)
>
> have added API to update net device per-cpu TX/RX stats.
>
> Use core API instead of ieee80211_tx/rx
r small features/cleanups
Colin Ian King (1):
nl80211/cfg80211: fix potential infinite loop
Johannes Berg (9):
wireless: remove CONFIG_WIRELESS_WDS
ath9k: remove WDS code
carl9170: remove WDS code
b43: remove
ave frames
mac80211: minstrel: remove deferred sampling code
mac80211: minstrel: fix tx status processing corner case
Johannes Berg (1):
mac80211: free sta in sta_info_insert_finish() on errors
net/mac80211/rc80211_minstrel.c | 27 +--
ne
On Wed, 2020-11-11 at 11:23 +0800, Claire Chang wrote:
> On Wed, Nov 11, 2020 at 1:35 AM Johannes Berg
> wrote:
> > On Tue, 2020-11-10 at 16:49 +0800, Claire Chang wrote:
> > > If a device is getting removed or reprobed during resume, use-after-free
> >
On Tue, 2020-11-10 at 16:49 +0800, Claire Chang wrote:
> If a device is getting removed or reprobed during resume, use-after-free
> might happen. For example, h5_btrtl_resume()[drivers/bluetooth/hci_h5.c]
> schedules a work queue for device reprobing. During the reprobing, if
> rfkill_set_block() i
On Sat, 2020-11-07 at 11:05 -0800, Jakub Kicinski wrote:
> On Sat, 7 Nov 2020 17:21:31 + Taehee Yoo wrote:
> > When debugfs file is opened, its module should not be removed until
> > it's closed.
> > Because debugfs internally uses the module's data.
> > So, it could access freed memory.
> >
On Sun, 2020-11-08 at 20:34 +0100, Thomas Deutschmann wrote:
>
>
> Can we please get this applied to linux-5.10 and linux-5.9?
It's tagged for that, so once it enters mainline will get picked up.
Should be soon now, I assume.
johannes
On Mon, 2020-11-02 at 18:26 +0200, Kalle Valo wrote:
> Arnd Bergmann writes:
>
> > From: Arnd Bergmann
> >
> > gcc-10 shows a false-positive warning with CONFIG_KASAN:
> >
> > drivers/net/wireless/ath/ath9k/dynack.c: In function
> > 'ath_dynack_sample_tx_ts':
> > include/linux/etherdevice.h:2
On Fri, 2020-10-30 at 13:52 -0700, Jakub Kicinski wrote:
> On Fri, 30 Oct 2020 10:43:48 +0100 Johannes Berg wrote:
> > Hi Jakub,
> >
> > Here's a first set of fixes, in particular the nl80211 eapol one
> > has people waiting for it.
> >
> > Please
* a regression in nl80211-transported EAPOL frames which had
affected a number of users, from Mathy
* kernel-doc markings in mac80211, from Mauro
* a format argument in reg.c, from Ye Bin
----
Johannes Berg (4):
mac80211: fix u
On Thu, 2020-10-29 at 22:24 +, Colin King wrote:
> From: Colin Ian King
>
> The for-loop iterates with a u8 loop counter and compares this
> with the loop upper limit of request->n_ssids which is an int type.
> There is a potential infinite loop if n_ssids is larger than the
> u8 loop counter
idea how we'll get this merged - Jakub, do you want to take
the whole series? Or is somebody else responsible for the core kcov
part?
In any case,
Reviewed-by: Johannes Berg
johannes
Greg said he'd appply the patch when he gets an Ack
> from the maintainers.
>
> Inaky, Johannes, Jakub: are you happy with this version?
Sure, looks fine to me.
Acked-by: Johannes Berg
Not that I have much relation to this code other than having fixed up
genetlink stuff over the years :)
johannes
On Wed, 2020-10-28 at 18:20 +, Aleksandr Nogikh wrote:
> From: Aleksandr Nogikh
>
> Add KCOV remote annotations to ieee80211_iface_work and
> ieee80211_rx. This will enable coverage-guided fuzzing of
> mac80211 code that processes incoming 802.11 frames.
>
> Signed-off-by: Aleksandr Nogikh
the specific case of __sta_info_flush(), add a documentation
> for sta_info_flush(), as this one is the one used outside
> sta_info.c.
Are you taking the entire series through some tree, or should I pick up
this patch?
If you're going to take it:
Reviewed-by: Johannes Berg
johannes
ht thing in the separate policies.
OTOH, that really just makes it use more space, for no discernible
effect to userspace.
So as far as the warning fix is concerned:
Acked-by: Johannes Berg
Looks like I introduced a bug there with WIMAX_GNL_MSG_PIPE_NAME, but
obviously nobody cared.
johannes
int_policy() helper")
Signed-off-by: Johannes Berg
---
lib/libnetlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/libnetlink.c b/lib/libnetlink.c
index a7b60d873afb..c958aa57d0cd 100644
--- a/lib/libnetlink.c
+++ b/lib/libnetlink.c
@@ -30,7 +30,9 @@
#include "libnetlink.h
On Wed, 2020-10-14 at 09:59 +0200, Heiner Kallweit wrote:
>
> > Do you have a link? What is the benefit and how can we use it?
> >
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1873080.html
There was also a long discussion a year or so back, starting at
http://lore.kernel.org/r
On Tue, 2020-10-13 at 22:41 +0200, Mauro Carvalho Chehab wrote:
> Em Tue, 13 Oct 2020 20:47:47 +0200
> Johannes Berg escreveu:
>
> > Thanks Mauro.
> >
> >
> > On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote:
> > > Changeset df
Thanks Mauro.
On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote:
> Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions")
> added a new parameter, but didn't add the corresponding kernel-doc
> markup, as repoted when doing "make htmldocs":
>
> ./include/net/cfg80
Hi,
Sorry, somehow didn't see this until now.
> > +/* Lanes, 1, 2, 4 or 8. */
> > +#define ETHTOOL_LANES_11
> > +#define ETHTOOL_LANES_22
> > +#define ETHTOOL_LANES_44
> > +#define ETHTOOL_LANES_88
>
> Not an extreme
1 - 100 of 1980 matches
Mail list logo
