Re: [PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT

2021-03-18 Thread Jeffrey Hugo
On Thu, Mar 18, 2021 at 11:06 AM Bjorn Andersson wrote: > > On Thu 18 Mar 11:56 CDT 2021, Jeffrey Hugo wrote: > > > form -> from in the subject? > > > > Seems like I only failed in the cover letter, right? Looks like. I didn't even parse that this was the cover letter. Nothing to see here.

Re: [PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT

2021-03-18 Thread Jeffrey Hugo
form -> from in the subject? On Thu, Mar 11, 2021 at 5:34 PM Bjorn Andersson wrote: > > The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others > needs > platform-, and perhaps even board-, specific firmware. Add support for > providing this in devicetree.

Re: [PATCH net-next v3] net: Add Qcom WWAN control driver

2021-03-09 Thread Jeffrey Hugo
sc minor numbers used, and this particular server has a fresh distro install on it. I would expect that number to go up as it gets provisioned for use. I guess, the question to you is, how many misc minor numbers is "too much" for a single driver to expect to consume? -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Jeffrey Hugo
Well. You sure know how to aggravate people. I said clearly that you can move forward on purpose build drivers (e.g. for WWAN). There is no way forward on this common shim driver as far as I'm concerned. -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v16 4/4] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Jeffrey Hugo
release() is called on UCI device file node. Device file node is created with format /dev/ Currently it supports QMI channel. Signed-off-by: Hemant Kumar Reviewed-by: Manivannan Sadhasivam Reviewed-by: Jeffrey Hugo Tested-by: Loic Poulain --- Can you provide a pointer to the open-source

Re: [PATCH 2/3] net: mhi: Get RX queue size from MHI core

2020-12-09 Thread Jeffrey Hugo
+ err = register_netdev(ndev); if (err) goto out_err; -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v15 4/4] bus: mhi: Add userspace client interface driver

2020-12-03 Thread Jeffrey Hugo
node is created with format /dev/ Currently it supports QMI channel. Signed-off-by: Hemant Kumar Reviewed-by: Manivannan Sadhasivam Reviewed-by: Jeffrey Hugo You dropped Loic's tested by. Was that a mistake, or did something actually change which would invalidate his testing? -- Je

Re: [PATCH v14 4/4] bus: mhi: Add userspace client interface driver

2020-12-03 Thread Jeffrey Hugo
node is created with format /dev/ Currently it supports QMI channel. Signed-off-by: Hemant Kumar Reviewed-by: Manivannan Sadhasivam Tested-by: Loic Poulain Reviewed-by: Jeffrey Hugo -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Jeffrey Hugo
On 12/1/2020 7:55 PM, Jakub Kicinski wrote: On Tue, 1 Dec 2020 13:48:36 -0700 Jeffrey Hugo wrote: On 12/1/2020 1:03 PM, Jakub Kicinski wrote: On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote: On 12/1/2020 12:29 PM, Jakub Kicinski wrote: On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Jeffrey Hugo
On 12/1/2020 1:03 PM, Jakub Kicinski wrote: On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote: On 12/1/2020 12:29 PM, Jakub Kicinski wrote: On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote: This patch series adds support for UCI driver. UCI driver enables userspace clients to

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Jeffrey Hugo
ators. -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-12-01 Thread Jeffrey Hugo
On 12/1/2020 11:05 AM, Loic Poulain wrote: On Tue, 1 Dec 2020 at 18:51, Jeffrey Hugo wrote: On 12/1/2020 10:52 AM, Loic Poulain wrote: On Tue, 1 Dec 2020 at 18:37, Jeffrey Hugo wrote: On 12/1/2020 10:36 AM, Loic Poulain wrote: On Tue, 1 Dec 2020 at 02:16, Hemant Kumar wrote: Hi Loic

Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-12-01 Thread Jeffrey Hugo
On 12/1/2020 10:52 AM, Loic Poulain wrote: On Tue, 1 Dec 2020 at 18:37, Jeffrey Hugo wrote: On 12/1/2020 10:36 AM, Loic Poulain wrote: On Tue, 1 Dec 2020 at 02:16, Hemant Kumar wrote: Hi Loic, On 11/30/20 10:22 AM, Loic Poulain wrote: On Sat, 28 Nov 2020 at 04:26, Hemant Kumar wrote

Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

2020-12-01 Thread Jeffrey Hugo
nces to expect, and only call mhi_unprepare_for_transfer() for the last one. -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-25 Thread Jeffrey Hugo
On 11/19/2020 12:02 PM, Bhaumik Bhatt wrote: On 2020-11-18 11:34 AM, Jeffrey Hugo wrote: On 11/18/2020 12:14 PM, Loic Poulain wrote: Le mer. 18 nov. 2020 à 19:34, Jeffrey Hugo <mailto:jh...@codeaurora.org>> a écrit :     On 11/18/2020 11:20 AM, Bhaumik Bhatt wrote: > Rese

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-18 Thread Jeffrey Hugo
On 11/18/2020 12:14 PM, Loic Poulain wrote: Le mer. 18 nov. 2020 à 19:34, Jeffrey Hugo <mailto:jh...@codeaurora.org>> a écrit : On 11/18/2020 11:20 AM, Bhaumik Bhatt wrote: > Reset MHI device channels when driver remove is called due to > module unload or any

Re: [PATCH] net: qrtr: Unprepare MHI channels during remove

2020-11-18 Thread Jeffrey Hugo
on to the auto-start being removed, but this seems odd to me. As a client, the MHI device is being removed, likely because of some factor outside of my control, but I still need to clean it up? This really feels like something MHI should be handling. -- Jeffrey Hugo Qualcomm Technologies, In

Re: [PATCH v9 3/4] docs: Add documentation for userspace client interface

2020-10-26 Thread Jeffrey Hugo
On 10/26/2020 7:46 AM, Dan Williams wrote: On Mon, 2020-10-26 at 07:38 -0600, Jeffrey Hugo wrote: On 10/25/2020 3:46 PM, Jakub Kicinski wrote: On Fri, 23 Oct 2020 16:17:54 -0700 Hemant Kumar wrote: +UCI driver enables userspace clients to communicate to external MHI devices +like modem and

Re: [PATCH v9 3/4] docs: Add documentation for userspace client interface

2020-10-26 Thread Jeffrey Hugo
other common channel that is usually used for the multistage firmware loading process. -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

2020-10-23 Thread Jeffrey Hugo
ointer comparison. Its a little bit more than that. Frankly, unless you are counting assembly instructions for both methods, the difference is likely to be in the noise. However, I wonder why core MHI changes were not copied to the proper list (namely linux-arm-msm)? -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

2020-10-23 Thread Jeffrey Hugo
e you're talking about? https://lkml.org/lkml/2020/10/22/186 -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.