Re: [PATCH net-next] net: virtio: fix virtnet_sq_free_stats initialization

On Fri, Jul 12, 2024 at 07:20:21PM +0100, Simon Horman wrote: > On Fri, Jul 12, 2024 at 06:41:34AM -0400, Michael S. Tsirkin wrote: > > On Fri, Jul 12, 2024 at 09:03:30AM +0100, Jean-Philippe Brucker wrote: > > > Commit c8bd1f7f3e61 ("virtio_net: add support for Byte Queue L

[PATCH net-next] net: virtio: fix virtnet_sq_free_stats initialization

igger the BUG at lib/dynamic_queue_limits.c:99 because dql_completed() receives a random value as count. Initialize the whole structure. Fixes: 23c81a20b998 ("net: virtio: unify code to init stats") Reported-by: Aishwarya TCV Signed-off-by: Jean-Philippe Brucker --- Both these patches are still in n

Re: [PATCH bpf-next 2/2] selftests: bpf: Add a new test for bare tracepoints

On Wed, Jan 13, 2021 at 10:21:31AM +, Qais Yousef wrote: > On 01/12/21 12:07, Andrii Nakryiko wrote: > > > > > $ sudo ./test_progs -v -t module_attach > > > > > > > > use -vv when debugging stuff like that with test_progs, it will output > > > > libbpf detailed logs, that often are very

Re: [PATCH AUTOSEL 5.4 08/10] selftests/bpf: Fix array access with signed variable test

Hi, On Sat, Dec 19, 2020 at 10:34:55PM -0500, Sasha Levin wrote: > From: Jean-Philippe Brucker > > [ Upstream commit 77ce220c0549dcc3db8226c61c60e83fc59dfafc ] > > The test fails because of a recent fix to the verifier, even though this That fix is commit b02709587ea3 ("

Re: csum_partial() on different archs (selftest/bpf)

Hi, On Fri, Nov 13, 2020 at 11:36:08AM +0100, Björn Töpel wrote: > I was running the selftest/bpf on riscv, and had a closer look at one > of the failing cases: > > #14/p valid read map access into a read-only array 2 FAIL retval > 65507 != -29 (run 1/1) > > The test does a csum_partial() call

Re: [PATCH v2] arm64: bpf: Fix branch offset in JIT

On Wed, Sep 16, 2020 at 03:39:37PM +0300, Yauheni Kaliuta wrote: > If you start to amend extables, could you consider a change like > > 05a68e892e89 ("s390/kernel: expand exception table logic to allow new > handling options") > > and implementation of BPF_PROBE_MEM then? Commit 800834285361 ("

Re: [PATCH v2] arm64: bpf: Fix branch offset in JIT

On Tue, Sep 15, 2020 at 02:11:03PM +0100, Will Deacon wrote: > > ret = build_insn(insn, ctx, extra_pass); > > if (ret > 0) { > > i++; > > if (ctx->image == NULL) > > - ctx->offset[i] = ctx->idx; > > +

[PATCH bpf] selftests/bpf: Fix cgroup sockopt verifier test

. Fixes: 0456ea170cd6 ("bpf: Enable more helpers for BPF_PROG_TYPE_CGROUP_{DEVICE,SYSCTL,SOCKOPT}") Signed-off-by: Jean-Philippe Brucker --- tools/testing/selftests/bpf/verifier/event_output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/verifier/event_o

Re: [PATCH bpf] libbpf: handle GCC noreturn-turned-volatile quirk

he fix: > > struct my_struct { > void (*fn)(int); > }; > > Reported-by: Jean-Philippe Brucker > Fixes: 351131b51c7a ("libbpf: add btf_dump API for BTF-to-C conversion") > Signed-off-by: Andrii Nakryiko Thanks, this fixes the issue I was seeing with the arm64 vmlinux Tested-by: Jean-Philippe Brucker

Re: [PATCH bpf] libbpf: Fix BTF-to-C conversion of noreturn function pointers

On Mon, Jun 08, 2020 at 04:50:37PM -0700, Andrii Nakryiko wrote: > On Mon, Jun 8, 2020 at 8:23 AM Jean-Philippe Brucker > wrote: > > > > When trying to convert the BTF for a function pointer marked "noreturn" > > to C code, bpftool currently generates a synta

[PATCH bpf] libbpf: Fix BTF-to-C conversion of noreturn function pointers

__noreturn (__efiapi *exit)(...); bpftool produces the following output: efi_status_tvolatile (*exit)(...); Fix the error by inserting the space before the function modifier. Fixes: 351131b51c7a ("libbpf: add btf_dump API for BTF-to-C conversion") Signed-off-by: Jean-Philippe

[PATCH v2] vhost: fix IOTLB locking

spinlock is taken while holding vq->mutex. Since calling vhost_poll_queue() doesn't require any lock, avoid the deadlock by not taking vq->mutex. Fixes: 78139c94dc8c ("net: vhost: lock the vqs one by one") Acked-by: Jason Wang Acked-by: Michael S. Tsirkin Signed-off-by: Je

Re: [PATCH] vhost: fix IOTLB locking

On 30/11/2018 13:32, Michael S. Tsirkin wrote: > On Fri, Nov 30, 2018 at 11:37:02AM +0000, Jean-Philippe Brucker wrote: >> Commit 78139c94dc8c ("net: vhost: lock the vqs one by one") moved the vq >> lock to improve scalability, but introduced a possible d

[PATCH] vhost: fix IOTLB locking

avoid the deadlock by not taking vq->mutex. Fixes: 78139c94dc8c ("net: vhost: lock the vqs one by one") Signed-off-by: Jean-Philippe Brucker --- drivers/vhost/vhost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/v

Re: [REBASE PATCH net-next v9 1/4] net: vhost: lock the vqs one by one

On 30/11/2018 02:34, Jason Wang wrote: > > On 2018/11/30 上午3:28, Jean-Philippe Brucker wrote: >> Hi, >> >> On 25/09/2018 13:36,xiangxia.m@gmail.com wrote: >>> From: Tonghao Zhang >>> >>> This patch changes the way that lock all vqs >&

Re: [REBASE PATCH net-next v9 1/4] net: vhost: lock the vqs one by one

Hi, On 25/09/2018 13:36, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > This patch changes the way that lock all vqs > at the same, to lock them one by one. It will > be used for next patch to avoid the deadlock. > > Signed-off-by: Tonghao Zhang > Acked-by: Jason Wang > Signed-off-

[PATCH] net/9p: fix error path of p9_virtio_probe

Currently when virtio_find_single_vq fails, we go through del_vqs which throws a warning (Trying to free already-free IRQ). Skip del_vqs if vq allocation failed. Signed-off-by: Jean-Philippe Brucker --- net/9p/trans_virtio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH iproute2] ss: fix NULL dereference when rendering without header

ed-off-by: Jean-Philippe Brucker --- misc/ss.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index e047f9c0..e087bef7 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -1197,10 +1197,15 @@ newline: /* Render buffered output with spacing and delimiters, then

[PATCH] igb: Fix TX map failure path

] PC is at igb_xmit_frame_ring+0x9c8/0xcb8 Fix the erroneous test that leads to this situation. Signed-off-by: Jean-Philippe Brucker --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b