Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-13 Thread Jan Moskyto Matejka
On Sat, May 13, 2017 at 11:13:38AM -0600, David Ahern wrote: > On 5/13/17 4:54 AM, Jan Moskyto Matejka wrote: > >> I see 2 problems: > >> 1. the kernel is not telling the user the supplied buffer is too small > >> (ie., if a single route does not fit in the skb then

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-13 Thread Jan Moskyto Matejka
On Sat, May 13, 2017 at 12:52:47AM -0600, David Ahern wrote: > On 5/12/17 3:41 PM, Jan Moskyto Matejka wrote: > > On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > >> On 5/12/17 8:24 AM, David Miller wrote: > >>> From: Jan Moskyto Matejka > >>

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:34:04PM +0200, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > > > -int rt6_dump_route(struct rt6_info *rt, void *p_a

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > On 5/12/17 8:24 AM, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > >> +int rt6_dump

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > >

[PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
ut is truncated This came to light by David Ahern's commit beb1afac518dec5a15dc ("net: ipv6: Add support to dump multipath routes via RTA_MULTIPATH attribute") but obviously existed before, just hidden. Signed-off-by: Jan Moskyto Matejka --- include/net/ip6_route.h | 2 +-

[PATCH] rtnetlink.7: add missing RTA_* attributes

2016-03-15 Thread Jan Moskyto Matejka
Used Bird's source code, kernel source code, iproute2 source code and iproute2 manpages to find meanings of these new attributes. Signed-off-by: Jan Moskyto Matejka --- man7/rtnetlink.7 | 61 ++-- 1 file changed, 55 insertions(+), 6 dele