Re: [PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-10 Thread Jan Kasprzak
Wang Hai wrote: : If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a : corresponding kfree() in exception handling. Thus add kfree() for this : function implementation. Acked-By: Jan "Yenya" Kasprzak Looks correct, thanks. That said, COSA is an ancient ISA bus device designed

Re: wan-cosa: Use memdup_user() rather than duplicating its implementation

2016-08-25 Thread Jan Kasprzak
SF Markus Elfring wrote: : > What about the GFP_DMA attribute, which your patch deletes? : > The buffer in question has to be ISA DMA-able. : : Thanks for your constructive feedback. : : Would you be interested in using a variant of the function "memdup_…" : with which the corresponding memor

Re: [PATCH] wan-cosa: Use memdup_user() rather than duplicating its implementation

2016-08-24 Thread Jan Kasprzak
Hello, SF Markus Elfring wrote: : From: Markus Elfring : Date: Sat, 20 Aug 2016 10:10:12 +0200 : : Reuse existing functionality from memdup_user() instead of keeping : duplicate source code. : : This issue was detected by using the Coccinelle software. What about the GFP_DMA at

[PATCH] terminology in ip-sysctl.txt

2006-08-09 Thread Jan Kasprzak
Hello, this minor patch fixes the description of net.ipv4.tcp_mem sysctl in ip-sysctl.txt - the headline names the values "min, pressure, max", while the description uses the "low, pressure, high" values. Both tcp_rmem and tcp_wmem descriptions use the "min, pressure, max" values, so I hav