[RFC PATCH net 1/2] amd-xgbe: Avoid sleeping in flush_workqueue() while holding a spinlock

2019-10-15 Thread James Morse
lock for the duration of xgbe_powerdown(). We have already stopeed the timers, so service_work can't be re-queued. Move the pdata->power_down flag earlier so that it can be used by the interrupt handler to know not to re-queue the tx_tstamp_work. Signed-off-by: James Morse --- RFC as I&#

[RFC PATCH net 0/2] amd-xgbe: Sleeping while atomic during hibernate

2019-10-15 Thread James Morse
Hi guys, While testing hibernate on Seattle, I ran over these two. I'm not sure the second one is correct, so I'm hoping someone else will know how to fix it! Thanks, James Morse (2): amd-xgbe: Avoid sleeping in flush_workqueue() while holding a spinlock amd-xgbe: Avoid s

[RFC PATCH net 2/2] amd-xgbe: Avoid sleeping in napi_disable() while holding a spinlock

2019-10-15 Thread James Morse
0x468 | dpm_suspend+0x114/0x388 | hibernation_snapshot+0xe8/0x378 | hibernate+0x18c/0x2f8 Move xgbe_napi_disable() outside the spin_lock()d region of xgbe_powerdown(). This matches its use in xgbe_stop() ... but this might only be safe because of the earlier call to xgbe_free_irqs(). Signed-off-by:

[PATCH net-next] amd-xgbe: Reset running devices after resume from hibernate

2016-08-26 Thread James Morse
asleep. Signed-off-by: James Morse --- drivers/net/ethernet/amd/xgbe/xgbe-main.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c index 3eee3201b58f..9de078819aa6 100644 --- a/drive

[PATCH net v3] openvswitch: Allocate memory for ovs internal device stats.

2015-10-19 Thread James Morse
- not syncing: Fatal exception in interrupt =%<== Fixes: 8c876639c985 ("openvswitch: Remove vport stats.") Signed-off-by: James Morse --- Change since v2: * Fixed error-handling in internal_dev_create() to free the netdev. Change since v1: * Removed superfluous rx/tx_dropped increment,

[PATCH net v2] openvswitch: Allocate memory for ovs internal device stats.

2015-10-16 Thread James Morse
- not syncing: Fatal exception in interrupt =%<== Fixes: 8c876639c985 ("openvswitch: Remove vport stats.") Signed-off-by: James Morse --- Hi netdev, "openvswitch: Fix ovs_vport_get_stats()" [0], is an incomplete fix for the issue in "openvswitch: Remove vport stats.&quo

[PATCH 2/2] openvswitch: Allocate memory for ovs internal device stats.

2015-10-15 Thread James Morse
- not syncing: Fatal exception in interrupt =====%<== Signed-off-by: James Morse Fixes: 8c876639c985 ("openvswitch: Remove vport stats.") --- Hi netdev, "openvswitch: Fix ovs_vport_get_stats()" - already applied according to [0] (where?), is an incomplete fix for the issue in "open