x27;t restart, as the locking is broken somehow.
Fixes: 0795fb2021f0 ("net/ncsi: Stop monitor if channel times out or is
inactive")
Signed-off-by: Milton Miller
Signed-off-by: Eddie James
---
net/ncsi/ncsi-manage.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions
nel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-rolling-lts&id=9392b8219b62b0536df25c9de82b33f8a00881ef
James
don't see any bonding
commits between linux-lts-5.10.25 and linux-lts 5.10.26.
Any thoughts, shy of performing a full bisect, would be appreciated.
James
s.
>
> Add a separate NULL check to tell gcc about it as well.
>
> Signed-off-by: Arnd Bergmann
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
fixes-v5.12
--
James Morris
gt; ---
> > The code churn is unfortunate. Alternative would be to change
> > the function signature of ->route_req:
> > struct dst_entry *(*route_req)(struct sock *sk, ...
> > [ i.e., drop 'const' ]. Thoughts?
>
> Security folks - is this
> Documentation/networking/ppp_generic.rst | 9 ++
> drivers/net/ppp/ppp_generic.c| 143 ++-
> include/uapi/linux/ppp-ioctl.h | 2 +
> 3 files changed, 152 insertions(+), 2 deletions(-)
>
Reviewed-by: James Chapman
On Tue, 2020-11-24 at 13:32 -0800, Kees Cook wrote:
> On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote:
> > Really, no ... something which produces no improvement has no value
> > at all ... we really shouldn't be wasting maintainer time with it
> > beca
On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote:
> On Mon, Nov 23, 2020 at 4:58 PM James Bottomley
> wrote:
> > Well, I used git. It says that as of today in Linus' tree we have
> > 889 patches related to fall throughs and the first series went in
> > in octob
On Mon, 2020-11-23 at 07:03 -0600, Gustavo A. R. Silva wrote:
> On Sun, Nov 22, 2020 at 11:53:55AM -0800, James Bottomley wrote:
> > On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
> > > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> > > > On Sun,
On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote:
> On Sun, Nov 22, 2020 at 11:36 PM James Bottomley
> wrote:
> > Well, it seems to be three years of someone's time plus the
> > maintainer review time and series disruption of nearly a thousand
> > patches. Let
is fixing a significant problem, but they
did cause someone time and trouble to investigate.
James
On Sun, 2020-11-22 at 21:35 +0100, Miguel Ojeda wrote:
> On Sun, Nov 22, 2020 at 7:22 PM James Bottomley
> wrote:
> > Well, it's a problem in an error leg, sure, but it's not a really
> > compelling reason for a 141 patch series, is it? All that fixing
> > this
On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
> On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > > > Please tell me our rewa
On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > Please tell me our reward for all this effort isn't a single
> > missing error print.
>
> There were quite literally dozens of logical defects found
>
atch series, is it? All that fixing this
error will do is get the driver to print "oh dear there's a problem"
under four more conditions than it previously did.
We've been at this for three years now with nearly a thousand patches,
firstly marking all the fall throughs with /* fall through */ and later
changing it to fallthrough. At some point we do have to ask if the
effort is commensurate with the protection afforded. Please tell me
our reward for all this effort isn't a single missing error print.
James
;t be perfect but will be better than doing it manually.
Here's a thought: perhaps we don't. sysfs_emit isn't a "new api" its a
minor rewrap of existing best practice. The damage caused by the churn
of forcing its use everywhere would far outweigh any actual benefit
because pretty much every bug in this area has already been caught and
killed by existing tools. We can enforce sysfs_emit going forwards
using tools like checkpatch but there's no benefit and a lot of harm to
be done by trying to churn the entire tree retrofitting it (both in
terms of review time wasted as well as patch series derailed).
James
he next thing you're going to cause is an explosion of suggested
MAINTAINERs entries.
Has anyone actually complained about treewide:?
James
dling some error edge cases.
Suggested new option name: SO_REUSEADDR_WS
Kind Regards
James
replace the flowi pointers with pointers
> to the address family independent flowi_common struct.
>
> Reported-by: Herbert Xu
> Signed-off-by: Paul Moore
Acked-by: James Morris
--
James Morris
clist()")
> Reported-by: Dan Carpenter
> Signed-off-by: Paul Moore
Reviewed-by: James Morris
> ---
> net/netlabel/netlabel_unlabeled.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netlabel/netlabel_unlabeled.c
> b/ne
(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
> > @@ -632,10 +627,8 @@ nfqnl_build_packet_message(struct net *net, struct
> > nfqnl_instance *queue,
> > }
> >
> > nlh->nlmsg_len = skb->len;
> > - if (seclen) {
> > - lsmcontext_init(&scaff, secdata, seclen, 0);
> > - security_release_secctx(&scaff);
> > - }
> > + if (context.len)
> > + security_release_secctx(&context);
> > return skb;
> >
> > nla_put_failure:
> > @@ -643,10 +636,8 @@ nfqnl_build_packet_message(struct net *net, struct
> > nfqnl_instance *queue,
> > kfree_skb(skb);
> > net_err_ratelimited("nf_queue: error creating packet message\n");
> > nlmsg_failure:
> > - if (seclen) {
> > - lsmcontext_init(&scaff, secdata, seclen, 0);
> > - security_release_secctx(&scaff);
> > - }
> > + if (context.len)
> > + security_release_secctx(&context);
> > return NULL;
> > }
> >
> > --
> > 2.24.1
> >
>
--
James Morris
ntainers on the
To: line or they may miss the email.
--
James Morris
ng back a secid.
> The infrastructure passes the correct entry from the lsmblob.
>
> Signed-off-by: Casey Schaufler
> Cc: netdev@vger.kernel.org
You probably need to include Netfilter maintainers specifically for this
(added them + the Netfilter list).
This also needs signoffs from LSM owners.
--
James Morris
On Tue, 27 Oct 2020, Paul Moore wrote:
> On Wed, Sep 30, 2020 at 9:44 AM Paul Moore wrote:
> > On Tue, Sep 29, 2020 at 7:09 PM James Morris wrote:
> > > I'm not keen on adding a parameter which nobody is using. Perhaps a note
> > > in the header instead?
> &g
it version.
>
> Reported-by: Roman Kiryanov
> https://android-review.googlesource.com/c/device/generic/goldfish/+/1468545/
> Signed-off-by: Jeff Vander Stoep
Reviewed-by: James Morris
--
James Morris
want anything in userspace
triggering since it's likely to be nearly dead). Remove removes the
device from the tree and cleans up everything. I think the function
you want that's closest to what shutdown needs is de_close(). That
basically just turns off the chip and frees the interrupt ... you'll
have to wrapper it to call it from the pci_driver, though.
James
IT has put some spam filter on the list that mangles URLs
this way.
James
On Sun, 2020-10-18 at 20:16 +0100, Matthew Wilcox wrote:
> On Sun, Oct 18, 2020 at 12:13:35PM -0700, James Bottomley wrote:
> > On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote:
> > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
> > > > cla
also likely a different colour from c_dst, so dst_kaddr has to be
flushed on kunmap and c_dst has to be invalidated on kmap. What we
should have is an architectural primitive for doing this, something
like kmemcopy_arch(dst, src). PIPT architectures can implement it as
the above (possibly losing kmap if they don't need it) but VIPT/VIVT
architectures can set up a correctly coloured mapping so they can
simply copy from c_src to c_dst without any need to flush and the data
arrives cache hot at c_dst.
James
tp/l2tp_core.h | 4 +-
> net/l2tp/l2tp_eth.c | 3 +-
> net/l2tp/l2tp_netlink.c | 20 +-
> net/l2tp/l2tp_ppp.c | 3 +-
> 9 files changed, 527 insertions(+), 28 deletions(-)
> create mode 100644 net/l2tp/l2tp_ac_pppoe.c
>
Reviewed-by: James Chapman
es the problem of
> the LSM hook callers sending the wrong secid which would be much
> worse.
>
> Reported-by: Herbert Xu
> Signed-off-by: Paul Moore
I'm not keen on adding a parameter which nobody is using. Perhaps a note
in the header instead?
--
James Morris
follow.
>
> As a stop gap use netif_rx_any_context() which invokes the correct code
> path depending on context and confines the in_interrupt() usage to core
> code.
>
> Signed-off-by: Sebastian Andrzej Siewior
> Signed-off-by: Thomas Gleixner
> Acked-by: Kalle Valo
On Tue, 2020-09-15 at 08:27 +0200, Christoph Hellwig wrote:
> On Mon, Sep 14, 2020 at 08:20:18AM -0700, James Bottomley wrote:
> > If you're going to change the macros from taking a device to taking
> > a hostdata structure then the descriptive argument name needs to
> >
t field %s at %d to
> 0x%x\n", \
> #symbol, A_##symbol##_used[i], val)); \
> } \
If you're going to change the macros from taking a device to taking a
hostdata structure then the descriptive argument name needs to change
... it can't be dev anymore. I'm happy with it simply becoming 'h' if
hostdata is too long.
I already asked for this on the first go around:
https://lore.kernel.org/alsa-devel/1598971960.4238.5.ca...@hansenpartnership.com/
James
de in l2tp_tunnel_closeall
>
> net/l2tp/l2tp_core.c| 134 +++-
> net/l2tp/l2tp_core.h| 10 ++-
> net/l2tp/l2tp_eth.c | 2 +-
> net/l2tp/l2tp_ip.c | 2 +-
> net/l2tp/l2tp_ip6.c | 2 +-
> net/l2tp/l2tp_netlink.c | 2 +-
> net/l2tp/l2tp_ppp.c | 15 -
> 7 files changed, 87 insertions(+), 80 deletions(-)
>
Reviewed-by: James Chapman
On Tue, 2020-09-01 at 16:05 +0100, Matthew Wilcox wrote:
> On Tue, Sep 01, 2020 at 07:52:40AM -0700, James Bottomley wrote:
> > I think this looks mostly OK, except for one misnamed parameter
> > below. Unfortunately, the last non-coherent parisc was the 700
> > series and
dma_sync_to_dev((dev),
> &(script)[A_##symbol##_used[i]], 4); \
> DEBUG((" script, patching short field %s at %d to
> 0x%x\n", \
> #symbol, A_##symbol##_used[i], val)); \
> } \
These macro arguments need updating. Since you changed the input from
hostdata->dev to hostdata, leaving the macro argument as dev is simply
misleading. It needs to become hostdata or h.
James
oints.
>
> This patchset refactors l2tp to:
>
> * remove excessive logging
> * tweak useful log messages to use the standard pr_* calls for logging
>rather than the l2tp wrappers
> * replace debug-level logging with tracepoints
> * add tracepoints for capturing tunnel and s
> So far we have a few which have been suggested as replacement
> for from_tasklet()
>
> - out_cast() or outer_cast()
> - from_member().
> - container_from() or from_container()
>
> from_container() sounds fine, would trimming it a bit work? like
> from_cont().
I'm fine with container_from(). It's the same form as container_of()
and I think we need urgent agreement to not stall everything else so
the most innocuous name is likely to get the widest acceptance.
James
On Wed, 2020-08-19 at 07:00 -0600, Jens Axboe wrote:
> On 8/18/20 1:00 PM, James Bottomley wrote:
[...]
> > Since both threads seem to have petered out, let me suggest in
> > kernel.h:
> >
> > #define cast_out(ptr, container, member) \
> > container_o
On 18/08/2020 19:57, Jakub Kicinski wrote:
> On Tue, 18 Aug 2020 16:11:35 +0100 jchap...@katalix.com wrote:
>> From: James Chapman
>>
>> Kernel documentation of L2TP has not been kept up to date and lacks
>> coverage of some L2TP APIs. While addressing this, refacto
On Tue, 2020-08-18 at 13:10 -0700, Kees Cook wrote:
> On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote:
> > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote:
> > > On 8/17/20 12:48 PM, Kees Cook wrote:
> > > > On Mon, Aug 17, 2020 at 12:4
ewide
>
> On naming? Implementation is just as it stands, from_tasklet() is
> totally generic which is why I objected to it. from_member()? Not
> great with naming... But I can see this going further and then we'll
> suddenly have tons of these. It's not good for readability.
Since both threads seem to have petered out, let me suggest in
kernel.h:
#define cast_out(ptr, container, member) \
container_of(ptr, typeof(*container), member)
It does what you want, the argument order is the same as container_of
with the only difference being you name the containing structure
instead of having to specify its type.
James
ger.kernel.org
I'd like to see Paul's acks on any networking related changes.
--
James Morris
+-
> net/l2tp/l2tp_ip6.c | 2 +-
> net/l2tp/l2tp_netlink.c | 206 ++--
> net/l2tp/l2tp_ppp.c | 59 ++++++--
> 6 files changed, 169 insertions(+), 150 deletions(-)
>
Reviewed-by: James Chapman
> net/l2tp/l2tp_ip.c | 17 +
> net/l2tp/l2tp_ip6.c | 29 +++
> net/l2tp/l2tp_netlink.c | 75 -----
> net/l2tp/l2tp_ppp.c | 20 +-
> 8 files changed, 145 insertions(+), 177 deletions(-)
>
Reviewed-by: James Chapman
ned by BPF.
I have reservations about using a bit in sk_user_data to indicate
ownership of that pointer. But putting that aside, I confirm that the
patch fixes the problem.
Acked-by: James Chapman
Tested-by: James Chapman
Reported-by: syzbot+9f092552ba9a5efca...@syzkaller.appspotmail.com
On Tue, Jul 07, 2020 at 11:31:28 -0700, Martin KaFai Lau wrote:
> On Mon, Jul 06, 2020 at 12:45:36PM -0700, David Miller wrote:
> > From: James Chapman
> > Date: Mon, 6 Jul 2020 13:12:59 +0100
> >
> > > The crash occurs in the socket destroy path. bpf_sk_reuseport_
On Wed, Jul 08, 2020 at 04:08:09 +0800, Xin Long wrote:
> On Wed, Jul 8, 2020 at 1:24 AM James Chapman wrote:
> >
> > On Tue, Jul 07, 2020 at 02:02:32 +0800, Xin Long wrote:
> > > In the tx path of l2tp, l2tp_xmit_skb() calls skb_dst_set() to set
> > > skb&#
On Tue, Jul 07, 2020 at 02:02:32 +0800, Xin Long wrote:
> In the tx path of l2tp, l2tp_xmit_skb() calls skb_dst_set() to set
> skb's dst. However, it will eventually call inet6_csk_xmit() or
> ip_queue_xmit() where skb's dst will be overwritten by:
>
>skb_dst_set_noref(skb, dst);
>
> without
I'm investigating a crash found by syzbot which turns out to be caused
by bpf_sk_reuseport_detach assuming ownership of sk_user_data in the
UDP socket destroy path and corrupts metadata of a UDP socket user (l2tp).
Here's the syzbot report:
https://syzkaller.appspot.com/bug?extid=9f092552ba9a5efca
SO_REUSEPORT were set after the
socket is initialised by l2tp.
2. Should the reuseport code have a dedicated member of struct sock
to use instead of sk_user_data such that SO_REUSEPORT can be used
by UDP encap socket users like l2tp?
Fixes: 6b9f34239b00 ("l2tp: fix races in tunnel cre
x-fsdevel/1587569663.3485.18.ca...@hansenpartnership.com/
The bottom line is that we think you could rewrite this one application
not to have the problem you're complaining about rather than introduce
a new kernel API to "fix" it.
James
On Wed, 13 May 2020, Alexei Starovoitov wrote:
> James,
>
> since you took the previous similar patch are you going to pick this
> one up as well?
> Or we can route it via bpf tree to Linus asap.
Routing via your tree is fine.
>
> Thanks
>
> On Tue, May 12, 202
> Thank you Arnd for helping me figure out what went wrong.
>
> CC: Arnd Bergmann
> Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
> Signed-off-by: Anders Roxell
Note, this patch should have been sent to me and cc'd the LSM list.
Acked-by: James Morris
--
James Morris
lock for the duration of xgbe_powerdown(). We have already
stopeed the timers, so service_work can't be re-queued. Move the
pdata->power_down flag earlier so that it can be used by the interrupt
handler to know not to re-queue the tx_tstamp_work.
Signed-off-by: James Morse
---
RFC as I&#
Hi guys,
While testing hibernate on Seattle, I ran over these two.
I'm not sure the second one is correct, so I'm hoping someone else will
know how to fix it!
Thanks,
James Morse (2):
amd-xgbe: Avoid sleeping in flush_workqueue() while holding a spinlock
amd-xgbe: Avoid s
0x468
| dpm_suspend+0x114/0x388
| hibernation_snapshot+0xe8/0x378
| hibernate+0x18c/0x2f8
Move xgbe_napi_disable() outside the spin_lock()d region of
xgbe_powerdown(). This matches its use in xgbe_stop() ... but this
might only be safe because of the earlier call to xgbe_free_irqs().
Signed-off-by:
On 16/09/2019 15:14, David Miller wrote:
From: James Byrne
Date: Fri, 13 Sep 2019 16:46:35 +
The documentation of skew values for the KSZ9021 PHY was misleading
because the driver implementation followed the erroneous information
given in the original KSZ9021 datasheet before it was
existing device trees, so instead this just
corrects the documentation to explain that what you actually get is not
what you might think when looking at the device tree.
Signed-off-by: James Byrne
---
.../bindings/net/micrel-ksz90x1.txt | 32 +--
1 file changed, 30
tually be delivered to the *other* "local" interface, that
was *actually* addressed, so that the domain daemon, in this example, would be
able to respond to the request, even when that daemon were only "listening" on
the *other* "local" interface, the one addressed? And, without using a bridge
interface, bridging these separate "local" interfaces, intended to be on
different subnets?
Thanks
James
another security
> module to take over lockdown decisions once it has initialized (including
> policy load), and to be able to access state that is currently private to the
> lockdown module, like the level.
Why not utilize stacking (restrictively), similarly to capabilities?
--
James Morris
--
My greeting to you and your family,
I am Captain JAMES WILLIAMS. I'm 49 years old, from the united states,
but I am currently in Syria for peace keeping mission. I am the
commanding officer of the third Battalion soldier regime.
Please forgive my manners I am not good when it com
--
My greeting to you and your family,
I am Captain JAMES WILLIAMS. I'm 49 years old, from the united states,
but I am currently in Syria for peace keeping mission. I am the
commanding officer of the third Battalion soldier regime.
Please forgive my manners I am not good when it com
On 19/02/2019 13:09, t.mart...@avm.de wrote:
>
> Hello,
>
> thanks for your quick response.
>
> "James Chapman" schrieb am 19.02.2019 13:40:10:
>
> > Von: "James Chapman"
> > An: t.mart...@avm.de
> > Kopie: da...@davemloft.net, "net
you really need to insert padding in transmitted L2TPv3 packets
between the L2TPv3 header and its payload, one option is to define a new
L2SpecificHeaderType and patch the kernel to accept it.
If you control both the sender and receiver, is using FOU an option?
James
for 14 days
after publication without paying for an lwn.net subscription, but by
the time these patches are upstream there will be no paywall because it
will expire on 24 January and that URL will then be readable by all.
That makes LWN.net a nice, reliable resource for us while still
supporting some business model to keep it going.
James
reted to the point where it's effectively a new CoC has been
the source of much debate and recrimination over the last few months
... you can read it in the ksummit-discuss archives, but I really think
we don't want to reopen that can of worms.
James
eated precisely because
there was a lot of push back on interpretation problems and ambiguities
with the original CoC and it specifically covers this case (and a lot
of others).
James
> After this discussion, I can say that I understand it less than
> before.
>
> /Jarkko
>
On Fri, 2018-11-30 at 13:54 -0800, Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 01:48:08PM -0800, David Miller wrote:
> > From: Jarkko Sakkinen
> > Date: Fri, 30 Nov 2018 13:44:05 -0800
> >
> > > On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote:
On Fri, 2018-11-30 at 13:44 -0800, Jarkko Sakkinen wrote:
> On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote:
> > No because use of what some people consider to be bad language
> > isn't necessarily abusive, offensive or degrading. Our most
> > heavily
e hugging, please propose something
> else
> :-)
The interpretation document also says this:
ontributions submitted for the kernel should use appropriate
language. Content that already exists predating the Code of Conduct
will not be addressed now as a violation.
So that definitely means there should be no hunting down of existing
comments in kernel code.
James
On Fri, Sep 7, 2018 at 1:34 PM, David Miller wrote:
> From: Willem de Bruijn
> Date: Fri, 7 Sep 2018 11:50:02 -0400
>
>> If you are not seeing these problems with other protocols, I must be
>> misreading that code.
>
> Right, the ethernet header is only guaranteed to be 2 byte aligned on
> transm
On Fri, Sep 7, 2018 at 11:50 AM, Willem de Bruijn wrote:
> Hi James,
>
> Thanks for the report. In the future please always include
> netdev@vger.kernel.org in technical discussions.
>
> On Fri, Sep 7, 2018 at 1:00 AM James Sakalaukus wrote:
>>
>> Hello Wil
ice ?
Thanks
James
se patches, so
> that David can apply the network patches to net-next.
Since it sounds like the net patches are ready now, I'll apply the MIPS
DTS ones for 4.18.
Thanks
James
signature.asc
Description: PGP signature
On Fri, 4 May 2018, David Herrmann wrote:
> Hi
>
> This is v2 of the socketpair(2) LSM hook introduction.
Thanks, all applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
next-general
--
James Morris
Hello,How are you,I contacted you for the first time concerning your late
relative that deposited value of funds in the bank that will not be mentioned
due to security reason,but I did not hear from you.WHY?I will appreciate you
get back to me for more details. Thanks James Manuh.
On Thu, 2018-04-26 at 11:05 -0400, Mikulas Patocka wrote:
>
> On Thu, 26 Apr 2018, James Bottomley wrote:
[...]
> > Perhaps find out beforehand instead of insisting on an approach
> without
> > knowing. On openSUSE the grub config is built from the files in
> > /etc
On Thu, 2018-04-26 at 10:28 -0400, Mikulas Patocka wrote:
>
> On Thu, 26 Apr 2018, Michal Hocko wrote:
>
> > On Wed 25-04-18 18:42:57, Mikulas Patocka wrote:
> > >
> > >
> > > On Wed, 25 Apr 2018, James Bottomley wrote:
> > [...]
> >
On Wed, 2018-04-25 at 19:00 -0400, Mikulas Patocka wrote:
>
> On Wed, 25 Apr 2018, James Bottomley wrote:
>
> > > > Do we really need the new config option? This could just be
> > > > manually tunable via fault injection IIUC.
> > >
> > > We
different boot option, you can (just have the tunable set
on the command line), but being tunable driven means that you don't
have to choose that option, you could automatically enable it under a
range of circumstances. I think most sane distributions would want
that flexibility.
Kconfig proliferation, conversely, is a bit of a nightmare from both
the user and the tester's point of view, so we're trying to avoid it
unless absolutely necessary.
James
On Wed, 25 Apr 2018, Paul Moore wrote:
> On Wed, Apr 25, 2018 at 2:44 PM, James Morris wrote:
> > On Mon, 23 Apr 2018, David Herrmann wrote:
> >> This patch series tries to close this gap and makes both behave the
> >> same. A new LSM-hook is added which allow
ck backend and maybe the hook name change,
I'll merge this unless DaveM wants it to go in via his networking tree.
--
James Morris
work properly on parisc, so I don't
think the replacement works.
James
s, and populate a struct seccomp_data to be passed to
> __secure_computing(). This allows samples/bpf/tracex5 to extract a
> sensible trace.
This broke o32 indirect syscalls, and was fixed by commit 3d729deaf287
("MIPS: seccomp: Fix indirect syscall args").
Cheers
James
signature.asc
Description: Digital signature
vchenko
> >
> > Acked-by: Hauke Mehrtens
> >
> > The patch looks good, but I haven't tested them on my devices.
>
> Any news on this, anyone?
Changes to this usually seem to go through the MIPS tree, so I've
applied for 4.17.
Thanks
James
signature.asc
Description: Digital signature
, European Citizens, Asian Citizen. All I
want you to do is to contact the atm card CENTER Via email or call the
office telephone number one of the Consultant will assist you for
their requirements to proceed and procure your Approval Slip on your
behalf.
CONTACT INFORMATION
NAME: James Williams
EMAIL
establish working relationship.
Sincerely,
James Tyler, MBA, CFA
Investment analyst.
On 6 March 2018 at 15:54, Eric Dumazet wrote:
> From: Eric Dumazet
>
> syzkaller found an issue caused by lack of sufficient checks
> in l2tp_tunnel_create()
>
> RAW sockets can not be considered as UDP ones for instance.
Acked-by: James Chapman
;
> Signed-off-by: Carlos Munoz
> Signed-off-by: Steven J. Hill
> Signed-off-by: David Daney
Acked-by: James Hogan
Cheers
James
signature.asc
Description: Digital signature
psregs.h
> @@ -1126,6 +1126,8 @@
> #define FPU_CSR_RD 0x3 /* towards -Infinity */
>
>
> +#define CAVIUM_OCTEON_SCRATCH_OFFSET (2 * 128 - 16 - 32768)
This feels a bit out of place, since its effectively cavium specific
memory mapped scratch register addresses. Would tlbex.h or octeon.h be
more appropriate, or even tlbex.c if it isn't used elsewhere?
Otherwise this patch looks reasonable I think.
Cheers
James
signature.asc
Description: Digital signature
patch into separate l2tp and ppp
parts")
Signed-off-by: James Chapman
---
net/l2tp/l2tp_ppp.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c
index 59f246d7b290..2d2955e8f710 100644
--- a/net/l2tp/l2tp_ppp.c
+++ b/net/l2tp/l2tp_ppp.c
47bd5acde002e353...@syzkaller.appspotmail.com
Reported-and-tested-by: syzbot+6e6a5ec8de31a94cd...@syzkaller.appspotmail.com
Reported-and-tested-by: syzbot+9df43faf09bd400f2...@syzkaller.appspotmail.com
Signed-off-by: James Chapman
---
net/l2tp/l2tp_core.c | 14 +++---
1 file changed, 7 insertions(+), 7 de
00 00 00 <49> 81 3c
24 80 93 3f 83 b8 00 00 00 00 44 0f 44 c0 83 fe 01 0f
RIP: __lock_acquire+0x263/0x1630 RSP: 88001a37fc70
CR2: 00a0
Fixes: 309795f4bec2d ("l2tp: Add netlink control API for L2TP")
Signed-off-by: James Chapman
---
net/l2tp/l2tp_core.c | 11 ++-
could be destroyed
while its associated tunnel/session object still existed (patches 3,
4). Patch 5 addresses a problem with the way tunnels are removed from
the tunnel list. Patch 5 is tagged that it addresses all four syzbot
issues, though all 5 patches are needed.
James Chapman (5):
l2tp
02 00 00 e8 13 d6 db fc 49 8d bc 24 28 02
00 00 48 b8 00 00 00 00 00 fc ff df 48 89 f
a 48 c1 ea 03 <80> 3c 02 00 0f 85 ed 02 00 00 4d 8b a4 24 28 02 00 00 e8 13 16
Fixes: 80d84ef3ff1dd ("l2tp: prevent l2tp_tunnel_delete racing with userspace
close")
Signed-off-by: Jame
20 85 64 85 e
8 2a 55 14 ff <0f> 0b 83 05 ad 2a 68 04 01 48 83 c4 18 5b 41 5c 41 5d 41 5e 41
Fixes: ee40fb2e1eb5b ("l2tp: protect sock pointer of struct pppol2tp_session
with RCU")
Signed-off-by: James Chapman
---
net/l2tp/l2tp_ppp.c | 52 +++
no longer used so is removed.
Fixes: 80d84ef3ff1dd ("l2tp: prevent l2tp_tunnel_delete racing with userspace
close")
Signed-off-by: James Chapman
---
net/l2tp/l2tp_core.c | 128 ++-
net/l2tp/l2tp_core.h | 26 ++-
net/l2tp/l2tp_
fixes/reported-by tags to end of commit text and add my
signoff which got dropped in v2.
James Chapman (16):
l2tp: update sk_user_data while holding sk_callback_lock
l2tp: add RCU read lock to protect tunnel ptr in ip socket destroy
l2tp: don't use inet_shutdown on tunnel destroy
1 - 100 of 826 matches
Mail list logo
