Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 4:17 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > > Can you recreate with this patch, and add "unwind_debug" to the > > > > > cmdline? > > > > > It will spi

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-04 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 7:10 PM Josh Poimboeuf wrote: > This line gives a big clue: > > [160676.608966][C4] RIP: 0010:0xc17d814c > > That address, without a function name, most likely means that it was > running in some generated code (mostly likely BPF) when it got > interrupted. W

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 4:17 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 03:30:35PM -0800, Ivan Babrou wrote: > > > > > Can you recreate with this patch, and add "unwind_debug" to the > > > > > cmdline? > > > > > It will spi

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 3:28 PM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 02:41:53PM -0800, Ivan Babrou wrote: > > On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > > > > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > >

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
On Wed, Feb 3, 2021 at 11:05 AM Josh Poimboeuf wrote: > > On Wed, Feb 03, 2021 at 09:46:55AM -0800, Ivan Babrou wrote: > > > Can you pretty please not line-wrap console output? It's unreadable. > > > > GMail doesn't make it easy, I'll send a link to a pa

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-03 Thread Ivan Babrou
> Can you pretty please not line-wrap console output? It's unreadable. GMail doesn't make it easy, I'll send a link to a pastebin next time. Let me know if you'd like me to regenerate the decoded stack. > > edfd9b7838ba5e47f19ad8466d0565aba5c59bf0 is the first bad commit > > commit edfd9b7838ba5e

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1df5/0x2650

2021-02-02 Thread Ivan Babrou
On Thu, Jan 28, 2021 at 7:35 PM Ivan Babrou wrote: > > Hello, > > We've noticed the following regression in Linux 5.10 branch: > > [ 128.367231][C0] > == > [ 128.368523][C0] BUG:

[PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-01-20 Thread Ivan Babrou
processing: sfc :86:00.0 ext0: XDP TX failed (-22) Signed-off-by: Ivan Babrou --- drivers/net/ethernet/sfc/efx_channels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-01-19 Thread Ivan Babrou
On Thu, Dec 17, 2020 at 10:14 AM Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 17:29:06 -0800 Ivan Babrou wrote: > > Without this change the driver tries to allocate too many queues, > > breaching the number of available msi-x interrupts on machines > > with many logical

[PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-14 Thread Ivan Babrou
processing: sfc :86:00.0 ext0: XDP TX failed (-22) Signed-off-by: Ivan Babrou --- drivers/net/ethernet/sfc/efx_channels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index

Re: [PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-13 Thread Ivan Babrou
On Sun, Dec 13, 2020 at 4:23 AM Martin Habets wrote: > > On Thu, Dec 10, 2020 at 04:18:53PM -0800, Ivan Babrou wrote: > > Queue sharing behaviour already exists in the out-of-tree sfc driver, > > available under xdp_alloc_tx_resources module parameter. > > This comment is

[PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-10 Thread Ivan Babrou
XDP processing: sfc :86:00.0 ext0: XDP TX failed (-22) Signed-off-by: Ivan Babrou --- drivers/net/ethernet/sfc/efx_channels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index

BUG: KASAN: double-free or invalid-free in ip_defrag after upgrade from 4.19.13

2019-01-30 Thread Ivan Babrou
Hey, Continuing from this thread earlier today: * https://marc.info/?t=15488672911&r=1&w=2 We fired up KASAN enabled kernel one one of those machine and this is what we saw: $ /tmp/decode_stacktrace.sh /usr/lib/debug/lib/modules/4.19.18-cloudflare-2019.1.8-1-gcabf55c/vmlinux linux-4.19.18 <

Re: BUG: KASAN: double-free or invalid-free in ip_defrag after upgrade from 4.19.13

2019-01-30 Thread Ivan Babrou
Eric, Are you going to propose the change then? I'm happy to test it out. On Wed, Jan 30, 2019 at 3:00 PM Michal Kubecek wrote: > > On Wed, Jan 30, 2019 at 02:26:32PM -0800, Ivan Babrou wrote: > > Hey, > > > > Continuing from this thread earlier today: &

Re: Crashes in skb clone/allocation in 4.19.18

2019-01-30 Thread Ivan Babrou
On Wed, Jan 30, 2019 at 9:28 AM Lance Richardson wrote: > > On Wed, Jan 30, 2019 at 12:17 PM Cong Wang wrote: > > > > On Wed, Jan 30, 2019 at 8:54 AM Ivan Babrou wrote: > > > > > > Hey, > > > > > > We've upgraded some machines from

Crashes in skb clone/allocation in 4.19.18

2019-01-30 Thread Ivan Babrou
Hey, We've upgraded some machines from 4.19.13 to 4.19.18 and some of them crashed with the following: [ 2313.192006] general protection fault: [#1] SMP PTI [ 2313.205924] CPU: 32 PID: 65437 Comm: nginx-fl Tainted: G O 4.19.18-cloudflare-2019.1.8 #2019.1.8 [ 2313.224973] Hardware name:

[PATCH] tools: bpftool: do not force gcc as CC

2018-12-19 Thread Ivan Babrou
This allows transparent cross-compilation with CROSS_COMPILE. Signed-off-by: Ivan Babrou --- tools/bpf/bpftool/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile index dac7eff4c7e5..ee906f597f21 100644 --- a/tools/bpf/bpftool

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Ivan Babrou
On Tue, Dec 18, 2018 at 7:02 PM Stanislav Fomichev wrote: > > On 12/18, Ivan Babrou wrote: > > On Tue, Dec 18, 2018 at 6:06 PM Stanislav Fomichev wrote: > > > > > > On 12/18, Ivan Babrou wrote: > > > > On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Ivan Babrou
On Tue, Dec 18, 2018 at 6:06 PM Stanislav Fomichev wrote: > > On 12/18, Ivan Babrou wrote: > > On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev wrote: > > > > > > On 12/18, Ivan Babrou wrote: > > > > Hey, > > > > > > > > I

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Ivan Babrou
On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev wrote: > > On 12/18, Ivan Babrou wrote: > > Hey, > > > > Is it possible to cross-compile bpftool for arm64? I'm trying to do > > the same thing we do for perf, but bpftool Makefile doesn't seem to > >

bpftool cross-compilation for arm64

2018-12-18 Thread Ivan Babrou
Hey, Is it possible to cross-compile bpftool for arm64? I'm trying to do the same thing we do for perf, but bpftool Makefile doesn't seem to support CROSS_COMPILE variable, so one needs to pass CC=aarch64-linux-gnu-gcc as well. Problems do not end there as it requires EXTRA_LDFLAGS="-lz" too. With

[PATCH] net: dummy: remove note about being Y by default

2016-04-23 Thread Ivan Babrou
Signed-off-by: Ivan Babrou --- drivers/net/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 2a1ba62b..bd86a23 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -62,9 +62,8 @@ config DUMMY this