Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Ion Badulescu
On 11/20/20 6:56 PM, Jakub Kicinski wrote: On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote: Frankly, no, I don't know of any users, and that unfortunately includes myself. I still have two cards in my stash, but they're 64-bit PCI-X, so plugging them in would likely requir

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Ion Badulescu
On 11/20/20 6:17 PM, Jakub Kicinski wrote: On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1...@gmail.com wrote: From: Kaixu Xia The body of the if statement can be executed only when the variable vlan_count equals to 32, so the condition of the while statement can not be true and the while stateme

Network packet reordering with the 5.4 stable tree

2020-09-30 Thread Ion Badulescu
r and its use of rx_copybreak to select between napi_gro_receive()/napi_gro_frags(). Signed-off-by: Alexander Lobakin Acked-by: Edward Cree Signed-off-by: David S. Miller [Ion: backported to v5.4] Signed-off-by: Ion Badulescu diff --git a/net/core/dev.c b/net/core/dev.c index

Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels

2005-09-02 Thread Ion Badulescu
Hi Alexey, On Sat, 3 Sep 2005, Alexey Kuznetsov wrote: Well, take a look at the double acks for 84439343, 84440447 and 84441059, they seem pretty much identical to me. It is just a little tcpdump glitch. 19:34:54.532271 < 10.2.20.246.33060 > 65.171.224.182.8700: . 44:44(0) ack 84439343 win

Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels

2005-09-02 Thread Ion Badulescu
Hi Alexey, On Fri, 2 Sep 2005, Alexey Kuznetsov wrote: This is where things start going bad. The window starts shrinking from 15340 all the way down to 2355 over the course of 0.3 seconds. Notice the many duplicate acks that serve no purpose These are not duplicate, TCP_NODELAY sender just st

Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels

2005-09-02 Thread Ion Badulescu
On Fri, 2 Sep 2005, John Heffner wrote: If it is window clamping, then you should be asymptotically approaching a ratio between receive buffer and window that corresponds (with a fudge factor) to the ratio between TCP segment data size and allocated packet size. If you make the receive buffer

Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels

2005-09-02 Thread Ion Badulescu
On Fri, 2 Sep 2005, Guillaume Autran wrote: I experienced the very same problem but with window size going all the way down to just a few bytes (14 bytes). dump files available upon requests :) Ion, how were you able to reproduce the issue ? Can the same type of traffice always reproduce the is

Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels

2005-09-01 Thread Ion Badulescu
Hi David, On Thu, 1 Sep 2005, David S. Miller wrote: Thanks for the empty posting. Please provide the content you intended to post, and furthermore please post it to the network developer mailing list, netdev@vger.kernel.org First of all, thanks for the reply (even to an empty posting :). T