Re: [PATCH] net: dev: Add API to check net_dev readiness

2020-08-05 Thread Ilia Lin
My comments inline. Thanks, Ilia Lin On Tue, Aug 4, 2020 at 10:24 PM Andrew Lunn wrote: > > On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote: > > Hi Andrew and David, > > Hi Ilia > > Please don't top post. > > > > > Thank you for your comments

Re: [PATCH] net: dev: Add API to check net_dev readiness

2020-08-04 Thread Ilia Lin
Hi Andrew and David, Thank you for your comments! The client driver is still work in progress, but it can be seen here: https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842 For HW performance reasons, it has to be in subsys_initcall. Here is the re

Re: [PATCH] net: dev: Add API to check net_dev readiness

2020-08-04 Thread Ilia Lin
Hi Andrew and David, Thank you for your comments! The client driver is still work in progress, but it can be seen here: https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842 For HW performance reasons, it has to be in subsys_initcall. Here is the re

[PATCH] net: dev: Add API to check net_dev readiness

2020-07-26 Thread Ilia Lin
From: Ilia Lin Add an API that returns true, if the net_dev_init was already called, and the driver was initialized. Some early drivers, that are initialized during the subsys_initcall may try accessing the net_dev or NAPI APIs before the net_dev_init, and will encounter a kernel bug. This API