Re: [PATCH net] net: ipconfig: ic_dev can be NULL in ic_close_devs

t; iterator variable was shortened to "lower" in order to > keep the 80 character limit. > > Fixes: f68cbaed67cb ("net: ipconfig: avoid use-after-free in ic_close_devs") > Fixes: 46acf7bdbc72 ("Revert "net: ipv4: handle DSA enabled master network > dev

Re: [PATCH net-next] net: ipconfig: avoid use-after-free in ic_close_devs

Hi Vladimir and all, > Due to the fact that ic_dev->dev is kept open in ic_close_dev, I had > thought that ic_dev will not be freed either. But that is not the case, > but instead "everybody dies" when ipconfig cleans up, and just the > net_device behind ic_dev->dev remains allocated but not ic_de

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

Hi all, Am Do., 25. Feb. 2021 um 22:15 Uhr schrieb Heiko Thiery : > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > This is only the case when the interface is down. This can be reproduced > by reading with 'phc_ctrl eth0 get'. > > Lik

[PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

d when the interface is down and leads to a system hang. So we check if the ptp clock status before reading the timecounter register. Signed-off-by: Heiko Thiery --- v2: - add mutex (thanks to Richard) v3: I did a mistake and did not test properly - add parenteses - fix the used variable drivers/ne

[PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

d when the interface is down and leads to a system hang. So we check if the ptp clock status before reading the timecounter register. Signed-off-by: Heiko Thiery --- v2: - add mutex (thanks to Richard) drivers/net/ethernet/freescale/fec_ptp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/d

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

Hi Richard, Am Do., 25. Feb. 2021 um 14:49 Uhr schrieb Heiko Thiery : > > Hi Richard, > > Am Di., 23. Feb. 2021 um 17:11 Uhr schrieb Richard Cochran > : > > > > On Tue, Feb 23, 2021 at 04:04:16PM +0100, Heiko Thiery wrote: > > > It is not only the PHC clock

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

Hi Richard, Am Di., 23. Feb. 2021 um 17:11 Uhr schrieb Richard Cochran : > > On Tue, Feb 23, 2021 at 04:04:16PM +0100, Heiko Thiery wrote: > > It is not only the PHC clock that stops. Rather, it is the entire > > ethernet building block in the SOC that is disabled, including the

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

Hi Richard, Am Di., 23. Feb. 2021 um 15:27 Uhr schrieb Richard Cochran : > > On Tue, Feb 23, 2021 at 09:00:32AM +0100, Heiko Thiery wrote: > > HI Jakub, > > > > Am Di., 23. Feb. 2021 um 04:00 Uhr schrieb Jakub Kicinski : > > > Why is the PTP interface reg

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

HI Jakub, Am Di., 23. Feb. 2021 um 04:00 Uhr schrieb Jakub Kicinski : > > On Sat, 20 Feb 2021 07:56:55 +0100 Heiko Thiery wrote: > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > > This is only the case when the interface is down. This can be reprodu

[PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

d when the interface is down and leads to a system hang. So we check if the ptp clock status before reading the timecounter register. Signed-off-by: Heiko Thiery --- drivers/net/ethernet/freescale/fec_ptp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c

Re: [PATCH ethtool 01/21] netlink: fix build warnings

Tested-by: Heiko Thiery -- Heiko

Re: ethtool build failure

Hi Michal, Am Sa., 6. Juni 2020 um 15:47 Uhr schrieb Heiko Thiery : > > Hi Michal, > > Am Sa., 6. Juni 2020 um 15:43 Uhr schrieb Michal Kubecek : > > > > On Sat, Jun 06, 2020 at 03:24:22PM +0200, Heiko Thiery wrote: > > > Hi Michael et all, > > > > >

Re: ethtool build failure

Hi Michal, Am Sa., 6. Juni 2020 um 15:43 Uhr schrieb Michal Kubecek : > > On Sat, Jun 06, 2020 at 03:24:22PM +0200, Heiko Thiery wrote: > > Hi Michael et all, > > > > I'm digging in the reason for a failure when building ethtool with > > buildroot [1]

ethtool build failure

Hi Michael et all, I'm digging in the reason for a failure when building ethtool with buildroot [1]. I see the following error: --- data/buildroot/buildroot-test/instance-0/output/host/bin/i686-linux-gcc -DHAVE_CONFIG_H -I. -I./uapi -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=