Re: [PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-12 Thread Heath Caldwell
On 2021-01-12 21:26 (+0100), Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 8:25 PM Heath Caldwell wrote: > > > > On 2021-01-12 18:05 (+0100), Eric Dumazet wrote: > > > On Tue, Jan 12, 2021 at 5:02 PM Heath Caldwell > > > wrote: > > > > > > &

Re: [PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-12 Thread Heath Caldwell
On 2021-01-12 18:05 (+0100), Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 5:02 PM Heath Caldwell wrote: > > > > On 2021-01-12 09:30 (+0100), Eric Dumazet wrote: > > > I think the whole patch series is an attempt to badly break TCP stack. > > > > Can you exp

Re: [PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-12 Thread Heath Caldwell
On 2021-01-12 09:30 (+0100), Eric Dumazet wrote: > I think the whole patch series is an attempt to badly break TCP stack. Can you explain the concern that you have about how these changes might break the TCP stack? Patches 1 and 3 fix clear bugs. Patches 2 and 4 might be arguable, though. Is y

[PATCH net-next 3/4] tcp: consistently account for overhead in rcv_wscale calculation

2021-01-11 Thread Heath Caldwell
window space. This adjustment keeps the scale of the maximum value consistent - that is, keeps it in window space. Without this adjustment, the window scale used could be larger than necessary, reducing granularity for the advertised window. Signed-off-by: Heath Caldwell --- net/ipv4/tcp_output.c

[PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-11 Thread Heath Caldwell
; 0 .: 0.0000.0080.0160.0250.0330.0410.0490.057 Note that the sender was able to send the entire object in a single burst and that it was fully acknowledged after a little over 1 rtt. Signed-off-by: Heath Caldwell --- net/ipv4/tcp_output.c | 2 +- 1 file c

[PATCH net-next 1/4] net: account for overhead when restricting SO_RCVBUF

2021-01-11 Thread Heath Caldwell
domain of R to [0, sysctl_rmem_max/2], removing the possibility for V to be greater than sysctl_rmem_max. Also, abstract the actions of converting "buffer" space to and from "available" space and clarify comments. Signed-off-by: Hea

[PATCH net-next 2/4] net: tcp: consistently account for overhead for SO_RCVBUF for TCP

2021-01-11 Thread Heath Caldwell
When setting SO_RCVBUF for TCP sockets, account for overhead in accord with sysctl_tcp_adv_win_scale. This makes the receive buffer overhead accounting for SO_RCVBUF consistent with how it is accounted elsewhere for TCP sockets. Signed-off-by: Heath Caldwell --- include/net/tcp.h | 17

[PATCH net-next 0/4] Fix receive window restriction

2021-01-11 Thread Heath Caldwell
facilitate research and use cases which could benefit from more direct and consistent control over the receive buffer and TCP receive window. Heath Caldwell (4): net: account for overhead when restricting SO_RCVBUF net: tcp: consistently account for overhead for SO_RCVBUF for TCP tcp: consistently