Re: 2.6.24-rc3: find complains about /proc/net

2007-11-20 Thread Guillaume Chazarain
On 11/21/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > i guess it was a v2.6.24 change, hence a regression that needs to be > fixed? It seems to be http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commitdiff;h=01660410 So, linux 2.6.0-test6 -- Guillaume - To unsubscribe from this li

Re: [PATCH] proc: Fix the threaded /proc/self.

2007-11-20 Thread Guillaume Chazarain
Hello Eric, This fills a need I had to get the current TID in a Java program, so I'm very interested in this change. OTOH, how will someone not reading LKML discover that the current TID is now in /proc/self and that it was not always the case? I would put my 2 cents in /proc/self/task/self, this

Re: Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno_sacks()

2007-11-15 Thread Guillaume Chazarain
David Miller <[EMAIL PROTECTED]> wrote: > Chazarain please let us know if it does indeed cure your > problem. Unfortunately, I couldn't manage to reproduce the problem with an unpatched kernel. But your investigation Ilpo was really impressive. BTW, even though I messed up the yahoo webmail conf

Re: PROBLEM: oops, Linus tree: 2.6.23-g4fa4d23f, BUG: unable to handle kernel NULL pointer dereference at virtual address 00000004

2007-10-21 Thread Guillaume Chazarain
Le Sun, 21 Oct 2007 13:16:32 +0800, Coly Li <[EMAIL PROTECTED]> a écrit : > > This should be fixed in recent git by > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b013e05e0289c190a53d78ca029e2f21c0e4485 > > > Maybe we encounter same condition, at least the symbol

Re: PROBLEM: oops, Linus tree: 2.6.23-g4fa4d23f, BUG: unable to handle kernel NULL pointer dereference at virtual address 00000004

2007-10-20 Thread Guillaume Chazarain
> > BUG: unable to handle kernel NULL pointer dereference at virtual address > > 0004 This should be fixed in recent git by http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b013e05e0289c190a53d78ca029e2f21c0e4485 HTH. -- Guillaume - To unsubscribe from this list

Re: kernel BUG at net/core/dev.c:1383 skb_checksum_help: BUG_ON(offset > (int)skb->len)

2007-10-15 Thread Guillaume Chazarain
Le Mon, 15 Oct 2007 13:15:05 +0300 (EEST), "Ilpo Järvinen" <[EMAIL PROTECTED]> a écrit : > ...Never mind, noticed the fix later on. Yes, but here is it anyway, in case you see something fishy. (gdb) p *(struct tcp_sock *)skb->sk $4 = {inet_conn = {icsk_inet = {sk = {__sk_common = {skc_family =

Re: [NET]: Fix csum_start update in pskb_expand_head

2007-10-15 Thread Guillaume Chazarain
Le Mon, 15 Oct 2007 12:57:23 +0800, Herbert Xu <[EMAIL PROTECTED]> a écrit : > [NET]: Fix csum_start update in pskb_expand_head > [NET]: Avoid copying TCP packets unnecessarily I am Bittorrenting for a few hours with these patches, and they seem to work well. Thanks for the quick response. > eth

Re: kernel BUG at net/core/dev.c:1383 skb_checksum_help: BUG_ON(offset > (int)skb->len)

2007-10-14 Thread Guillaume Chazarain
Le Sun, 14 Oct 2007 19:26:40 +0200, Guillaume Chazarain <[EMAIL PROTECTED]> a écrit : > #0 0xc02c9d5e in skb_checksum_help (skb=0xe218dcb0) at net/core/dev.c:1372 > 1372BUG_ON(offset > (int)skb->len); Just another data point, it seems that running the standard

Re: Patch "[PKT_SCHED]: PSCHED_TADD() and PSCHED_TADD2() can result,tv_usec >= 1000000" seems wrong

2006-07-19 Thread Guillaume Chazarain
(__delta >= USEC_PER_SEC){ ... }" instead of "while (__delta > USEC_PER_SEC){ ... }"] Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]> --- pkt_sched.h | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) --- a/include/net/pkt_sched.h +++

Re: [PATCH] clear skb cb on IP input

2006-07-19 Thread Guillaume Chazarain
added safety seems worth, but for IPv6 it's less clear. Thanks. -- Guillaume Clear the accumulated junk in IP6CB when starting to handle an IPV6 packet. Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]> --- ip6_input.c |2 ++ 1 file changed, 2 insertions(+) --- a/net/ipv6/

Re: [PATCH] clear skb cb on IP input

2006-07-18 Thread Guillaume Chazarain
chas williams - CONTRACTOR wrote: why does the input side of the ip layer believe the cb contains valid data? it should zero the contents of the cb, or just fill in the cb correctly when the packet arrives at its doorstop. Why not clearing the whole IPCB(skb) instead of just IPCB(skb)->opts?

[PATCH] Fix slab corruption with netem (2nd try)

2006-07-16 Thread Guillaume Chazarain
is a patch to initialize cb later, and make it clear that initializing it sooner is a bad idea. [From Stephen Hemminger: leave cb unitialized in order to let gcc complain in case of use before initialization] Thanks. -- Guillaume Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]>

Re: [PATCH] Fix slab corruption with netem

2006-07-15 Thread Guillaume Chazarain
Stephen Hemminger wrote : -struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb; +/* We don't fill cb now as skb_unshare() may invalidate it */ +struct netem_skb_cb *cb = NULL; Would rather leave it unitialized, rather than setting to NULL. I find that strange. If someone mi

[PATCH] Fix slab corruption with netem

2006-07-14 Thread Guillaume Chazarain
|| q->reorder < get_crandom(&q->reorder_cor)) { -- Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]>

Re: Netem does not work with loopback

2006-07-14 Thread Guillaume Chazarain
Stephen Hemminger wrote: No, the correct fix is to make IP input not accept any options from the device. OK. Does this work? Yes it does. Thank you very much. -- Guillaume - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] M

Re: Netem does not work with loopback

2006-07-14 Thread Guillaume Chazarain
the private data accumulated in the sending part */ + memset(skb->cb, 0, sizeof(skb->cb)); + netif_rx(skb); return(0); -- Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]>

Netem does not work with loopback

2006-07-14 Thread Guillaume Chazarain
Hello, Is it a known problem that the Netem qdisc is very unreliable on the loopback (unlike on a true NIC)? This seems to come from its usage of skb->cb which conflicts with IPCB. For instance, the field IPCB(skb)->opt.optlen becomes non-null and memory corruption follows. I ``worked aroun

Patch "[PKT_SCHED]: PSCHED_TADD() and PSCHED_TADD2() can result,tv_usec >= 1000000" seems wrong

2006-07-14 Thread Guillaume Chazarain
usec += (delta); \ - if ((tv).tv_usec > USEC_PER_SEC) { (tv).tv_sec++; \ + while ((tv).tv_usec > USEC_PER_SEC) { (tv).tv_sec++; \ (tv).tv_usec -= USEC_PER_SEC; } \ }) -- Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]> diff -r 672dc37bf355 include/net/pkt_sched.h --- a