Christoph Hellwig wrote:
On Thu, May 03, 2007 at 09:33:43AM +0200, Gerd Hoffmann wrote:
Guess so. It defaults to flip. I simplified the rx_copy/flip module
parameter to a simple rx_mode=0/1, but this is preserved from the
original. My guess is that originally there was only flip, and copy
Jeremy Fitzhardinge wrote:
Gerd Hoffmann wrote:
Gerd, in change 11196:b85da7cd9ea5 "front: Fix rx buffer leak when
tearing down an interface." you added a call to
"add_id_to_freelist(np->rx_skbs, id);". However, rx_skbs doesn't have
an extra entry for the list
Hi,
Gerd, in change 11196:b85da7cd9ea5 "front: Fix rx buffer leak when
tearing down an interface." you added a call to
"add_id_to_freelist(np->rx_skbs, id);". However, rx_skbs doesn't have
an extra entry for the list head, and there's never any corresponding
get_id_from_freelist(np->rx_skbs).
Hi,
The bridging code copies 16 bytes unconditionally, where as the ethernet
header is 14 bytes only. In most cases it works ok nevertheless due to
NET_IP_ALIGN, sometimes it doesn't though. Fix is attached below.
please apply,
Gerd
--
Gerd Hoffmann <[EMAIL PROTECTE