Re: [EXT] Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-23 Thread Frederic Weisbecker
On Mon, Nov 23, 2020 at 10:39:34PM +, Alex Belits wrote: > > On Mon, 2020-11-23 at 23:29 +0100, Frederic Weisbecker wrote: > > External Email > > > > --- > > --- > > On Mon, Nov 23, 2020 at

Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-23 Thread Frederic Weisbecker
On Mon, Nov 23, 2020 at 05:58:42PM +, Alex Belits wrote: > From: Yuri Norov > > Make sure that kick_all_cpus_sync() does not call CPUs that are running > isolated tasks. > > Signed-off-by: Yuri Norov > [abel...@marvell.com: use safe task_isolation_cpumask() implementation] > Signed-off-by:

Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-11-23 Thread Frederic Weisbecker
Hi Alex, On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote: > From: Yuri Norov > > For nohz_full CPUs the desirable behavior is to receive interrupts > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > obviously not desirable because it breaks isolation. > > This p

Re: [PATCH v4 2/4] sched/isolation: Extend nohz_full to isolate managed IRQs

2020-10-23 Thread Frederic Weisbecker
gt; > requires isolation for maintaining lower latency for the listed CPUs. > > > > Suggested-by: Frederic Weisbecker Ah and yes there is this tag :-p So that's my bad, I really thought this thing was about managed IRQ. The problem is that I can't find a single documenta

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-19 Thread Frederic Weisbecker
On Mon, Oct 19, 2020 at 01:11:37PM +0200, Peter Zijlstra wrote: > > > And what are the (desired) semantics vs hotplug? Using a cpumask without > > > excluding hotplug is racy. > > > > The housekeeping_mask should still remain constant, isn't? > > In any case, I can double check this. > > The goal

Re: [EXT] Re: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-10-06 Thread Frederic Weisbecker
On Sun, Oct 04, 2020 at 03:22:09PM +, Alex Belits wrote: > > On Thu, 2020-10-01 at 16:44 +0200, Frederic Weisbecker wrote: > > > @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) > > > */ > > > void tick_nohz_full_kick_cpu(int cpu) > > &

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-06 Thread Frederic Weisbecker
On Mon, Oct 05, 2020 at 02:52:49PM -0400, Nitesh Narayan Lal wrote: > > On 10/4/20 7:14 PM, Frederic Weisbecker wrote: > > On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > >> On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote:

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-04 Thread Frederic Weisbecker
On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote: > > External Email > > > > --- > > --- > > On Wed, Jul 22, 2020 at 02

Re: [PATCH v4 0/4] isolation: limit msix vectors to housekeeping CPUs

2020-10-01 Thread Frederic Weisbecker
| 2 +- > 4 files changed, 30 insertions(+), 2 deletions(-) Acked-by: Frederic Weisbecker Peter, if you're ok with the set, I guess this should go through the scheduler tree? Thanks.

Re: [PATCH v4 11/13] task_isolation: net: don't flush backlog on CPUs running isolated tasks

2020-10-01 Thread Frederic Weisbecker
On Wed, Jul 22, 2020 at 02:58:24PM +, Alex Belits wrote: > From: Yuri Norov > > If CPU runs isolated task, there's no any backlog on it, and > so we don't need to flush it. What guarantees that we have no backlog on it? > Currently flush_all_backlogs() > enqueues corresponding work on all C

Re: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-10-01 Thread Frederic Weisbecker
On Wed, Jul 22, 2020 at 02:57:33PM +, Alex Belits wrote: > From: Yuri Norov > > For nohz_full CPUs the desirable behavior is to receive interrupts > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > obviously not desirable because it breaks isolation. > > This patch adds

Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-01 Thread Frederic Weisbecker
On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > +/** > + * task_isolation_kernel_enter() - clear low-level task isolation flag > + * > + * This should be called immediately after entering kernel. > + */ > +static inline void task_isolation_kernel_enter(void) > +{ > + unsigned lon

Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-01 Thread Frederic Weisbecker
On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > +/* > + * Description of the last two tasks that ran isolated on a given CPU. > + * This is intended only for messages about isolation breaking. We > + * don't want any references to actual task while accessing this from > + * CPU that

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Frederic Weisbecker
On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: > Introduce a new API hk_num_online_cpus(), that can be used to > retrieve the number of online housekeeping CPUs that are meant to handle > managed IRQ jobs. > > This API is introduced for the drivers that were previously relying

Re: [PATCH v2 1/4] sched/isolation: API to get housekeeping online CPUs

2020-09-24 Thread Frederic Weisbecker
On Thu, Sep 24, 2020 at 10:40:29AM +0200, pet...@infradead.org wrote: > On Wed, Sep 23, 2020 at 02:11:23PM -0400, Nitesh Narayan Lal wrote: > > Introduce a new API hk_num_online_cpus(), that can be used to > > retrieve the number of online housekeeping CPUs that are meant to handle > > managed IRQ

Re: [RFC][Patch v1 3/3] PCI: Limit pci_alloc_irq_vectors as per housekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Tue, Sep 22, 2020 at 09:54:58AM -0400, Nitesh Narayan Lal wrote: > >> If min_vecs > num_housekeeping, for example: > >> > >> /* PCI MSI/MSIx support */ > >> #define XGBE_MSI_BASE_COUNT 4 > >> #define XGBE_MSI_MIN_COUNT (XGBE_MSI_BASE_COUNT + 1) > >> > >> Then the protection fails. > > R

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Tue, Sep 22, 2020 at 09:50:55AM -0400, Nitesh Narayan Lal wrote: > On 9/22/20 6:08 AM, Frederic Weisbecker wrote: > TBH I don't have a very strong case here at the moment. > But still, IMHO, this will force the user to have both managed irqs and > nohz_full in their environmen

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Tue, Sep 22, 2020 at 09:34:02AM -0400, Nitesh Narayan Lal wrote: > On 9/22/20 5:54 AM, Frederic Weisbecker wrote: > > But I don't also want to push toward a complicated solution to handle CPU > > hotplug > > if there is no actual problem to solve there. > >

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Mon, Sep 21, 2020 at 11:16:51PM -0400, Nitesh Narayan Lal wrote: > > On 9/21/20 7:40 PM, Frederic Weisbecker wrote: > > On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote: > >> +/* > >> + * num_housekeeping_cpus() - Read the number of housekeepin

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-22 Thread Frederic Weisbecker
On Mon, Sep 21, 2020 at 11:08:20PM -0400, Nitesh Narayan Lal wrote: > > On 9/21/20 6:58 PM, Frederic Weisbecker wrote: > > On Thu, Sep 17, 2020 at 11:23:59AM -0700, Jesse Brandeburg wrote: > >> Nitesh Narayan Lal wrote: > >> > >>> In a realtime enviro

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-21 Thread Frederic Weisbecker
On Wed, Sep 09, 2020 at 11:08:16AM -0400, Nitesh Narayan Lal wrote: > +/* > + * num_housekeeping_cpus() - Read the number of housekeeping CPUs. > + * > + * This function returns the number of available housekeeping CPUs > + * based on __num_housekeeping_cpus which is of type atomic_t > + * and is i

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-21 Thread Frederic Weisbecker
On Thu, Sep 17, 2020 at 11:23:59AM -0700, Jesse Brandeburg wrote: > Nitesh Narayan Lal wrote: > > > In a realtime environment, it is essential to isolate unwanted IRQs from > > isolated CPUs to prevent latency overheads. Creating MSIX vectors only > > based on the online CPUs could lead to a poten

Re: Heads-up: two regressions in v4.11-rc series

2017-04-21 Thread Frederic Weisbecker
On Fri, Apr 21, 2017 at 10:52:29AM -0700, Linus Torvalds wrote: > On Thu, Apr 20, 2017 at 7:30 AM, Mel Gorman > wrote: > >> The end result was a revert, and this is waiting in AKPMs quilt queue: > >> > >> http://ozlabs.org/~akpm/mmots/broken-out/revert-mm-page_alloc-only-use-per-cpu-allocator-f

Re: Heads-up: two regressions in v4.11-rc series

2017-04-20 Thread Frederic Weisbecker
On Thu, Apr 20, 2017 at 11:00:42AM +0200, Jesper Dangaard Brouer wrote: > Hi Linus, > > Just wanted to give a heads-up on two regressions in 4.11-rc series. > > (1) page allocator optimization revert > > Mel Gorman and I have been playing with optimizing the page allocator, > but Tariq spotted t

Re: Bisected softirq accounting issue in v4.11-rc1~170^2~28

2017-03-29 Thread Frederic Weisbecker
On Wed, Mar 29, 2017 at 11:30:30AM +0200, Jesper Dangaard Brouer wrote: > On Tue, 28 Mar 2017 23:11:22 +0200 > Frederic Weisbecker wrote: > > > On Tue, Mar 28, 2017 at 05:23:03PM +0200, Jesper Dangaard Brouer wrote: > > > On Tue, 28 Mar 2017 16:34:36 +0200 > >

Re: Bisected softirq accounting issue in v4.11-rc1~170^2~28

2017-03-28 Thread Frederic Weisbecker
On Tue, Mar 28, 2017 at 05:23:03PM +0200, Jesper Dangaard Brouer wrote: > On Tue, 28 Mar 2017 16:34:36 +0200 > Frederic Weisbecker wrote: > > > On Tue, Mar 28, 2017 at 10:14:03AM +0200, Jesper Dangaard Brouer wrote: > > > > > > (While evaluating some changes to

Re: Bisected softirq accounting issue in v4.11-rc1~170^2~28

2017-03-28 Thread Frederic Weisbecker
nt kcpustat directly on irqtime > account") > > a499a5a14dbd1d0315a96fc62a8798059325e9e6 is the first bad commit > commit a499a5a14dbd1d0315a96fc62a8798059325e9e6 > Author: Frederic Weisbecker > Date: Tue Jan 31 04:09:32 2017 +0100 > > sched/cpu

Re: Bisected softirq accounting issue in v4.11-rc1~170^2~28

2017-03-28 Thread Frederic Weisbecker
On Tue, Mar 28, 2017 at 02:26:42PM +0200, Peter Zijlstra wrote: > On Tue, Mar 28, 2017 at 06:34:52PM +0800, Wanpeng Li wrote: > > > > sched_clock_cpu(cpu) should be converted from cputime to ns. > > Uhm, no. sched_clock_cpu() returns u64 in ns. Yes, and most of the cputime_t have been converted

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-20 Thread Frederic Weisbecker
On Mon, Jul 20, 2015 at 05:22:12PM -0400, Chris Metcalf wrote: > On 07/11/2015 10:30 AM, Frederic Weisbecker wrote: > >On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: > >>The tilegx chips typically don't do cpu offlining anyway, since > >>we

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-11 Thread Frederic Weisbecker
On Fri, Jul 10, 2015 at 03:37:25PM -0400, Chris Metcalf wrote: > Normally the tilegx networking shim sends irqs to all the cores > to distribute the load of processing incoming-packet interrupts, > so that you can get to multiple Gb's of traffic inbound. > > However, in nohz_full mode we don't wan

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-11 Thread Frederic Weisbecker
On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: > On 07/10/2015 02:24 PM, Frederic Weisbecker wrote: > >Indeed we are doing more and more references on housekeeping_mask, so > >we should probably think about an off-case. > > > >Now the nohz-ful

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Frederic Weisbecker
On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote: > In nohz_full mode, by default distribute networking shim > interrupts across the housekeeping cores, not all the cores. I can't really tell, I have no idea what this driver does. It seems to be about networking CPUs but I have no ide