Re: [PATCH net v2 1/1] net/udp_gso: Allow TX timestamp with UDP GSO

2019-06-13 Thread Fred Klassen
>> It also appears that other TX CMSG types cause similar issues, for >> example trying to set SOL_IP/IP_TOS. > > If correct we need to find the root cause. Without that, this is not > very informative. And likely the fix is not related, as that does not > involve tx_flags or tskey. > > What exac

Re: [PATCH net-next v3 1/1] net/udp_gso: Allow TX timestamp with UDP GSO

2019-05-30 Thread Fred Klassen
> On May 28, 2019, at 2:44 PM, Willem de Bruijn > wrote: >> It also appears that other TX CMSG types cause similar issues, for >> example trying to set SOL_IP/IP_TOS. > > See previous comment in v2 > > http://patchwork.ozlabs.org/patch/1105564/ > Sorry, missed those updates. I am still rel

Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue

2019-05-27 Thread Fred Klassen
> On May 27, 2019, at 6:15 PM, Willem de Bruijn > wrote: >> I wanted to discuss whether or not to attach a buffer to the >> recvmsg(fd, &msg, MSG_ERRQUEUE). Without it, I have >> MSG_TRUNC errors in my msg_flags. Either I have to add >> a buffer, or ignore that error flag. > > Either sounds r