Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-08 Thread Eugene Syromiatnikov
On Mon, Jan 07, 2019 at 09:19:23PM -0800, Richard Cochran wrote: > On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote: > > From: Eugene Syromiatnikov > > Date: Mon, 7 Jan 2019 16:22:29 +0100 > > > > > Otherwise it is impossible to use it for so

[PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-07 Thread Eugene Syromiatnikov
Otherwise it is impossible to use it for something else, as it will break userspace that puts garbage there. The same check should be done in other structures, but the fact that data in reserved fields is ignored is already part of the kernel ABI. Signed-off-by: Eugene Syromiatnikov

[PATCH net 2/2] ptp: uapi: change _IOW to IOWR in PTP_SYS_OFFSET_EXTENDED definition

2019-01-07 Thread Eugene Syromiatnikov
The ioctl command is read/write (or just read, if the fact that user space writes n_samples field is ignored). Signed-off-by: Eugene Syromiatnikov --- include/uapi/linux/ptp_clock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi

Re: [net-next,v2,2/4] net/smc: ipv6 support for smc_diag.c

2018-10-12 Thread Eugene Syromiatnikov
On Tue, Oct 09, 2018 at 04:41:43PM +0200, Ursula Braun wrote: > Eugene, > > we are considering the following patch: > > --- > net/smc/smc_diag.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/smc/smc_diag.c b/net/smc/smc_diag.c > index dbf64a93d68a..371b4cf31fcd

Re: [net-next,v2,2/4] net/smc: ipv6 support for smc_diag.c

2018-10-06 Thread Eugene Syromiatnikov
On Wed, May 02, 2018 at 04:56:45PM +0200, Ursula Braun wrote: > From: Karsten Graul > > Update smc_diag.c to support ipv6 addresses on the diagnosis interface. > > Signed-off-by: Karsten Graul > Signed-off-by: Ursula Braun > --- > net/smc/smc_diag.c | 39 ++

[PATCH bpf 0/2] Use __aligned_u64 in UAPI fields

2018-05-27 Thread Eugene Syromiatnikov
nsistently throughout the UAPI header. Eugene Syromiatnikov (2): bpf: fix alignment of netns_dev/netns_ino fields in bpf_{map,prog}_info bpf: enforce usage of __aligned_u64 in the UAPI header include/uapi/linux/bpf.h | 30 +++--- tools/include/uapi/linux/

[PATCH bpf 2/2] bpf: enforce usage of __aligned_u64 in the UAPI header

2018-05-27 Thread Eugene Syromiatnikov
d were added to struct bpf_sock_ops in commit v4.16-rc1~123^2~33^2~5^2~4, struct bpf_perf_event_value was added in commit v4.15-rc1~84^2~532^2~3). Signed-off-by: Eugene Syromiatnikov --- include/uapi/linux/bpf.h | 22 +++--- tools/include/uapi/linux/bpf.h | 22 +++-

[PATCH bpf 1/2] bpf: fix alignment of netns_dev/netns_ino fields in bpf_{map,prog}_info

2018-05-27 Thread Eugene Syromiatnikov
for these fields. Reported-by: Dmitry V. Levin Fixes: 52775b33bb507 ("bpf: offload: report device information about offloaded maps") Fixes: 675fc275a3a2d ("bpf: offload: report device information for offloaded programs") Signed-off-by: Eugene Syromiatnikov --- include/uapi/l

Re: [PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-25 Thread Eugene Syromiatnikov
On Thu, May 24, 2018 at 04:34:51PM -0700, Alexei Starovoitov wrote: > On Thu, May 24, 2018 at 09:41:08AM +0200, Jesper Dangaard Brouer wrote: > > On Wed, 23 May 2018 15:02:45 -0700 > > Alexei Starovoitov wrote: > > > > > On Wed, May 23, 2018 at 02:18:19PM +02

[PATCH bpf-next v2 1/3] bpf: add ability to configure unprivileged BPF via boot-time parameter

2018-05-23 Thread Eugene Syromiatnikov
is desirable. Signed-off-by: Eugene Syromiatnikov --- Documentation/admin-guide/kernel-parameters.txt | 8 +++ init/Kconfig| 31 + kernel/bpf/syscall.c| 16 + 3 files changed, 55 insertions

[PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-23 Thread Eugene Syromiatnikov
, and net.core.bpf_jit_kallsyms. Eugene Syromiatnikov (3): bpf: add ability to configure unprivileged BPF via boot-time parameter bpf: add ability to configure BPF JIT hardening via boot-time parameter bpf: add ability to configure BPF JIT kallsyms export at the boot time Documentation

[PATCH bpf-next v2 2/3] bpf: add ability to configure BPF JIT hardening via boot-time parameter

2018-05-23 Thread Eugene Syromiatnikov
This patch introduces two configuration options, BPF_JIT_HARDEN_BOOTPARAM and BPF_JIT_HARDEN_BOOTPARAM_VALUE, that allow configuring the initial value of net.core.bpf_jit_harden sysctl knob, which is useful for enforcing JIT hardening during the early boot. Signed-off-by: Eugene Syromiatnikov

[PATCH bpf-next v2 3/3] bpf: add ability to configure BPF JIT kallsyms export at the boot time

2018-05-23 Thread Eugene Syromiatnikov
igned-off-by: Eugene Syromiatnikov --- Documentation/admin-guide/kernel-parameters.txt | 10 + init/Kconfig| 30 + kernel/bpf/core.c | 14 3 files changed, 54 insertions(+) diff --

Re: [PATCH 0/3] bpf: add boot parameters for sysctl knobs

2018-05-23 Thread Eugene Syromiatnikov
On Mon, May 21, 2018 at 11:58:13AM -0700, Alexei Starovoitov wrote: > On Mon, May 21, 2018 at 02:29:30PM +0200, Eugene Syromiatnikov wrote: > > Hello. > > > > This patch set adds ability to set default values for > > kernel.unprivileged_bpf_disab

[PATCH 3/3] bpf: add ability to configure BPF JIT kallsyms export at the boot time

2018-05-21 Thread Eugene Syromiatnikov
igned-off-by: Eugene Syromiatnikov --- Documentation/admin-guide/kernel-parameters.txt | 10 + init/Kconfig| 30 + kernel/bpf/core.c | 14 3 files changed, 54 insertions(+) diff --

[PATCH 2/3] bpf: add ability to configure BPF JIT hardening via boot-time parameter

2018-05-21 Thread Eugene Syromiatnikov
This patch introduces two configuration options, BPF_JIT_HARDEN_BOOTPARAM and BPF_JIT_HARDEN_BOOTPARAM_VALUE, that allow configuring the initial value of net.core.bpf_jit_harden sysctl knob, which is useful for enforcing JIT hardening during the early boot. Signed-off-by: Eugene Syromiatnikov

[PATCH 1/3] bpf: add ability to configure unprivileged BPF via boot-time parameter

2018-05-21 Thread Eugene Syromiatnikov
is desirable. Signed-off-by: Eugene Syromiatnikov --- Documentation/admin-guide/kernel-parameters.txt | 8 +++ init/Kconfig| 31 + kernel/bpf/syscall.c| 16 + 3 files changed, 55 insertions

[PATCH 0/3] bpf: add boot parameters for sysctl knobs

2018-05-21 Thread Eugene Syromiatnikov
Hello. This patch set adds ability to set default values for kernel.unprivileged_bpf_disable, net.core.bpf_jit_harden, net.core.bpf_jit_kallsyms sysctl knobs as well as option to override them via a boot-time kernel parameter. Eugene Syromiatnikov (3): bpf: add ability to configure