On Mon, Dec 7, 2020 at 10:14 PM Jakub Kicinski wrote:
>
> On Mon, 7 Dec 2020 11:35:53 -0800 Brian Norris wrote:
> > On Mon, Dec 7, 2020 at 2:42 AM Kalle Valo wrote:
> > > Jakub Kicinski writes:
> > > > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote:
> > > > There's also a patch which
>
> On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach
> wrote:
> > So I believe we already have this uevent, it is the devcoredump. All
> > we need is to add the unique id.
>
> I think there are a few reasons that devcoredump doesn't satisfy what
> eith
Hi all,
Since I have been involved quite a bit in the firmware debugging
features in iwlwifi, I think I can give a few insights here.
But before this, we need to understand that there are several sources of issues:
1) the firmware may crash but the bus is still alive, you can still
use the bus
Hello,
> > > >
> > > > our hardware teams from the Bluetooth and WiFi side really need to look
> > > > at this.
> >
> > Were you able to get attention from the hardware teams with the logs
> > I've provided? Are there any news or an idea of when / if we can
> > expect this to be fixed in firmware
On Mon, Jun 12, 2017 at 12:30 AM, Emil Lenngren wrote:
> 2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach :
>> On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote:
>>>
>>> On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
>>> > "Jason A. Donenfeld" w
On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote:
>
> On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote:
> > "Jason A. Donenfeld" writes:
> >
> >> Whenever you're comparing two MACs, it's important to do this using
> >> crypto_memneq instead of memcmp. With memcmp, you leak timing information,
>
are check to iwl_mvm_thermal_zone_register() and
> stops the thermal zone from being created if the ucode hasn't been loaded.
>
> Signed-off-by: Prarit Bhargava
> Cc: Johannes Berg
> Cc: Emmanuel Grumbach
> Cc: Luca Coelho
> Cc: Intel Linux Wireless
> Cc: Kalle Va
On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds
wrote:
> On Tue, May 17, 2016 at 12:11 PM, David Miller wrote:
>>
>> Highlights:
>
> Lowlights:
>
> 1) the iwlwifi driver seems to be broken
>
> My laptop that uses the intel 7680 iwlwifi module no longer connects
> to the network. It fails with a
On Tue, Apr 19, 2016 at 1:09 PM, Johannes Berg
wrote:
> On Mon, 2016-04-18 at 23:52 -0400, David Miller wrote:
>> From: David Miller
>> Date: Mon, 18 Apr 2016 21:48:51 -0400 (EDT)
>>
>> > I think the time has probably come to have a new netlink attribute
>> > format that doesn't have this multi-d
On Wed, Mar 30, 2016 at 3:58 PM, Eyal Reizer wrote:
>
> From: Eyal
Are you trying to hide or something? :)
>
> Add support for using with both wl12xx and wl18xx.
>
> - all wilink family needs special init command for entering wspi mode.
> extra clock cycles should be sent after the spi init c
On Mon, Feb 22, 2016 at 9:53 PM, David Miller wrote:
> From: Emmanuel Grumbach
> Date: Mon, 22 Feb 2016 13:49:47 +0200
>
>> This will allow to pass the typecheck in the comparators:
>> codel_time_{after,before}
>>
>> Signed-off-by: Emmanuel Grumbach
>
> I
This will allow to pass the typecheck in the comparators:
codel_time_{after,before}
Signed-off-by: Emmanuel Grumbach
---
include/net/codel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/codel.h b/include/net/codel.h
index 267e702..0d92e39 100644
--- a/include
Signed-off-by: Emmanuel Grumbach
---
include/net/codel.h | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/include/net/codel.h b/include/net/codel.h
index 267e702..0775c24 100644
--- a/include/net/codel.h
+++ b/include/net/codel.h
On Mon, Feb 8, 2016 at 12:00 PM, Michal Kazior wrote:
> On 5 February 2016 at 17:47, Dave Taht wrote:
>>> A bursted txop can be as big as 5-10ms. If you consider you want to
>>> queue 5-10ms worth of data for *each* station at any given time you
>>> obviously introduce a lot of lag. If you have 1
On Fri, Feb 5, 2016 at 10:44 AM, Michal Kazior wrote:
> On 4 February 2016 at 22:14, Ben Greear wrote:
>> On 02/04/2016 12:56 PM, Grumbach, Emmanuel wrote:
>>> On 02/04/2016 10:46 PM, Ben Greear wrote:
>>>> On 02/04/2016 12:16 PM, Emmanuel Grumbach wrote:
>>&
s,
but it seems that the wireless problems mentioned in
https://lwn.net/Articles/616241/ may have a solution.
Cc: Stephen Hemminger
Cc: Dave Taht
Cc: Jonathan Corbet
Signed-off-by: Emmanuel Grumbach
---
Fix Dave's email address
---
drivers/net/wireless/intel/iwlwifi/pcie/internal.h |
s,
but it seems that the wireless problems mentioned in
https://lwn.net/Articles/616241/ may have a solution.
Cc: Stephen Hemminger
Cc: Dave Taht
Cc: Jonathan Corbet
Signed-off-by: Emmanuel Grumbach
---
Fix Dave's email address
---
drivers/net/wireless/intel/iwlwifi/pcie/internal.h |
s,
but it seems that the wireless problems mentioned in
https://lwn.net/Articles/616241/ may have a solution.
Cc: Stephen Hemminger
Cc: Dave Taht
Cc: Jonathan Corbet
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 6
drivers/net/wireless/intel/iw
Hi Kalle,
On Wed, Nov 18, 2015 at 4:45 PM, Kalle Valo wrote:
>
> Part of reorganising wireless drivers directory and Kconfig.
>
I am sorry but I'd prefer to wait with this. We have a big machinery
of scripts / builds and alike that will break. I did give a heads up a
while ago to the people in c
sume here that the
> packet is not WEP / TKIP and has a proper SNAP header.
>
> Signed-off-by: Emmanuel Grumbach
Assuming your review queue works as a FIFO and you reviewed the TSO
helper patch, I can assume you ACK this one? :)
Or at least, don't NACK it :)
--
To unsubscribe from
Adding IPv6 for the TSO helper API is trivial:
* Don't play with the id (which doesn't exist in IPv6)
* Correctly update the payload_len (don't include the
length of the IP header itself)
Signed-off-by: Emmanuel Grumbach
---
v3: use vlan_get_protocol and call it once in tso_star
Adding IPv6 for the TSO helper API is trivial:
* Don't play with the id (which doesn't exist in IPv6)
* Correctly update the payload_len (don't include the
length of the IP header itself)
Signed-off-by: Emmanuel Grumbach
---
v2: add else if
NOTE: instead of checking the skb-&
Adding IPv6 for the TSO helper API is trivial:
* Don't play with the id (which doesn't exist in IPv6)
* Correctly update the payload_len (don't include the
length of the IP header itself)
Signed-off-by: Emmanuel Grumbach
---
net/core/tso.c | 17 -
1 file changed
account) to make sure that the skb that is passed
down to the transport are not longer than the maximal
A-MSDU allowed.
Signed-off-by: Emmanuel Grumbach
---
No change since RFCv4
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 143 --
1 file changed, 135 insertions(+), 8
when
it is reclaimed. When the page gets full, it is released
and a new one is allocated.
Since any SKB that doesn't go through the fast-xmit path
of mac80211 will be segmented, we can assume here that the
packet is not WEP / TKIP and has a proper SNAP header.
Signed-off-by: Emmanue
account) to make sure that the skb that is passed
down to the transport are not longer than the maximal
A-MSDU allowed.
Signed-off-by: Emmanuel Grumbach
---
v4: Don't use the original skb after it has been consumed
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 143
when
it is reclaimed. When the page gets full, it is released
and a new one is allocated.
Since any SKB that doesn't go through the fast-xmit path
of mac80211 will be segmented, we can assume here that the
packet is not WEP / TKIP and has a proper SNAP header.
Signed-off-by: Emmanuel Grumba
hope) we are getting close :)
Emmanuel Grumbach (2):
iwlwifi: pcie: allow to build an A-MSDU using TSO core
iwlwifi: mvm: send large SKBs to the transport
drivers/net/wireless/iwlwifi/iwl-devtrace-data.h | 16 ++
drivers/net/wireless/iwlwifi/iwl-trans.h | 6 +-
drivers/net/wirel
account) to make sure that the skb that is passed
down to the transport are not longer than the maximal
A-MSDU allowed.
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 143 --
1 file changed, 135 insertions(+), 8 deletions(-)
diff --git a
when
it is reclaimed. When the page gets full, it is released
and a new one is allocated.
Since any SKB that doesn't go through the fast-xmit path
of mac80211 will be segmented, we can assume here that the
packet is not WEP / TKIP and has a proper SNAP header.
Signed-off-by: Emmanue
.
type=feature
Change-Id: I238ffa79cacc5bbdacdfbf3e9673c8d4f02b462a
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 513 +++---
1 file changed, 481 insertions(+), 32 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c
b/drivers/net
: I5ea1b1132a57542187cd4c34c5299dbf44fe8b01
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 3 +-
drivers/net/wireless/iwlwifi/mvm/sta.c | 4 +-
drivers/net/wireless/iwlwifi/mvm/sta.h | 6 +-
drivers/net/wireless/iwlwifi/mvm/tx.c | 159
v2:
*
+ I fixed the whitespace problem spotted by Sergei.
+ I changed the D'tor check for truesize accounting.
Since the D'tor seems to be set to tcp_wfree if it
exists, I just the D'tor not being NULL.
Emmanuel Grumbach (3):
iwlwifi: mvm: add real
: I3c894cf2afc0aedfe7b2a5b992ba41653ff79c0e
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c
b/drivers/net/wireless/iwlwifi/mvm/tx.c
index 5046833..2aeb5fd 100644
--- a
: I3c894cf2afc0aedfe7b2a5b992ba41653ff79c0e
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c
b/drivers/net/wireless/iwlwifi/mvm/tx.c
index 5046833..046e50d 100644
--- a
: I5ea1b1132a57542187cd4c34c5299dbf44fe8b01
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/mac80211.c | 3 +-
drivers/net/wireless/iwlwifi/mvm/sta.c | 4 +-
drivers/net/wireless/iwlwifi/mvm/sta.h | 6 +-
drivers/net/wireless/iwlwifi/mvm/tx.c | 159
.
type=feature
Change-Id: I238ffa79cacc5bbdacdfbf3e9673c8d4f02b462a
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/iwlwifi/mvm/tx.c | 513 +++---
1 file changed, 481 insertions(+), 32 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c
b/drivers/net
e different
layouts of the skb (payload partition amongst the header
and the different frags).
I'll be very happy to get comments on that code, this is
why I am sending it to netdev as well since the TSO experts
are there :)
Emmanuel Grumbach (3):
iwlwifi: mvm: add real TSO implementation
iw
On Tue, Aug 4, 2015 at 2:48 PM, Emmanuel Grumbach wrote:
> On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko
> wrote:
>> On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote:
>>> There is no need to use hex_dump_to_buffer() in the cases like this:
>>>
>>&g
On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko
wrote:
> On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote:
>> There is no need to use hex_dump_to_buffer() in the cases like this:
>>
>> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); > /*
>> len <= 16
>> */
>> s
On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui
wrote:
> Enable wiphy device to suspend/resume asynchronously. This can improve
> system suspend/resume speed.
>
How will that impact the timing with respect to the suspend call
coming from the bus?
I think that a few drivers rely on the suspend call
On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko
wrote:
> On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov
> wrote:
>>> +#define IWL_READ_WRITE(static_inline) \
>>> +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \
>>> +{ \
>>> + trace_iwlwifi_dev_iowrite8(trans->dev
The subject is wrong. You are not patch mac80211, but bcrmsmac.
On Wed, Jul 8, 2015 at 10:32 PM, Christophe JAILLET
wrote:
> Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve
> readability.
>
> Signed-off-by: Christophe JAILLET
> ---
> drivers/net/wireless/brcm80211/brcmsmac
43 matches
Mail list logo
