RE: [PATCH net-next v2 1/6] qed: Add doorbell overflow recovery mechanism

2018-10-22 Thread Elior, Ariel
> > > +#ifndef writeq > > +#define writeq writeq > > +static inline void writeq(u64 val, void __iomem *reg) > > +{ > > + writel(val & 0x, reg); > > + writel(val >> 32, reg + 0x4UL); > > +} > > +#endif > > Please use the appropriate generic header file to achieve this, do not > reim

RE: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb()

2018-03-29 Thread Elior, Ariel
> Subject: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb() > > barrier() doesn't guarantee memory writes to be observed by the hardware on > all architectures. barrier() only tells compiler not to move this code > with respect to other read/writes. > > If memory write needs to be obse

RE: [PATCH net 1/1] qede: Fix barrier usage after tx doorbell write.

2018-03-21 Thread Elior, Ariel
> Subject: [PATCH net 1/1] qede: Fix barrier usage after tx doorbell write. > > Since commit c5ad119fb6c09b0297446be05bd66602fa564758 > ("net: sched: pfifo_fast use skb_array") driver is exposed > to an issue where it is hitting NULL skbs while handling TX > completions. Driver uses mmiowb() to fl

RE: mmiowb() vs wmb() with write combined MMIO

2018-03-13 Thread Elior, Ariel
> has uncovered an issue in qede NIC driver [/drivers/net/ethernet/qlogic/qede] > and > this driver is seriously broken for basic L2. That's a bit extreme. There is a race condition bug that needs fixing. > Before the series from John, driver was running fine, probably with hiding a > serious >

RE: [PATCH v4 net-next 0/4] qed*: Advance to FW 8.33.1.0

2018-01-02 Thread Elior, Ariel
> From: Tomer Tayar > Date: Wed, 27 Dec 2017 19:30:04 +0200 > > > This series advances all qed* drivers to use firmware 8.33.1.0 which brings > > new capabilities and initial support of new HW. The changes are mostly in > > qed, and include changes in the FW interface files, as well as updating t

RE: [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW

2017-12-04 Thread Elior, Ariel
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Michael Chan > Sent: Monday, December 04, 2017 1:13 PM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org > Subject: [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW > > Introduc

RE: [PATCH] qed: use kzalloc instead of kmalloc and memset

2017-11-15 Thread Elior, Ariel
> Subject: [PATCH] qed: use kzalloc instead of kmalloc and memset > > From: Colin Ian King > > Replace kmalloc followed by a memset with kzalloc > > Signed-off-by: Colin Ian King Acked-by: Ariel Elior Thanks Colin, Ariel

RE: qed*: debug infrastructures

2017-04-26 Thread Elior, Ariel
Jiri, Florian, Jakub, Thanks all for you suggestions. Some answers to questions posted: The signal tracing in our device can be used for tracing things like load/store/program_counter from our fastpath processors (which handle every packet) which can then be re-run in a simulative environment (re

qed*: debug infrastructures

2017-04-24 Thread Elior, Ariel
Hi Dave, According to the recent messages on the list indicating debugfs is not the way to go, I am looking for some guidance on what is. dpipe approach was mentioned as favorable, but I wanted to make sure molding our debug features to this infrastructure will result in something acceptable. A fe

RE: [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC

2016-09-20 Thread Elior, Ariel
> On Tue, Sep 20, 2016 at 01:35:52PM +0300, Ram Amrani wrote: ... > > The series adds on top of RFC v1: > > * a check for all drivers that IB_ACCESS_MW_BIND isn't set for ib_get_dma_mr > > * relocation of qedr user API to include/rdma/uapi/providers/ > > * removal of qedr_devlist_local > > * fixed

RE: [RFC 02/11] Add RoCE driver framework

2016-09-20 Thread Elior, Ariel
> From: Leon Romanovsky [mailto:l...@kernel.org] > On Thu, Sep 15, 2016 at 05:11:03AM +, Mintz, Yuval wrote: > > > As a summary, I didn't see in your responses any real life example where > > > you will > > > need global debug level for your driver. > > > > Not sure what you you're expecting -