RE: [Aspeed, ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue

2020-12-21 Thread Dylan Hung
Hi Hongwei, The NCSI should run on 3.3V RMII. According your log, you enabled NCSI on ftgmac100@1e66 which can only support 1.8V I/O voltage. Did you observe the same error on ftgmac100@1e67 (MAC3) or ftgmac100@1e69 (MAC4)? -- Dylan > -Original Message- > From: Linux-aspee

RE: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-23 Thread Dylan Hung
> -Original Message- > From: Andrew Jeffery [mailto:and...@aj.id.au] > Sent: Wednesday, October 21, 2020 6:26 AM > To: Benjamin Herrenschmidt ; Arnd Bergmann > ; Dylan Hung > Cc: BMC-SW ; linux-aspeed > ; Po-Yu Chuang ; > netdev ; OpenBMC Maillist > ; Linux Ke

RE: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-19 Thread Dylan Hung
> -Original Message- > From: Jakub Kicinski [mailto:k...@kernel.org] > Sent: Tuesday, October 20, 2020 3:01 AM > To: Joel Stanley > Cc: Dylan Hung ; Benjamin Herrenschmidt > ; David S . Miller ; > netdev@vger.kernel.org; Linux Kernel Mailing List > ; Po-Yu

RE: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-19 Thread Dylan Hung
Hi Joel, > -Original Message- > From: Joel Stanley [mailto:j...@jms.id.au] > Sent: Monday, October 19, 2020 4:57 PM > To: Dylan Hung ; Benjamin Herrenschmidt > > Cc: David S . Miller ; Jakub Kicinski > ; netdev@vger.kernel.org; Linux Kernel Mailing List > ; Po-Yu

[PATCH 4/4] ftgmac100: Restart MAC HW once

2020-10-19 Thread Dylan Hung
The interrupt handler may set the flag to reset the mac in the future, but that flag is not cleared once the reset has occured. Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling") Signed-off-by: Dylan Hung Signed-off-by: Joel Stanley --- drivers/net/ethernet/far

[PATCH 3/4] ftgmac100: Add a dummy read to ensure running sequence

2020-10-19 Thread Dylan Hung
On the AST2600 care must be taken to ensure writes appear correctly when modifying the interrupt reglated registers. Add a function to perform a read after all writes to the IER and ISR registers. Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property") Signed-off

[PATCH 0/4] fix ftgmac100 issues on aspeed soc

2020-10-19 Thread Dylan Hung
This patch series fixes the ftgmac100 mac hw issues on aspeed soc. Fixes: 52c0cae ("ftgmac100: Remove tx descriptor accessors") Fixes: 39bfab8 ("net: ftgmac100: Add support for DT phy-handle property") Fixes: 10cbd64 ("ftgmac100: Rework NAPI & interrupts handling&qu

[PATCH 1/4] ftgmac100: Fix race issue on TX descriptor[0]

2020-10-19 Thread Dylan Hung
c0cae87465 ("ftgmac100: Remove tx descriptor accessors") Signed-off-by: Dylan Hung Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/etherne

[PATCH 2/4] ftgmac100: Fix missing-poll issue

2020-10-19 Thread Dylan Hung
the tx-poll command may advance the tx descriptor due the HW design. By adding a pseudo read and proper memory barrier, we can ensure all the data are ready before TX poll command. Fixes: 52c0cae87465 ("ftgmac100: Remove tx descriptor accessors") Signed-off-by: Dylan Hung Signed-of

[PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-19 Thread Dylan Hung
after the last data write, we can ensure the data are pushed to the memory, then guarantee the processing sequence Signed-off-by: Dylan Hung --- drivers/net/ethernet/faraday/ftgmac100.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b

RE: [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-14 Thread Dylan Hung
> -Original Message- > From: Joel Stanley [mailto:j...@jms.id.au] > Sent: Thursday, October 15, 2020 6:31 AM > To: Dylan Hung > Cc: David S . Miller ; Jakub Kicinski > ; netdev@vger.kernel.org; Linux Kernel Mailing List > ; Po-Yu Chuang ; > linux-aspeed ; Ope

RE: [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-14 Thread Dylan Hung
Hi Joel, > -Original Message- > From: Joel Stanley [mailto:j...@jms.id.au] > Sent: Wednesday, October 14, 2020 2:41 PM > To: Dylan Hung > Cc: David S . Miller ; Jakub Kicinski > ; netdev@vger.kernel.org; Linux Kernel Mailing List > ; Po-Yu Chuang ; > linux-a

[PATCH 0/1] Fix Aspeed ast2600 MAC TX hang

2020-10-13 Thread Dylan Hung
This patch fixes the TX hang issue on Aspeed AST2600. Two HW arbitration features are added onto ast2600, but these features will cause MAC TX to hang when handling scatter-gather DMA. These two problematic features can be disabled by setting MAC register 0x58 bit28 and bit27. Dylan Hung (1

[PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-13 Thread Dylan Hung
The new HW arbitration feature on Aspeed ast2600 will cause MAC TX to hang when handling scatter-gather DMA. Disable the problematic feature by setting MAC register 0x58 bit28 and bit27. Signed-off-by: Dylan Hung --- drivers/net/ethernet/faraday/ftgmac100.c | 5 + drivers/net/ethernet