[PATCH v2 2/2] ath10k: Get rid of "per_ce_irq" hw param

2020-07-09 Thread Douglas Anderson
As of the patch ("ath10k: Keep track of which interrupts fired, don't poll them") we now have no users of this hardware parameter. Remove it. Suggested-by: Brian Norris Signed-off-by: Douglas Anderson --- Changes in v2: - Patch ("ath10k: Get rid of "per_ce_i

[PATCH v2 1/2] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-09 Thread Douglas Anderson
read the Copy Engines. Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1 Signed-off-by: Douglas Anderson Reviewed-by: Rakesh Pillai Reviewed-by: Brian Norris --- This patch continues work to try to squash all instances of the crash we've been seeing while reading CE registers and

[PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-07 Thread Douglas Anderson
read the Copy Engines. Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1 Signed-off-by: Douglas Anderson --- This patch continues work to try to squash all instances of the crash we've been seeing while reading CE registers and hopefully this patch addresses the true root of the i

[PATCH] ath10k: Wait until copy complete is actually done before completing

2020-06-09 Thread Douglas Anderson
would also be important to double-check that the interrupt we cared about actually fired. Signed-off-by: Douglas Anderson --- drivers/net/wireless/ath/ath10k/ce.c | 30 +++- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k

[PATCH] ath10k: Remove ath10k_qmi_register_service_notifier() declaration

2020-05-28 Thread Douglas Anderson
or wcn3990 client") Signed-off-by: Douglas Anderson --- drivers/net/wireless/ath/ath10k/qmi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/qmi.h b/drivers/net/wireless/ath/ath10k/qmi.h index dc257375f161..e03581182919 100644 --- a/drivers/net/wireless/a

[PATCH v3 0/5] brcmfmac: sdio: Deal better w/ transmission errors related to idle

2019-06-07 Thread Douglas Anderson
brcmfmac: sdio: Don't tune while the card is off") new for v3. Changes in v2: - A full revert, not just a partial one (Arend). ...with explicit Cc. - Updated commit message to clarify based on discussion of v1. Douglas Anderson (5): Revert "brcmfmac: disable command decode in s

[PATCH v3 1/5] Revert "brcmfmac: disable command decode in sdio_aos"

2019-06-07 Thread Douglas Anderson
Cc: Wright Feng Cc: Double Lo Cc: Madhan Mohan R Cc: Chi-Hsien Lin Signed-off-by: Douglas Anderson --- As far as I know this patch can land anytime. Changes in v3: None Changes in v2: - A full revert, not just a partial one (Arend). ...with explicit Cc. drivers/net/wireless/broadcom/brc

[PATCH v2 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-06-03 Thread Douglas Anderson
Let's disable retuning around the commands we expect might fail. Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") Signed-off-by: Douglas Anderson --- Changes in v2: None drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++ 1 file chang

[PATCH 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

2019-05-17 Thread Douglas Anderson
Let's disable retuning around the commands we expect might fail. Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") Signed-off-by: Douglas Anderson --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --

[PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354

2019-05-17 Thread Douglas Anderson
we fixed it. Disabling a feature on all boards just because one SD card controller is broken seems bad. ...so instead of just this patch possibly the right thing to do is to fully revert the original commit. Fixes: 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") Signed-off-

[PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep

2019-05-17 Thread Douglas Anderson
n should be. Douglas Anderson (3): brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 mmc: core: API for temporarily disabling auto-retuning due to errors brcmfmac: sdio: Disable auto-tuning around commands expected to fail drivers/mmc/core/core.c

[RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

2017-09-19 Thread Douglas Anderson
e is allocating much less than 4K worth of data and probably never fails. Signed-off-by: Douglas Anderson --- drivers/net/usb/usbnet.c | 50 +--- 1 file changed, 22 insertions(+), 28 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net

[RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

2017-09-19 Thread Douglas Anderson
gged". ALSO NOTE: If somehow some of the types of work need to be repeated if usbnet_defer_kevent() is called multiple times then that should be quite easy to accomplish without dropping any work on the floor. We can just keep an atomic count for that type of work and add a loop into usb

[RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails

2017-09-19 Thread Douglas Anderson
If rx_submit() returns an error code then nobody calls usb_free_urb(). That means it's leaked. NOTE: This problem was found solely by code inspection and not due to any failing test cases. Signed-off-by: Douglas Anderson --- drivers/net/usb/usbnet.c | 9 ++--- 1 file changed, 6 inser

[PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Douglas Anderson
to hci_req_sync_complete(). Let's make sure we always check the flag. For more details on debugging done, see <http://crbug.com/588288>. Fixes: 44d271377479 ("Bluetooth: Compress the size of struct hci_ctrl") Signed-off-by: Douglas Anderson --- Testing was done on a Chrome O