ound a patch (https://patchwork.ozlabs.org/patch/501666/) that
was intended to fix setting of mpu values which never got pushed.
Printing definitely deserved a fix but there is some more work to it at
the kernel side.
On Ср., 2016-02-17 at 17:51 -0800, Stephen Hemminger wrote:
> On Sat, 19
b3 buffer has been deleted previously so b2 is followed by b4 which is not
consistent
Signed-off-by: Dmitrii Shcherbakov
Acked-by: Jesper Dangaard Brouer
Acked-by: Phil Sutter
---
tc/q_htb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/q_htb.c b/tc/q_htb.c
index
Remove printing according to the previously used encoding of mpu and overhead
values within the tc_ratespec's mpu field. This encoding is no longer being
used as a separate 'overhead' field in the ratespec structure has been
introduced.
Signed-off-by: Dmitrii Shcherbakov
A
Phil,
18.12.2015, 19:55, "Phil Sutter" :
> On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote:
>> > Dmitrii, did iproute2 without your change even print the overhead as set
>> > by you before? Looking at the code, I'd assume not.
>>
thernet burst 1600b/1 mpu 0b overhead 0b cburst 1600b/1 mpu 0b
overhead 0b level 0
~/src/iproute2/tc$ lsmod | grep htb
sch_htb24576 1
So it looks like the overhead is being set correctly, but the mpu is not, even
though the respective kernel module is loaded judging by what I s
Jesper,
> Thank you Dmitrii for cleaning this up :-)
You are welcome :^)
I should read more carefully: its what you asked from the beginning.
Thank you,
Dmitrii Shcherbakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a mess
Jesper,
Sorry, it seems that I accidentally sent out an unfinished e-mail.
>I don't think your patch should contain this cleanup of "b4".
It seems that b3 is only used for the legacy overhead part and if I remove it,
b3 is not going to be used. So I figured I remove b4 put b3 instead.
administ
", (int)hopt->level);
>> } else {
>> fprintf(f, "burst %s ", sprint_size(buffer, b1));
Ok, but I don't see any other usage of b4:
administrator@UX32LN:~/Sources/iproute2/tc$ git branch
* (HEAD detached at 654ae88)
Phil,
> Dmitrii, did iproute2 without your change even print the overhead as
set by you before? Looking at the code, I'd assume not.
I used an iproute2 provided by the distribution and an OpenVZ 3.10 kernel
so there are differences there but I
noticed the 'manual' overhead-related code is include
el.org/cgit/linux/kernel/git/shemminger/iproute2.git/tree/tc/q_tbf.c#n279
|fprintf(f, "burst %s/%u mpu %s ", sprint_size(buffer, b1),|
Please take a look at my patch if you have time for it as this would simplify
testing in the project I work on and make the output of the command less
am
10 matches
Mail list logo
