Re: Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-03 Thread Diego Viola
On Fri, Mar 3, 2017 at 12:40 PM, Diego Viola wrote: > On Fri, Mar 3, 2017 at 12:37 PM, Diego Viola wrote: >> On Wed, Mar 1, 2017 at 12:47 PM, Diego Viola wrote: >>> On Wed, Mar 1, 2017 at 12:44 PM, Diego Viola wrote: >>>> My machine (a Dell Inspiron 5558 laptop

Re: Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-03 Thread Diego Viola
On Fri, Mar 3, 2017 at 12:37 PM, Diego Viola wrote: > On Wed, Mar 1, 2017 at 12:47 PM, Diego Viola wrote: >> On Wed, Mar 1, 2017 at 12:44 PM, Diego Viola wrote: >>> My machine (a Dell Inspiron 5558 laptop) fails to resume from suspend >>> unless I rmmod r8169 first.

Re: Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-03 Thread Diego Viola
On Wed, Mar 1, 2017 at 12:47 PM, Diego Viola wrote: > On Wed, Mar 1, 2017 at 12:44 PM, Diego Viola wrote: >> My machine (a Dell Inspiron 5558 laptop) fails to resume from suspend >> unless I rmmod r8169 first. >> >> Another workaround is to do this before suspend

Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-01 Thread Diego Viola
My machine (a Dell Inspiron 5558 laptop) fails to resume from suspend unless I rmmod r8169 first. Another workaround is to do this before suspend: echo 0 > /sys/power/pm_async I've been reproducing the freeze like this: $ i3lock && systemctl suspend I would have to repeat this at least 5 times

Re: Dell Inspiron 5558/0VNM2T and suspend/resume problem with r8169

2017-03-01 Thread Diego Viola
On Wed, Mar 1, 2017 at 12:44 PM, Diego Viola wrote: > My machine (a Dell Inspiron 5558 laptop) fails to resume from suspend > unless I rmmod r8169 first. > > Another workaround is to do this before suspend: > > echo 0 > /sys/power/pm_async > > I've been

[PATCH TRIVIAL] drivers/net/usb/plusb.c: Fix typo

2016-03-27 Thread Diego Viola
Signed-off-by: Diego Viola --- drivers/net/usb/plusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c index 1bfe0fc..22e1a9a 100644 --- a/drivers/net/usb/plusb.c +++ b/drivers/net/usb/plusb.c @@ -38,7 +38,7 @@ * HEADS UP

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-03-06 Thread Diego Viola
On Wed, Mar 2, 2016 at 2:04 AM, Guo-Fu Tseng wrote: > Dear Diego and who concerns about this driver: > > Thanks for reporting it. I can still provide some help, but it's just I'm > quite busy. > So that you have not seem me sending patch for a long time. > > I wrote this driver when I wan an inte

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-04 Thread Diego Viola
On Fri, Mar 4, 2016 at 1:32 AM, Diego Viola wrote: > On Thu, Mar 3, 2016 at 6:19 PM, Diego Viola wrote: >> On Thu, Mar 3, 2016 at 6:14 PM, Diego Viola wrote: >>> On Thu, Mar 3, 2016 at 2:55 AM, Diego Viola wrote: >>>> On Thu, Mar 3, 2016 at 12:19 AM, Diego Vio

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-03 Thread Diego Viola
On Thu, Mar 3, 2016 at 6:19 PM, Diego Viola wrote: > On Thu, Mar 3, 2016 at 6:14 PM, Diego Viola wrote: >> On Thu, Mar 3, 2016 at 2:55 AM, Diego Viola wrote: >>> On Thu, Mar 3, 2016 at 12:19 AM, Diego Viola wrote: >>>> On Wed, Mar 2, 2016 at 2:14 AM, Guo-Fu Tseng

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-03 Thread Diego Viola
On Thu, Mar 3, 2016 at 6:14 PM, Diego Viola wrote: > On Thu, Mar 3, 2016 at 2:55 AM, Diego Viola wrote: >> On Thu, Mar 3, 2016 at 12:19 AM, Diego Viola wrote: >>> On Wed, Mar 2, 2016 at 2:14 AM, Guo-Fu Tseng >>> wrote: >>>> On Wed, 24 Feb 2016 2

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-03 Thread Diego Viola
On Thu, Mar 3, 2016 at 2:55 AM, Diego Viola wrote: > On Thu, Mar 3, 2016 at 12:19 AM, Diego Viola wrote: >> On Wed, Mar 2, 2016 at 2:14 AM, Guo-Fu Tseng wrote: >>> On Wed, 24 Feb 2016 23:58:56 -0500 (EST), David Miller wrote >>>> From: Diego Viola >>>

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-02 Thread Diego Viola
On Thu, Mar 3, 2016 at 12:19 AM, Diego Viola wrote: > On Wed, Mar 2, 2016 at 2:14 AM, Guo-Fu Tseng wrote: >> On Wed, 24 Feb 2016 23:58:56 -0500 (EST), David Miller wrote >>> From: Diego Viola >>> Date: Tue, 23 Feb 2016 12:04:04 -0300 >>> >>> >

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-03-02 Thread Diego Viola
On Wed, Mar 2, 2016 at 2:14 AM, Guo-Fu Tseng wrote: > On Wed, 24 Feb 2016 23:58:56 -0500 (EST), David Miller wrote >> From: Diego Viola >> Date: Tue, 23 Feb 2016 12:04:04 -0300 >> >> > The JMC260 network card fails to suspend/resume because the call to >> >

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-02-25 Thread Diego Viola
On Thu, Feb 25, 2016 at 1:58 AM, David Miller wrote: > From: Diego Viola > Date: Tue, 23 Feb 2016 12:04:04 -0300 > >> The JMC260 network card fails to suspend/resume because the call to >> jme_start_irq() was too early, moving the call to jme_start_irq() after >>

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-02-24 Thread Diego Viola
On Tue, Feb 23, 2016 at 1:34 PM, Diego Viola wrote: > On Tue, Feb 23, 2016 at 12:04 PM, Diego Viola wrote: >> The JMC260 network card fails to suspend/resume because the call to >> jme_start_irq() was too early, moving the call to jme_start_irq() after >> the call to jme_

Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

2016-02-23 Thread Diego Viola
On Tue, Feb 23, 2016 at 12:04 PM, Diego Viola wrote: > The JMC260 network card fails to suspend/resume because the call to > jme_start_irq() was too early, moving the call to jme_start_irq() after > the call to jme_reset_link() makes it work. > > Prior this change suspend/resume wo

[PATCH v3] net: jme: fix suspend/resume on JMC260

2016-02-23 Thread Diego Viola
report: https://bugzilla.kernel.org/show_bug.cgi?id=112351 Signed-off-by: Diego Viola --- drivers/net/ethernet/jme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index b1de7af..8adbe8f 100644 --- a/drivers/net

[PATCH v2] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
-by: Diego Viola --- drivers/net/ethernet/jme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index b1de7af..8adbe8f 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -3312,13 +3312,14

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Tue, Feb 23, 2016 at 2:11 AM, Diego Viola wrote: > On Tue, Feb 23, 2016 at 1:42 AM, David Miller wrote: >> From: Diego Viola >> Date: Mon, 22 Feb 2016 22:58:48 -0300 >> >>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >>>> On Mon, F

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Tue, Feb 23, 2016 at 1:42 AM, David Miller wrote: > From: Diego Viola > Date: Mon, 22 Feb 2016 22:58:48 -0300 > >> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >>>> Signed-off-by: Die

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 10:58 PM, Diego Viola wrote: > On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: >> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >>> Signed-off-by: Diego Viola >> >> You should write a commit log. > > I thought about

Re: [PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam wrote: > On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola wrote: >> Signed-off-by: Diego Viola > > You should write a commit log. I thought about including the link to my bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351

Re: [PATCH] jme: remove the jme driver as it is no longer maintained

2016-02-22 Thread Diego Viola
On Sun, Feb 21, 2016 at 2:17 PM, Diego Viola wrote: > On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes > wrote: >>> I would appreciate some hint from someone who is more experienced with >>> drivers. >> >> Start by testing >> >> - loading

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 4:20 PM, Pavel Machek wrote: > On Mon 2016-02-22 15:59:48, Diego Viola wrote: >> On Mon, Feb 22, 2016 at 7:09 AM, Pavel Machek wrote: >> > Hi! >> > >> >> >>>> Every time I initiate a suspend (systemctl suspend) the mac

[PATCH] net: jme: fix suspend/resume on JMC260

2016-02-22 Thread Diego Viola
Signed-off-by: Diego Viola --- drivers/net/ethernet/jme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index b1de7af..8adbe8f 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c @@ -3312,13

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-22 Thread Diego Viola
On Mon, Feb 22, 2016 at 7:09 AM, Pavel Machek wrote: > Hi! > >> Every time I initiate a suspend (systemctl suspend) the machine hangs >> at resume unless I unload the jme driver. > > It seems to have some kind of suspend/resume support. ... and it is > rather complex. > > Maybe jme_start

Re: [PATCH] jme: remove the jme driver as it is no longer maintained

2016-02-21 Thread Diego Viola
On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes wrote: >> I would appreciate some hint from someone who is more experienced with >> drivers. > > Start by testing > > - loading the driver as a module > - using the networking > - unloading the module (and checking it stays unloaded!) > > then

Re: [PATCH] jme: remove the jme driver as it is no longer maintained

2016-02-20 Thread Diego Viola
On Sat, Feb 20, 2016 at 10:16 PM, David Miller wrote: > > Sorry, this is not how things work. > > You can suggest marking the driver unmaintained in MAINTAINERS if the > listed developer has been unresponsive for a very long time. > > But removing the driver altogether is not prudent at all. > > J

[PATCH] jme: remove the jme driver as it is no longer maintained

2016-02-20 Thread Diego Viola
This driver also breaks my suspend/resume support, see the link below for details: https://bugzilla.kernel.org/show_bug.cgi?id=112351 If you choose to keep this garbage, move it to staging at least, where it belongs. Signed-off-by: Diego Viola --- MAINTAINERS |6

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-14 Thread Diego Viola
On Sat, Feb 13, 2016 at 6:38 PM, Diego Viola wrote: > On Fri, Feb 12, 2016 at 6:17 AM, Diego Viola wrote: >> On Wed, Feb 10, 2016 at 7:36 PM, Diego Viola wrote: >>> On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola wrote: >>>> Hi Guo, >>>> >>

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-13 Thread Diego Viola
On Fri, Feb 12, 2016 at 6:17 AM, Diego Viola wrote: > On Wed, Feb 10, 2016 at 7:36 PM, Diego Viola wrote: >> On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola wrote: >>> Hi Guo, >>> >>> I have an x86 computer with this network card: >>> >>>

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-12 Thread Diego Viola
On Wed, Feb 10, 2016 at 7:36 PM, Diego Viola wrote: > On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola wrote: >> Hi Guo, >> >> I have an x86 computer with this network card: >> >> 02:00.0 Ethernet controller: JMicron Technology Corp. JMC260 PCI >> E

Re: Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-10 Thread Diego Viola
On Wed, Feb 10, 2016 at 2:19 AM, Diego Viola wrote: > Hi Guo, > > I have an x86 computer with this network card: > > 02:00.0 Ethernet controller: JMicron Technology Corp. JMC260 PCI > Express Fast Ethernet Controller (rev 03) > > Every time I initiate a suspend (system

Computer fails to resume from suspend unless I rmmod jme before initiating the suspend

2016-02-09 Thread Diego Viola
Hi Guo, I have an x86 computer with this network card: 02:00.0 Ethernet controller: JMicron Technology Corp. JMC260 PCI Express Fast Ethernet Controller (rev 03) Every time I initiate a suspend (systemctl suspend) the machine hangs at resume unless I unload the jme driver. Here is a Call Trace