Re: [PATCH V2 02/16] net: iosm: irq handling

2021-04-20 Thread David Miller
From: M Chetan Kumar Date: Tue, 20 Apr 2021 21:42:56 +0530 > 1) Request interrupt vector, frees allocated resource. > 2) Registers IRQ handler. > > Signed-off-by: M Chetan Kumar > --- > v2: Streamline multiple returns using goto. > --- > drivers/net/wwan/iosm/iosm_ipc_irq.c | 91 ++

[PATCH net-next] korina: Fix conflict with global symbol desc_empty on x86.

2021-04-20 Thread David Miller
Signed-off-by: David S. Miller --- drivers/net/ethernet/korina.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 4878e527e3c8..4613bc21130b 100644 --- a/drivers/net/ethernet/korina.c +++ b/d

Re: [PATCH] net: ethernet: ravb: Fix release of refclk

2021-04-19 Thread David Miller
From: Adam Ford Date: Sat, 17 Apr 2021 08:23:29 -0500 > The call to clk_disable_unprepare() can happen before priv is > initialized. This means moving clk_disable_unprepare out of > out_release into a new label. > > Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk") > Signed-off-

Re: [PATCH][next] sctp: Fix out-of-bounds warning in sctp_process_asconf_param()

2021-04-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 16 Apr 2021 19:07:05 -0500 > Dave, > > On 4/16/21 19:00, patchwork-bot+netdev...@kernel.org wrote: >> Hello: >> >> This patch was applied to netdev/net-next.git (refs/heads/master): >> >> On Fri, 16 Apr 2021 14:12:36 -0500 you wrote: >>> Fix the following

Re: [PATCH v2 net-next 0/9] net: Korina improvements

2021-04-14 Thread David Miller
From: Thomas Bogendoerfer Date: Wed, 14 Apr 2021 17:29:36 +0200 > While converting Mikrotik RB532 support to use device tree I stumbled > over the korina ethernet driver, which used way too many MIPS specific > hacks. This series cleans this all up and adds support for device tree. > > Changes i

Re: [PATCH net-next 0/5] dpaa2-switch: add tc hardware offload on ingress traffic

2021-04-14 Thread David Miller
From: Ioana Ciornei Date: Wed, 14 Apr 2021 18:17:28 +0300 > This patch set is in the 'Accepted' state in patchwork but is nowhere to > be found in the net-next tree. > > Should I do something else or it was just not pushed yet? It should be there now. Thanks.

Re: [PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-13 Thread David Miller
From: Balaev Pavel Date: Tue, 13 Apr 2021 14:55:04 +0300 > @@ -222,6 +230,9 @@ struct netns_ipv4 { > #ifdef CONFIG_IP_ROUTE_MULTIPATH > u8 sysctl_fib_multipath_use_neigh; > u8 sysctl_fib_multipath_hash_policy; > + int sysctl_fib_multipath_hash_seed; > + struct multipath_seed_

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-04-12 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 12 Apr 2021 18:33:45 -0400 > On Mon, Apr 12, 2021 at 06:08:21PM -0400, Michael S. Tsirkin wrote: >> OK I started looking at this again. My idea is simple. >> A. disable callbacks before we try to drain skbs >> B. actually do disable callbacks even with event

Re: [PATCH net-next 6/7] net: stmmac: Enable RX via AF_XDP zero-copy

2021-04-12 Thread David Miller
+ /* synchronize_rcu() needed for pending XDP buffers to drain */ + for (queue = 0; queue < rx_queues_cnt; queue++) { + rx_q = &priv->rx_queue[queue]; + if (rx_q->xsk_pool) { + synchronize_rcu(); Are you sure this is safe here, especial

Re: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread David Miller
From: Dexuan Cui Date: Fri, 9 Apr 2021 00:24:51 + >> From: David Miller >> Sent: Thursday, April 8, 2021 4:46 PM >> ... >> > +struct gdma_msg_hdr { >> > + u32 hdr_type; >> > + u32 msg_type; >> > + u16 msg_version; >>

Re: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread David Miller
From: Dexuan Cui Date: Thu, 8 Apr 2021 15:58:40 -0700 > +struct gdma_msg_hdr { > + u32 hdr_type; > + u32 msg_type; > + u16 msg_version; > + u16 hwc_msg_id; > + u32 msg_size; > +} __packed; > + > +struct gdma_dev_id { > + union { > + struct { > +

Re: [PATCH] bnx2x: Fix potential infinite loop

2021-04-07 Thread David Miller
From: Colin King Date: Wed, 7 Apr 2021 15:28:02 +0100 > From: Colin Ian King > > The for_each_tx_queue loop iterates with a u8 loop counter i and > compares this with the loop upper limit of bp->num_queues that > is an int type. There is a potential infinite loop if bp->num_queues > is larger

Re: [PATCH net-next] net: tipc: Fix spelling errors in net/tipc module

2021-04-06 Thread David Miller
From: Zheng Yongjun Date: Tue, 6 Apr 2021 23:19:09 +0800 > These patches fix a series of spelling errors in net/tipc module. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun This does not apply to net-next, please respin. Thanks.

Re: [PATCH net v4] atl1c: move tx cleanup processing out of interrupt

2021-04-06 Thread David Miller
From: Gatis Peisenieks Date: Tue, 06 Apr 2021 17:49:32 +0300 > Tx queue cleanup happens in interrupt handler on same core as rx queue > processing. Both can take considerable amount of processing in high > packet-per-second scenarios. > > Sending big amounts of packets can stall the rx processin

Re: [PATCH] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-06 Thread David Miller
From: Anirudh Rayabharam Date: Tue, 6 Apr 2021 18:13:59 +0530 > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-ptr-deref. > > The get_free_serial_index() function r

Re: [PATCH net-next v5] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-04-06 Thread David Miller
From: Xie He Date: Fri, 2 Apr 2021 02:30:00 -0700 > X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable > datalink service such that no packets are reordered or dropped. And > X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. > > However, this reliabili

Re: [PATCH] net: tun: set tun->dev->addr_len during TUNSETLINK processing

2021-04-05 Thread David Miller
From: Phillip Potter Date: Mon, 5 Apr 2021 12:35:55 +0100 > When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len > to match the appropriate type, using new tun_get_addr_len utility function > which returns appropriate address length for given type. Fixes a > KMSAN-found unini

Re: [PATCH net-next] ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods

2021-03-31 Thread David Miller
From: Eric Dumazet Date: Wed, 31 Mar 2021 08:00:24 +0200 > Can you merge this patch so that I can send my global fix for fallback > tunnels, with a correct Fixes: tag for this patch ? Done.

Re: [PATCH] net/rds: Fix a use after free in rds_message_map_pages

2021-03-30 Thread David Miller
From: Lv Yunlong Date: Tue, 30 Mar 2021 03:16:02 -0700 > @@ -348,7 +348,7 @@ struct rds_message *rds_message_map_pages(unsigned long > *page_addrs, unsigned in > rm->data.op_sg = rds_message_alloc_sgs(rm, num_sgs); > if (IS_ERR(rm->data.op_sg)) { > rds_message_put(rm);

Re: [PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC interface

2021-03-26 Thread David Miller
From: Jakub Kicinski Date: Thu, 25 Mar 2021 19:07:21 -0700 > Our FEC configuration interface is one of the more confusing. > It also lacks any error checking in the core. This certainly > shows in the varying implementations across the drivers. > > Improve the documentation and add most basic ch

Re: [PATCH] fddi: skfp: Rudimentary spello fixes

2021-03-25 Thread David Miller
From: Bhaskar Chowdhury Date: Thu, 25 Mar 2021 12:38:35 +0530 > > s/autohorized/authorized/ > s/recsource/resource/ > s/measuered/measured/ > sauthoriziation/authorization/ > > Signed-off-by: Bhaskar Chowdhury Does not apply cleanly to net-next please respin. Thank you.

Re: [net-next 05/15] net/mlx5e: Move params logic into its dedicated file

2021-03-25 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Mar 2021 22:04:28 -0700 > +static inline u8 mlx5e_get_rqwq_log_stride(u8 wq_type, int ndsegs) Please no inline in foo.c files. Thasnk you.

Re: [pull request][net-next 00/15] mlx5 updates 2021-03-24

2021-03-25 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Mar 2021 22:04:23 -0700 > From: Saeed Mahameed > > Hi Dave/Jakub, > > This series provides update to mlx5 netdev driver, mostly refactoring. > For more information please see tag log below. > > Please pull and let me know if there is any problem. Please res

Re: [PATCH] ptp_qoriq: fix overflow in ptp_qoriq_adjfine() u64 calcalation

2021-03-25 Thread David Miller
From: Guenter Roeck Date: Thu, 25 Mar 2021 03:23:07 -0700 > mul_u64_u64_div_u64() is not exported. As result, every build with > CONFIG_PTP_1588_CLOCK_QORIQ=m (ie every allmodconfig build) fails with: > > ERROR: modpost: "mul_u64_u64_div_u64" [drivers/ptp/ptp-qoriq.ko] undefined! > > or a simil

[GIT] Networking

2021-03-24 Thread David Miller
Various fixes, all over: 1) Fix overflow in ptp_qoriq_adjfine(), from Yangbo Lu. 2) Always store the rx queue mapping in veth, from Maciej Fijalkowski. 3) Don't allow vmlinux btf in map_create, from Alexei Starovoitov. 4) Fix memory leak in octeontx2-af from Colin Ian King. 5) Use kvalloc in

Re: [PATCH net-next] net: set initial device refcount to 1

2021-03-22 Thread David Miller
From: David Miller Date: Mon, 22 Mar 2021 16:55:26 -0700 (PDT) > From: Eric Dumazet > Date: Mon, 22 Mar 2021 11:21:45 -0700 > > This hunk: >> @@ -10682,6 +10682,9 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, >> const char *name, >> dev-&

Re: [PATCH net-next] net: set initial device refcount to 1

2021-03-22 Thread David Miller
From: Eric Dumazet Date: Mon, 22 Mar 2021 11:21:45 -0700 > From: Eric Dumazet > > When adding CONFIG_PCPU_DEV_REFCNT, I forgot that the > initial net device refcount was 0. > > When CONFIG_PCPU_DEV_REFCNT is not set, this means > the first dev_hold() triggers an illegal refcount > operation (a

Re: [PATCH] net: make unregister netdev warning timeout configurable

2021-03-22 Thread David Miller
From: Dmitry Vyukov Date: Sat, 20 Mar 2021 15:28:51 +0100 > netdev_wait_allrefs() issues a warning if refcount does not drop to 0 > after 10 seconds. While 10 second wait generally should not happen > under normal workload in normal environment, it seems to fire falsely > very often during fuzzin

Re: [Bug 212353] New: Requesting IP_RECVTTL via setsockopt returns IP_TTL via recvmsg()'s cmsghdr

2021-03-19 Thread David Miller
Although IP_RECVTTL is the socket option used to control the reporting, the value is reported using IP_TTL. This is intentional, and correct.

Re: [PATCH net] net: core: avoid napi_disable to cause deadlock

2021-03-18 Thread David Miller
From: Eric Dumazet Date: Thu, 18 Mar 2021 10:22:23 +0100 > On Thu, Mar 18, 2021 at 9:04 AM Lijun Pan wrote: >> >> There are chances that napi_disable is called twice by NIC driver. > > > ??? > > Please fix the buggy driver, or explain why it can not be fixed. Agreed,.

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread David Miller
From: Andreas Roeseler Date: Wed, 17 Mar 2021 22:11:47 -0500 > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > Is there something that I'm not understanding about compiling kernel > components modularly? How do I avoid this error? > You cannot reference module exported symbols fro

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-17 Thread David Miller
From: Menglong Dong Date: Wed, 17 Mar 2021 16:21:14 +0800 > Hello, > > On Wed, Mar 17, 2021 at 9:38 AM Guenter Roeck wrote: >> >> On Wed, Mar 17, 2021 at 01:02:51AM +0200, Andy Shevchenko wrote: >> > On Wednesday, March 17, 2021, Guenter Roeck wrote: >> > > ... >> >> The problem is in net/pack

Re: [PATCH net-next] net: sched: remove unnecessay lock protection for skb_bad_txq/gso_skb

2021-03-16 Thread David Miller
From: Yunsheng Lin Date: Tue, 16 Mar 2021 10:40:56 +0800 > On 2021/3/16 7:41, David Miller wrote: >> From: Yunsheng Lin > > At least for the fast path, taking two locks for lockless qdisc hurts > performance when handling requeued skb, especially if the lockles

Re: [PATCH net-next] net: sched: remove unnecessay lock protection for skb_bad_txq/gso_skb

2021-03-15 Thread David Miller
From: Yunsheng Lin Date: Mon, 15 Mar 2021 17:30:10 +0800 > Currently qdisc_lock(q) is taken before enqueuing and dequeuing > for lockless qdisc's skb_bad_txq/gso_skb queue, qdisc->seqlock is > also taken, which can provide the same protection as qdisc_lock(q). > > This patch removes the unnecess

Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-15 Thread David Miller
From: Cristian Ciocaltea Date: Mon, 15 Mar 2021 13:29:17 +0200 > + > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK) > +static int debug = -1; > +module_param(debug, int, 0); > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); Module parameters are stron

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread David Miller
From: Vladimir Oltean Date: Sun, 14 Mar 2021 20:44:49 + > On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote: >> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: >> >> Smells like a breaking change for existing consumers of this value. >> >> How about we change the

Re: [PATCH net-next 0/2] axienet clock additions

2021-03-14 Thread David Miller
From: Robert Hancock Date: Thu, 11 Mar 2021 14:11:15 -0600 > Add support to the axienet driver for controlling all of the clocks that > the logic core may utilize. This series does not apply to net-next, please respin. Thanks.

Re: [PATCH v2 net-next 0/6] skbuff: micro-optimize flow dissection

2021-03-13 Thread David Miller
None of these apply to net-next as per the patchwork automated checks. Any idea why? Thanks.

Re: [PATCH] net: bonding: fix error return code of bond_neigh_init()

2021-03-12 Thread David Miller
From: Eric Dumazet Date: Wed, 10 Mar 2021 17:55:04 +0100 > > Agreed, this commit made no sense, please revert. Done.

Re: [PATCH 4/4] ftgmac100: Restart MAC HW once

2021-03-11 Thread David Miller
From: Joel Stanley Date: Fri, 12 Mar 2021 00:26:43 + > On Tue, 20 Oct 2020 at 04:14, Joel Stanley wrote: >> >> On Mon, 19 Oct 2020 at 08:57, Dylan Hung wrote: >> > >> > The interrupt handler may set the flag to reset the mac in the future, >> > but that flag is not cleared once the reset ha

Re: [PATCH net-next 00/23] netfilter: flowtable enhancements

2021-03-11 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 11 Mar 2021 22:45:05 +0100 > > I can extend the documentation to describe the invalidation problem in > a follow up patch and to explicit state that this is not addressed at > this stage. Please do, thank you.

Re: [PATCH net-next 2/2] net: broadcom: bcm4908_enet: support TX interrupt

2021-03-10 Thread David Miller
From: Rafał Miłecki Date: Wed, 10 Mar 2021 10:14:10 +0100 > > + if (enet->irq_tx >= 0) { ... > + if (enet->irq_tx > 0) { Tests are not consistent, please fix. Thank you.

Re: [PATCH net-next 00/15] dpaa2-switch: CPU terminated traffic and move out of staging

2021-03-10 Thread David Miller
From: Greg KH Date: Wed, 10 Mar 2021 15:12:57 +0100 > Yes, either I can provide a stable tag to pull from for the netdev > maintainers, or they can just add the whole driver to the "proper" place > in the network tree and I can drop the one in staging entirely. Or > people can wait until 5.13-rc

net-next is OPEN

2021-03-09 Thread David Miller
Ready for your submissions as always :)

Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

2021-03-05 Thread David Miller
Please resubmit these again when net-next opens back up, thank you.

Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread David Miller
From: Paul Moore Date: Thu, 4 Mar 2021 18:13:21 -0500 > On Thu, Mar 4, 2021 at 5:33 PM David Miller wrote: >> From: Paul Moore >> Date: Thu, 04 Mar 2021 16:29:51 -0500 >> >> > +static void calipso_doi_putdef(struct calipso_doi *doi_def); >> > + >>

Re: [PATCH] cipso,calipso: resolve a number of problems with the DOI refcounts

2021-03-04 Thread David Miller
From: Paul Moore Date: Thu, 04 Mar 2021 16:29:51 -0500 > +static void calipso_doi_putdef(struct calipso_doi *doi_def); > + This is a global symbol, so why the static decl here? Thanks.

Re: [PATCH net v2 0/2][pull request] Intel Wired LAN Driver Updates 2021-03-04

2021-03-04 Thread David Miller
From: Tony Nguyen Date: Thu, 4 Mar 2021 11:20:15 -0800 > This series contains updates to ixgbe and ixgbevf drivers. > > Antony Antony adds a check to fail for non transport mode SA with > offload as this is not supported for ixgbe and ixgbevf. > > Dinghao Liu fixes a memory leak on failure to

Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete,Re: [PATCH net] can: dev: Move device back to init netns on owning netns delete

2021-03-03 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 3 Mar 2021 21:29:39 +0100 > Acked-by: Marc Kleine-Budde > > David, Jakub are you taking this patch? Nope, please take via the can tree, thanks!

Re: [PATCH] tcp: avoid unnecessary loop if even ports are used up

2021-02-20 Thread David Miller
From: Honglei Wang Date: Sat, 20 Feb 2021 19:03:56 +0800 > We are getting port for connect() from even ports firstly now. This > makes bind() users have more available slots at odd part. But there is a > problem here when the even ports are used up. This happens when there > is a flood of short l

Re: [PATCH v15 0/4] Adding the Sparx5 Serdes driver

2021-02-18 Thread David Miller
From: Steen Hegelund Date: Thu, 18 Feb 2021 17:14:47 +0100 > Adding the Sparx5 Serdes driver > The net-next tree is closed so this will have to wait until the next merge window. Thanks.

Re: [PATCH net-next v2 0/2] net: phy: at803x: paging support

2021-02-18 Thread David Miller
From: Michael Walle Date: Thu, 18 Feb 2021 20:46:10 +0100 > Am 2021-02-18 20:26, schrieb Vladimir Oltean: >> On Thu, Feb 18, 2021 at 07:52:38PM +0100, Michael Walle wrote: >>> Add paging support to the QCA AR8031/33 PHY. This will be needed if we >>> add support for the .config_inband_aneg callba

Re: [PATCH V3 net-next 0/5] add support for RFC 8335 PROBE

2021-02-17 Thread David Miller
From: Andreas Roeseler Date: Wed, 17 Feb 2021 10:07:38 -0800 > The popular utility ping has several severe limitations such as the > inability to query specific interfaces on a node and requiring > bidirectional connectivity between the probing and probed interfaces. > RFC 8335 attempts to solve

Re: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread David Miller
From: Sven Van Asbroeck Date: Wed, 17 Feb 2021 17:04:05 -0500 > Hi Jakub and Bryan, > > Jakub, is there anything else you'd like to see from us, before you > are satisfied that patches 1/5 and 2/5 can be merged into your tree? They are already merged into net-next

Re: [PATCH net-next] octeontx2-pf: fix an off by one bug in otx2_get_fecparam()

2021-02-15 Thread David Miller
From: Dan Carpenter Date: Mon, 15 Feb 2021 18:56:46 +0300 > The "<= FEC_MAX_INDEX" comparison should be "< FEC_MAX_INDEX". > > I did some cleanup in this function to hopefully make the code a bit > clearer. There was no blank line after the declaration block. The > closing curly brace on the f

Re: [PATCH net-next 0/8] mptcp: Add genl events for connection info

2021-02-13 Thread David Miller
From: Mat Martineau Date: Fri, 12 Feb 2021 20:46:30 -0800 (PST) > On Fri, 12 Feb 2021, Mat Martineau wrote: > >> This series from the MPTCP tree adds genl multicast events that are >> important for implementing a userspace path manager. In MPTCP, a path >> manager is responsible for adding or re

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread David Miller
From: Nobuhiro Iwamatsu Date: Thu, 11 Feb 2021 01:29:52 +0900 > +static int visconti_eth_init_hw(struct platform_device *pdev, struct > plat_stmmacenet_data *plat_dat) > +{ > + struct visconti_eth *dwmac; > + unsigned int reg_val, clk_sel_val; Please use reverse christmas tree ordering

Re: [PATCH net v3] ibmvnic: fix a race between open and reset

2021-02-10 Thread David Miller
For some reason git am thinks this is an empty patch when I pull it out of patchwork. Please fiux that and resubmit, thank you.

Re: [PATCH v3 net-next 07/11] net: prep switchdev drivers for concurrent SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS

2021-02-10 Thread David Miller
From: Vladimir Oltean Date: Wed, 10 Feb 2021 11:14:41 +0200 > From: Vladimir Oltean > > Because the bridge will start offloading SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS > while not serialized by any lock such as the br->lock spinlock, existing > drivers that treat that attribute and cache the brpor

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-10 Thread David Miller
From: Steen Hegelund Date: Wed, 10 Feb 2021 09:52:53 +0100 > Provide new phy configuration interfaces for media type and speed that > allows allows e.g. PHYs used for ethernet to be configured with this > information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-b

Re: [PATCH v12 net-next 12/15] net: mvpp2: add BM protection underrun feature support

2021-02-10 Thread David Miller
From: Date: Wed, 10 Feb 2021 11:48:17 +0200 > > +static int bm_underrun_protect = 1; > + > +module_param(bm_underrun_protect, int, 0444); > +MODULE_PARM_DESC(bm_underrun_protect, "Set BM underrun protect feature > (0-1), def=1"); No new module parameters, please.

[GIT] Networking

2021-02-09 Thread David Miller
Another pile of networing fixes: 1) ath9k build error fix from Arnd Bergmann 2) dma memory leak fix in mediatec driver from Lorenzo Bianconi. 3) bpf int3 kprobe fix from Alexei Starovoitov. 4) bpf stackmap integer overflow fix from Bui Quang Minh. 5) Add usb device ids for Cinterion MV31 to

Re: [PATCH net-next V3 0/2] net: ks8851: Add KS8851 PHY support

2021-01-05 Thread David Miller
From: Marek Vasut Date: Tue, 5 Jan 2021 15:11:49 +0100 > The KS8851 has a reduced internal PHY, which is accessible through its > registers at offset 0xe4. The PHY is compatible with KS886x PHY present > in Micrel switches, including the PHY ID Low/High registers swap, which > is present both in

Re: [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread David Miller
From: Michael Ellerman Date: Tue, 5 Jan 2021 20:15:15 +1100 > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in > drivers/net/ethernet/freescale/fs_enet/mii-fec.o > ERRO

Re: [PATCH net v2] macvlan: remove redundant null check on data

2021-01-05 Thread David Miller
From: wangyunjian Date: Tue, 5 Jan 2021 14:31:34 +0800 > From: Yunjian Wang > > Because macvlan_common_newlink() and macvlan_changelink() already > checked NULL data parameter, so the additional check is unnecessary, > just remove it. > > Fixes: 79cf79abce71 ("macvlan: add source mode") > Sign

Re: [PATCH net,stable v3] net: cdc_ncm: correct overhead in delayed_ndp_size

2021-01-05 Thread David Miller
From: Jouni Seppänen Date: Tue, 5 Jan 2021 06:52:49 +0200 > From: Jouni K. Seppänen > > Aligning to tx_ndp_modulus is not sufficient because the next align > call can be cdc_ncm_align_tail, which can add up to ctx->tx_modulus + > ctx->tx_remainder - 1 bytes. This used to lead to occasional cra

Re: [PATCH v2] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-05 Thread David Miller
From: Qinglang Miao Date: Tue, 5 Jan 2021 13:57:54 +0800 > A null-ptr-deref bug is reported by Hulk Robot like this: > -- > KASAN: null-ptr-deref in range [0x0128-0x012f] > Call Trace: > qrtr_ns_remove+0x22/0x40 [ns] > qrtr_proto_fini+0xa/0x31 [qrtr] > __x64_sy

Re: [PATCH net 0/3] net: hns3: fixes for -net

2021-01-05 Thread David Miller
From: Huazhong Tan Date: Tue, 5 Jan 2021 11:37:25 +0800 > There are some bugfixes for the HNS3 ethernet driver. Series applies and queued up for -stable, thanks

Re: [PATCH net v2] docs: net: fix documentation on .ndo_get_stats

2021-01-05 Thread David Miller
From: Jakub Kicinski Date: Mon, 4 Jan 2021 17:22:24 -0800 > Fix calling context. > > Signed-off-by: Jakub Kicinski Applied, thanks.

Re: [PATCH net] net: vlan: avoid leaks on register_vlan_dev() failures

2021-01-05 Thread David Miller
From: Jakub Kicinski Date: Wed, 30 Dec 2020 19:40:27 -0800 > VLAN checks for NETREG_UNINITIALIZED to distinguish between > registration failure and unregistration in progress. > > Since commit cb626bf566eb ("net-sysfs: Fix reference count leak") > registration failure may, however, result in NET

Re: [PATCH net] net: suggest L2 discards be counted towards rx_dropped

2021-01-05 Thread David Miller
From: Jakub Kicinski Date: Wed, 30 Dec 2020 19:37:53 -0800 > From the existing definitions it's unclear which stat to > use to report filtering based on L2 dst addr in old > broadcast-medium Ethernet. > > Signed-off-by: Jakub Kicinski Applied.

Re: [PATCH net-next] net: nfc: nci: Change the NCI close sequence

2021-01-05 Thread David Miller
From: Bongsu Jeon Date: Mon, 28 Dec 2020 10:46:31 +0900 > From: Bongsu Jeon > > Change the NCI close sequence because the NCI Command timer should be > deleted after flushing the NCI command work queue. > > Signed-off-by: Bongsu Jeon Applied.

Re: [PATCH] neighbour: Disregard DEAD dst in neigh_update

2021-01-05 Thread David Miller
From: Tong Zhu Date: Wed, 30 Dec 2020 17:54:23 -0500 > In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated > with loopback net_device and leads to loopback neighbour. It > leads to an ethernet header with all zero addresses. > > A very troubling case is working with mac80211 and ath9k.

Re: [PATCH v3 net-next] net: kcm: Replace fput with sockfd_put

2021-01-05 Thread David Miller
From: Zheng Yongjun Date: Wed, 30 Dec 2020 17:18:09 +0800 > The function sockfd_lookup uses fget on the value that is stored in > the file field of the returned structure, so fput should ultimately be > applied to this value. This can be done directly, but it seems better > to use the specific m

Re: [PATCH net-next] net/mlxfw: Use kzalloc for allocating only one thing

2021-01-05 Thread David Miller
From: Zheng Yongjun Date: Wed, 30 Dec 2020 16:18:35 +0800 > Use kzalloc rather than kcalloc(1,...) > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > @@ > > - kcalloc(1, > + kzalloc( > ...) > // > > Signed-off-by: Zheng Yongju

Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths

2021-01-05 Thread David Miller
From: Finn Thain Date: Sun, 03 Jan 2021 11:26:26 +1100 > From: Christophe JAILLET > > A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors(). > > This is correctly freed in the remove function, but not in the error > handling path of the probe function. Fix this by adding the m

Re: [PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0.

2021-01-05 Thread David Miller
From: YANG LI Date: Wed, 30 Dec 2020 14:07:30 +0800 > The warning was because of the following line in function > liquidio_set_fec(): > > retval = wait_for_sc_completion_timeout(oct, sc, 0); > if (retval) > return (-EIO); > > If this statement is not true, retval must be 0 and not upd

Re: [pull request][net-next 00/16] mlx5 SW steering updates 2021-01-05

2021-01-05 Thread David Miller
From: Saeed Mahameed Date: Tue, 5 Jan 2021 15:03:17 -0800 > From: Saeed Mahameed > > Hi Jakub, Dave > > This series introduces some refactoring to SW steering to support > different formats of different Hardware. > For more information please see tag log below. > > Please pull and let me kno

Re: [PATCH net-next v3] net: mhi: Add raw IP mode support

2021-01-05 Thread David Miller
From: Loic Poulain Date: Tue, 29 Dec 2020 10:04:54 +0100 > MHI net is protocol agnostic, the payload protocol depends on the modem > configuration, which can be either RMNET (IP muxing and aggregation) or > raw IP. This patch adds support for incomming IPv4/IPv6 packets, that > was previously unc

Re: [PATCH RESEND net-next 0/4] enetc: code cleanups

2021-01-05 Thread David Miller
From: Michael Walle Date: Mon, 28 Dec 2020 14:00:30 +0100 > This are some code cleanups in the MDIO part of the enetc. They are > intended to make the code more readable. Series applied, thank you.

Re: pull-request: bpf 2020-12-28

2020-12-28 Thread David Miller
From: Daniel Borkmann Date: Mon, 28 Dec 2020 22:28:30 +0100 > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > There is a small merge conflict between bpf tree commit 69ca310f3416 > ("bpf: Save correct stopping point in file seq iteration") and ne

Re: [PATCH v4] net: neighbor: fix a crash caused by mod zero

2020-12-28 Thread David Miller
From: weichenchen Date: Fri, 25 Dec 2020 13:44:45 +0800 > pneigh_enqueue() tries to obtain a random delay by mod > NEIGH_VAR(p, PROXY_DELAY). However, NEIGH_VAR(p, PROXY_DELAY) > migth be zero at that point because someone could write zero > to /proc/sys/net/ipv4/neigh/[device]/proxy_delay after

Re: [PATCH net] ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst()

2020-12-28 Thread David Miller
From: Guillaume Nault Date: Thu, 24 Dec 2020 20:01:09 +0100 > RT_TOS() only clears one of the ECN bits. Therefore, when > fib_compute_spec_dst() resorts to a fib lookup, it can return > different results depending on the value of the second ECN bit. > > For example, ECT(0) and ECT(1) packets cou

Re: [PATCH net v2] net: hdlc_ppp: Fix issues when mod_timer is called while timer is running

2020-12-28 Thread David Miller
From: Xie He Date: Sun, 27 Dec 2020 18:53:39 -0800 > ppp_cp_event is called directly or indirectly by ppp_rx with "ppp->lock" > held. It may call mod_timer to add a new timer. However, at the same time > ppp_timer may be already running and waiting for "ppp->lock". In this > case, there's no need

Re: [PATCH v2] atlantic: remove architecture depends

2020-12-28 Thread David Miller
From: dftxb...@free.fr Date: Sun, 27 Dec 2020 17:11:36 +0100 > From: Léo Le Bouter > > This was tested on a RaptorCS Talos II with IBM POWER9 DD2.2 CPUs and an > ASUS XG-C100F PCI-e card without any issue. Speeds of ~8Gbps could be > attained with not-very-scientific (wget HTTP) both-ways measur

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2020-12-28 Thread David Miller
From: Defang Bo Date: Sun, 27 Dec 2020 22:11:35 +0800 > Similar to commit<2423496af35>, the fragmentation code tries to parse the > header options in order > to figure out where to insert the fragment option. Since nexthdr points > to an invalid option, the calculation of the size of the networ

Re: [Patch net] erspan: fix version 1 check in gre_parse_header()

2020-12-28 Thread David Miller
From: Cong Wang Date: Sat, 26 Dec 2020 15:44:53 -0800 > From: Cong Wang > > Both version 0 and version 1 use ETH_P_ERSPAN, but version 0 does not > have an erspan header. So the check in gre_parse_header() is wrong, > we have to distinguish version 1 from version 0. > > We can just check the g

Re: [PATCH -net] net: sched: prevent invalid Scell_log shift count

2020-12-28 Thread David Miller
From: Randy Dunlap Date: Thu, 24 Dec 2020 22:23:44 -0800 > Check Scell_log shift size in red_check_params() and modify all callers > of red_check_params() to pass Scell_log. > > This prevents a shift out-of-bounds as detected by UBSAN: > UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22

Re: [PATCH net v2] net: hns: fix return value check in __lb_other_process()

2020-12-28 Thread David Miller
From: wangyunjian Date: Sat, 26 Dec 2020 16:10:05 +0800 > From: Yunjian Wang > > The function skb_copy() could return NULL, the return value > need to be checked. > > Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet > support") > Signed-off-by: Yunjian Wang Applied

Re: [PATCH net-next V8] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-12-15 Thread David Miller
From: Dmytro Shytyi Date: Wed, 09 Dec 2020 04:27:54 +0100 > Variable SLAAC [Can be activated via sysctl]: > SLAAC with prefixes of arbitrary length in PIO (randomly > generated hostID or stable privacy + privacy extensions). > The main problem is that SLAAC RA or PD allocates a /64 by the Wirele

Fw: [GIT] Networking

2020-12-10 Thread David Miller
Typod this lists addr first two times, third times the cgarm I suppose. --- Begin Message --- 1) IPsec compaat fixes, from Dmitrey Safonov. 2) Fix memory leak in xfrm_user_policy(). Fix from Yu Kuai. 3) Fix polling in xsk sockets by using sk_poll_wait() instead of datagram_poll() which key

Re: [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels

2020-12-10 Thread David Miller
From: Tom Parkin Date: Thu, 10 Dec 2020 17:16:45 + > On Thu, Dec 10, 2020 at 18:13:09 +0100, Guillaume Nault wrote: >> On Thu, Dec 10, 2020 at 03:50:56PM +, Tom Parkin wrote: >> > Following on from my previous RFC[1], this series adds two ioctl calls >> > to the ppp code to implement "ch

Re: pull-request: bpf 2020-12-10

2020-12-10 Thread David Miller
From: Alexei Starovoitov Date: Thu, 10 Dec 2020 14:25:01 -0800 > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 21 non-merge commits during the last 12 day(s) which contain > a total of 21 files changed, 163 insertions(+), 88 deletio

Re: [PATCH net-next] rtnetlink: RCU-annotate both dimensions of rtnl_msg_handlers

2020-12-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Dec 2020 18:16:08 -0800 > We use rcu_assign_pointer to assign both the table and the entries, > but the entries are not marked as __rcu. This generates sparse > warnings. > > Signed-off-by: Jakub Kicinski > --- Applied.

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2020-12-10 Thread David Miller
From: Willy Tarreau Date: Wed, 9 Dec 2020 19:47:40 +0100 > This reverts commit 0a4e9ce17ba77847e5a9f87eed3c0ba46e3f82eb. > > The code was developed and tested on an MSC313E SoC, which seems to be > half-way between the AT91RM9200 and the AT91SAM9260 in that it supports > both the 2-descriptors

Re: [PATCH net-next] net: qualcomm: rmnet: Update rmnet device MTU based on real device

2020-12-10 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 9 Dec 2020 22:51:46 -0700 > Packets sent by rmnet to the real device have variable MAP header > lengths based on the data format configured. This patch adds checks > to ensure that the real device MTU is sufficient to transmit the MAP > packet comp

Re: [PATCH net-next] net: lapbether: Consider it successful if (dis)connecting when already (dis)connected

2020-12-10 Thread David Miller
From: Xie He Date: Tue, 8 Dec 2020 14:50:44 -0800 > When the upper layer instruct us to connect (or disconnect), but we have > already connected (or disconnected), consider this operation successful > rather than failed. > > This can help the upper layer to correct its record about whether we a

Re: [net-next] tcp: correctly handle increased zerocopy args struct size

2020-12-10 Thread David Miller
From: Arjun Roy Date: Thu, 10 Dec 2020 11:16:03 -0800 > From: Arjun Roy > > A prior patch increased the size of struct tcp_zerocopy_receive > but did not update do_tcp_getsockopt() handling to properly account > for this. > > This patch simply reintroduces content erroneously cut from the > re

Re: [PATCH net-next] igc: Add new device ID

2020-12-10 Thread David Miller
From: Tony Nguyen Date: Thu, 10 Dec 2020 11:08:12 -0800 > From: Sasha Neftin > > Add new device ID for the next step of the silicon and > reflect the I226_K part. > > Signed-off-by: Sasha Neftin > Tested-by: Aaron Brown > Signed-off-by: Tony Nguyen > Applied.

Re: [PATCH net-next] net: mediatek: simplify the return expression of mtk_gmac_sgmii_path_setup()

2020-12-10 Thread David Miller
From: Zheng Yongjun Date: Thu, 10 Dec 2020 21:50:50 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied, thanks.

  1   2   3   4   5   6   7   8   9   10   >