Re: [PATCH net-next v2] net: phy: at803x: fix probe error if copper page is selected

2021-04-20 Thread David Bauer
an > error. > > Fixes: c329e5afb42f ("net: phy: at803x: select correct page on config init") > Signed-off-by: Michael Walle Reviewed-by: David Bauer Best David > --- > Changes since v1: > - take the bus lock > > drivers/net/phy/at803x.c | 23

[PATCH net-next v2] net: phy: at803x: select correct page on config init

2021-04-14 Thread David Bauer
selected by the bootloader. Notably, Ubiquiti UniFi bootloaders show this behavior. Select the copper page when probing to circumvent this. Signed-off-by: David Bauer --- Changes in v2: - rebase to latest net-next - squash both patches drivers/net/phy/at803x.c | 50

[PATCH net-next 2/2] net: phy: at803x: select correct page on config init

2021-04-14 Thread David Bauer
selected by the bootloader. Notably, Ubiquiti UniFi bootloaders show this behavior. Select the copper page when probing to circumvent this. Signed-off-by: David Bauer --- drivers/net/phy/at803x.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy

[PATCH net-next 1/2] net: phy: at803x: use paged reads

2021-04-14 Thread David Bauer
Refactor the page-switching in at803x_aneg_done to use paged reads as suggested by Andrew Lunn. This way, potential race conditions are avoided, as the MDIO lock was previously not taken. Suggested-by: Andrew Lunn Signed-off-by: David Bauer --- drivers/net/phy/at803x.c | 42

[PATCH v3 2/3] net: phy: add support for reset-controller

2019-04-17 Thread David Bauer
This commit adds support for PHY reset pins handled by a reset controller. Signed-off-by: David Bauer --- drivers/net/phy/mdio_bus.c| 27 +-- drivers/net/phy/mdio_device.c | 13 +++-- include/linux/mdio.h | 1 + 3 files changed, 37 insertions(+), 4

[PATCH v3 3/3] net: mdio: rename mdio_device reset to reset_gpio

2019-04-17 Thread David Bauer
This renames the GPIO reset of mdio devices from 'reset' to 'reset_gpio' to better differentiate between GPIO and reset-controller driven reset line. Signed-off-by: David Bauer --- drivers/net/phy/at803x.c | 2 +- drivers/net/phy/mdio_bus.c| 6 +++--- drivers/net/p

[PATCH v3 0/3] net: add reset-controller driven PHY reset

2019-04-17 Thread David Bauer
v3: - add missing newline in mdio_bus.c v2: - fixed missed rename of "reset" in at803x.c - move initial reset to mdio_device_reset David Bauer (3): dt-bindings: net: add PHY reset controller binding net: phy: add support for reset-controller net: mdio: rename mdio_device reset

[PATCH v3 1/3] dt-bindings: net: add PHY reset controller binding

2019-04-17 Thread David Bauer
Add the documentation for PHY reset lines controlled by a reset controller. Signed-off-by: David Bauer --- Documentation/devicetree/bindings/net/phy.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings

[PATCH v2 3/3] net: mdio: rename mdio_device reset to reset_gpio

2019-04-17 Thread David Bauer
This renames the GPIO reset of mdio devices from 'reset' to 'reset_gpio' to better differentiate between GPIO and reset-controller driven reset line. Reviewed-by: Andrew Lunn Signed-off-by: David Bauer --- drivers/net/phy/at803x.c | 2 +- drivers/net/phy/mdio_bus.c

[PATCH v2 0/3] net: add reset-controller driven PHY reset

2019-04-17 Thread David Bauer
This patchset adds support for a PHY reset driven by a reset-controller. Currently, only GPIO driven resets are supported by the PHY subsystem. v2: - fixed missed rename of "reset" in at803x.c - move initial reset to mdio_device_reset David Bauer (3): dt-bindings: net: add

[PATCH v2 2/3] net: phy: add support for reset-controller

2019-04-17 Thread David Bauer
This commit adds support for PHY reset pins handled by a reset controller. Reviewed-by: Andrew Lunn Signed-off-by: David Bauer --- drivers/net/phy/mdio_bus.c| 26 -- drivers/net/phy/mdio_device.c | 13 +++-- include/linux/mdio.h | 1 + 3 files

[PATCH v2 1/3] dt-bindings: net: add PHY reset controller binding

2019-04-17 Thread David Bauer
Add the documentation for PHY reset lines controlled by a reset controller. Reviewed-by: Andrew Lunn Signed-off-by: David Bauer --- Documentation/devicetree/bindings/net/phy.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/phy.txt b

[PATCH 1/3] dt-bindings: net: add PHY reset controller binding

2019-04-15 Thread David Bauer
Add the documentation for PHY reset lines controlled by a reset controller. Signed-off-by: David Bauer --- Documentation/devicetree/bindings/net/phy.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings

[PATCH 3/3] net: mdio: rename mdio_device reset to reset_gpio

2019-04-15 Thread David Bauer
This renames the GPIO reset of mdio devices from 'reset' to 'reset_gpio' to better differentiate between GPIO and reset-controller driven reset line. Signed-off-by: David Bauer --- drivers/net/phy/mdio_bus.c| 6 +++--- drivers/net/phy/mdio_device.c | 6 +++---

[PATCH 2/3] net: phy: add support for reset-controller

2019-04-15 Thread David Bauer
This commit adds support for PHY reset pins handled by a reset controller. Signed-off-by: David Bauer --- drivers/net/phy/mdio_bus.c| 25 + drivers/net/phy/mdio_device.c | 13 +++-- include/linux/mdio.h | 1 + 3 files changed, 37 insertions(+), 2