Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-10-15 Thread Dave Stevenson
Hi Eric. On Mon, 15 Oct 2018 at 16:42, Eric Dumazet wrote: > > On Mon, Oct 15, 2018 at 8:15 AM Stephen Hemminger > wrote: > > > > > > > > Begin forwarded message: > > > > Date: Sun, 14 Oct 2018 10:42:48 + > > From: bugzilla-dae...@bugzilla.kernel.org > > To: step...@networkplumber.org > > Su

[PATCH 3/4] net: lan78xx: Add support for VLAN tag stripping.

2018-06-25 Thread Dave Stevenson
The chip supports stripping the VLAN tag and reporting it in metadata. Complete the support for this. Signed-off-by: Dave Stevenson --- drivers/net/usb/lan78xx.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c

[PATCH 0/4] lan78xx minor fixes

2018-06-25 Thread Dave Stevenson
the h/w VLAN stripping. Dave Stevenson (4): net: lan78xx: Allow for VLAN headers in timeout calcs net: lan78xx: Add support for VLAN filtering. net: lan78xx: Add support for VLAN tag stripping. net: lan78xx: Use s/w csum check on VLANs without tag stripping drivers/net/usb/lan78xx.c | 37

[PATCH 1/4] net: lan78xx: Allow for VLAN headers in timeout calcs

2018-06-25 Thread Dave Stevenson
The frame abort timeout being set by lan78xx_set_rx_max_frame_length didn't account for any VLAN headers, resulting in very low throughput if used with tagged VLANs. Use VLAN_ETH_HLEN instead of ETH_HLEN to correct for this. Signed-off-by: Dave Stevenson --- drivers/net/usb/lan78xx.

[PATCH 4/4] net: lan78xx: Use s/w csum check on VLANs without tag stripping

2018-06-25 Thread Dave Stevenson
Observations of VLANs dropping packets due to invalid checksums when not offloading VLAN tag receive. With VLAN tag stripping enabled no issue is observed. Drop back to s/w checksums if VLAN offload is disabled. Signed-off-by: Dave Stevenson --- drivers/net/usb/lan78xx.c | 7 ++- 1 file

[PATCH 2/4] net: lan78xx: Add support for VLAN filtering.

2018-06-25 Thread Dave Stevenson
HW_VLAN_CTAG_FILTER was partially implemented, but not advertised to Linux. Complete the implementation of this. Signed-off-by: Dave Stevenson --- drivers/net/usb/lan78xx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb