Re: [PATCH 0/5] virtio_net: enable premapped mode by default

Hi Michael / Xuan Zhuo, On Wednesday, 2024-10-16 at 08:55:21 +01, Darren Kenny wrote: > Hi Michael, > > On Monday, 2024-10-14 at 00:57:41 -04, Michael S. Tsirkin wrote: >> On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote: >>> In the last linux version, we disabled

Re: [PATCH 0/5] virtio_net: enable premapped mode by default

Hi Michael, On Monday, 2024-10-14 at 00:57:41 -04, Michael S. Tsirkin wrote: > On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote: >> In the last linux version, we disabled this feature to fix the >> regress[1]. >> >> The patch set is try to fix the problem and re-enable it. >> >> More in

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

For the record, I got a chance to test these changes and confirmed that they resolved the issue for me when applied on 6.11-rc7. Tested-by: Darren Kenny Thanks, Darren. PS - I'll try get to looking at the other potential fix when I have time. On Tuesday, 2024-09-10 at 08:12:06 -04, Mich

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

Hi, Apologies, I've been OOTO for the best part of 2 weeks, I'll try get to this as soon as I can, but playing catch-up right now. Thanks, Darren. On Saturday, 2024-09-07 at 12:16:24 +09, Takero Funaki wrote: > 2024年9月6日(金) 18:55 Michael S. Tsirkin : >> >> On Fri, Sep 06, 2024 at 05:46:02PM +08

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

Hi Michael, On Tuesday, 2024-08-20 at 12:50:39 -04, Michael S. Tsirkin wrote: > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: >> leads to regression on VM with the sysctl value of: >> >> - net.core.high_order_alloc_disable=1 > > > > >> which could see reliable crashes or scp failur

Re: [PATCH net V2] vhost: correctly remove wait queue during poll failure

eue to make sure it won't be freed twice. Cc: Darren Kenny Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend") Signed-off-by: Jason Wang Reviewed-by: Darren Kenny --- Changes from V1:

Re: [PATCH net] vhost: correctly remove wait queue during poll failure

Hi Jason, On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. This text seems at odds with t

Re: [PATCH] vhost: fix vhost ioctl signature to build with clang

ioctl(). Signed-off-by: Sonny Rao Reviewed-by: Darren Kenny All the other callers of this function already appear to assume that it is an unsigned int. Thanks, Darren. --- drivers/vhost/vhost.c | 2 +- drivers/vhost/vhost.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --