Re: [PATCH 0/3] fix reuseaddr regression

2017-09-18 Thread Cole Robinson
On 09/18/2017 12:28 PM, jo...@toxicpanda.com wrote: > I introduced a regression when reworking the fastreuse port stuff that allows > bind conflicts to occur once a reuseaddr socket successfully opens on an > existing tb. The root cause is I reversed an if statement which caused us to > set the tb

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-17 Thread Cole Robinson
On 09/15/2017 01:51 PM, Josef Bacik wrote: > Finally got access to a box to run this down myself. This patch on top of > the other patches fixes the problem for me, could you verify it works for > you? Thanks, > Yup I can confirm that patch fixes things when applied on top of the previous 3 p

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Cole Robinson
On 09/13/2017 03:44 PM, Josef Bacik wrote: > Alright thanks, this should fix it. > Still no luck with all three patches applied to fedora 4.12.8-300 RPM. Pretty sure I didn't mess up the testing but since I rarely do kernel builds it's not impossible... Thanks, Cole

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Cole Robinson
On 09/13/2017 01:40 PM, Cole Robinson wrote: > On 09/13/2017 01:28 PM, Josef Bacik wrote: >> Sorry I thought I had made this other fix, can you apply this on top of the >> other one and try that? I have more things to try if this doesn’t work, >> sorry you are playing go b

Re: 319554f284dd ("inet: don't use sk_v6_rcv_saddr directly") causes bind port regression

2017-09-13 Thread Cole Robinson
On 09/13/2017 01:28 PM, Josef Bacik wrote: > Sorry I thought I had made this other fix, can you apply this on top of the > other one and try that? I have more things to try if this doesn’t work, > sorry you are playing go between, but I want to make sure I know _which_ fix > actually fixes the