Re: [PATCH v2] tools: do not include scripts/Kbuild.include

2021-04-16 Thread Christian Borntraeger
.include. Link: https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f4...@linux.ibm.com/ Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler") Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada looks better. Tested-by: Christian Borntraeger

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Christian Borntraeger
On 15.04.21 10:06, Christian Borntraeger wrote: On 15.04.21 09:27, Masahiro Yamada wrote: Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler"), some kselftests fail to build. The tools/ directory opted out Kbuild, and went in a different

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Christian Borntraeger
Link: https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f4...@linux.ibm.com/ Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler") Reported-by: Janosch Frank Reported-by: Christian Borntraeger Signed-off-by: Masahiro Yamada When applyin

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Christian Herber
On 4/13/2021 3:57 PM, Andrew Lunn wrote: Ok, we can agree that there will not be a perfect naming. Would it be a possibility to rename the existing TJA11xx driver to TJA1100-1-2 or is that unwanted? It is generally a bad idea. It makes back porting fixing harder if the file changes name. If n

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-13 Thread Christian Herber
On 4/13/2021 3:30 PM, Andrew Lunn wrote: On Tue, Apr 13, 2021 at 08:56:30AM +0200, Christian Herber wrote: Hi Andrew, On 4/12/2021 6:52 PM, Andrew Lunn wrote: So what you are say is, you don't care if the IP is completely different, it all goes in one driver. So lets put this driver

Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-13 Thread Christian Brauner
On Tue, Apr 13, 2021 at 03:08:48AM -0400, Jonathon Reinhart wrote: > Currently, tcp_allowed_congestion_control is global and writable; > writing to it in any net namespace will leak into all other net > namespaces. > > tcp_available_congestion_control and tcp_allowed_congestion_control are > the o

Re: Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-12 Thread Christian Herber
1xx is creating more issues, as it assumes that the devices which are managed by the driver are always TJA... devices which may not be true. Christian

[PATCH] erspan/erspan6: fix JSON output

2021-04-09 Thread Christian Poessinger
The format for erspan/erspan6 output is not valid JSON, as on version 2 a valueless key was presented. The direction should be value and erspan_dir should be the key. Fixes: 289763626721 ("erspan: add erspan version II support") Cc: u9012...@gmail.com Cc: Stephen Hemminger Reported-by:

Re: [PATCH net-next v4] net: Allow to specify ifindex when device is moved to another namespace

2021-04-08 Thread Christian Brauner
where they have to > be restored, then CRIU will restore network namespaces and move devices > into them. The problem is that devices have to be restored with the same > indexes that they have before C/R. > > Cc: Alexander Mikhalitsyn > Suggested-by: Christian Brauner > Reviewed

Re: [PATCH iproute2] erspan: fix JSON output

2021-04-07 Thread Christian Pössinger
On Tue, Apr 6, 2021 at 9:28 AM Stephen Hemminger wrote: > > The format for erspan output is not valid JSON. > The direction should be value and erspan_dir should be the key. > > Fixes: 289763626721 ("erspan: add erspan version II support") > Cc: u9012...@gmail.

iproute2 ERSPAN version 2 JSON output shows valueless key

2021-04-06 Thread Christian Pössinger
e one from Python) I have tested this with the following iproute2 versions: iproute2-5.11.0 iproute2-5.9.0 If you can point me to the location which could be responsible for this issue, I am happy to submit a fix to the net tree. Thanks in advance, Christian Poessinger

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Christian Melki
On 4/5/21 2:09 PM, Heiner Kallweit wrote: > On 05.04.2021 10:43, Christian Melki wrote: >> On 4/5/21 12:48 AM, Heiner Kallweit wrote: >>> On 04.04.2021 16:09, Heiner Kallweit wrote: >>>> On 04.04.2021 12:07, Joakim Zhang wrote: >>>>> commit 4c0d2e96ba

Re: [PATCH] net: Allow to specify ifindex when device is moved to another namespace

2021-04-05 Thread Christian Brauner
where they have to > be restored, then CRIU will restore network namespaces and move devices > into them. The problem is that devices have to be restored with the same > indexes that they have before C/R. > > Cc: Alexander Mikhalitsyn > Suggested-by: Christian Brauner > Signed-of

Re: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-05 Thread Christian Melki
On 4/5/21 12:48 AM, Heiner Kallweit wrote: > On 04.04.2021 16:09, Heiner Kallweit wrote: >> On 04.04.2021 12:07, Joakim Zhang wrote: >>> commit 4c0d2e96ba055 ("net: phy: consider that suspend2ram may cut >>> off PHY power") invokes phy_init_hw() when MDIO bus resume, it will >>> soft reset PHY if P

Re: [PATCH] carl9170: remove get_tid_h

2021-04-02 Thread Christian Lamparter
On 02/04/2021 23:31, Christophe JAILLET wrote: 'get_tid_h()' is the same as 'ieee80211_get_tid()'. So this function can be removed to save a few lines of code. Signed-off-by: Christophe JAILLET Acked-by: Christian Lamparter --- drivers/net/wireless/ath/car

Re: [PATCH net-next] net: Allow to specify ifindex when device is moved to another namespace

2021-04-02 Thread Christian Brauner
er Mikhalitsyn > Suggested-by: Christian Brauner > Signed-off-by: Andrei Vagin > --- Thank you for doing this! This will really help a lot of people with using CRIU's network dump+restore capabilities. It might be worth to point out that the ifindex of a netdev can already change d

Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Christian Brauner
On Wed, Mar 31, 2021 at 09:59:07PM +0800, Yongji Xie wrote: > On Wed, Mar 31, 2021 at 8:23 PM Christian Brauner > wrote: > > > > On Wed, Mar 31, 2021 at 07:32:33PM +0800, Yongji Xie wrote: > > > On Wed, Mar 31, 2021 at 5:15 PM Christian Brauner > > > wrote:

Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Christian Brauner
On Wed, Mar 31, 2021 at 07:32:33PM +0800, Yongji Xie wrote: > On Wed, Mar 31, 2021 at 5:15 PM Christian Brauner > wrote: > > > > On Wed, Mar 31, 2021 at 04:05:10PM +0800, Xie Yongji wrote: > > > Export receive_fd() so that some modules can use > > > it to pa

Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Christian Brauner
On Wed, Mar 31, 2021 at 12:26:24PM +0300, Dan Carpenter wrote: > On Wed, Mar 31, 2021 at 11:15:45AM +0200, Christian Brauner wrote: > > On Wed, Mar 31, 2021 at 04:05:10PM +0800, Xie Yongji wrote: > > > Export receive_fd() so that some modules can use > > > it to p

Re: [PATCH v6 01/10] file: Export receive_fd() to modules

2021-03-31 Thread Christian Brauner
On Wed, Mar 31, 2021 at 04:05:10PM +0800, Xie Yongji wrote: > Export receive_fd() so that some modules can use > it to pass file descriptor between processes without > missing any security stuffs. > > Signed-off-by: Xie Yongji > --- Yeah, as I said in the other mail I'd be comfortable with expos

Re: [PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-22 Thread Christian Brauner
nction fails. > > Add a separate NULL check to tell gcc about it as well. > > Signed-off-by: Arnd Bergmann > --- Seems reasonable, Acked-by: Christian Brauner

Re: [PATCH v5 01/11] file: Export __receive_fd() to modules

2021-03-15 Thread Christian Brauner
ging the syscalls of another task. Drivers swapping out fds doesn't sound like a good idea to me. Christian

Re: [PATCH bpf 2/4] nsfs: add an ioctl to discover the network namespace cookie

2021-03-02 Thread Christian Brauner
On Tue, Mar 02, 2021 at 09:47:10AM +, Lorenz Bauer wrote: > On Mon, 1 Mar 2021 at 10:04, Christian Brauner > wrote: > > > > Hey Lorenz, > > > > Just to make sure: is it intentional that any user can retrieve the > > cookie associated with any network n

Triggering WARN in net/wireless/nl80211.c

2021-03-02 Thread Christian Brauner
:6a:a7:16:8c:cb [ 36.861423] iwlwifi :02:00.0: Applying debug destination EXTERNAL_DRAM [ 36.993832] iwlwifi :02:00.0: Applying debug destination EXTERNAL_DRAM [ 37.061293] iwlwifi :02:00.0: FW already configured (0) - re-configuring Thanks! Christian

Re: [PATCH bpf 2/4] nsfs: add an ioctl to discover the network namespace cookie

2021-03-01 Thread Christian Brauner
cookie associated with any network namespace, i.e. you don't require any form of permission checking in the owning user namespace of the network namespace? Christian

[PATCH v3 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081

2021-02-24 Thread Christian Melki
this implementation during a 4.9.x to 5.4.x LTS transition. I think it's a good thing to remove unwanted soft resets but wonder if it did open a can of worms? Atleast this fixes one iMX6 FEC/RMII/8081 combo. Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") Signed-off

[PATCH v2 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081

2021-02-23 Thread Christian Melki
tgus implementation during a 4.9.x to 5.4.x LTS transition. I think it's a good thing to remove unwanted soft resets but wonder if it did open a can of worms? Atleast this fixes one iMX6 FEC/RMII/8081 combo. Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") Signed-off

[PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081

2021-02-18 Thread Christian Melki
with implementation during a 4.9.x to 5.4.x LTS transition. I think it's a good thing to remove unwanted soft resets but wonder if it did open a can of worms? Atleast this fixes one iMX6 FEC/RMII/8081 combo. Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") Signed-off

Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood

2021-02-15 Thread Christian König
: Christian König to the series. But looking at the use cases for this, wouldn't it make more sense to teach kprintf some new format modifier for this? Christian. --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +- drivers/gpu/drm/i915/i915_utils.h

Re: [PATCH] carl9170: fix struct alignment conflict

2021-02-04 Thread Christian Lamparter
ructures to only apply packing where it does not violate the alignment requirement of the contained structure. Signed-off-by: Arnd Bergmann Acked-by: Christian Lamparter I've also applied this patch and a previous one dealing with VLAs to the firmware source at <https://github.com/chunk

Re: [PATCH net-next] net: core: Namespace-ify sysctl_wmem_default and sysctl_rmem_default

2021-01-18 Thread Christian Brauner
hich makes it way easier to figure out what to apply it to when wanting to review a series in the larger context of a tree. Thanks! Christian

Re: [PATCH net 3/3] net: ip: always refragment ip defragmented packets

2021-01-06 Thread Christian Perle
gt; 2.26.2 Did some tests yesterday and I can confirm that this patch fixes the problem for both IPIP tunnel and XFRM tunnel interfaces. Thanks for the fix! Christian Perle -- Christian Perle Senior Berater / Senior Consultant Netzwerk- und Client-Sicherheit / Network & Client Security Öffen

BUG: IPv4 conntrack reassembles forwarded packets

2021-01-05 Thread Christian Perle
6, using reassembly for conntrack reasons *only* and not forwarding the reassembly result but the original fragments. Regards, Christian Perle -- Christian Perle Senior Berater / Senior Consultant Netzwerk- und Client-Sicherheit / Network & Client Security Öffentliche Auftraggeber / Public A

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
On Thursday, 3 December 2020, 16:52:46 CET, Vladimir Oltean wrote: > On Thu, 3 Dec 2020 at 17:36, Christian Eggers wrote: > > Should ptp_sysfs be extended with a "pulse" attribute with calls > > enable() with only PTP_PEROUT_DUTY_CYCLE set? > > Use tools/testing

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
On Thursday, 3 December 2020, 15:12:55 CET, Richard Cochran wrote: > On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote: > > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to > > generate periodic signals. > > > > The pulse length can be alt

[PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Christian Eggers
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to generate periodic signals. The pulse length can be altered via a device attribute. Tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- Changes in v4: -- - 80 chars per line - reverse christmas

[PATCH net-next v5 8/9] net: dsa: microchip: ksz9477: remaining hardware time stamping support

2020-12-03 Thread Christian Eggers
this field is negative. Of course, the UDP checksums (if any) have to be corrected after this (for both directions). Everything has been tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- Changes in v5: -- - Fix compile error reported by kernel test robot

[PATCH net-next v5 7/9] net: dsa: microchip: ksz9477: initial hardware time stamping support

2020-12-03 Thread Christian Eggers
details: https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-cegg...@arri.de/ Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- Changes in v4: -- - Remove useless case statement - Reviewed-by: Vladimir Oltean drivers/net/dsa/microchip/ksz9477_main.c

[PATCH net-next v5 6/9] net: ptp: add helper for one-step P2P clocks

2020-12-03 Thread Christian Eggers
tail-tag is set to zero) or move the value from the correction field back to the tail-tag. Changing the correction field requires updating the UDP checksum (if UDP is used as transport). Signed-off-by: Christian Eggers --- include/linux/ptp_classify.h | 73 1

[PATCH net-next v5 5/9] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock

2020-12-03 Thread Christian Eggers
Implement routines (adjfine, adjtime, gettime and settime) for manipulating the chip's PTP clock. Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Kconfig| 8 + drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/micr

[PATCH net-next v5 3/9] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init()

2020-12-03 Thread Christian Eggers
The next patch will add basic interrupt support. Chip reset must be performed before requesting the IRQ, so move this from ksz9477_setup() to ksz9477_init(). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz9477_main.c | 15 +++ 1 file

[PATCH net-next v5 4/9] net: dsa: microchip: ksz9477: basic interrupt support

2020-12-03 Thread Christian Eggers
Interrupts are required for TX time stamping. Probably they could also be used for PHY connection status. This patch only adds the basic infrastructure for interrupts, no interrupts are finally enabled nor handled. Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- Changes in v4

[PATCH net-next v5 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property

2020-12-03 Thread Christian Eggers
The devices have an optional interrupt line. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree

[PATCH net-next v5 0/9] net: dsa: microchip: PTP support for KSZ956x

2020-12-03 Thread Christian Eggers
[1] http://ww1.microchip.com/downloads/en/DeviceDoc/KSZ9563R-Data-Sheet-DS2419D.pdf Changes from v4 --> v5 [8/9]- Fix compile error reported by kernel test robot (NET_DSA_TAG_KSZ must select NET_PTP_CLASSIFY) Changes from v3 --> v4 -

[PATCH net-next v5 1/9] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c

2020-12-03 Thread Christian Eggers
PTP functionality will be built into a separate source file (ksz9477_ptp.c). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0 2 files changed, 1 insert

[PATCH net-next v4 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-01 Thread Christian Eggers
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to generate periodic signals. The pulse length can be altered via a device attribute. Tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- Changes in v4: -- - 80 chars per line - reverse christmas

[PATCH net-next v4 8/9] net: dsa: microchip: ksz9477: remaining hardware time stamping support

2020-12-01 Thread Christian Eggers
this field is negative. Of course, the UDP checksums (if any) have to be corrected after this (for both directions). Everything has been tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- Changes in v4: -- - s/low active/active low/ - 80 chars per line - Use IEEE

[PATCH net-next v4 7/9] net: dsa: microchip: ksz9477: initial hardware time stamping support

2020-12-01 Thread Christian Eggers
details: https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-cegg...@arri.de/ Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- Changes in v4: -- - Remove useless case statement - Reviewed-by: Vladimir Oltean drivers/net/dsa/microchip/ksz9477_main.c

[PATCH net-next v4 6/9] net: ptp: add helper for one-step P2P clocks

2020-12-01 Thread Christian Eggers
tail-tag is set to zero) or move the value from the correction field back to the tail-tag. Changing the correction field requires updating the UDP checksum (if UDP is used as transport). Signed-off-by: Christian Eggers --- include/linux/ptp_classify.h | 73 1

[PATCH net-next v4 5/9] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock

2020-12-01 Thread Christian Eggers
Implement routines (adjfine, adjtime, gettime and settime) for manipulating the chip's PTP clock. Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Kconfig| 8 + drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/micr

[PATCH net-next v4 4/9] net: dsa: microchip: ksz9477: basic interrupt support

2020-12-01 Thread Christian Eggers
Interrupts are required for TX time stamping. Probably they could also be used for PHY connection status. This patch only adds the basic infrastructure for interrupts, no interrupts are finally enabled nor handled. Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- Changes in v4

[PATCH net-next v4 3/9] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init()

2020-12-01 Thread Christian Eggers
The next patch will add basic interrupt support. Chip reset must be performed before requesting the IRQ, so move this from ksz9477_setup() to ksz9477_init(). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz9477_main.c | 15 +++ 1 file

[PATCH net-next v4 1/9] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c

2020-12-01 Thread Christian Eggers
PTP functionality will be built into a separate source file (ksz9477_ptp.c). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0 2 files changed, 1 insert

[PATCH net-next v4 2/9] dt-bindings: net: dsa: microchip,ksz: add interrupt property

2020-12-01 Thread Christian Eggers
The devices have an optional interrupt line. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree

[PATCH net-next v4 0/9] net: dsa: microchip: PTP support for KSZ956x

2020-12-01 Thread Christian Eggers
There is only little documentation for PTP available on the data sheet [1] (more or less only the register reference). Questions to the Microchip support were seldom answered comprehensively or in reasonable time. So this is more or less the result of reverse engineering. [1] http://ww1.microchip.

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-26 Thread Christian Eggers
:01:81-01:00:5E:00:01:ff)? The data sheet mentions that the static address table can be used for multicast addresses, so there should be a way. Alternatively, is there a hidden "disable TC" setting which disables the transparent clock entirely? regards Christian Look

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-25 Thread Christian Eggers
sful in blocking other communication (e.g. by MAC address), the matching rules above seem not to work. Is there an error in the ACL, or is forwarding of PTP traffic independent of configured ACLs? regards Christian

[PATCH net-next v2 3/3] net: phy: mscc: use new PTP_MSGTYPE_* defines

2020-11-23 Thread Christian Eggers
Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ defines instead of a driver internal enumeration. Signed-off-by: Christian Eggers Reviewed-by: Antoine Tenart Cc: Antoine Tenart --- drivers/net/phy/mscc/mscc_ptp.c | 14 +++--- drivers/net/phy/mscc/mscc_ptp.h | 5

[PATCH net-next v2 2/3] mlxsw: spectrum_ptp: use PTP wide message type definitions

2020-11-23 Thread Christian Eggers
Use recently introduced PTP wide defines instead of a driver internal enumeration. Signed-off-by: Christian Eggers Reviewed-by: Ido Schimmel Cc: Petr Machata Cc: Jiri Pirko Cc: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 8 drivers/net/ethernet/mellanox

[PATCH net-next v2 1/3] net: phy: dp83640: use new PTP_MSGTYPE_SYNC define

2020-11-23 Thread Christian Eggers
Replace use of magic number with recently introduced define. Signed-off-by: Christian Eggers Cc: Kurt Kanzenbach --- drivers/net/phy/dp83640.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index f2caccaf4408

[PATCH net-next v2 0/3] net: ptp: use common defines for PTP message types in further drivers

2020-11-23 Thread Christian Eggers
driver internal enumeration / uses of magic numbers with the newly introduced PTP_MSGTYPE_* defines. On Friday, 20 November 2020, 23:39:10 CET, Vladimir Oltean wrote: > On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote: > > This series introduces commen defines for PTP event

[PATCH net-next 3/3] net: phy: mscc: use new PTP_MSGTYPE_* defines

2020-11-22 Thread Christian Eggers
Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ defines instead of a driver internal enumeration. Signed-off-by: Christian Eggers Cc: Quentin Schulz Cc: Antoine Tenart Cc: Antoine Tenart --- drivers/net/phy/mscc/mscc_ptp.c | 14 +++--- drivers/net/phy/mscc

[PATCH net-next 2/3] mlxsw: spectrum_ptp: use PTP wide message type definitions

2020-11-22 Thread Christian Eggers
Use recently introduced PTP wide defines instead of a driver internal enumeration. Signed-off-by: Christian Eggers Cc: Petr Machata Cc: Jiri Pirko Cc: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.c | 8 drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h | 7

[PATCH net-next 1/3] net: phy: dp83640: use new PTP_MSGTYPE_SYNC define

2020-11-22 Thread Christian Eggers
Replace use of magic number with recently introduced define. Signed-off-by: Christian Eggers Cc: Kurt Kanzenbach --- drivers/net/phy/dp83640.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c index f2caccaf4408

[PATCH net-next 0/3] net: ptp: use common defines for PTP message types in further drivers

2020-11-22 Thread Christian Eggers
This series replaces further driver internal enumeration / uses of magic numbers with the newly introduced PTP_MSGTYPE_* defines. On Friday, 20 November 2020, 23:39:10 CET, Vladimir Oltean wrote: > On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote: > > This series introduc

[PATCH net-next 4/4] net: dsa: microchip: ksz8795: setup SPI mode

2020-11-20 Thread Christian Eggers
This should be done in the device driver instead of the device tree. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz8795_spi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c index

[PATCH net-next 3/4] net: dsa: microchip: ksz9477: setup SPI mode

2020-11-20 Thread Christian Eggers
This should be done in the device driver instead of the device tree. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_spi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477_spi.c b/drivers/net/dsa/microchip/ksz9477_spi.c index

[PATCH net-next 2/4] net: dsa: microchip: support for "ethernet-ports" node

2020-11-20 Thread Christian Eggers
The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and "ports". Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next 1/4] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-20 Thread Christian Eggers
Convert the bindings document for Microchip KSZ Series Ethernet switches from txt to yaml. Removed spi-cpha and spi-cpol flags is this should be handled by the device driver. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/ksz.txt | 125 --- .../bindings

[PATCH net-next 0/4] dt-bindings: net: dsa: microchip: convert KSZ bindings to yaml

2020-11-20 Thread Christian Eggers
These patches are orginally from the series "net: dsa: microchip: PTP support for KSZ956x" As the the device tree conversion to yaml is not really related to the PTP patches and the original series is going to take more time than I expected, I would like to split this. Changes (original series -

[PATCH net-next v3 3/3] ptp: ptp_ines: use new PTP_MSGTYPE_* define(s)

2020-11-20 Thread Christian Eggers
Remove driver internal defines for this. Masking msgtype with 0xf is already done within ptp_get_msgtype(). Signed-off-by: Christian Eggers Cc: Richard Cochran Cc: Kurt Kanzenbach --- drivers/ptp/ptp_ines.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git

[PATCH net-next v3 2/3] dpaa2-eth: use new PTP_MSGTYPE_* define(s)

2020-11-20 Thread Christian Eggers
Remove usage of magic numbers. Signed-off-by: Christian Eggers Cc: Ioana Ciornei Cc: Ioana Radulescu Cc: Yangbo Lu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b

[PATCH net-next v3 1/3] net: ptp: introduce common defines for PTP message types

2020-11-20 Thread Christian Eggers
Using PTP wide defines will obsolete different driver internal defines and uses of magic numbers. Signed-off-by: Christian Eggers Cc: Kurt Kanzenbach --- include/linux/ptp_classify.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/linux/ptp_classify.h b

[PATCH net-next v3 0/3] net: ptp: introduce common defines for PTP message types

2020-11-20 Thread Christian Eggers
This series introduces commen defines for PTP event messages. Driver internal defines are removed and some uses of magic numbers are replaced by the new defines. Changes v2 --> v3 -- - extend commit description for ptp_ines (Jacob Keller) Changes v1 --> v2 -- - use

Re: [PATCH net-next v3 01/12] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-19 Thread Christian Eggers
On Thursday, 19 November 2020, 14:48:01 CET, Rob Herring wrote: > On Wed, Nov 18, 2020 at 09:30:02PM +0100, Christian Eggers wrote: > > Convert the bindings document for Microchip KSZ Series Ethernet switches > > from txt to yaml. > > > > Sign

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-19 Thread Christian Eggers
Hi Tristram, thank you for joining this thread. On Thursday, 19 November 2020, 19:51:15 CET, tristram...@microchip.com wrote: > > On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote: > > > On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christi

[PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-19 Thread Christian Eggers
If dsa_switch_ops::port_txtstamp() returns false, clone will be freed immediately. Shouldn't store a pointer to freed memory. Signed-off-by: Christian Eggers Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX timestamping") --- Changes since v1: - Fixed &q

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-18 Thread Christian Eggers
Hi Vladimir, On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote: > On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christian Eggers wrote: > > This series adds support for PTP to the KSZ956x and KSZ9477 devices. > > > > There is only little documentation for PTP

Re: [PATCH net-next v2 3/3] ptp: ptp_ines: use new PTP_MSGTYPE_* define(s)

2020-11-18 Thread Christian Eggers
On Wednesday, 18 November 2020, 22:03:56 CET, Jacob Keller wrote: > On 11/18/2020 8:22 AM, Christian Eggers wrote: > > Remove driver internal defines for this. > > > > Signed-off-by: Christian Eggers > > Cc: Richard Cochran > > Cc: Kurt Kanzenbach > > --

Re: [PATCH net-next] net: dsa: avoid potential use-after-free error

2020-11-18 Thread Christian Eggers
On Thursday, 19 November 2020, 00:33:57 CET, Vladimir Oltean wrote: > On Wed, Nov 18, 2020 at 04:43:35PM +0100, Christian Eggers wrote: > > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > > immediately. Storing the pointer in DSA_SKB_CB(skb)->clone an

[PATCH net-next v3 12/12] net: dsa: microchip: ksz9477: add periodic output support

2020-11-18 Thread Christian Eggers
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to generate periodic signals. The pulse length can be altered via a device attribute. Tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_ptp.c | 197

[PATCH net-next v3 11/12] net: dsa: microchip: ksz9477: add Pulse Per Second (PPS) support

2020-11-18 Thread Christian Eggers
The KSZ9563 has a Trigger Output Unit (TOU) which can be used to generate periodic signals. After adjusting the PTP clock time, the PPS signal has to be restarted. Tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_ptp.c | 251

[PATCH net-next v3 10/12] net: dsa: microchip: ksz9477: remaining hardware time stamping support

2020-11-18 Thread Christian Eggers
an invalid UDP checksum if this field is negative. Of course, the UDP checksums (if any) have to be corrected after this (for both directions). Everything has been tested on a Microchip KSZ9563 switch. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_main.c | 12

[PATCH net-next v3 09/12] net: dsa: microchip: ksz9477: initial hardware time stamping support

2020-11-18 Thread Christian Eggers
details: https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-cegg...@arri.de/ Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_main.c | 6 + drivers/net/dsa/microchip/ksz9477_ptp.c | 187 +++ drivers/net/dsa/microchip/ksz9477_ptp.h | 22

[PATCH net-next v3 08/12] net: ptp: add helper for one-step P2P clocks

2020-11-18 Thread Christian Eggers
tail-tag is set to zero) or move the value from the correction field back to the tail-tag. Changing the correction field requires updating the UDP checksum (if UDP is used as transport). Signed-off-by: Christian Eggers --- include/linux/ptp_classify.h | 73 1

[PATCH net-next v3 07/12] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock

2020-11-18 Thread Christian Eggers
Implement routines (adjfine, adjtime, gettime and settime) for manipulating the chip's PTP clock. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/Kconfig| 8 + drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/ksz9477_i2c.c | 2 +- dr

[PATCH net-next v3 06/12] net: dsa: microchip: ksz9477: basic interrupt support

2020-11-18 Thread Christian Eggers
Interrupts are required for TX time stamping. Probably they could also be used for PHY connection status. This patch only adds the basic infrastructure for interrupts, no interrupts are finally enabled nor handled. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_i2c.c

[PATCH net-next v3 05/12] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init()

2020-11-18 Thread Christian Eggers
The next patch will add basic interrupt support. Chip reset must be performed before requesting the IRQ, so move this from ksz9477_setup() to ksz9477_init(). Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_main.c | 15 +++ 1 file changed, 7 insertions(+), 8

[PATCH net-next v3 04/12] dt-bindings: net: dsa: microchip,ksz: add interrupt property

2020-11-18 Thread Christian Eggers
The devices have an optional interrupt line. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree

[PATCH net-next v3 03/12] net: dsa: microchip: rename ksz9477.c to ksz9477_main.c

2020-11-18 Thread Christian Eggers
PTP functionality will be built into a separate source file (ksz9477_ptp.c). Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/Makefile | 1 + drivers/net/dsa/microchip/{ksz9477.c => ksz9477_main.c} | 0 2 files changed, 1 insert

[PATCH net-next v3 02/12] net: dsa: microchip: support for "ethernet-ports" node

2020-11-18 Thread Christian Eggers
The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and "ports". Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next v3 01/12] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-18 Thread Christian Eggers
Convert the bindings document for Microchip KSZ Series Ethernet switches from txt to yaml. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/ksz.txt | 125 -- .../bindings/net/dsa/microchip,ksz.yaml | 152 ++ MAINTAINERS

[PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-18 Thread Christian Eggers
This series adds support for PTP to the KSZ956x and KSZ9477 devices. There is only little documentation for PTP available on the data sheet [1] (more or less only the register reference). Questions to the Microchip support were seldom answered comprehensively or in reasonable time. So this is more

[PATCH net-next v2 3/3] ptp: ptp_ines: use new PTP_MSGTYPE_* define(s)

2020-11-18 Thread Christian Eggers
Remove driver internal defines for this. Signed-off-by: Christian Eggers Cc: Richard Cochran Cc: Kurt Kanzenbach --- drivers/ptp/ptp_ines.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c index

[PATCH net-next v2 2/3] dpaa2-eth: use new PTP_MSGTYPE_* define(s)

2020-11-18 Thread Christian Eggers
Remove usage of magic numbers. Signed-off-by: Christian Eggers Cc: Ioana Ciornei Cc: Ioana Radulescu Cc: Yangbo Lu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b

[PATCH net-next v2 1/3] net: ptp: introduce common defines for PTP message types

2020-11-18 Thread Christian Eggers
Using PTP wide defines will obsolete different driver internal defines and uses of magic numbers. Signed-off-by: Christian Eggers Cc: Kurt Kanzenbach --- include/linux/ptp_classify.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/linux/ptp_classify.h b

[PATCH net-next v2 0/3] net: ptp: introduce common defines for PTP message types

2020-11-18 Thread Christian Eggers
This series introduces commen defines for PTP event messages. Driver internal defines are removed and some uses of magic numbers are replaced by the new defines.

[PATCH net-next] net: dsa: avoid potential use-after-free error

2020-11-18 Thread Christian Eggers
If dsa_switch_ops::port_txtstamp() returns false, clone will be freed immediately. Storing the pointer in DSA_SKB_CB(skb)->clone anyway, supports annoying use-after-free bugs. Signed-off-by: Christian Eggers Fixes 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX time

[PATCH net-next 4/4] ptp: ptp_ines: use enum ptp_msg_type

2020-11-17 Thread Christian Eggers
Use new return type of ptp_get_msgtype(). Remove driver internal defines for this. Signed-off-by: Christian Eggers Cc: Richard Cochran Cc: Kurt Kanzenbach --- drivers/ptp/ptp_ines.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/ptp

[PATCH net-next 3/4] dpaa2-eth: use enum ptp_msg_type

2020-11-17 Thread Christian Eggers
Use new return type of ptp_get_msgtype(). Remove usage of magic numbers. Signed-off-by: Christian Eggers Cc: Ioana Ciornei Cc: Ioana Radulescu Cc: Yangbo Lu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a

  1   2   3   4   5   6   7   >