Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-20 Thread Chris Metcalf
On 07/20/2015 05:49 PM, Frederic Weisbecker wrote: On Mon, Jul 20, 2015 at 05:22:12PM -0400, Chris Metcalf wrote: On 07/11/2015 10:30 AM, Frederic Weisbecker wrote: On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: The tilegx chips typically don't do cpu offlining anyway,

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-20 Thread Chris Metcalf
On 07/11/2015 10:30 AM, Frederic Weisbecker wrote: On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: The tilegx chips typically don't do cpu offlining anyway, since we've never really found a usecase, so whatever you boot with you always have available. We do have sup

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-11 Thread Chris Metcalf
> On Jul 11, 2015, at 10:44 AM, Frederic Weisbecker wrote: > >> On Fri, Jul 10, 2015 at 03:37:25PM -0400, Chris Metcalf wrote: >> Normally the tilegx networking shim sends irqs to all the cores >> to distribute the load of processing incoming-packet interrupts, &

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
under a #ifdef CONFIG_NO_HZ_FULL check, given that are stubbed tick_nohz_full_enabled() defined above. True for the "if" clause, but the "housekeeping_mask" variable is only defined under CONFIG_NO_HZ_FULL. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com -- To u

[PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
the set of cores we use to only the online housekeeping cores. To make client code easier to read, we introduce a new nohz_full accessor, housekeeping_cpumask(), which returns a pointer to the housekeeping_mask if nohz_full is enabled, and otherwise returns the cpu_possible_mask. Signed-off-by: Chr

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
On 07/10/2015 02:24 PM, Frederic Weisbecker wrote: On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote: In nohz_full mode, by default distribute networking shim interrupts across the housekeeping cores, not all the cores. I can't really tell, I have no idea what this driver doe

[PATCH] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
In nohz_full mode, by default distribute networking shim interrupts across the housekeeping cores, not all the cores. Signed-off-by: Chris Metcalf --- The alternate approaches to this might be: 1. "#define housekeeping_mask cpu_online_mask" in the non-nohz_full arm in ,

Re: [PATCH] tile:Remove unused marcos from the file tilepro.c

2015-07-08 Thread Chris Metcalf
se; if you specify "#define FOO" it implicitly defines it to the empty string. Regardless, it doesn't matter what value it is defined to if the only uses are "#ifdef", as is true here. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com -- To unsubscribe from this list: